I’m ok with this Brent.
-Chris.
On 29 Dec 2014, at 21:43, Brent Christian brent.christ...@oracle.com wrote:
Hi,
The
java/lang/ClassLoader/deadlock/GetResource.java
test has started causing problems for Hotspot nightly testing. A real fix
is being worked on under [1], but in the
Just to note that an IndexOutOfBoundsException is mentioned in the
text (line 274, 350) but there is no matching @throws clause. The
IndexOutOfBoundsException could have a message added.
In general, I would expect an offset/length overload for most methods
that take an array, so this seems like a
Hi Lev!
When you'll be preparing the final webrev, can you please also include a
typo fix in it?
s/dstbegin/dstBegin/g
This typo is found in a couple of places in String.java.
Sincerely yours,
Ivan
I've checked the bug database [1], JEPs list [2] and Google but this
JEP appears to have disappeared. Can this be confirmed?
Stephen
[1] https://bugs.openjdk.java.net/issues/?jql=issuetype%20%3D%20JEP
[2] http://openjdk.java.net/jeps/0
On 13 February 2014 at 11:05, Florian Weimer
Just to note that there is some overlap between improving
serialization and the meta-model for Java (Beans v2.0) work I'm
looking at [1][2]. The key tool that a meta-model provides is to
enable class authors to select which pieces of their state form the
published properties. In most cases, the
Thanks Ivan,
As I understood dstbegin typo was only in comments. I've changed it to
camelCase as in code.
I've also applied benchmarked by Claes patch from
http://cr.openjdk.java.net/~redestad/8067471/webrev.03/
Please review latest changeset:
I’ve added the suggested @throws tags here:
http://cr.openjdk.java.net/~bpb/4026465/webrev.01/
Thanks,
Brian
On Dec 30, 2014, at 2:33 AM, Stephen Colebourne scolebou...@joda.org wrote:
Just to note that an IndexOutOfBoundsException is mentioned in the
text (line 274, 350) but there is no
Thanks, Chris.
On 12/30/14 12:52 AM, Chris Hegarty wrote:
I’m ok with this Brent.
-Chris.
On 29 Dec 2014, at 21:43, Brent Christian brent.christ...@oracle.com wrote:
Hi,
The
java/lang/ClassLoader/deadlock/GetResource.java
test has started causing problems for Hotspot nightly testing. A
Hi All
Can I get your review on this change.
http://cr.openjdk.java.net/~tyan/8051563/webrev.00/
http://cr.openjdk.java.net/~tyan/8051563/webrev.00/
These fixes originally come from bug
https://bugs.openjdk.java.net/browse/JDK-8051563
https://bugs.openjdk.java.net/browse/JDK-8051563 as part
Hi Tristan,
I will look at this but doubt I will get to this tomorrow
Best,
Lance
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Sent from my iPad
On Dec 30, 2014, at 5:28 PM,
Hi,
Thanks for looking at this patch and agreeing to sponsor - I've pushed
fixes for these issues at:
http://cr.openjdk.java.net/~rwarburton/string-patch-webrev-10/
Hope everyone has had a happy holiday period. Just following up on this
issue to make sure that you have all the information
Hi Brian,
The new changes generally look good. A few comments, for the new code like
291 } else if ((off 0) || (off val.length) || (len 0) ||
292((off + len) val.length) || ((off + len) 0)) {
293 throw new IndexOutOfBoundsException();
it is not
Please add @since 1.9 to the new constructors.
Cheers,
Paul
On Tue, Dec 30, 2014 at 8:15 PM, joe darcy joe.da...@oracle.com wrote:
Hi Brian,
The new changes generally look good. A few comments, for the new code like
291 } else if ((off 0) || (off val.length) || (len 0) ||
13 matches
Mail list logo
