Re: RFR: JDK-8152352 Compiling warnings in zip_util.c blocks devkit to build with --with-zlib=system

2016-03-21 Thread Martin Buchholz
Loos good! On Sat, May 21, 2016 at 2:06 PM, Xueming Shen wrote: > Hi, > > Please help review the change to remove two compiling warnings in zip_util.c > > issue: https://bugs.openjdk.java.net/browse/JDK-8152352 > webrev: http://cr.openjdk.java.net/~sherman/8152352/webrev/ > > thanks, > Sherman

Re: JAXP default implementation and JDK-8152063

2016-03-21 Thread huizhe wang
On 3/21/2016 12:55 PM, David M. Lloyd wrote: On 03/21/2016 01:38 PM, Alan Bateman wrote: On 21/03/2016 14:39, David M. Lloyd wrote: This message is in reference to the aforementioned issue [1] that I've requested my colleague Andrew Hughes to open on my behalf. As expressed in that issue, th

RFR: JDK-8152352 Compiling warnings in zip_util.c blocks devkit to build with --with-zlib=system

2016-03-21 Thread Xueming Shen
Hi, Please help review the change to remove two compiling warnings in zip_util.c issue: https://bugs.openjdk.java.net/browse/JDK-8152352 webrev: http://cr.openjdk.java.net/~sherman/8152352/webrev/ thanks, Sherman

Re: Analysis on JDK-8022321 java/lang/ref/OOMEInReferenceHandler.java fails intermittently

2016-03-21 Thread David Holmes
On 22/03/2016 3:32 AM, Kim Barrett wrote: On Mar 21, 2016, at 8:20 AM, Per Liden wrote: Hi Peter & David, (Resurrecting an old thread here...) On 2014-01-22 03:19, David Holmes wrote: Hi Peter, On 22/01/2014 12:00 AM, Peter Levart wrote: Hi, David, Kalyan, Summing up the discussion, I pro

Re: Analysis on JDK-8022321 java/lang/ref/OOMEInReferenceHandler.java fails intermittently

2016-03-21 Thread David Holmes
On 21/03/2016 11:41 PM, Per Liden wrote: Hi David, On 2016-03-21 13:49, David Holmes wrote: Hi Per, On 21/03/2016 10:20 PM, Per Liden wrote: Hi Peter & David, (Resurrecting an old thread here...) On 2014-01-22 03:19, David Holmes wrote: Hi Peter, On 22/01/2014 12:00 AM, Peter Levart wro

Re: JAXP default implementation and JDK-8152063

2016-03-21 Thread David M. Lloyd
On 03/21/2016 01:38 PM, Alan Bateman wrote: On 21/03/2016 14:39, David M. Lloyd wrote: This message is in reference to the aforementioned issue [1] that I've requested my colleague Andrew Hughes to open on my behalf. As expressed in that issue, the means of specifying a JAXP default provider (

RFR: 8151901: test/tools/pack200/Pack200Test fails on verifying native unpacked JAR

2016-03-21 Thread Kumar Srinivasan
Hi John, This patch contains fixes for two bugs: 8151901: test/tools/pack200/Pack200Test fails on verifying native unpacked JAR 8062335: Pack200 Java implementation differs from C version, outputs unused UTF8 for BootstrapMethods Note: The test case exhibits both of the above. With this the

Re: JAXP default implementation and JDK-8152063

2016-03-21 Thread Alan Bateman
On 21/03/2016 14:39, David M. Lloyd wrote: This message is in reference to the aforementioned issue [1] that I've requested my colleague Andrew Hughes to open on my behalf. As expressed in that issue, the means of specifying a JAXP default provider (via system property which specifies a class

Re: RFR [9] 8152277: Move URLClassPath.pathToURLs(String) to RegistryImpl

2016-03-21 Thread Alan Bateman
On 21/03/2016 17:45, Chris Hegarty wrote: In the context of 8149122 & 8152190 it was noticed that sun.rmi.registry.RegistryImpl is the only invoker of URLClassPath::pathToURLs. Rather that adding a qualified export to java.rmi for this, it makes sense to move pathToURLs(String) to RegistryImpI

Re: RFR [9] 8152277: Move URLClassPath.pathToURLs(String) to RegistryImpl

2016-03-21 Thread Lance Andersen
Looks good Chris.. On Mar 21, 2016, at 1:45 PM, Chris Hegarty wrote: > In the context of 8149122 & 8152190 it was noticed that > sun.rmi.registry.RegistryImpl is the only invoker of URLClassPath::pathToURLs. > Rather that adding a qualified export to java.rmi for this, it makes sense to > move >

RFR [9] 8152277: Move URLClassPath.pathToURLs(String) to RegistryImpl

2016-03-21 Thread Chris Hegarty
In the context of 8149122 & 8152190 it was noticed that sun.rmi.registry.RegistryImpl is the only invoker of URLClassPath::pathToURLs. Rather that adding a qualified export to java.rmi for this, it makes sense to move pathToURLs(String) to RegistryImpI ( and "modernize" the implementation a littl

Re: RFR [9] 8152190: Move sun.misc.JarIndex and InvalidJarIndexException to an internal package

2016-03-21 Thread Chris Hegarty
On 21 Mar 2016, at 08:33, Alan Bateman wrote: > On 21/03/2016 05:53, Chris Hegarty wrote: >> sun.misc.JarIndex, and its accompanying InvalidJarIndexException, are not >> "Critical APIs", as defined by JEP 260, so they should be moved out of >> sun.misc and placed into a more appropriate package

Re: Analysis on JDK-8022321 java/lang/ref/OOMEInReferenceHandler.java fails intermittently

2016-03-21 Thread Kim Barrett
> On Mar 21, 2016, at 8:20 AM, Per Liden wrote: > > Hi Peter & David, > > (Resurrecting an old thread here...) > > On 2014-01-22 03:19, David Holmes wrote: >> Hi Peter, >> >> On 22/01/2014 12:00 AM, Peter Levart wrote: >>> Hi, David, Kalyan, >>> >>> Summing up the discussion, I propose the fo

Re: Analysis on JDK-8022321 java/lang/ref/OOMEInReferenceHandler.java fails intermittently

2016-03-21 Thread Peter Levart
On 03/21/2016 04:13 PM, Peter Levart wrote: Hi Per, David, As things stand, there is a very good chance that sun.misc.Cleaner will go away in JDK9, so all this speculation about the source of OOME(s) can be put to rest. But for JDK 8u, I agree that this should be sorted out. My feeling is

Re: Analysis on JDK-8022321 java/lang/ref/OOMEInReferenceHandler.java fails intermittently

2016-03-21 Thread Peter Levart
Hi Per, May I point you to my proposed change in Reference(Handler) for JDK 9, being discussed in the thread about JDK-8149925. It will hopefully remove the special-casing of sun.misc.Cleaner, change the way how pending references are being enqueued by ReferenceHandler thread and how other th

Re: Analysis on JDK-8022321 java/lang/ref/OOMEInReferenceHandler.java fails intermittently

2016-03-21 Thread Peter Levart
Hi Per, David, As things stand, there is a very good chance that sun.misc.Cleaner will go away in JDK9, so all this speculation about the source of OOME(s) can be put to rest. But for JDK 8u, I agree that this should be sorted out. My feeling is that (instanceof Cleaner) can not result in all

JAXP default implementation and JDK-8152063

2016-03-21 Thread David M. Lloyd
This message is in reference to the aforementioned issue [1] that I've requested my colleague Andrew Hughes to open on my behalf. As expressed in that issue, the means of specifying a JAXP default provider (via system property which specifies a class name on the application class path) is rela

Re: Analysis on JDK-8022321 java/lang/ref/OOMEInReferenceHandler.java fails intermittently

2016-03-21 Thread Per Liden
Hi David, On 2016-03-21 13:49, David Holmes wrote: Hi Per, On 21/03/2016 10:20 PM, Per Liden wrote: Hi Peter & David, (Resurrecting an old thread here...) On 2014-01-22 03:19, David Holmes wrote: Hi Peter, On 22/01/2014 12:00 AM, Peter Levart wrote: Hi, David, Kalyan, Summing up the disc

Re: Review request for JDK-8151065 : Typo in java.time.Instant until(Temporal endExclusive, TemporalUnit unit)

2016-03-21 Thread Stephen Colebourne
+1 Stephen On 21 March 2016 at 12:28, Abhijit Roy wrote: > Hi all, > > > > Please review a fix for Bug - > https://bugs.openjdk.java.net/browse/JDK-8151868 > > > > Bug - Typo in java.time.Instant until(Temporal endExclusive, TemporalUnit > unit) > > > > Webrev - http://cr.openjdk.java.net/~ntv

Re: Review request for JDK-8151065 : Typo in java.time.Instant until(Temporal endExclusive, TemporalUnit unit)

2016-03-21 Thread Lance Andersen
Looks fine Abhijit Best Lance On Mar 21, 2016, at 8:28 AM, Abhijit Roy wrote: > Hi all, > > > > Please review a fix for Bug - > https://bugs.openjdk.java.net/browse/JDK-8151868 > > > > Bug - Typo in java.time.Instant until(Temporal endExclusive, TemporalUnit > unit) > > > > Webrev -

Re: Analysis on JDK-8022321 java/lang/ref/OOMEInReferenceHandler.java fails intermittently

2016-03-21 Thread David Holmes
Hi Per, On 21/03/2016 10:20 PM, Per Liden wrote: Hi Peter & David, (Resurrecting an old thread here...) On 2014-01-22 03:19, David Holmes wrote: Hi Peter, On 22/01/2014 12:00 AM, Peter Levart wrote: Hi, David, Kalyan, Summing up the discussion, I propose the following patch for ReferenceHa

Re: RFR: 8079136: Accessing a nested sublist leads to StackOverflowError

2016-03-21 Thread Ivan Gerasimov
Hello everyone! As the CCC request has been approved, the change is ready to be integrated. Here's the latest variant of the webrev: http://cr.openjdk.java.net/~igerasim/8079136/08/webrev/ It differs from the previous revision only in the javadoc section of AbstractList. All the code changes a

Review request for JDK-8151065 : Typo in java.time.Instant until(Temporal endExclusive, TemporalUnit unit)

2016-03-21 Thread Abhijit Roy
Hi all, Please review a fix for Bug - https://bugs.openjdk.java.net/browse/JDK-8151868 Bug - Typo in java.time.Instant until(Temporal endExclusive, TemporalUnit unit) Webrev - http://cr.openjdk.java.net/~ntv/abhijit/webrev.00/ I have just rectified and modified those error. And

Re: [9] RFR: 8145039: JAXB marshaller fails with ClassCastException on classes generated by xjc

2016-03-21 Thread Aleksej Efimov
Hi Lance, Thank you for the review and suggestion to change the comment - will change comment to state that ClassCastException is not expected in this test. Best Regards, Aleksej On 03/19/2016 03:16 PM, Lance Andersen wrote: Hi Aleksej I think the changeset is fine overall. Once minor com

Re: Analysis on JDK-8022321 java/lang/ref/OOMEInReferenceHandler.java fails intermittently

2016-03-21 Thread Per Liden
Hi Peter & David, (Resurrecting an old thread here...) On 2014-01-22 03:19, David Holmes wrote: Hi Peter, On 22/01/2014 12:00 AM, Peter Levart wrote: Hi, David, Kalyan, Summing up the discussion, I propose the following patch for ReferenceHandler: http://cr.openjdk.java.net/~plevart/jdk9-de

Re: RFR [9] 8152190: Move sun.misc.JarIndex and InvalidJarIndexException to an internal package

2016-03-21 Thread Alan Bateman
On 21/03/2016 05:53, Chris Hegarty wrote: sun.misc.JarIndex, and its accompanying InvalidJarIndexException, are not "Critical APIs", as defined by JEP 260, so they should be moved out of sun.misc and placed into a more appropriate package where they can be encapsulated. http://cr.openjdk.java.ne

RE: Instruction to test webrev

2016-03-21 Thread Thanh Hong Dai
Dear Sherman, Thank you very much. I can't wait to test it later this week. Best regards, Hong Dai Thanh. -Original Message- From: Xueming Shen [mailto:xueming.s...@oracle.com] Sent: Saturday, 19 March, 2016 4:15 AM To: hdth...@tma.com.vn Cc: core-libs-dev@openjdk.java.net Subject: Re: