Re: RFR 8164934: Optional.map() javadoc code example is incorrect

Looks good. At some point we should provide a way to de-activate checked exception in Java ! I vote for 10. I know it's a bold move but seriously checked exception are fine as feature until you try to compose it with another feature. This is a perfect example of why checked exceptions are a bad

Re: RFR 8132097: Stream.generate should use a covariant Supplier as parameter

Good for me ! Remi On November 9, 2016 1:43:52 AM GMT+01:00, Paul Sandoz wrote: >Hi > >Please review this compatible fix to Stream.generate to accept a >covariant Supplier. > >Paul. > >diff -r 3e3ca9800322 >src/java.base/share/classes/java/util/stream/Stream.java >--- a/src/java.base/share/cla

RFR 8132097: Stream.generate should use a covariant Supplier as parameter

Hi Please review this compatible fix to Stream.generate to accept a covariant Supplier. Paul. diff -r 3e3ca9800322 src/java.base/share/classes/java/util/stream/Stream.java --- a/src/java.base/share/classes/java/util/stream/Stream.java Tue Nov 08 15:37:20 2016 -0800 +++ b/src/java.base/share/c

Re: 8169001: Remove launcher's built-in ergonomics

Hi Kumar, FYI regarding the test, I was mis-remembering - it was actually an issue with the VM's notion of is_server_class_machine(), not the launcher. It's used for GC ergonomic selection. Cheers, David On 9/11/2016 3:28 AM, Kumar Srinivasan wrote: Hi David, Thanks for the review please

RFR 8164934: Optional.map() javadoc code example is incorrect

Hi, Please review an update to the api note of Optional.map() which embarrassingly contained erroneous code (labouring under the misapprehension that exception transparency is supported!). I tweaked the example to refer to a Stream where a URI is transformed into a Path. Paul. diff -r df7e62

8169425: Values computed by a ClassValue should not strongly reference the ClassValue

Hi, Please review the addition of an api note to ClassValue.computeValue. There is some history behind this issue. Another issue was logged [1] related to Groovy using ClassValue and there being a memory leak with classes/loaders not being GC’ed, but it turned out the problem was with Groovy's

Re: RFR 9: JDK-8168862:Tighten permissions granted to the jdk.zipfs module

On 11/8/16 4:30 PM, Xueming Shen wrote: On 10/31/2016 01:56 PM, Sean Mullan wrote: It would be good to add or modify existing test(s) to run with a Security Manager, if there is not one already. Hi Sean, All current zipfs tests are being run under "default" security manager as one of their te

Re: RFR 9: JDK-8168862:Tighten permissions granted to the jdk.zipfs module

On 10/31/2016 01:56 PM, Sean Mullan wrote: It would be good to add or modify existing test(s) to run with a Security Manager, if there is not one already. Hi Sean, All current zipfs tests are being run under "default" security manager as one of their testing scenario, for example * @summary

Re: RFR: 8164479: Update JAX-WS RI integration to latest version

Hi Roman, Not sure why there is an @since in package.html http://cr.openjdk.java.net/~aefimov/8164479/04/raw_files/new/jaxws/src/java.xml.bind/share/classes/javax/xml/bind/attachment/package.html

Re: XALAN: Text node of value 'null' - Is this illegal or does XSLTC have an issue here?

On 11/7/2016 11:31 PM, Langer, Christoph wrote: Hi Joe, thanks for your comments. Yes the customer does not really want to insert a null value but create an empty text node. So they’ll fix their code anyway. However, I thought it would be a good Idea to make the Serializer more robust wi

Re: 8169001: Remove launcher's built-in ergonomics

Hi David, Thanks for the review please see embedded comments: Hi Kumar, On 8/11/2016 4:47 AM, Kumar Srinivasan wrote: Hello, Please review the fix for: https://bugs.openjdk.java.net/browse/JDK-8169001 Webrev at: http://cr.openjdk.java.net/~ksrini/8169001/webrev.00/ Overall this looks li

Re: RFR: 8164479: Update JAX-WS RI integration to latest version

> On Nov 8, 2016, at 5:18 AM, Roman Grigoriadi > wrote: > > Thanks for suggestions Mandy. xjc -m option is used to pass module name if > module-info generation is desired. Here is updated webrev with all > suggestions included: > > http://cr.openjdk.java.net/~aefimov/8164479/04/ > +1. O

Re: [9] RFR: 8167240: Write new tests to cover functionality of existing 'jimage' options

Hi, Looks OK to me. I can suggest two more cases. A directory and file symlink can be passed in options where tool requires a file path. —Andrey > On 8 Nov 2016, at 16:17, Denis Kononenko wrote: > > > Hi, > > The new version of changes. > > - Switched back to jdk/test/testlibrary to avoid

Re: RFR: 8164479: Update JAX-WS RI integration to latest version

Thanks for suggestions Mandy. xjc -m option is used to pass module name if module-info generation is desired. Here is updated webrev with all suggestions included: http://cr.openjdk.java.net/~aefimov/8164479/04/ Roman On 11/03/2016 09:37 PM, Mandy Chung wrote: On Nov 3, 2016, at 4:53 AM, Ro

Re: [9] RFR: 8167240: Write new tests to cover functionality of existing 'jimage' options

Hi, The new version of changes. - Switched back to jdk/test/testlibrary to avoid unwanted dependencies (JImageToolTest.java); - Verified tests on smallest possible JDK build. WEBREV: http://cr.openjdk.java.net/~dkononenko/8167240/webrev.02/ BUGURL: https://bugs.openjdk.java.net/browse/JDK-81

Re: RFR[9] JDK-8158916: ProblemList.txt update for com/sun/jndi/ldap/DeadSSLLdapTimeoutTest.java

Hi John, On 08/11/16 01:30, John Jiang wrote: Hi Daniel, Thanks for your comments. On 2016/11/7 19:21, Daniel Fuchs wrote: Hi John, Maybe you should reach out to Rob who fixed JDK-8141370 to make sure this is the right thing to do. just cc Rob Mckenna It seems the exclusion on problematic

Re: 8169001: Remove launcher's built-in ergonomics

Build changes look ok. /Erik On 2016-11-07 19:47, Kumar Srinivasan wrote: Hello, Please review the fix for: https://bugs.openjdk.java.net/browse/JDK-8169001 Webrev at: http://cr.openjdk.java.net/~ksrini/8169001/webrev.00/ Background: Launcher ergonomics was introduced last decade to help

Re: RFR: 8159035: com/sun/crypto/provider/Cipher/CTS/CTSMode.java test crashed due to unhandled case of cipher length value as 0

Hi Rahul, On 07.11.2016 12:21, Rahul Raghavan wrote: > Hi, > > Request review for closed bug fix - JDK-8159035. > > - http://cr.openjdk.java.net/~rraghavan/8159035/webrev.03/ Looks good to me! > Notes: > > 1. - https://bugs.openjdk.java.net/browse/JDK-8159035 - > (com/sun/crypto/provider/C