Review Request: JDK-8170633 backslashes in, gensrc/module-info.java comments need escaping

> The build tool generating module-info.java includes the path name of > the source files in the comment for diagnosis where backslash > character needs escaping. This patch prints URI rather than file > path. As submitter and having tested the build patch, looks good to me. Brad

Re: Review Request: JDK-8170633 backslashes in gensrc/module-info.java comments need escaping

On 02/12/2016 17:39, Mandy Chung wrote: The build tool generating module-info.java includes the path name of the source files in the comment for diagnosis where backslash character needs escaping. This patch prints URI rather than file path. Putting the URI in the comment looks fine.

Re: Review Request: JDK-8170633 backslashes in gensrc/module-info.java comments need escaping

> On 2 Dec 2016, at 09:39, Mandy Chung wrote: > > The build tool generating module-info.java includes the path name of the > source files in the comment for diagnosis where backslash character needs > escaping. This patch prints URI rather than file path. > +1

Review Request: JDK-8170633 backslashes in gensrc/module-info.java comments need escaping

The build tool generating module-info.java includes the path name of the source files in the comment for diagnosis where backslash character needs escaping. This patch prints URI rather than file path. Mandy diff --git a/make/src/classes/build/tools/module/GenModuleInfoSource.java

RE: [NEW BUG]: Reduce allocations in sun.reflect.annotation.AnnotationInvocationHandler.invoke()

Hey, >>> doing a bit of digging it appears a similar improvement - along with a >>> lot of other things - was suggested and filed a few years back: >>> https://bugs.openjdk.java.net/browse/JDK-8029019 >> Really sorry for missing that! >> If https://bugs.openjdk.java.net/browse/JDK-8029019 is

Re: Review Request: JDK-8170660 RMI regression test failures due to missing @build TestLibrary

+1 > On Dec 2, 2016, at 12:27 PM, Mandy Chung wrote: > > @build TestLibrary in ContextWithNullProperties test was inadvertently > removed from JDK-8169231 [1]. This patch puts it back. > > > diff --git >

Review Request: JDK-8170660 RMI regression test failures due to missing @build TestLibrary

@build TestLibrary in ContextWithNullProperties test was inadvertently removed from JDK-8169231 [1]. This patch puts it back. diff --git a/test/com/sun/jndi/rmi/registry/RegistryContext/ContextWithNullProperties.java

Re: RFR: JDK-8075577: java.time does not support HOST provider

Hi Rachna, Ok, looks fine. Thanks, Roger On 12/1/2016 8:20 AM, Rachna Goel wrote: Hi Roger, Thanks for the review. Updated patch is : http://cr.openjdk.java.net/~rgoel/JDK-8075577/webrev.02/ Please find some of my comments inlined. On 30/11/16 10:17 PM, Roger Riggs wrote: Hi

Re: On what issues could I help clean up for JDK 9

Community-wide 'starter issues' are a better idea in theory, then they are in practice. Typically the theory behind them is to mark some low priority issues for someone else to fix. But in practice, not all low priority fixes are welcome at all times. See

Re: RFR: 8170595: Optimize Class.isAnonymousClass

Hi, On 2016-12-01 22:25, Claes Redestad wrote: On 12/01/2016 10:21 AM, Mandy Chung wrote: On Dec 1, 2016, at 9:52 AM, Claes Redestad wrote: Hi, good suggestion, this tidies up a bit while not affecting score:

potential error in fdlibm asin

[resent after subscribing core-libs-dev] Hi, I'm looking at some strange code in the asin implementation: Basically the code in http://hg.openjdk.java.net/jdk9/dev/jdk/file/bc6c31fd98cf/src/java.base/share/native/libfdlibm/e_asin.c after line 101 is indented wrong. But I think in truth the

potential error in fdlibm asin

Hi, I'm looking at some strange code in the asin implementation: Basically the code in http://hg.openjdk.java.net/jdk9/dev/jdk/file/bc6c31fd98cf/src/java.base/share/native/libfdlibm/e_asin.c after line 101 is indented wrong. But I think in truth the "else" statement should be deleted. "t =

Re: On what issues could I help clean up for JDK 9

Hi, I'd suggest start looking at requests for code cleanup, performance optimizations or similar that doesn't alter any public semantics (such as adding public APIs or subtly changing the behavior of existing ones). A few simple JBS searches lists at least some things that look tempting:

Re: On what issues could I help clean up for JDK 9

What was the outcome of that discussion? I seem to miss that one. My question comes from the past presentation I gave about contributing to the OpenJDK. And one of the main things was not only to do some local hacking but instead try to solve some small issues, that else would not be fixed

Re: RFR: JDK-8170629 Remove code duplication in test makefiles

Looks good. /Erik On 2016-12-02 10:24, Magnus Ihse Bursie wrote: There is a lot of common code that has been duplicated in */test/Makefile. For jdk, hotspot, jaxp and nashorn, most of the code in the corresponding files are identical. (The odd-man-out is langtools which is quite different.)

Re: On what issues could I help clean up for JDK 9

There's no JBS query that I know of (I think in the distant past we discussed adding a low hanging fruit 'Duke' tag?). Cheers, Martijn On 1 December 2016 at 21:58, Patrick Reinhart wrote: > Hi there, > > I wanted to ask if there is a simple JBS query to find small clean up

Re: RFR (JAXP) 8167340: XMLStreamReader.getElementText return corrupt content when size of element is > 8192

On 01/12/16 17:25, Joe Wang wrote: Thanks Christoph, Daniel! I've updated the test, removing the comments. As for 80 chars line limit, or slightly longer than that is fine with me. Given our codebase, it would be an enormous undertaking. I'm therefore fine with taking care of only the extremely

Re: RFR of JDK-8170644: java/rmi/registry/interfaceHash/InterfaceHash.java failed intermittently with "Port already in use"

Hi Hamlin, Looks good to me! best regards, -- daniel On 02/12/16 08:25, Hamlin Li wrote: Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8170644 webrev: http://cr.openjdk.java.net/~mli/8170644/webrev.00/ Thank you -Hamlin

Re: RFR: 8169495: Add a method to set an Authenticator on a HttpURLConnection.

On 10/11/16 15:12, Daniel Fuchs wrote: Hi, Please find below a patch for: https://bugs.openjdk.java.net/browse/JDK-8169495 8169495: Add a method to set an Authenticator on a HttpURLConnection. Thank you Daniel. This addresses a long standing request to have a per-instance Authenticator.

Re: RFR of JDK-8078587: java/rmi/server/Unreferenced/leaseCheckInterval/LeaseCheckInterval.java fails intermittently with Port already in use

On 02/12/16 09:39, Hamlin Li wrote: Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8078587 webrev: http://cr.openjdk.java.net/~mli/8078587/webrev.00/ Reviewed. -Chris. Thank you -Hamlin

RFR of JDK-8078587: java/rmi/server/Unreferenced/leaseCheckInterval/LeaseCheckInterval.java fails intermittently with Port already in use

Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8078587 webrev: http://cr.openjdk.java.net/~mli/8078587/webrev.00/ Thank you -Hamlin diff -r 08f81d321087

RFR: JDK-8170629 Remove code duplication in test makefiles

There is a lot of common code that has been duplicated in */test/Makefile. For jdk, hotspot, jaxp and nashorn, most of the code in the corresponding files are identical. (The odd-man-out is langtools which is quite different.) These files should be unified to share a single code base, to

Re: RFR of JDK-8080550: java/rmi/server/useCustomRef/UseCustomRef.java failed with java.net.BindException intermittently

On 02/12/16 09:06, Hamlin Li wrote: Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8080550 webrev: http://cr.openjdk.java.net/~mli/8080550/ Looks good Hamlin. -Chris. Thank you -Hamlin

RFR of JDK-8080550: java/rmi/server/useCustomRef/UseCustomRef.java failed with java.net.BindException intermittently

Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8080550 webrev: http://cr.openjdk.java.net/~mli/8080550/ Thank you -Hamlin diff -r 99dd72e05060

Re: RFR of JDK-8153916: com/sun/jndi/rmi/registry/RegistryContext/ContextWithNullProperties.java failed with BindException

On 02/12/16 08:42, Hamlin Li wrote: Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8153916 webrev: http://cr.openjdk.java.net/~mli/8153916/webrev.00/ Looks good. Thanks Hamlin. -Chris. Thank you -Hamlin

RFR of JDK-8153916: com/sun/jndi/rmi/registry/RegistryContext/ContextWithNullProperties.java failed with BindException

Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8153916 webrev: http://cr.openjdk.java.net/~mli/8153916/webrev.00/ Thank you -Hamlin diff -r 35c87712682f

RFR of JDK-8170644: java/rmi/registry/interfaceHash/InterfaceHash.java failed intermittently with "Port already in use"

Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8170644 webrev: http://cr.openjdk.java.net/~mli/8170644/webrev.00/ Thank you -Hamlin

RE: RFR (JAXP) 8167340: XMLStreamReader.getElementText return corrupt content when size of element is > 8192

Hi Joe, thanks, looks fine now. In test/javax/xml/jaxp/unittest/stream/XMLStreamReaderTest/StreamReaderTest.java, the brace in line 63 could still move one line up, but this really is nit-picking ;-) Best regards Christoph > -Original Message- > From: Joe Wang