Re: [10] RFR 8194959: Correct test tag to move bugid from @test to @bug

+1 -Sundar On 12/01/18, 10:21 AM, Amy Lu wrote: Please review this minor test-tag-only change to move bugid from @test to @bug bug: https://bugs.openjdk.java.net/browse/JDK-8194959 webrev: http://cr.openjdk.java.net/~amlu/8194959/webrev.00/ Thanks, Amy

[10] RFR 8194959: Correct test tag to move bugid from @test to @bug

Please review this minor test-tag-only change to move bugid from @test to @bug bug: https://bugs.openjdk.java.net/browse/JDK-8194959 webrev: http://cr.openjdk.java.net/~amlu/8194959/webrev.00/ Thanks, Amy

Can @Stable (or something similar) be made accessible?

MethodHandle.invokeExact() can match the performance of direct invocation, but it requires constant folding to do so. Otherwise results are similar to Java reflection(e.g [1]). While TrustFinalNonStaticFields can be used, it’s a sledgehammer where a scalpel is really be more appropriate. The

RFR: 8194287 and 8194286: simple test changes for the execution of these tests in a docket container

Hi, Please review bug fixes for 2 test bugs, which fails with a base Linux installation in a docker container. Thanks Kumar [1] http://cr.openjdk.java.net/~ksrini/8194287/webrev-00/ [2] http://cr.openjdk.java.net/~ksrini/8194287/cmt.txt

Re: RFR 4358774: Add null InputStream and OutputStream

Thanks. The final version is updated in place under webrev.03. Pushing the change is pending CSR-reapproval. Brian On Jan 11, 2018, at 11:16 AM, Roger Riggs wrote: > +1 looks fine > > On 1/11/2018 11:59 AM, Brian Burkhalter wrote: >> While there appears now to be agreement on using naming opt

Re: [11] RFR 8194148: bcp47u/SymbolsTests.java and FormatTests.java fail on th_TH locale

Hi Naoto, Looks fine. Thanks On 1/10/2018 2:04 PM, Naoto Sato wrote: Hello, Please review a simple test fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8194148 The proposed changeset is located at: http://cr.openjdk.java.net/~naoto/8194148/webrev.00/ The gist of the i

Re: RFR 4358774: Add null InputStream and OutputStream

+1 looks fine On 1/11/2018 11:59 AM, Brian Burkhalter wrote: While there appears now to be agreement on using naming option C below, formal Reviewer approval appears still to be lacking. It would be good if there were at least two approvals forthcoming, if appropriate. http://cr.openjdk.java.

Re: RFR 4358774: Add null InputStream and OutputStream

While there appears now to be agreement on using naming option C below, formal Reviewer approval appears still to be lacking. It would be good if there were at least two approvals forthcoming, if appropriate. http://cr.openjdk.java.net/~bpb/4358774/webrev.03/ Thanks, Brian On Jan 4, 2018, at

Re: RFR 8194929 : Unreferenced FileDescriptors not closed

Hi  Alan, On 1/11/2018 11:14 AM, Alan Bateman wrote: On 11/01/2018 15:19, Roger Riggs wrote: Please review a fix for a missing entry in the mapfiles.  The missing entry point caused the closing of unreferenced FileDescriptors to be skipped. Looks good. The tests for FileInputStream, File

Re: RFR 8194929 : Unreferenced FileDescriptors not closed

On 11/01/2018 15:19, Roger Riggs wrote: Please review a fix for a missing entry in the mapfiles.  The missing entry point caused the closing of unreferenced FileDescriptors to be skipped. Looks good. The tests for FileInputStream, FileOutputStream, and RandomAccess file unreferenced File

RFR 8194929 : Unreferenced FileDescriptors not closed

Please review a fix for a missing entry in the mapfiles.  The missing entry point caused the closing of unreferenced FileDescriptors to be skipped. The tests for FileInputStream, FileOutputStream, and RandomAccess file unreferenced FileDescriptors have been updated to verify the raw fds have b

Re: [11] RFR of 8146656: Wrong Months Array for DateFormatSymbols

Hi Joe, I have revised this webrev to include your feedback and also updated this CSR. Kindly have a look at : CSR: https://bugs.openjdk.java.net/browse/JDK-8191414 webrev: http://cr.openjdk.java.net/~rgoel/8146656/webrev.01/ Thanks, Rachna On 20/12/17 10:44 PM, joe darcy wrote: Hi Rac