RFR: [11] 8202537: CLDR 33

Hi, Kindly review fix for JDK-8202537. Fix is to upgrade Unicode consortium's CLDR data into JDK from current version 29 to 33. For more info : http://cldr.unicode.org/index/downloads/cldr-33 Bug : https://bugs.openjdk.java.net/browse/JDK-8202537 Patch:

Re: RFR JDK-8066709 Make some JDK system properties read only

In fact, why is setting user.name and user.home always evil? If I only want to set them on the command line so that a special "user environment" is used, why is it a problem? In fact, we have a test setting user.home to an empty directory to avoid unexpected result because we cannot control

Re: RFR JDK-8066709 Make some JDK system properties read only

Hi Roger 1. Should all occurrences of reading of these system properties be updated? For example, the following one is not touched http://hg.openjdk.java.net/jdk/jdk/file/4d2e3f5abb48/src/java.base/share/classes/sun/security/tools/keytool/Main.java#l842 2. I assume that with this change not

Re: [core-libs] RFR (L): 8010319: Implementation of JEP 181: Nest-Based Access Control

On 6/11/2018 10:38 PM, mandy chung wrote: On 6/11/18 10:16 PM, David Holmes wrote: Here is one further minor update from the CSR discussions: http://cr.openjdk.java.net/~dholmes/8010319-JEP181/webrev.corelibs.v5-incr/src/java.base/share/classes/java/lang/Class.java.cdiff.html "This

Re: RFC: Experiment in accessing/managing persistent memory from Java

On 06/12/2018 06:12 PM, Paul Sandoz wrote: > >> We may also want to look at related enhancements like unmapping >> buffers. I think those pieces are sufficient decoupled that they >> won't be dependencies for the pmem API though, unlike other factors >> such as the availability of test hardware.

Re: RFR (JDK11/NIO) 8201276: (fs) Add methods to Files for reading/writing a string from/to a file

Hi Joe, Looks good to me. Typo: StringCoding.java:1026 "unmappble"  (no new webrev needed) Regards, Roger On 6/12/2018 12:52 PM, Joe Wang wrote: Hi all, It's been a while since the 1st round of reviews. Thank you all for the valuable comments and suggestions!  Note that Roger's last

Re: RFC: Experiment in accessing/managing persistent memory from Java

Hi Jonathan, > On Jun 8, 2018, at 3:59 AM, Jonathan Halliday > wrote: > > > Hi Paul > > Looks like we're all on the same page regarding the basic approach of using a > small API and making the critical bits intrinsic. We perhaps have some way to > go on exactly what that API looks like in

Re: RFR (JDK11/NIO) 8201276: (fs) Add methods to Files for reading/writing a string from/to a file

Hi all, It's been a while since the 1st round of reviews. Thank you all for the valuable comments and suggestions! Note that Roger's last response went to nio-dev, but not core-libs-dev, I've therefore attached it below. CSR [2]: the CSR is now approved. Note the write method has been

Re: RFR: 8196988 (Resolve disabled warnings for libjimage)

Have you verified the build on all platforms (release and debug)? Mandy On 6/11/18 10:23 PM, Srinivas Dama wrote: Gentle reminder. May I have review for the below changeset. Regards, Srinivas -Original Message- From: Srinivas Dama Sent: Friday, June 08, 2018 11:47 AM To:

Re: RFR: 8196988 (Resolve disabled warnings for libjimage)

Looks ok. Including Jim in case he is not listening in… I am guessing the comment selectively disables the warning in this code (rather than using a diagnostic pragma). Thanks, Paul. > On Jun 7, 2018, at 11:17 PM, Srinivas Dama wrote: > > Hi, > > Please review

Re: RFR 8197930: JNI exception pending in initializeEncoding of jni_util.c

Looks good. Mandy On 6/12/18 7:17 AM, Roger Riggs wrote: Please review a cleanup to not ignore errors from GetMethodID and GetFieldID while initializing the system encoding. Webrev:    http://cr.openjdk.java.net/~rriggs/webrev-jnicheck-8197930/ issue:   

Re: RFR: 8202216: (bf) Add Buffer mismatch()

+1 Paul. > On Jun 12, 2018, at 2:34 AM, Vivek Theeyarath > wrote: > > Hi All, > > Please review fix for > https://bugs.openjdk.java.net/browse/JDK-8202216 > > > > Webrev: http://cr.openjdk.java.net/~vtheeyarath/8202216/webrev.00/ > > CSR :

Re: RFR 8197930: JNI exception pending in initializeEncoding of jni_util.c

Looks good. Thanks, Thomas On Tue, Jun 12, 2018 at 4:17 PM, Roger Riggs wrote: > Please review a cleanup to not ignore errors from GetMethodID and GetFieldID > while initializing the system encoding. > > Webrev: >http://cr.openjdk.java.net/~rriggs/webrev-jnicheck-8197930/ > issue: >

Re: RFR: 8202216: (bf) Add Buffer mismatch()

Hi Peter, Buffer is not currently a generic class and making it so likely would cause some source compatibility issues (e.g. lots of raw type warnings/errors). Paul. > On Jun 12, 2018, at 3:20 AM, Peter Levart wrote: > > Hi, > > On 06/12/2018 11:34 AM, Vivek Theeyarath wrote: >> Hi All, >>

Re: BiCollector

I don’t have anything publicly available. I’ll see if i can dig something out and send it to you directly. Paul. > On Jun 11, 2018, at 11:28 AM, Peter Levart wrote: > > Hi Paul, > > Can you point me to some BiStream code (if it is available publicly)? > > Thanks, Peter > > On 06/11/18

Re: RFR: 8204342: CLONE - methods in java.time's TCKZoneRules OpenJDK test miss @Test annotation

+1 Naoto On 6/12/18 3:45 AM, Vivek Theeyarath wrote: Hi All, Please review fix for https://bugs.openjdk.java.net/browse/JDK-8204342 . The jtreg test runs fine with the changes. http://cr.openjdk.java.net/~vtheeyarath/8204342/webrev.00/ Regards Vivek

RFR 8197930: JNI exception pending in initializeEncoding of jni_util.c

Please review a cleanup to not ignore errors from GetMethodID and GetFieldID while initializing the system encoding. Webrev:    http://cr.openjdk.java.net/~rriggs/webrev-jnicheck-8197930/ issue:    https://bugs.openjdk.java.net/browse/JDK-8197930 Thanks, Roger

Re: RFR: 8204342: CLONE - methods in java.time's TCKZoneRules OpenJDK test miss @Test annotation

Hi Vivek, Look fine, Roger On 6/12/18 6:45 AM, Vivek Theeyarath wrote: Hi All, Please review fix for https://bugs.openjdk.java.net/browse/JDK-8204342 . The jtreg test runs fine with the changes. http://cr.openjdk.java.net/~vtheeyarath/8204342/webrev.00/ Regards

Re: RFR: 8204861 : fix for 8196993 has broken the build on linux

On 06/12/2018 02:46 PM, Srinivas Dama wrote: > Hi, > > My earlier fix for https://bugs.openjdk.java.net/browse/JDK-8196993 has > broken the build on linux. > So I am reverting my fix for now. > > Bug : https://bugs.openjdk.java.net/browse/JDK-8204861 > webrev:

Re: RFR: 8204861 : fix for 8196993 has broken the build on linux

Looks good to me. Thanks for fixing this. StefanK On 2018-06-12 14:46, Srinivas Dama wrote: Hi, My earlier fix for https://bugs.openjdk.java.net/browse/JDK-8196993 has broken the build on linux. So I am reverting my fix for now. Bug : https://bugs.openjdk.java.net/browse/JDK-8204861 webrev:

RFR: 8204861 : fix for 8196993 has broken the build on linux

Hi, My earlier fix for https://bugs.openjdk.java.net/browse/JDK-8196993 has broken the build on linux. So I am reverting my fix for now. Bug : https://bugs.openjdk.java.net/browse/JDK-8204861 webrev: http://cr.openjdk.java.net/~sdama/8204861/webrev.00/ Regards, Srinivas

Re: Ping!! Re: RFR: 8203357 Container Metrics

> On Jun 12, 2018, at 1:43 AM, David Holmes wrote: > >> On 12/06/2018 3:31 PM, mandy chung wrote: >> On 6/11/18 10:12 PM, David Holmes wrote: >>> >>> For the Java code ... methods that return arrays should return >>> zero-length arrays when something is not available rather than

Re: Ping!! Re: RFR: 8203357 Container Metrics

> On Jun 12, 2018, at 1:12 AM, David Holmes wrote: > > On 12/06/2018 9:30 AM, Bob Vandette wrote: >>> On Jun 11, 2018, at 5:21 PM, David Holmes wrote: >>> >>> On 12/06/2018 12:12 AM, Bob Vandette wrote: > On Jun 11, 2018, at 4:32 AM, David Holmes >

RFR: 8204342: CLONE - methods in java.time's TCKZoneRules OpenJDK test miss @Test annotation

Hi All, Please review fix for https://bugs.openjdk.java.net/browse/JDK-8204342 . The jtreg test runs fine with the changes. http://cr.openjdk.java.net/~vtheeyarath/8204342/webrev.00/ Regards Vivek

Re: RFR: 8202216: (bf) Add Buffer mismatch()

Hi, On 06/12/2018 11:34 AM, Vivek Theeyarath wrote: Hi All, Please review fix for https://bugs.openjdk.java.net/browse/JDK-8202216 Webrev: http://cr.openjdk.java.net/~vtheeyarath/8202216/webrev.00/ CSR : https://bugs.openjdk.java.net/browse/JDK-8204852 Regards

RFR: 8202216: (bf) Add Buffer mismatch()

Hi All, Please review fix for https://bugs.openjdk.java.net/browse/JDK-8202216 Webrev: http://cr.openjdk.java.net/~vtheeyarath/8202216/webrev.00/ CSR : https://bugs.openjdk.java.net/browse/JDK-8204852 Regards Vivek

Re: [AIX] Add charset IBM-964 (default charset for zh_TW.IBM-eucTW) to stdcs

Thank you for review. This is not new charset. This codepage already exist in openJDK and current fix is to move it to standard charset list (only for AIX) as it is default charset for locale zh_TW.IBM-eucTW. This enabling jdk11 on locale zh_TW.IBM-eucTW. May I request someone to create JIRA

Re: Ping!! Re: RFR: 8203357 Container Metrics

On 6/11/18 10:43 PM, David Holmes wrote: On 12/06/2018 3:31 PM, mandy chung wrote: On 6/11/18 10:12 PM, David Holmes wrote: For the Java code ... methods that return arrays should return zero-length arrays when something is not available rather than null. All methods do return zero length