Re: [12] (AIX) 8207744: Clean up inconsistent use of opendir/closedir versus opendir64/closedir64

Hi Bernard, I think you are correct. Webrev updated accordingly: http://cr.openjdk.java.net/~bpb/8207744/webrev.01/ I know you cannot do it, but a build of this on AIX by someone would be appreciated (not urgent). Thanks, Brian On Jul 27, 2018, at 7:16 AM, B. Blaser wrote: > I cannot

Re: Long chains created by direct Buffer::slice

> On Jul 27, 2018, at 1:09 AM, Florian Weimer wrote: > > * Paul Sandoz: > >> I created this issue: >> >> https://bugs.openjdk.java.net/browse/JDK-8208362 > > Thanks. > >> The suggested fix requires a tweak though since an instance of a >> DirectBuffer interface is passed. This is

Re: [12] RFR 8208363: test/jdk/java/lang/Package/PackageFromManifest.java missing module dependencies declaration

Looks fine. This test uses JarUtils instead of jar tool and so it does not depend on jdk.jar. Mandy On 7/27/18 1:42 AM, Chris Yin wrote: Please review below minor change to add missing module dependencies declaration, thanks bug: https://bugs.openjdk.java.net/browse/JDK-8208363 Changes:

Re: [12] RFR 8208363: test/jdk/java/lang/Package/PackageFromManifest.java missing module dependencies declaration

Hi Chris, This the change is fine > On Jul 27, 2018, at 4:42 AM, Chris Yin wrote: > > Please review below minor change to add missing module dependencies > declaration, thanks > > bug: https://bugs.openjdk.java.net/browse/JDK-8208363 > > >

Re: Draft JEP proposal: JDK-8200758: Packaging Tool

Right, I explicitly want to make the distinction between this and the “Multiple launchers” stretch goal. I want to use the "multiple launchers” as well. One way that I have used multiple launchers (on Linux, I don’t think I could get it to work on Windows) is to have one launcher be a

Re: [12] (AIX) 8207744: Clean up inconsistent use of opendir/closedir versus opendir64/closedir64

Hi Brian, On 26 July 2018 at 22:13, Brian Burkhalter wrote: > https://bugs.openjdk.java.net/browse/JDK-8207744 > http://cr.openjdk.java.net/~bpb/8207744/webrev.00/ > > This change simply adds > > #if defined(_AIX) > #define DIR DIR64 > #define opendir opendir64 > #define closedir

Re: Draft JEP proposal: JDK-8200758: Packaging Tool

I don't see why this isn't feasible, and will file such an enhancement request, but should be possible to deliver a suite of apps in one bundle.  This is the third 'stretch goal' : "Multiple launchers (enables a suite of applications to be bundled in a single self-contained application

Re: Draft JEP proposal: JDK-8200758: Packaging Tool

With the existing javapackager there are some limitations. On Windows I only use it to go as far as creating the application image. I then run the WiX commands in my Gradle build script to finish creating an installer that has an added custom component used to tweak the .cfg file. (Creating

Re: RFR: 8207851 JEP Draft: Support ByteBuffer mapped over non-volatile memory

* Andrew Dinn: >> +// TODO - remove the following defines >> +// for testing we need to define the extra MAP_XXX flags used for >> +// persistent memory. they will eventually get defined by the >> +// system and included via sys/mman.h >> >> Do you really want to change

Re: RFR: 8207851 JEP Draft: Support ByteBuffer mapped over non-volatile memory

On 26/07/18 20:05, Florian Weimer wrote: > * Andrew Dinn: > >>> +// TODO - remove the following defines >>> +// for testing we need to define the extra MAP_XXX flags used for >>> +// persistent memory. they will eventually get defined by the >>> +// system and included via

Re: Draft JEP proposal: JDK-8200758: Packaging Tool

> Will it be possible to NOT include the JRE, but specify instead a pre-existing location for the JRE? This does seem like an interesting use case. As you say, it is similar in many ways to both the Multiple Launchers and system JRE, but not quite the same as either. The mechanism to manage

RE: Draft JEP proposal: JDK-8200758: Packaging Tool

Thanks for the info - I was not aware of these possibilities in javapackager. @Kevin: just fyi, this would be also a very useful feature for the company I work for and for our projects @Scott: please, let me know, how to achieve this with javapackager Cheers Jörg -Original Message-

[12] RFR 8208363: test/jdk/java/lang/Package/PackageFromManifest.java missing module dependencies declaration

Please review below minor change to add missing module dependencies declaration, thanks bug: https://bugs.openjdk.java.net/browse/JDK-8208363 Changes: diff -r 65fc31d1042b test/jdk/java/lang/Package/PackageFromManifest.java ---

Re: Long chains created by direct Buffer::slice

* Paul Sandoz: > I created this issue: > > https://bugs.openjdk.java.net/browse/JDK-8208362 Thanks. > The suggested fix requires a tweak though since an instance of a > DirectBuffer interface is passed. This is required because views > over direct ByteBuffers can be created. Noticed that as

Re: [12] RFR 8200151: Add 8 JNDI tests to com/sun/jndi/dns/ConfigTests/

Hi, Vyom Thank a lot for your review and comments, inline and update new webrev as below, thanks http://cr.openjdk.java.net/~xyin/8200151/webrev.01/ > On 26 Jul 2018, at 5:27 PM, vyom tewari wrote: > > Hi Chris, > > Thanks for writing