Sorry for offtopic – figured might still be a good Addition to the question,
If you can switch the JDK (and do not yet need Java 11) then you can use the
binaries from the ojdkbuild Project (Fedora/RH upstream), they provide the PDB
files in the *debuginfo* packages (havent tested them myself).
Hi Alexander,
Not really a core-libs question, but in any case the simple answer for
the Oracle JDK is No. We can not provide the PDB files to you.
David
On 18/10/2018 1:08 AM, Alexander Miloslavskiy wrote:
Hello,
I'm trying to debug a native crash that regularly happens for one of our
Hi Joe,
On 10/17/2018 09:16 PM, joe darcy wrote:
PS In response to some off-list feedback, an updated webrev uses a
stream-ier implementation:
http://cr.openjdk.java.net/~darcy/6304578.1/
I suggest further niceing:
- if you make typeVarBounds() static, you could use it in Stream.map()
Hi Joe,
webrevs: http://cr.openjdk.java.net/~joehw/jdk12/8202285/webrev_v05/
I concur with Roger's comments on the test file generation. It would be good to
find some way to reduce the redundancy. He had some suggestions that might work.
You might also want to play around with variations to
David, thanks for the review.
Mandy
On 10/16/18 8:33 PM, David Holmes wrote:
Hi Mandy,
I took a look through all of this and it seems okay - though it was a
little surprising how far the name change needed to spread.
Thanks,
David
On 17/10/2018 2:08 AM, Mandy Chung wrote:
Webrev:
+1
> On Oct 17, 2018, at 4:50 PM, Andrew Luo
> wrote:
>
> Done as well, thanks for spotting that also.
>
> diff --git a/src/java.base/share/classes/java/lang/ref/Cleaner.java
> b/src/java.base/share/classes/java/lang/ref/Cleaner.java
> ---
On 10/17/18 1:08 PM, Roger Riggs wrote:
I think the @bug line should be empty, this is not a test for a bug.
I don't think you need or use the testng group= functionality; if you don't have
a need for it omit it.
I think it would be helpful to have the bug ID in the test's @bug line. If in
On 16/10/2018 02:25, Kim Barrett wrote:
On Oct 15, 2018, at 7:51 AM, Aleksei Voitylov
wrote:
Kim,
If you were suggesting to just proceed with the change without giving a
sufficient lead time for the ports that were willing to upgrade to do so, that
sounds very alarming.
What is
Hi Joe,
A few comments about the test.
45: the summary should mention it is testing the Files.mismatch method
I think the @bug line should be empty, this is not a test for a bug.
I don't think you need or use the testng group= functionality; if you
don't have a need for it omit it.
On the
On 10/17/18, 7:16 AM, Roger Riggs wrote:
Hi Joe,
Looks good, straightforward and easy to understand.
Glad to hear that, while it's been back and forth a couple of times, it
seems "straightforward and easy" won :-)
The spec text in the CSR need to be updated to match. (At least the
PS In response to some off-list feedback, an updated webrev uses a
stream-ier implementation:
http://cr.openjdk.java.net/~darcy/6304578.1/
Thanks,
-Joe
On 10/11/2018 6:11 PM, joe darcy wrote:
Hello,
Prompted by recent work on the toString implementations of
AnnotatedType objects
Change seems to make sense
looks like a semi-colon could be added after as well as part of the update:
private final Cleaner.Cleanable cleanable
> On Oct 17, 2018, at 2:10 PM, Andrew Luo
> wrote:
>
> Noticed a typo in the Javadoc for Cleaner... Patch attached below:
>
> diff --git
Noticed a typo in the Javadoc for Cleaner... Patch attached below:
diff --git a/src/java.base/share/classes/java/lang/ref/Cleaner.java
b/src/java.base/share/classes/java/lang/ref/Cleaner.java
--- a/src/java.base/share/classes/java/lang/ref/Cleaner.java
+++
Looks good.
Naoto
On 10/16/18 8:01 PM, Dora Zhou wrote:
Hello,
Please help review the fix for refactor java.util.PluggableLocale:i18n
shell tests to plain java tests. Thank you.
Bug: https://bugs.openjdk.java.net/browse/JDK-8210406
webrev:
Hello,
I'm trying to debug a native crash that regularly happens for one of our
customers.
It crashes somewhere amidst java interpreter code, with corrupted value
in CPU's RIP register. So it's quite complicated.
It would certainly help me a lot if I had access to jvm.pdb files for
On 2018-10-17 17:03, Aleksey Shipilev wrote:
On 10/17/2018 04:55 PM, Claes Redestad wrote:
Webrev: http://cr.openjdk.java.net/~redestad/8212597/jdk.00/
Nice.
Thanks!
This optimization is obvious in hindsight!
Aren't they all? :-)
/Claes
On 10/17/2018 04:55 PM, Claes Redestad wrote:
> Webrev: http://cr.openjdk.java.net/~redestad/8212597/jdk.00/
Nice. This optimization is obvious in hindsight!
-Aleksey
Hi,
this patch optimizes setup of the default strategy for indified String
concat to setup and use fewer intermediary MHs when some arguments are
non-char primitives.
Webrev: http://cr.openjdk.java.net/~redestad/8212597/jdk.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8212597
I've
Hi Joe,
Looks good, straightforward and easy to understand.
The spec text in the CSR need to be updated to match. (At least the
paragraph about reflexive and atomic).
Thanks, Roger
On 10/16/2018 02:10 PM, Joe Wang wrote:
Hi Daniel,
@linkplain it is! Thanks! And yes, int totalRead was
I'd like to re-boot this review. I've been working with Erik off thread
who's been helping with code and test design.
Some of the main changes worthy of highlighting :
* Separate out the tests for JFR and Logger events
* Rename some events
* Normalize the data view for X509ValidationEvent (old
20 matches
Mail list logo
