> If n == 1, then it would become `mask = n << 32`, and the loop would
run 32 times.
Forget my implementation. It is incorrect at all. In only works for odd
numbers :(
пт, 30 нояб. 2018 г. в 13:58, Ivan Gerasimov :
> Hi Zheka and Tagir!
>
>
> On 11/29/18 10:37 PM, Zheka Kozlov wrote:
> >
Hi Zheka and Tagir!
On 11/29/18 10:37 PM, Zheka Kozlov wrote:
Thanks, Tagir!
I was also thinking of how to calculate hashCode quickly but my direction
was wrong. I thought that we can use the formula of the sum of a geometric
progression: Sum(p^k, k = 0..n) = (1-p^n)/(1-p). Unfortunately,
Brian,
You get the problem outside the proxied network as well; the problem is
that the root certificate used by the DoD is not supported by some
browsers. It needs to be fixed either by the US Navy or by the browsers.
Either way, it's nothing we can fix, although now we understand the root
Hi Alan, Martin,
Do you want me to make any more changes to this patch, or is it OK to go in
with just the modified #ifdef?
Thanks,
Nick
From: Martin Buchholz
Sent: 28 November 2018 11:33
To: Nick Gasson
Cc: Alan Bateman ; Magnus Ihse Bursie
; build-dev ;
core-libs-dev@openjdk.java.net; nd
Thanks, Tagir!
I was also thinking of how to calculate hashCode quickly but my direction
was wrong. I thought that we can use the formula of the sum of a geometric
progression: Sum(p^k, k = 0..n) = (1-p^n)/(1-p). Unfortunately, this
involves division which doesn't work with the overflow of
Hi all,
I updated the Release note, please have a look.
Note that the linked style guide under [3] was not accessible to me
outside Oracle. So I did my best by mimicking the release notes Iris
send me.
Especially, it was not clear to me if we should clearly mark
experimental features as such.
Hi,
Please review the fix for 8213294, which upgrades the IANA LSR data to
the latest available version.
Bug: https://bugs.openjdk.java.net/browse/JDK-8213294
Webrev: http://cr.openjdk.java.net/~nishjain/8213294/webrev.00
Regards,
Nishit Jain
Hello!
If you are doing it fast, why not doing it really fast? If you
deparenthesize and regroup terms, you'll got
h(e, n) = p ^ n + e * f(n)
Where h(e, n) is the hashCode of n elements with hashCode of single
element = e; p = 31 and
f(n) = Sum(p^k, k = 0..n-1)
Using simple algebraic rules,
Hi Joe,
On 30/11/2018 12:14 pm, Joseph D. Darcy wrote:
Hello,
The specification of a system property includes both its name and its
set of legal values. If the set of legal values changes, a CSR is
warranted to document that.
Hmmm. That should be clearly documented on the CSR page(s). At
Hello,
The specification of a system property includes both its name and its
set of legal values. If the set of legal values changes, a CSR is
warranted to document that.
Cheers,
-Joe
On 11/29/2018 4:26 PM, David Holmes wrote:
Hi Roger,
On 30/11/2018 5:54 am, Roger Riggs wrote:
Hi
On 11/1/18 8:12 PM, Kishor Gollapalliwar wrote:
Thank you for providing this opportunity. I'm up for this challenge and I'd
love to take this task. The only huddle would be, how to proceed, ie planning
things step by step, as this is my first time. If you can help me with the
planning, I'll do
Hi Roger,
On 30/11/2018 5:54 am, Roger Riggs wrote:
Hi Thomas,
We'll also need a retroactive CSR for JDK 12 to change its status in JDK
12 to be documented.
With my CSR Group member hat on ... not sure what you mean by
"documented" here? The property already exists and should already have
Looks OK Joe!
> On Nov 29, 2018, at 3:25 PM, Joe Wang wrote:
>
> Thanks Lance. Changed the for loop to a while loop:
>
> http://cr.openjdk.java.net/~joehw/jdk12/8213734/webrev_02/
>
> previous:
> http://cr.openjdk.java.net/~joehw/jdk12/8213734/webrev_01/
>
> -Joe
>
> On 11/29/18, 11:17 AM,
Thanks Lance. Changed the for loop to a while loop:
http://cr.openjdk.java.net/~joehw/jdk12/8213734/webrev_02/
previous:
http://cr.openjdk.java.net/~joehw/jdk12/8213734/webrev_01/
-Joe
On 11/29/18, 11:17 AM, Joe Wang wrote:
Hi,
Please review a fix for the issue as reported that the
Hi Naoto,
Indeed for the Navy links, inside the proxied network I get a “your connection
is not secure” page in Firefox but you indicate this is out of our control.
Therefore this looks OK.
Brian
> On Nov 29, 2018, at 12:11 PM, naoto.s...@oracle.com wrote:
>
> Please review the URL fixes to
Hi,
Please review the URL fixes to the following issues:
https://bugs.openjdk.java.net/browse/JDK-8212870 : Broken links for
www.usno.navy.mil
https://bugs.openjdk.java.net/browse/JDK-8212878 : host in ftp: link not
found
The proposed changesets are located at:
Hi Thomas,
We'll also need a retroactive CSR for JDK 12 to change its status in JDK
12 to be documented.
Can you take a swing at that?
On the Jira issue[2] there is a "More" menu with a 'Create CSR' button.
It comes pre-filled with a template that should be pretty
straightforward to fill
Hi,
Please review a fix for the issue as reported that the SAXParser does
not close the underlying reader. This code always existed in Xerces, but
it was somehow removed as the comment for the closeReaders method
showed. The comment stated "readers are closed in the endEntity method",
that
On 11/29/18 9:08 AM, naoto.s...@oracle.com wrote:
Hi,
I updated the webrev, incorporating Mandy's suggestions. Please review.
http://cr.openjdk.java.net/~naoto/8214170/webrev.02/
Looks okay to me.
Mandy
Hi Michihiro,
I still do not understand which Region node you are swapping. Where it is
coming from?
> + // Swap current RegionNode with new one
Regards,
Vladimir
On 11/28/18 10:31 PM, Michihiro Horie wrote:
Vladimir,Roger,
Thank you so much for your responses.
Vladimir,
Regarding the
Hi,
I updated the webrev, incorporating Mandy's suggestions. Please review.
http://cr.openjdk.java.net/~naoto/8214170/webrev.02/
Naoto
On 11/28/18 5:56 AM, naoto.s...@oracle.com wrote:
Thank you, Mandy, for pointing out. I was wrong on JDK8 result. With a
modified test case, I got the
Hi John & Brian,
Thanks for the proposed approach, I agree we are in the design discussion;
adding such API enhancements will take time, I said 13 to not hurry for 12
(CSR...).
John, you wrote me a very detailed letter, I will try to be more concise
and focus on Array.sort() API.
Le jeu. 29
Hi Deepak,
A small change could avoid creating the array if it would be empty.
Move the array creation inside the if and compare (startIndex < endIndex).
Thanks, Roger
On 11/29/2018 05:10 AM, Deepak Kejriwal wrote:
Hi Roger / Lance,
Thanks for reviewing the fix. I have modified the fix
Hi,
A couple of other thoughts.
Assuming that the performance improvement is significant and
the structure is being put in place to be able to inline on PPC,
we should also consider adding the hand coding the range comparisons for
x64 and other ISAs.
I don't know whether or how much avoiding
Hi Michihiro,
I may have missed the earliest part of this thread.
Have you run performance tests on these functions to ensure no regression
on other platforms and to note the improvements for PPC.
There are a few JMH tests for upper and lower in the
jmh-jdk-microbenchmarks repo. [1]
Hi Stuart,
Thank you Stuart for cleaning up my mistake. I thought I'd done a
recent CI build.
Regards, Roger
On 11/28/2018 09:18 PM, Stuart Marks wrote:
Hi all,
https://bugs.openjdk.java.net/browse/JDK-8214460
Please review this small fix to correct broken macOS build caused by
the fix
Hello Alan & Magnus.
Sorry for you confusion.
I did many copy actions and rename actions.
So you may see, I added unexpected code into non AIX platform.
I think I should not put 2 kind of modification.
For this bug id, I'll handle IBM964 and IBM33722.
(also SimpleEUCEncoder.java is required)
* David Holmes:
> This should really be being discussed on core-libs-dev.
Okay, moving the conversation.
>> diff -r 70a423caee44 src/share/native/com/sun/java/util/jar/pack/zip.cpp
>> --- a/src/share/native/com/sun/java/util/jar/pack/zip.cppTue Oct 09
>> 08:33:33 2018 +0100
>> +++
Hi Roger / Lance,
Thanks for reviewing the fix. I have modified the fix as the review comments
given.
Please find the below the updated webrev for fix.
http://cr.openjdk.java.net/~rpatil/8199776/webrev.02/
Regards,
Deepak
From: Roger Riggs
Sent: Wednesday, November 28, 2018
29 matches
Mail list logo
