Hi Rémi,
I can sponsor this for you. Can you file a bug report?
Thanks,
s'marks
On 11/25/18 12:10 PM, Remi Forax wrote:
ping !
Rémi
- Mail original -
De: "Remi Forax"
À: "core-libs-dev"
Envoyé: Mardi 13 Novembre 2018 15:47:54
Objet: Both Collector.of() are not correctly typed
Hi Vinnie,
Roger Riggs wrote:
The 'forEachOrdered' should not be necessary and may raise questions about why.
if there's no good reason, use 'forEach’.
Using forEachOrdered() is necessary. The dumpAsStream() method produces a
stream; presumably it has a defined order that's the same as its
Hi Stuart,
Looks fine; thanks,
-Joe
On 12/5/2018 4:39 PM, Stuart Marks wrote:
Hi all,
Please review this small fix to correct some broken links in
serialized-form.html. Patch appended below.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8211882
Thanks,
s'marks
# HG changeset
Hi Mandy,
On 12/5/18 1:12 PM, Mandy Chung wrote:
On 12/3/18 11:12 AM, Vicente Romero wrote:
Hi all,
Can I have the final nod to the JVM constants API, there have been
some changes since the last review iteration. Thanks to the internal
and external developers that have taken the time to
Hi all,
Please review this small fix to correct some broken links in
serialized-form.html. Patch appended below.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8211882
Thanks,
s'marks
# HG changeset patch
# User smarks
# Date 1544056617 28800
# Wed Dec 05 16:36:57 2018 -0800
Thanks to everyone who commented on this: it’s pushed at last.
Brian
Hi Sergey,
Hotspot test changes should be reviewed on hotspot-dev not core-libs-dev.
Thanks,
David
On 6/12/2018 6:47 am, Sergey wrote:
Hi,
As stated in the bug description [1] there are few
places in the tests where bash syntax is being used.
First one is (as per ticket):
-
+1
Brian
> On Dec 5, 2018, at 2:16 PM, Lance Andersen wrote:
>
> Looks OK roger :-)
>> On Dec 5, 2018, at 4:42 PM, Roger Riggs wrote:
>>
>> Please review a bug fix for incorrect setting the user.xx.display and
>> user.xx.format
>> system properties when merging the native OS values for
Looks OK roger :-)
> On Dec 5, 2018, at 4:42 PM, Roger Riggs wrote:
>
> Please review a bug fix for incorrect setting the user.xx.display and
> user.xx.format
> system properties when merging the native OS values for locale and the command
> line overiddes. The command line argument for
Please review a bug fix for incorrect setting the user.xx.display and
user.xx.format
system properties when merging the native OS values for locale and the
command
line overiddes. The command line argument for user.xx, if set,
overrides any native
OS settings.
The bug causes a test failure
Hi,
Editorial comments java.lang.contant package javadoc:
- In the Nominal Descriptors 2nd paragraph: "of of" -> "of"
- DirectMethodHandleDescImpl - Its unusual to see a Class named *Impl in
a developer facing API. And if its intended, it should be linked.
- "These classes provides"
Hi,
As stated in the bug description [1] there are few
places in the tests where bash syntax is being used.
First one is (as per ticket):
- vmTestbase/vm/compiler/CodeCacheInfoOnCompilation
I've made a quick fix for that one and patch could be found
inlined below.
Moreover what I've observed is
Hi Michihiro,
On 12/05/2018 07:21 AM, Michihiro Horie wrote:
>There are a few JMH tests for upper and lower in the
jmh-jdk-microbenchmarks repo. [1]
Here is a jmh webrev for the Character methods._
__http://cr.openjdk.java.net/~mhorie/8213754/jmh-webrev.00/_
On 12/3/18 11:12 AM, Vicente Romero wrote:
Hi all,
Can I have the final nod to the JVM constants API, there have been
some changes since the last review iteration. Thanks to the internal
and external developers that have taken the time to provide feedback
so far. The links to the last
Looks fine.
On 12/04/2018 08:07 PM, Brian Burkhalter wrote:
Hi Daniel,
You are correct: at line 154 ’n’ should have been passed instead of ‘-1’ here:
http://cr.openjdk.java.net/~bpb/6516099/webrev.08-delta/
Hi Claes,
This is awesome. Like the change of encapsulating all the individual
fields into the single instance of 'archivedModuleGraph'! All the
improvements look great from subgraph archiving point of view. I'll
leave the module part to Alan, Mandy and others.
Thanks!
Jiangli
On 12/5/18
Looks good to me.
Naoto
On 12/4/18 9:35 PM, Dora Zhou wrote:
Hello,
Please help review the fix for refactor
test/java/util/ResourceBundle/Control/MissingResourceCauseTest.sh to
plain java tests. Thank you.
Bug: https://bugs.openjdk.java.net/browse/JDK-8213127
Webrev:
Hi,
a few improvements to how we archive module graph information:
- archive an instance of ArchiveModuleGraph rather than individual fields
- archiving the exportedPackagesToOpen and concealedPackagesToOpen maps
improve sharing and substantially reduce bytecode executed (~30k)
- archiving the
Hi Roger,
I closed the issue as "Delivered" as you suggested:
https://bugs.openjdk.java.net/browse/JDK-8214454
I hope all is well now. I am still finding my way in this process.
Thanks, Thomas
On Fri, Nov 30, 2018 at 3:28 PM Roger Riggs wrote:
>
> Hi Thomas,
>
> The updates to the release
>There are a few JMH tests for upper and lower in the
jmh-jdk-microbenchmarks repo. [1]
Here is a jmh webrev for the Character methods.
http://cr.openjdk.java.net/~mhorie/8213754/jmh-webrev.00/
Also, I updated C2 changes in the latest webrev. (Thank you for giving
valuable comments off-list,
David, Roger, Alan,
thank you for clarifying all this, and sorry for my confusion.
I found describing jdk.lang.Process.launcMechanism especially
problematic since to understand it one must understand the details of
fork/vfork plus know the details of the underlying implementation of
the libc.
On 05/12/2018 11:02, David Holmes wrote:
:
That said this particular property doesn't seem to actually be
documented directly. No mention of it in the Process API that I can
see. It seems a semi-secret means of influencing the implementation.
So I can understand there can be some confusion
On 5/12/2018 8:54 pm, Alan Bateman wrote:
On 05/12/2018 10:44, David Holmes wrote:
so IMHO for this issue the "specification" should simply be:
Update the allowed values of the jdk.lang.Process.launchMechanism
property on Linux to accept the value "posix_spawn", which will use
the
On 05/12/2018 10:44, David Holmes wrote:
so IMHO for this issue the "specification" should simply be:
Update the allowed values of the jdk.lang.Process.launchMechanism
property on Linux to accept the value "posix_spawn", which will use
the posix_spawn() API. The default value of "vfork"
Hi Thomas,
Pardon the top-posting but ...
The launchMechanism property was introduced by the following issue:
https://bugs.openjdk.java.net/browse/JDK-5049299
at the time there was no CSR process and it went through our internal
CCC process. The "specification" was as follows:
---
Thank you, Joe! Pushed the change.
Frank
>
> Hi Frank,
>
> The change looks good to me. Thanks for fixing the failure!
>
> Best,
> Joe
>
> On 12/4/18, 6:19 PM, Frank Yuan wrote:
> > Hi all
> >
> >
> >
> > Would you like to review this patch?
> >
> > Bug:
John,
Any feedback ?
We could discuss that during next OpenJDK workshop, but I would prefer
going slowly but surely.
Laurent
Le jeu. 29 nov. 2018 à 17:52, Laurent Bourgès a
écrit :
> Hi John & Brian,
>
> Thanks for the proposed approach, I agree we are in the design discussion;
> adding such
Hi Roger,
thanks for all your help, I appreciate it.
I thought a while and got some fundamental doubts about the whole
process, see inline.
On Fri, Nov 30, 2018 at 9:21 PM Roger Riggs wrote:
>
> Hi Thomas,
>
> On 11/30/2018 02:06 PM, Thomas Stüfe wrote:
>
> Hi Roger,
>
> I updated the CSR
28 matches
Mail list logo
