[PATCH] Remove unused variables in io_util_md.c handleLseek

While looking through this code debugging another issue I noticed there were some extra unused local variables. Patch is inline below. Thanks, -Andrew diff --git a/src/java.base/windows/native/libjava/io_util_md.c b/src/java.base/windows/native/libjava/io_util_md.c ---

Re: [PATCH] improve javadoc in TreeSet#add api documentation

Hi Kishor, I took a look at the patch you sent. It looks like it was created against an older repository, paerhaps jdk8u-dev. We don't make spec changes to the older releases. Please base your changes on the latest mainline repository, which is http://hg.openjdk.java.net/jdk/jdk/

Re: 8215759: java/math/BigInteger/ModPow.java can throw an ArithmeticException

HI Stuart, > On Dec 21, 2018, at 11:49 AM, Stuart Marks wrote: > > On 12/21/18 8:36 AM, Brian Burkhalter wrote: >> I updated the test to use RandomFactory: >> http://cr.openjdk.java.net/~bpb/8215759/webrev.01/ >> > > Oddly enough, changing

Re: 8215759: java/math/BigInteger/ModPow.java can throw an ArithmeticException

On 12/21/18 8:36 AM, Brian Burkhalter wrote: I updated the test to use RandomFactory: http://cr.openjdk.java.net/~bpb/8215759/webrev.01/ Oddly enough, changing this to use RandomFactory instead of the fixed seed makes it MORE likely that the random modulus will be zero. But this is OK, since

Re: RFR - CSR: 8213082: (zipfs) Add support for POSIX file permissions

Hello, On 12/21/2018 8:43 AM, Volker Simonis wrote: Hi Alan, thanks for looking at this issue. I've dived into the ZipFS implementation during the last weeks and together with Christoph we've extended and improved both the implementation the test coverage. As Christoph already emphasized, this

Re: RFR - CSR: 8213082: (zipfs) Add support for POSIX file permissions (was: Re: RFR 8213031: (zipfs) Add support for POSIX file permissions)

Hi Alan, thanks for looking at this issue. I've dived into the ZipFS implementation during the last weeks and together with Christoph we've extended and improved both the implementation the test coverage. As Christoph already emphasized, this change is only for improving jdk.nio.zipfs without any

Re: 8215759: java/math/BigInteger/ModPow.java can throw an ArithmeticException

I updated the test to use RandomFactory: http://cr.openjdk.java.net/~bpb/8215759/webrev.01/ Thanks, Brian > On Dec 21, 2018, at 8:22 AM, Brian Burkhalter > wrote: > > Probably you are correct however about the randomness. It should be changed > to use RandomFactory.

Re: [12] RFR: 8214567 and 8214569: Use {@systemProperty} for definitions of system properties

On 12/21/18 1:49 AM, Deepak Kejriwal wrote: Hi all, Please review the fix for following issues:- https://bugs.openjdk.java.net/browse/JDK-8214567 https://bugs.openjdk.java.net/browse/JDK-8214569 Below is the webrev for above issues:

Re: RFR 8213031: (zipfs) Add support for POSIX file permissions

Hi Christoph, thanks for updating the change. I think it is in a good state now and ready to go! Also the documentation in the CSR for this issue ( https://bugs.openjdk.java.net/browse/JDK-8213082) is greatly appreciated and answers all the questions which have been raised so far. So if there

Re: 8215759: java/math/BigInteger/ModPow.java can throw an ArithmeticException

Hi Peter, > On Dec 21, 2018, at 8:15 AM, Peter Levart wrote: > > This is really highly unlikely (1 in 2^800). In fact, it was not possible for > this particular test to produce zero BigInteger. That's because the test uses > a pseudo-random generator with deterministic algorithm and it uses a

Re: 8215759: java/math/BigInteger/ModPow.java can throw an ArithmeticException

Hi Brian, This is really highly unlikely (1 in 2^800). In fact, it was not possible for this particular test to produce zero BigInteger. That's because the test uses a pseudo-random generator with deterministic algorithm and it uses a constant seed to initialize it before generating the next

Re: [12] RFR: 8214567 and 8214569: Use {@systemProperty} for definitions of system properties

Reviewed these and they look good. src/java.base/share/classes/java/time/zone/ZoneRulesProvider.java src/java.base/share/classes/java/util/Currency.java src/java.base/share/classes/java/util/PropertyResourceBundle.java src/java.base/share/classes/java/util/spi/LocaleServiceProvider.java Naoto

Re: 8215759: java/math/BigInteger/ModPow.java can throw an ArithmeticException

Hi Brian, The changes look fine. Adding the bugid to @bug helps close the loop, the test failed, a bug was fixed. Happy Holidays, Roger On 12/20/2018 07:36 PM, Brian Burkhalter wrote: https://bugs.openjdk.java.net/browse/JDK-8215759 http://cr.openjdk.java.net/~bpb/8215759/webrev.00/

RE: RFR 8213031: (zipfs) Add support for POSIX file permissions

Hi all, here comes the updated webrev: http://cr.openjdk.java.net/~clanger/webrevs/8213031.3/ I've rebased the change to the current state of the JDK depot. Thanks to Volker, the test has been enhanced and now also tests more copy operations (from zip file system to zip file system and from

RE: RFR - CSR: 8213082: (zipfs) Add support for POSIX file permissions (was: Re: RFR 8213031: (zipfs) Add support for POSIX file permissions)

Hi Alan, > Adding support for POSIX file permissions to the zip APIs is problematic > as we've been discussing here. There are security concerns and also > concerns that how it interacts with JAR files and signed JAR in > particular. I don't disagree that we can come to agreement on zipfs >

Re: RFR - CSR: 8213082: (zipfs) Add support for POSIX file permissions (was: Re: RFR 8213031: (zipfs) Add support for POSIX file permissions)

On 21/12/2018 10:41, Langer, Christoph wrote: Hi folks, getting back to the topic of adding POSIX file permission support to jdk.zipfs... I think as we are now in the early stages of JDK13, it's a good point in time to get some (hopefully final) activity on that one. In the last review

RFR - CSR: 8213082: (zipfs) Add support for POSIX file permissions (was: Re: RFR 8213031: (zipfs) Add support for POSIX file permissions)

Hi folks, getting back to the topic of adding POSIX file permission support to jdk.zipfs... I think as we are now in the early stages of JDK13, it's a good point in time to get some (hopefully final) activity on that one. In the last review discussions you were asking me to provide some

Re: [12] RFR: 8214567 and 8214569: Use {@systemProperty} for definitions of system properties

On 21/12/2018 09:49, Deepak Kejriwal wrote: Hi all, Please review the fix for following issues:- https://bugs.openjdk.java.net/browse/JDK-8214567 https://bugs.openjdk.java.net/browse/JDK-8214569 Below is the webrev for above issues:

[12] RFR: 8214567 and 8214569: Use {@systemProperty} for definitions of system properties

Hi all, Please review the fix for following issues:- https://bugs.openjdk.java.net/browse/JDK-8214567 https://bugs.openjdk.java.net/browse/JDK-8214569 Below is the webrev for above issues: http://cr.openjdk.java.net/~rpatil/8214567%2b8214569/webrev.00/ Regards, Deepak