Re: RFR 8218228 : The constructor StringBuffer(CharSequence) violates spec for negatively sized argument

On 2/7/19 6:33 PM, David Holmes wrote: On 8/02/2019 11:59 am, Ivan Gerasimov wrote: Hi David! On 2/7/19 5:16 PM, David Holmes wrote: Hi Ivan, On 8/02/2019 11:02 am, Ivan Gerasimov wrote: Hello! The specification states: """ If the length of the specified CharSequence is less than or

Re: RFR 8218228 : The constructor StringBuffer(CharSequence) violates spec for negatively sized argument

On 8/02/2019 11:59 am, Ivan Gerasimov wrote: Hi David! On 2/7/19 5:16 PM, David Holmes wrote: Hi Ivan, On 8/02/2019 11:02 am, Ivan Gerasimov wrote: Hello! The specification states: """ If the length of the specified CharSequence is less than or equal to zero, then an empty buffer of

Re: RFR 8218228 : The constructor StringBuffer(CharSequence) violates spec for negatively sized argument

Hi David! On 2/7/19 5:16 PM, David Holmes wrote: Hi Ivan, On 8/02/2019 11:02 am, Ivan Gerasimov wrote: Hello! The specification states: """ If the length of the specified CharSequence is less than or equal to zero, then an empty buffer of capacity 16 is returned. """ However, the current

Re: RFR 8218228 : The constructor StringBuffer(CharSequence) violates spec for negatively sized argument

Hi Ivan, On 8/02/2019 11:02 am, Ivan Gerasimov wrote: Hello! The specification states: """ If the length of the specified CharSequence is less than or equal to zero, then an empty buffer of capacity 16 is returned. """ However, the current implementation throws either

RFR 8218228 : The constructor StringBuffer(CharSequence) violates spec for negatively sized argument

Hello! The specification states: """ If the length of the specified CharSequence is less than or equal to zero, then an empty buffer of capacity 16 is returned. """ However, the current implementation throws either NegativeArraySizeException or IndexOutOfBounds instead (the actual exception

Re: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

In 8/02/2019 10:05 am, David Holmes wrote: Hi Volker, Aaarggh!! Sorry Volker and Goetz. No idea where that came from. David - You know I'm not going to be a big fan of this :), but as long as we don't pay for it if we don't want it, then that's okay. (I'm still trying to gauge that)

Re: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Hi Volker, You know I'm not going to be a big fan of this :), but as long as we don't pay for it if we don't want it, then that's okay. (I'm still trying to gauge that) I have a little test for this that I ran through your patch: public class NPE { static class B { C b() { return

Re: RFR: JDK-8217687: jpackage --help improvements

Hi Andy, http://cr.openjdk.java.net/~herrick/8217687/webrev.01/src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources.properties.frames.html Line 140: I think we do not need " at the end. Otherwise looks fine. Thanks, Alexander On 2/7/2019 9:11 AM, Andy Herrick wrote:

Re: RFR(s): 8212828: (process) Change the Process launch mechanism default on Linux to be posix_spawn

Hi, I agree with Martin's editorial comments. I've had an eye on the helperPath methods and they could be removed; the path is no longer architecture specific and javahome is available statically; So the methods can be removed and helperpath reduces to: 172 private static final byte[]

Re: RFR(s): 8212828: (process) Change the Process launch mechanism default on Linux to be posix_spawn

This is very good. Approved. But as always I have review suggestions typos: ithe Preceede => Precede Drop "the" How does the glibc implement posix_spawn? How does the muslc implement posix_spawn? parents => the parent CLONE_VFORK means parents waits until we exec, as with (2) an own => a

Re: RFR: JDK-8214564 : --win-upgrade-uuid does not work as expected

looks good to me. /ANdy On 2/6/2019 11:18 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Upgrade did not work, because element was missing. Fixed by adding this

RFR: JDK-8217687: jpackage --help improvements

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). JDK-8217687: jpackage --help improvements Changes to help text, internal names, and several tests. [1]

Re: RFR(s): 8212828: (process) Change the Process launch mechanism default on Linux to be posix_spawn

Hi all, second version, including the updated comment in ProcessImpl.c Martin requested: http://cr.openjdk.java.net/~stuefe/webrevs/8213192--(process)-change-the-process-launch-mechanism-default-on-linux-to-be-posix_spawn/webrev.01/webrev/index.html @Roger: thanks for feeding this into your

RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Hi, since Java 5, our internal VM reports verbose null pointer exception messages. I would like to contribute this feature to OpenJDK. With this change, messages as "java.lang.NullPointerException: while trying to load from a null int array loaded from local variable 'ia1'" are printed. For

Re: RFR(s): 8212828: (process) Change the Process launch mechanism default on Linux to be posix_spawn

Hi Thomas, The CI tests here ran fine. Overall looks ok. Regards, Roger On 02/06/2019 01:16 PM, Thomas Stüfe wrote: Hi Roger, On Wed, Feb 6, 2019 at 4:15 PM Roger Riggs > wrote: Hi Thomas, On 02/06/2019 04:29 AM, Thomas Stüfe wrote: Hi all

Re: [PATCH] Improvements in jdk.internal.org.objectweb.asm.Type

On 06/02/2019 21:26, Сергей Цыпанов wrote: Hello, several days ago I’ve proposed some improvements into asm library: - https://gitlab.ow2.org/asm/asm/commit/ef945457bc19dbc09c02bd21b52f1950990f33f7 - https://gitlab.ow2.org/asm/asm/commit/9b914d524b7fe7ea694fc11ec784e67133ba383f The patches