Re: Proposal: JDK-8148917 Enhanced-For Statement Should Allow Streams

2019-02-28 Thread Tagir Valeev
One more alternative which could be considered (though it requires a language change) is to allow the inference of Iterable type for enhanced for when iteration value is a function expression and iteration parameter type is explicitly specified as T. In this case for(T t : stream::iterator) {}

Re: Proposal: JDK-8148917 Enhanced-For Statement Should Allow Streams

2019-02-28 Thread Tagir Valeev
Hello! The proposal looks good to me. In particular it's very nice to have this properly (ability to iterate only once) to be encoded in the type system. This could be helpful for static analysis tools to warn when IterableOnce is reused. Scanner case looks funny. In general such pattern could

RFR: JDK-8219889 : Update jpackage tests for JDK-8219678 changes

2019-02-28 Thread Alexander Matveev
Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Remove JPackageCreateImageOverwriteTest and JPackageCreateImageStripNativeCommandsTest. - Remove usage of --overwrite. [1]

Proposal: JDK-8148917 Enhanced-For Statement Should Allow Streams

2019-02-28 Thread Stuart Marks
Hi all, Please review and comment on this proposal to allow Stream instances to be used in enhanced-for ("for-each") loops. Abstract Occasionally it's useful to iterate a Stream using a conventional loop. However, the Stream interface doesn't implement Iterable, and therefore streams cannot

Re: [PATCH] 8218268: Javac treats Manifest Class-Path entries as Paths instead of URLs

2019-02-28 Thread Jonathan Gibbons
On 02/28/2019 01:06 PM, Alan Bateman wrote: On 28/02/2019 20:58, Jonathan Gibbons wrote: Looking at the revised JAR specification, approved in [1], it is disappointing that the spec contains text which is specific to a JAR file being used in a classloader: |The resulting URLs are inserted

Re: [13] RFR: 8219890: Calendar.getDisplayName() returns empty string for new Japanese Era on some locales

2019-02-28 Thread Lance Andersen
looks fine Naoto > On Feb 28, 2019, at 4:15 PM, Naoto Sato wrote: > > Hello, > > Please review the fix to the following issue: > > https://bugs.openjdk.java.net/browse/JDK-8219890 > > The proposed changeset is located at: > > http://cr.openjdk.java.net/~naoto/8219890/webrev.00/ > > After

[13] RFR: 8219890: Calendar.getDisplayName() returns empty string for new Japanese Era on some locales

2019-02-28 Thread Naoto Sato
Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8219890 The proposed changeset is located at: http://cr.openjdk.java.net/~naoto/8219890/webrev.00/ After the fix for 8217609, some locales return empty string for the display name for the new era.

Re: [PATCH] 8218268: Javac treats Manifest Class-Path entries as Paths instead of URLs

2019-02-28 Thread Alan Bateman
On 28/02/2019 20:58, Jonathan Gibbons wrote: Looking at the revised JAR specification, approved in [1], it is disappointing that the spec contains text which is specific to a JAR file being used in a classloader: |The resulting URLs are inserted into the search path of the class loader opening

Re: [PATCH] 8218268: Javac treats Manifest Class-Path entries as Paths instead of URLs

2019-02-28 Thread Jonathan Gibbons
Looking at the revised JAR specification, approved in [1], it is disappointing that the spec contains text which is specific to a JAR file being used in a classloader: |The resulting URLs are inserted into the search path of the class loader opening the context JAR immediately following the

Re: Manifest ignores last line if not terminated by line break

2019-02-28 Thread Lance Andersen
Hi Philipp, Thank you for looking into this issue and proposing a fix. I ran the JCK and encountered 9 failures similar to the JavaClassPathTest failure. The JCK tests that I looked at did not validate all of the attributes which is one of the reasons this was not caught earlier Given the

[PATCH] 8218268: Javac treats Manifest Class-Path entries as Paths instead of URLs

2019-02-28 Thread Donald Kwakkel
a Hi All, This is my first contribution to openjdk, so hope to learn a lot! I first posted this to compiler-dev, but they explained that I better can discuss this first on this list. I created a fix + tests for https://bugs.openjdk.java.net/browse/JDK-8218268 (I will rewrite the test to java

Re: [8u-dev] Request for Approval: Backport of JDK-8202088, JDK-8207152, JDK-8211398, JDK-8180469, JDK-8206120, JDK-8218915, JDK-8217710

2019-02-28 Thread Hohensee, Paul
I added the 'jdk8u-fix-request' tag to these issues. Paul On 2/28/19, 3:13 AM, "core-libs-dev on behalf of Deepak Kejriwal" wrote: Hi All, Please approve the backport of following bugs to 8u-dev. JDK-8202088 : Japanese new era implementation

[8u-dev] Request for Approval: Backport of JDK-8202088, JDK-8207152, JDK-8211398, JDK-8180469, JDK-8206120, JDK-8218915, JDK-8217710

2019-02-28 Thread Deepak Kejriwal
Hi All, Please approve the backport of following bugs to 8u-dev. JDK-8202088 : Japanese new era implementation JDK-8207152 : Placeholder for Japanese new era should be two characters JDK-8211398 : Square character support for the Japanese new era JDK-8180469 : Wrong short form text for

Re: "java.lang.Error: Probable fatal error:No fonts found" does not show on 11

2019-02-28 Thread Bernd Eckenfels
Hello, I can confirm the same ugly error stack with 12-b33 EA, this time with debug: $ jdk-12/bin/java -cp . -Dsun.java2d.debugfonts=true FontTest Are we headless? true g = sun.java2d.HeadlessGraphicsEnvironment headless: true Feb 28, 2019 9:50:32 AM sun.awt.X11FontManager registerFontDir INFO: