Re: RFR: JDK-8139820: URLClassPath.FileLoader constructor redundantly checks protocol

2019-08-18 Thread Claes Redestad
Hi, On 2019-08-18 21:22, Evgeny Mandrikov wrote: [1] https://cr.openjdk.java.net/~godin/8139820/webrev.00/ looks ok to me. I'd add a comment that protocol is assumed to be "file", and perhaps make the constructor private (valid since JDK 11). I can sponsor the change, seeing how I

RFR: JDK-8139820: URLClassPath.FileLoader constructor redundantly checks protocol

2019-08-18 Thread Evgeny Mandrikov
Hello! Please review patch [1] for JDK-8139820 [2]. Also it needs a sponsor since I have only author status in OpenJDK Census [3]. With best regards, Evgeny Mandrikov [1] https://cr.openjdk.java.net/~godin/8139820/webrev.00/ [2] https://bugs.openjdk.java.net/browse/JDK-8139820 [3]