Re: [EXTERNAL] JDK-8234076 bug fix candidate

Nikola, The change looks fine to me as well, I’ll run the test and push it before RDP1 if everything is good with Kumar as reviewer. Cheers, Henry > On Dec 11, 2019, at 2:26 PM, Kumar Srinivasan wrote: > > Hi Nikola, > > Thank you for making the changes. Looks good to me. > > Kumar

Re: [14] Review Request: 8233827 Enable screenshots in the enhanced failure handler on Linux/macOS

Hi Sergey, overall looks good to me. a question about linux, is there an alternative to gnome-screenshot for DEs other than GNOME? -- Igor > On Dec 11, 2019, at 1:00 AM, Sergey Bylokhov > wrote: > > Hello. > Please review the fix for JDK 14. > > Bug:

Re: RFR: 8235625: [TESTBUG] tools/jpackage/share/JavaOptionsEqualsTest.java fails with debug VMs

Thanks Andy for your review. Done. Best regards, Jie

8235668: LineNumberReader#getLineNumber() returns wrong line number (one fewer) in Lucene test

https://bugs.openjdk.java.net/browse/JDK-8235668 http://cr.openjdk.java.net/~bpb/8235668/webrev.00/ Due to the problems reported in [1], in the interest of not changing longstanding behavior, we would like to revert the fix for [2], despite the fact that it makes the behavior of

Re: [EXTERNAL] JDK-8234076 bug fix candidate

Hi Nikola, Thank you for making the changes. Looks good to me. Kumar Srinivasan PS: my new and official email address: kusriniva...@vmware.com On Wed, Dec 11, 2019 at 10:04 AM Nikola Grcevski < nikola.grcev...@microsoft.com> wrote: > Thank you again for reviewing my code Kumar! > > I have

RFR 8235238: Parsing a time string ignores any custom TimeZoneNameProvider

Hi, Please review the fix for the following issue: https://bugs.openjdk.java.net/browse/JDK-8235238 The proposed changeset is located at: https://cr.openjdk.java.net/~naoto/8235238/webrev.00/ The fix will retrieve the custom zone names from the time zone name provider, for the custom

Re: RFR: JDK-8235252: Repair run_tests.sh by locating jtreg locally

looks good /Andy On 12/11/2019 3:59 PM, Alexander Matveev wrote: webrev.01 is incorrect, since it uses JTREG_ prefix for variables name. Correct webrev is http://cr.openjdk.java.net/~almatvee/8235252/webrev.02/ It is identical to webrev.01, except prefix of variable names changed to JT_.

Re: RFR: JDK-8235252: Repair run_tests.sh by locating jtreg locally

webrev.01 is incorrect, since it uses JTREG_ prefix for variables name. Correct webrev is http://cr.openjdk.java.net/~almatvee/8235252/webrev.02/ It is identical to webrev.01, except prefix of variable names changed to JT_. Thanks, Alexander On 12/10/19 3:54 PM, Alexander Matveev wrote:

Re: RFR: JDK-8235728: JDK-8212780 breaks builds with a custom X11 include path

ok. all good. -phil On 12/11/19 12:14 PM, Alexey Semenyuk wrote: Yes, I did a test build. - Alexey On 12/11/2019 1:48 PM, Phil Race wrote: Looks OK. I presume you did a test build in our build system ? -phil On 12/11/19 10:46 AM, Alexey Semenyuk wrote: Please review fix [2] for jpackage

Re: RFR: 8235788: Changeset for JDK-8235252 pushed with wrong bug ID

Looks good. - Alexey On 12/11/2019 2:57 PM, Phil Race wrote: +1 -phil On 12/11/19 11:43 AM, Andy Herrick wrote: sorry - fix is at: [3] http://cr.openjdk.java.net/~herrick/8235788/webrev.01/ /Andy On 12/11/2019 2:42 PM, Andy Herrick wrote: Please review fix [1] for issue [2] This is

Re: RFR: JDK-8235728: JDK-8212780 breaks builds with a custom X11 include path

Yes, I did a test build. - Alexey On 12/11/2019 1:48 PM, Phil Race wrote: Looks OK. I presume you did a test build in our build system ? -phil On 12/11/19 10:46 AM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. - adds $(X_CFLAGS) to compiler command line. Patch

Re: RFR: 8235788: Changeset for JDK-8235252 pushed with wrong bug ID

+1 -phil On 12/11/19 11:43 AM, Andy Herrick wrote: sorry - fix is at: [3] http://cr.openjdk.java.net/~herrick/8235788/webrev.01/ /Andy On 12/11/2019 2:42 PM, Andy Herrick wrote: Please review fix [1] for issue [2] This is backing out the fix to JDK-8235252 so I can re-push it with the

Re: RFR: 8235788: Changeset for JDK-8235252 pushed with wrong bug ID

sorry - fix is at: [3] http://cr.openjdk.java.net/~herrick/8235788/webrev.01/ /Andy On 12/11/2019 2:42 PM, Andy Herrick wrote: Please review fix [1] for issue [2] This is backing out the fix to JDK-8235252 so I can re-push it with the right comment [1] 8235788

RFR: 8235788: Changeset for JDK-8235252 pushed with wrong bug ID

Please review fix [1] for issue [2] This is backing out the fix to JDK-8235252 so I can re-push it with the right comment [1] 8235788 Changeset for JDK-8235252 pushed with wrong bug ID [2] https://bugs.openjdk.java.net/browse/JDK-8235788

Re: RFR: JDK-8235728: JDK-8212780 breaks builds with a custom X11 include path

looks good /Andy On 12/11/2019 1:46 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. - adds $(X_CFLAGS) to compiler command line. Patch contributed by Arthur Eubanks (aeuba...@google.com). - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8235728 [2]

Re: RFR: JDK-8235728: JDK-8212780 breaks builds with a custom X11 include path

Looks good, thanks for fixing this! On Wed, Dec 11, 2019 at 10:55 AM Erik Joelsson wrote: > Looks good. > > /Erik > > On 2019-12-11 10:46, Alexey Semenyuk wrote: > > Please review fix [2] for jpackage bug [1]. > > > > - adds $(X_CFLAGS) to compiler command line. > > > > Patch contributed by

Re: RFR: JDK-8235728: JDK-8212780 breaks builds with a custom X11 include path

Looks good. /Erik On 2019-12-11 10:46, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. - adds $(X_CFLAGS) to compiler command line. Patch contributed by Arthur Eubanks (aeuba...@google.com). - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8235728 [2]

Re: RFR: JDK-8235728: JDK-8212780 breaks builds with a custom X11 include path

Looks OK. I presume you did a test build in our build system ? -phil On 12/11/19 10:46 AM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. - adds $(X_CFLAGS) to compiler command line. Patch contributed by Arthur Eubanks (aeuba...@google.com). - Alexey [1]

RFR: JDK-8235728: JDK-8212780 breaks builds with a custom X11 include path

Please review fix [2] for jpackage bug [1]. - adds $(X_CFLAGS) to compiler command line. Patch contributed by Arthur Eubanks (aeuba...@google.com). - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8235728 [2] http://cr.openjdk.java.net/~asemenyuk/8235728/webrev.00

RE: [EXTERNAL] JDK-8234076 bug fix candidate

Thank you again for reviewing my code Kumar! I have applied your refactoring suggestions. Using the array approach as you suggested made the test code a lot more tidier. I’m attaching the updated patch after my signature and the external webrev is here for reference:

Re: RFR: 8235730: Incorrect javadoc in MatchKind

Indeed it is, thanks. Resolved. s'marks On 12/11/19 8:41 AM, Stefan Zobel wrote: FWIW, I believe this bug is duplicate of https://bugs.openjdk.java.net/browse/JDK-8213238 Regards, Stefan Am Mi., 11. Dez. 2019 um 17:07 Uhr schrieb Arthur Eubanks : Hi, could I get a review for a trivial and

Re: RFR: 8235730: Incorrect javadoc in MatchKind

FWIW, I believe this bug is duplicate of https://bugs.openjdk.java.net/browse/JDK-8213238 Regards, Stefan Am Mi., 11. Dez. 2019 um 17:07 Uhr schrieb Arthur Eubanks : > > Hi, could I get a review for a trivial and tiny doc fix? > > Bug: https://bugs.openjdk.java.net/browse/JDK-8235730 > Webrev:

Re: RFR JDK-8234049: Implementation of Memory Access API (Incubator)

Looks very good, Paul. > On Dec 11, 2019, at 7:39 AM, Maurizio Cimadamore > wrote: > > I went ahead and created a new revision: > > http://cr.openjdk.java.net/~mcimadamore/panama/8234049_v6/ > > Delta from latest (v5) here: > >

Re: RFR: 8235730: Incorrect javadoc in MatchKind

Looks good to me. My own policy is to never update Oracle copyright years for changes by a non-Oracle employee. On Wed, Dec 11, 2019 at 8:30 AM Pavel Rappo wrote: > Looks good to me. Trivially, update the copyright years before pushing. > > This is one of those changes that decrease the

Re: RFR: 8235730: Incorrect javadoc in MatchKind

Looks good to me. Trivially, update the copyright years before pushing. This is one of those changes that decrease the entropy, but have little visible effects on the outside world. Neither MatchOps nor MatchOps.MatchKind type should be visible in the online API docs. P.S. I'm not a Reviewer.

Re: RFR (S): 8235750: [jpackage] Cleanup imports in WinMsiBundler.java

Looks good. - Alexey On 12/11/2019 9:25 AM, Andy Herrick wrote: looks good - thank you. /Andy On 12/11/2019 5:02 AM, Langer, Christoph wrote: Hi, please review this import statements cleanup for src/jdk.incubator.jpackage/windows/classes/jdk/incubator/jpackage/internal/WinMsiBundler.java.

Re: RFR: JDK-8235767: Compilation failure caused by JDK-8212780: Packaging Tool Implementation

Looks good. - Alexey On 12/11/2019 10:42 AM, Andy Herrick wrote: The revised webrev at [3] is confirmed by the submitter to fix the build. please review /Andy [3] http://cr.openjdk.java.net/~herrick/8235767/webrev.02/ On 12/11/2019 9:49 AM, Andy Herrick wrote: Please review simple

Re: RFR: JDK-8234284: [dmg] Change DMG background image to TIFF

Looks good. - Alexey On 12/10/2019 10:24 PM, Alexander Matveev wrote: Please review fix [2] for jpackage bug [1].  - Changed background image for DMG to TIFF format, which can be used to embed 2x image to support HiDPI displays. Thanks, Alexander [1]

Re: RFR: JDK-8234284: [dmg] Change DMG background image to TIFF

Build change looks good. /Erik On 2019-12-11 06:54, Andy Herrick wrote: Fix looks fine to me. adding build-dev since even this simple a makefile change should be reviewed by build-dev On 12/10/2019 10:24 PM, Alexander Matveev wrote: Please review fix [2] for jpackage bug [1].  - Changed

Re: RFR: JDK-8235767: Compilation failure caused by JDK-8212780: Packaging Tool Implementation

That fix looks good to me. Thanks! Roman > The revised webrev at [3] is confirmed by the submitter to fix the build. > > please review > > /Andy > > [3] http://cr.openjdk.java.net/~herrick/8235767/webrev.02/ > > On 12/11/2019 9:49 AM, Andy Herrick wrote: >> Please review simple jpackage fix

Re: RFR JDK-8234049: Implementation of Memory Access API (Incubator)

I went ahead and created a new revision: http://cr.openjdk.java.net/~mcimadamore/panama/8234049_v6/ Delta from latest (v5) here: http://cr.openjdk.java.net/~mcimadamore/panama/8234049_v6_delta/ No javadoc chnages here. Summary of changes: * addressed Paul feedback on MemoryScope * on

Re: RFR: JDK-8234284: [dmg] Change DMG background image to TIFF

Fix looks fine to me. adding build-dev since even this simple a makefile change should be reviewed by build-dev On 12/10/2019 10:24 PM, Alexander Matveev wrote: Please review fix [2] for jpackage bug [1].  - Changed background image for DMG to TIFF format, which can be used to embed 2x

RFR: JDK-8235767: Compilation failure caused by JDK-8212780: Packaging Tool Implementation

Please review simple jpackage fix for issue [1] at [2] [1] https://bugs.openjdk.java.net/browse/JDK-8235767 [2] http://cr.openjdk.java.net/~herrick/8235767/webrev.01/ /Andy

Re: RFR (S): 8235750: [jpackage] Cleanup imports in WinMsiBundler.java

looks good - thank you. /Andy On 12/11/2019 5:02 AM, Langer, Christoph wrote: Hi, please review this import statements cleanup for src/jdk.incubator.jpackage/windows/classes/jdk/incubator/jpackage/internal/WinMsiBundler.java. I stumbled over an issue when I imported the jpackage project

Re: RFR: 8235625: [TESTBUG] tools/jpackage/share/JavaOptionsEqualsTest.java fails with debug VMs

yes - looks good /Andy On 12/9/2019 9:26 PM, Jie Fu wrote: Hi all, May I get reviews for the small fix? JBS:    https://bugs.openjdk.java.net/browse/JDK-8235625 Webrev: http://cr.openjdk.java.net/~jiefu/8235625/webrev.00/ Thanks a lot. Best regards, Jie

RE: [8u] RFR: JDK-8227715: GPLv2 files missing Classpath Exception

Thanks Paul. :) Best Regards Adam Farley IBM Runtimes "Hohensee, Paul" wrote on 10/12/2019 20:16:31: > From: "Hohensee, Paul" > To: Severin Gehwolf , Adam Farley8 > , Java Core Libs > Cc: jdk8u-dev > Date: 10/12/2019 20:16 > Subject: [EXTERNAL] Re: [8u] RFR: JDK-8227715: GPLv2 files

Re: Multi Part publisher for java.net.http.HttpClient

Hi Behrang, net-dev is a better list to discuss networking/http related topics. On 03/12/2019 12:22, Behrang Saeedzadeh wrote:> Hi all, > > Are there any plans to implement a "multipart/form-data" BodyPublisher in > Java 14 or later? There are no plans - especially not for 14 since we will be

Re: RFR: JDK-8229871: Improve performance of Method.copy() and leafCopy()

Hi, I re-evaluated the performance of Peter's improvement [1] using the same base version. Sorry for taking long time, but it took time to verify if results are reliable. The Peter's version reduced elapsed time of a micro bench [2] that repeatedly calls Class.getMethods() by 30.3%.

RFR (S): 8235750: [jpackage] Cleanup imports in WinMsiBundler.java

Hi, please review this import statements cleanup for src/jdk.incubator.jpackage/windows/classes/jdk/incubator/jpackage/internal/WinMsiBundler.java. I stumbled over an issue when I imported the jpackage project into Eclipse. Due to importing both, static

Re: RFR: 8235625: [TESTBUG] tools/jpackage/share/JavaOptionsEqualsTest.java fails with debug VMs

Hi Alexey, Thanks for your review [1]. May I get one more review from a reviewer? Thanks a lot. Best regards, Jie [1] https://mail.openjdk.java.net/pipermail/core-libs-dev/2019-December/063967.html On 2019/12/10 上午10:26, Jie Fu wrote: Hi all, May I get reviews for the small fix? JBS:   

[14] Review Request: 8233827 Enable screenshots in the enhanced failure handler on Linux/macOS

Hello. Please review the fix for JDK 14. Bug: https://bugs.openjdk.java.net/browse/JDK-8233827 Fix: http://cr.openjdk.java.net/~serb/8233827/webrev.01 This change adds the "screen capture on the test failure" feature on macOS and Linux. - On Linux, it is implemented by the "gnome-screenshot"