1) ZoneRules.of() implies that transitionList is a superset of
standardOffsetTransitionList but doesn't check that. Then it's possible to
construct ZoneRules instances that don't work correctly:
@Test
public void zoneRulesTest() {
LocalDateTime transitionDay =
looks good.
/Andy
On 1/29/2020 4:02 PM, Alexander Matveev wrote:
Please review the jpackage fix for bug [1] at [2].
- Fixed code which enumerates folders and files to include empty folders.
- Added EmptyFolderTest.
[1] https://bugs.openjdk.java.net/browse/JDK-8233166
[2]
I guess we need tests for empty folders in packages on all platforms.
They can be a part of the fix or a follow up CR. Whatever your prefer.
- Alexey
On 1/29/2020 4:02 PM, Alexander Matveev wrote:
Please review the jpackage fix for bug [1] at [2].
- Fixed code which enumerates folders and
Please review the jpackage fix for bug [1] at [2].
- Fixed code which enumerates folders and files to include empty folders.
- Added EmptyFolderTest.
[1] https://bugs.openjdk.java.net/browse/JDK-8233166
[2] http://cr.openjdk.java.net/~almatvee/8233166/webrev.00/
Thanks,
Alexander
+1
-phil.
On 1/29/20, 10:34 AM, Andy Herrick wrote:
Please review trivial jpackage fix to [1] at [2]
[1] https://bugs.openjdk.java.net/browse/JDK-8238168
[2] http://cr.openjdk.java.net/~herrick/8238168/webrev.01/
/Andy
Looks good.
- Alexey
On 1/29/2020 1:34 PM, Andy Herrick wrote:
Please review trivial jpackage fix to [1] at [2]
[1] https://bugs.openjdk.java.net/browse/JDK-8238168
[2] http://cr.openjdk.java.net/~herrick/8238168/webrev.01/
/Andy
Looks good.
+1
-- Kevin
On 1/29/2020 10:34 AM, Andy Herrick wrote:
Please review trivial jpackage fix to [1] at [2]
[1] https://bugs.openjdk.java.net/browse/JDK-8238168
[2] http://cr.openjdk.java.net/~herrick/8238168/webrev.01/
/Andy
Please review trivial jpackage fix to [1] at [2]
[1] https://bugs.openjdk.java.net/browse/JDK-8238168
[2] http://cr.openjdk.java.net/~herrick/8238168/webrev.01/
/Andy
On 1/29/20 8:32 AM, Maurizio Cimadamore wrote:
On 28/01/2020 23:31, David Holmes wrote:
I tested again with jdk_core and hotspot_all_no_apps with no new
failures.
Would you or Maurizio mind sponsoring this for me if your testing is
OK?
Sorry, as the bulk of this change is core-libs code
Thanks for the reviews. I found an issue with the new test also -
it's loading the custom factory class via the non-serviceloader
approach. I was hoping to exercise ServiceLoader here. I'll address this
and the comments raised and revert with a new patch shortly.
Regards,
Sean.
On 29/01/20
On 28/01/2020 23:31, David Holmes wrote:
Hi Nick,
On 27/01/2020 4:41 pm, Nick Gasson wrote:
Hi David,
On 01/25/20 06:34 am, David Holmes wrote:
I've done this here:
http://cr.openjdk.java.net/~ngasson/8237521/webrev.02/
Need to check bytes >= 0 before aligning up so that
On 29/01/2020 15:55, Daniel Fuchs wrote:
Hi Seán,
http://cr.openjdk.java.net/~coffeys/webrev.8223260.v1/webrev/
A WeakHashKey with the TCCL as the key should be okay here.
If the TCCL is the key then there are good chances that the
concrete factory class is expected to be loaded by the TCCL.
Hi Seán,
http://cr.openjdk.java.net/~coffeys/webrev.8223260.v1/webrev/
A WeakHashKey with the TCCL as the key should be okay here.
If the TCCL is the key then there are good chances that the
concrete factory class is expected to be loaded by the TCCL.
If that happens then the value will
13 matches
Mail list logo
