In that case, I'll withdraw it, unless a maintenance review comes along.
Thanks,
Paul
On 2/19/20, 9:01 AM, "Joe Darcy" wrote:
As a practical matter, no. Since a Java SE specification is modified by
this changeset, a maintenance review (MR) would be needed for Java SE 11
for this
On 19/02/2020 05:45, Joe Darcy wrote:
> Hi Paul,
>
> This looks like a spec change to a Java SE API so would be out of bounds
> for 11u without a maintenance update of Java SE 11.
>
> Naoto, do you agree with that analysis?
>
> Thanks,
>
> -Joe
>
> On 2/18/2020 5:44 PM, Hohensee, Paul
As a practical matter, no. Since a Java SE specification is modified by
this changeset, a maintenance review (MR) would be needed for Java SE 11
for this change to go into 11u.
HTH,
-Joe
On 2/19/2020 8:09 AM, Hohensee, Paul wrote:
So, not backportable?
Paul
On 2/19/20, 5:23 AM,
So, not backportable?
Paul
On 2/19/20, 5:23 AM, "naoto.s...@oracle.com" wrote:
Hi Joe, Paul,
Yes, I was thinking the same. It is a spec change in 14.
Naoto
On 2/18/20 9:45 PM, Joe Darcy wrote:
> Hi Paul,
>
> This looks like a spec change to a Java
Matthias,
There is
jdk.incubator.jpackage.internal.LinuxRpmBundler.TOOL_RPMBUILD_MIN_VERSION
constant that is currently set to "4.0". Feel free to file a CR and bump
it up to "4.10"
- Alexey
On 2/19/2020 3:05 AM, Baesken, Matthias wrote:
Thank's for the reviews.
Do you have a good
Hi Joe, Paul,
Yes, I was thinking the same. It is a spec change in 14.
Naoto
On 2/18/20 9:45 PM, Joe Darcy wrote:
Hi Paul,
This looks like a spec change to a Java SE API so would be out of bounds
for 11u without a maintenance update of Java SE 11.
Naoto, do you agree with that analysis?
+1
Gruß, Thomas
On Wed, Feb 19, 2020, 10:35 Baesken, Matthias
wrote:
> Hello Thomas / Lance / Martin, thanks for the reviews .
>
> I added a little helper function, new webrev :
>
>
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8239351.1/
>
>
>
> Best regards, Matthias
>
>
>
>
>
>
>
> I
Hello Thomas / Lance / Martin, thanks for the reviews .
I added a little helper function, new webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8239351.1/
Best regards, Matthias
I like this too. +1 for factoring out throwing the error.
..Thomas
On Tue, Feb 18, 2020 at 6:51 PM Martin
Thank's for the reviews.
Do you have a good central place in the existing coding to add a similar
rpmbuild version check (e.g. for 4.10 or 4.11 which seem to be reasonable ) ?
Best regards, Matthias
> +1
>
> - Alexey
>
> On 2/18/2020 10:56 AM, Langer, Christoph wrote:
> > Hi
