On Mar 20, 2020, at 10:49 AM, Jorn Vernee wrote:
>
> W.r.t. the source type being needed, I see the following 4 major cases:
>
> 1. src=Prim & dst=Prim -> cast convert. For boolean the least-significant-bit
> is used to convert it to/from an integer type.
> 2. src=Prim & dst=Ref -> box the
Thanks Ivan, I merged your changes with mine and pushed the resulting changeset.
> On 20 Mar 2020, at 20:11, Ivan Gerasimov wrote:
>
> Thank you Paul!
>
> grep found a few more occurrences of 'equals to' across java.base, so I
> fixed them as well.
>
> Here's the updated webrev:
>
>
Thank you Paul!
grep found a few more occurrences of 'equals to' across java.base, so
I fixed them as well.
Here's the updated webrev:
http://cr.openjdk.java.net/~igerasim/XXX-typos/01/webrev/
Pavel, I checked your portion of correction, everything looks good to me!
One minor nit:
On 20/03/2020 16:17, Mandy Chung wrote:
:
I like these shorter names.
Updated webrev.02 in place.
Looks good.
W.r.t. the source type being needed, I see the following 4 major cases:
1. src=Prim & dst=Prim -> cast convert. For boolean the
least-significant-bit is used to convert it to/from an integer type.
2. src=Prim & dst=Ref -> box the source value and potentially cast
3. src=Ref & dst=Prim ->
+1
Paul.
> On Mar 13, 2020, at 8:42 AM, Pavel Rappo wrote:
>
> Hello,
>
> Please review the change for https://bugs.openjdk.java.net/browse/JDK-8241014:
>
> http://cr.openjdk.java.net/~prappo/8241014/webrev.00/
>
> This is a documentation cleanup. There are no code changes involved,
> and
--- a/src/java.base/share/classes/java/lang/invoke/MethodType.java
+++ b/src/java.base/share/classes/java/lang/invoke/MethodType.java
@@ -1379,12 +1379,12 @@
/**
* This implementation returns {@code true} if {@code obj} is
another
- * {@code WeakEntry}
Looks good! Thanks!
Maurizio
On 20/03/2020 16:17, Mandy Chung wrote:
On 3/20/20 6:51 AM, Alan Bateman wrote:
On 20/03/2020 03:43, Mandy Chung wrote:
Alan, Maurizio,
New webrev:
http://cr.openjdk.java.net/~mchung/jdk15/webrevs/8240975/webrev.02/
newJavaNativeInterfaceLibraries creates a
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8241311
The proposed changeset is located at:
https://cr.openjdk.java.net/~naoto/8241311/webrev.04/
This is simply to move some test cases that have been in closed
repository into open repository.
On 3/20/20 6:51 AM, Alan Bateman wrote:
On 20/03/2020 03:43, Mandy Chung wrote:
Alan, Maurizio,
New webrev:
http://cr.openjdk.java.net/~mchung/jdk15/webrevs/8240975/webrev.02/
newJavaNativeInterfaceLibraries creates a NativeLIbraries for
loading JNI native libraries.
- native
On 20/03/2020 03:43, Mandy Chung wrote:
Alan, Maurizio,
New webrev:
http://cr.openjdk.java.net/~mchung/jdk15/webrevs/8240975/webrev.02/
newJavaNativeInterfaceLibraries creates a NativeLIbraries for loading
JNI native libraries.
- native libraries are unloaded when the class loader is
Looks even better.
/Erik
On 2020-03-20 04:42, Magnus Ihse Bursie wrote:
On 2020-03-19 19:12, Remi Forax wrote:
Hi Magnus,
please try not to use @SuppressWarnings("unchecked") on methods, but
on local variable instead to reduce the scope,
you can introduce a local variable for that.
Aha, I
On 2020-03-19 18:54, Erik Joelsson wrote:
Looks good to me.
Thanks.
I love the WrapperGenerator using Vector and Hashtable!
Yeah. State of the art.
I'm still trying to wrap my head around this piece of beauty:
assert !(currentContainer instanceof Entry);
On 2020-03-19 19:12, Remi Forax wrote:
Hi Magnus,
please try not to use @SuppressWarnings("unchecked") on methods, but on local
variable instead to reduce the scope,
you can introduce a local variable for that.
Aha, I did not know that possibility existed! (My Java skills is
becoming somewhat
14 matches
Mail list logo
