Agreed, +1
On 3/25/20 5:53 PM, Claes Redestad wrote:
Looks good and trivial, including the drive-by cleanups.
I can sponsor.
/Claes
On 2020-03-25 22:18, Сергей Цыпанов wrote:
Hello,
I think we can reduce allocation rate for j.l.Character.toString() by
calling String.valueOf(char) instead
Looks good and trivial, including the drive-by cleanups.
I can sponsor.
/Claes
On 2020-03-25 22:18, Сергей Цыпанов wrote:
Hello,
I think we can reduce allocation rate for j.l.Character.toString() by calling
String.valueOf(char) instead of String.valueOf(char[]).
Current implementation
Hello,
I think we can reduce allocation rate for j.l.Character.toString() by calling
String.valueOf(char) instead of String.valueOf(char[]).
Current implementation creates char[] with one char which is later decoded into
byte[].
Instead String.valueOf(char) decodes char directly consuming
Hi Naoto,
See another patch attached with Locale.ROOT for the BreakIterator. I
will be glad to hear of any feedback.
There is another patch [1] around dealing with manifest attributes
during application launch. It certainly is related to 6202130 but feels
like a distinct set of changes with a
Thank you Roger for review!
On 3/25/20 6:56 AM, Roger Riggs wrote:
Hi Ivan,
Looks fine.
Interesting edge case, would never be seen with 8 bit charsets.
Thanks, Roger
On 3/21/20 3:15 AM, Ivan Gerasimov wrote:
Gentle ping.
The webrev was rebased to accommodate recent changes in
Hi Ivan,
Looks fine.
Interesting edge case, would never be seen with 8 bit charsets.
Thanks, Roger
On 3/21/20 3:15 AM, Ivan Gerasimov wrote:
Gentle ping.
The webrev was rebased to accommodate recent changes in RegExTest.java.
The fix is to handle an edge case situation, which is
On 2020-03-25 02:22, David Holmes wrote:
On 25/03/2020 3:49 am, Florian Weimer wrote:
* Magnus Ihse Bursie:
On 2020-03-24 09:59, Andrew Dinn wrote:
On 23/03/2020 18:38, Erik Joelsson wrote:
Looks good.
Thanks for the review, Erik.
I'm assuming that also implies it is trivial (because,
Hello
Please review following simple changes to cleanup raw types warning for open
jndi tests (under test/jdk/com/sun/jndi and test/jdk/javax/naming), thanks
Bug: https://bugs.openjdk.java.net/browse/JDK-8214694
Webrev: http://cr.openjdk.java.net/~xyin/8214694/webrev.00/
The changes should be
On Tue, Mar 24, 2020 at 10:25 PM Florian Weimer wrote:
> * Thomas Stüfe:
>
> > Hi Tagir,
> >
> > nice work. Only a partwise review for TreeMap.java, did not yet look at
> the
> > tests.
> >
> > remapValue:
> >
> > 711 } else {
> > 712 // replace old mapping
> > 713
