Re: RFR 15 8242327: List spec should state that unmodifiable lists implement RandomAccess

2020-04-09 Thread Stuart Marks
Thanks Lance. Upon advice from Pavel Rappo, I've adjusted the link markup to use the full reference form of a javadoc link. Revised patch below. Also, could you review the CSR? https://bugs.openjdk.java.net/browse/JDK-8242406 Thanks, s'marks # HG changeset patch # User smarks # Date

Re: RFR [15/java.xml] 8242470 : Upgrade Xerces to Version 2.12.1

2020-04-09 Thread naoto . sato
+1 Naoto On 4/9/20 2:28 PM, Joe Wang wrote: Please review an update to Xerces 2.12.1. Xerces 2.12.1 was a bug fix release. Bugs in the release were either already in the JDK or not applicable. This patch therefore includes only an update to the md file. ---

Re: RFR [15/java.xml] 8242470 : Upgrade Xerces to Version 2.12.1

2020-04-09 Thread Lance Andersen
+1 > On Apr 9, 2020, at 5:28 PM, Joe Wang wrote: > > Please review an update to Xerces 2.12.1. Xerces 2.12.1 was a bug fix > release. Bugs in the release were either already in the JDK or not > applicable. This patch therefore includes only an update to the md file. > > ---

RFR [15/java.xml] 8242470 : Upgrade Xerces to Version 2.12.1

2020-04-09 Thread Joe Wang
Please review an update to Xerces 2.12.1. Xerces 2.12.1 was a bug fix release. Bugs in the release were either already in the JDK or not applicable. This patch therefore includes only an update to the md file. --- a/src/java.xml/share/legal/xerces.md +++ b/src/java.xml/share/legal/xerces.md @@

Re: JDK 15 RFR of JDK-8225540: In core reflection note whether returned annotations are declaration or type annotations

2020-04-09 Thread Joe Darcy
Hi Pavel, On 4/9/2020 3:46 AM, Pavel Rappo wrote: http://cr.openjdk.java.net/~darcy/8225540.1/ I'm not an expert in this area, but AFAIK this looks good. A couple of nits. 1. The newly added text in the top-level doc comment for AnnotatedElement is missing some tags. It looks nice in

Re: RFR: 8188055: (ref) Add Reference.refersTo predicate

2020-04-09 Thread Paul Sandoz
Reference.java — 335 * 336 * @return The object to which this reference refers, or 337 * {@code null} if this reference object has been cleared Add @see refersTo 338 */ 339 @HotSpotIntrinsicCandidate 340 public T get() { Paul. > On Apr 7, 2020, at

RFR 15 8242462: Residual Cleanup of rmic removal

2020-04-09 Thread Roger Riggs
Please review a few cleanups I missed on the removal of rmic. I didn't get a reply on the changes to the hotspot (cds) tests. (I did get an ok on the javadoc changes) Webrev: http://cr.openjdk.java.net/~rriggs/webrev-remove-rmic-8225319-misc-1/ Issue:  

Re: JDK 15 RFR of JDK-8225540: In core reflection note whether returned annotations are declaration or type annotations

2020-04-09 Thread Pavel Rappo
> http://cr.openjdk.java.net/~darcy/8225540.1/ I'm not an expert in this area, but AFAIK this looks good. A couple of nits. 1. The newly added text in the top-level doc comment for AnnotatedElement is missing some tags. It looks nice in source, but it won't be like that in the output. (For

RE: RFR: 8242039: Improve jlink VersionPropsPlugin

2020-04-09 Thread Langer, Christoph
Hi Claes and Mark, thanks again for your inputs. I'll push this with Claes' review then. Best regards Christoph > -Original Message- > From: core-libs-dev On Behalf > Of Claes Redestad > Sent: Mittwoch, 8. April 2020 00:12 > To: core-libs-dev@openjdk.java.net > Subject: Re: RFR: