Re: RFR(S): 8241638: launcher time metrics alway report 1 on Linux when _JAVA_LAUNCHER_DEBUG set(Internet mail)

Hi Henry, Alan, David My colleague Bin(Buddy) just remind me that the copyright info of the touched files should be updated, sorry that I forgot to add it in my original patch , do you think there should be a patch for fixing that? BRs, Lin On 2020/4/7, 4:56 PM, "Alan Bateman"

Re: RFR 8243491: Implementation of Foreign-Memory Access API (Second Incubator)

On 24/04/2020 01:35, Paul Sandoz wrote: Hi, Looks good. I have seen almost all of this in reviews on panama-dev hence the lack of substantial comments here. I suspect we are not gonna need the drop argument VH combinator, dropping coordinates feels a little suspicious to me, but I can see

Re: RFR 8243491: Implementation of Foreign-Memory Access API (Second Incubator)

Hi, Looks good. I have seen almost all of this in reviews on panama-dev hence the lack of substantial comments here. I suspect we are not gonna need the drop argument VH combinator, dropping coordinates feels a little suspicious to me, but I can see why it's there for completeness. Paul. >

Re: RFR: JDK-8236129: Exe installers have wrong properties

Hi Alexey, Looks fine. Thanks, Alexander On 4/23/20 2:34 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Implement rebranding of exe installers produced by jpackage. - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8236129 [2] 

Re: RFR: JDK-8219536: Add Option for user defined jlink options

Hi Andy, http://cr.openjdk.java.net/~herrick/8219536/webrev.04/src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/Arguments.java.frames.html 1) Copyright year needs to be updated. Other files also needs copyright year to be updated. 2) Line 778: Not sure why it was moved

RFR: JDK-8236129: Exe installers have wrong properties

Please review fix [2] for jpackage bug [1]. Implement rebranding of exe installers produced by jpackage. - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8236129 [2] http://cr.openjdk.java.net/~asemenyuk/8236129/webrev.00

Re: RFR: JDK-8219536: Add Option for user defined jlink options

Looks good. - Alexey On 4/23/2020 4:48 PM, Andy Herrick wrote: Please review updated webrev at [5] to address comments below from Alexey. [5] http://cr.openjdk.java.net/~herrick/8219536/webrev.04 /Andy On 4/23/2020 11:17 AM, Alexey Semenyuk wrote:

Re: RFR: JDK-8219536: Add Option for user defined jlink options

Please review updated webrev at [5] to address comments below from Alexey. [5] http://cr.openjdk.java.net/~herrick/8219536/webrev.04 /Andy On 4/23/2020 11:17 AM, Alexey Semenyuk wrote:

RFR 8243491: Implementation of Foreign-Memory Access API (Second Incubator)

Hi, time has come for another round of foreign memory access API incubation (see JEP 383 [3]). This iteration aims at polishing some of the rough edges of the API, and adds some of the functionalities that developers have been asking for during this first round of incubation. The revised API

Re: RFR 15: 8243010: Test support: Customizable Hex Printer

Hi Roger, Sorry, I thought I replied. I think this looks good and I look forward to using it more going forward. +1 from me Best Lance > On Apr 23, 2020, at 2:46 PM, Roger Riggs wrote: > > Ping... > > I appreciate the comments about extending the functionality and uses and will > take

RE: RFR 15 8243099: Adding ADQ support to JDK

Thanks a lot to Chris and Alan for detailed comments. The updated version of patch available at http://cr.openjdk.java.net/~sviswanathan/Vladimir/8243099/webrev.01/ Changes: 1. in native code the common pattern was used for the 'getsockopt' call. 2. condition to define SO_INCOMING_NAPI_ID was

Re: RFR: JDK-8242302 : Refactor jpackage native code

Thank you for the review! Whitespace issues will be fixed in the final patch. - Alexey On 4/23/2020 2:51 PM, Erik Joelsson wrote: Thanks, that looks good! Only two minor whitespace nits. Line 32-33, 102-103: continuation indent 4 spaces Line 101: extra space No need for new webrev. /Erik

Re: RFR: JDK-8242302 : Refactor jpackage native code

Thanks, that looks good! Only two minor whitespace nits. Line 32-33, 102-103: continuation indent 4 spaces Line 101: extra space No need for new webrev. /Erik On 2020-04-23 11:38, Alexey Semenyuk wrote: Erik, Please review updated patch with the suggested improvements at [1]. The webrev

Re: RFR 15: 8243010: Test support: Customizable Hex Printer

Ping... I appreciate the comments about extending the functionality and uses and will take them up as a separate enhancement. A review would be appreciated. Thanks, Roger On 4/16/20 3:17 PM, Roger Riggs wrote: Please review[2] and comment on a new Hex printing utility to support OpenJDK

Re: RFR: JDK-8242302 : Refactor jpackage native code

Erik, Please review updated patch with the suggested improvements at [1]. The webrev includes only incremental changes to Lib-jdk.incubator.jpackage.gmk for clarity. [1] http://cr.openjdk.java.net/~asemenyuk/8242302/webrev.01/webrev.01/index.html - Alexey On 4/20/2020 1:17 PM, Erik

Re: RFR: JDK-8219536: Add Option for user defined jlink options

http://cr.openjdk.java.net/~herrick/8219536/webrev.03/test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JPackageCommand.java.sdiff.html:731 - 'launcherName' parameter of readRuntimeReleaseFile() function seems to be not used.

RFR: JDK-8219536: Add Option for user defined jlink options

Please review webrev at [1] to address issue [2]. This is the new feature to add the jpackage option --jlink-options as specified in CSR at [3] /Andy [1] http://cr.openjdk.java.net/~herrick/8219536/webrev.03 [2] https://bugs.openjdk.java.net/browse/JDK-8219536 [3]

Re: RFR(S): 8242848: Improve performance of InflaterOutputStream.write()

On Wed, Apr 22, 2020 at 10:45 PM Claes Redestad wrote: > > > > On 2020-04-22 22:08, Volker Simonis wrote: > > http://cr.openjdk.java.net/~simonis/webrevs/2020/8242848.02/ > > > > Notice that this new version only changes the microbenchmark, all the > > other files are untouched. > > > > As

Re: RFR(S): 8242848: Improve performance of InflaterOutputStream.write()

On 16/04/2020 07:48, Thomas Stüfe wrote: As for increasing the buffer size, it makes sense but IMHO needs a CSR and a release note. Yes, a release note would be appropriate here. Lance is going to dig into the history to try to find the rational for the original code in case there is

RFR: 8243469: Lazily encode name in ZipFile.getEntryPos

Hi, current implementation of ZipFile.getEntryPos takes the encoded byte[] of the String we're looking up. Which means when looking up entries across multiple jar files, we allocate the byte[] over and over for each jar file searched. If we instead refactor the internal hash table to use a

Re: RFR(S): 8242848: Improve performance of InflaterOutputStream.write()

On Thu, Apr 23, 2020 at 1:42 PM Laurent Bourgès wrote: > > Thank you Volker for sharing your results. > > It is amazing, to improve such widely used feature (zip -> jar, http > compression...) > Watch out, there's mor eto come :) > Congratulations. Thank.. > Laurent > > Le jeu. 23 avr. 2020

Re: RFR(S): 8242848: Improve performance of InflaterOutputStream.write()

On Thu, Apr 23, 2020 at 1:22 PM Lance Andersen wrote: > Hi Volker > > On Apr 22, 2020, at 4:08 PM, Volker Simonis > wrote: > > On Tue, Apr 21, 2020 at 5:23 PM Lance Andersen > wrote: > > > Hi Volker, > > I think overall this looks OK. I went through the older SCCS histories to > see if I

Re: RFR(S): 8242848: Improve performance of InflaterOutputStream.write()

On Thu, Apr 23, 2020 at 10:18 AM Langer, Christoph wrote: > Hi Volker, > > since it's not yet pushed, I also went over the change and I like it. +1  > Thanks! > > One little style nit caught my eye, which you could correct before > pushing: The style of the if/else blocks in >

Re: RFR(S): 8242848: Improve performance of InflaterOutputStream.write()

Thank you Volker for sharing your results. It is amazing, to improve such widely used feature (zip -> jar, http compression...) Congratulations. Laurent Le jeu. 23 avr. 2020 à 12:19, Volker Simonis a écrit : > On Thu, Apr 23, 2020 at 10:56 AM Laurent Bourgès > wrote: > > > > Hi Volker, > >

Re: RFR(S): 8242848: Improve performance of InflaterOutputStream.write()

Hi Volker > On Apr 22, 2020, at 4:08 PM, Volker Simonis wrote: > > On Tue, Apr 21, 2020 at 5:23 PM Lance Andersen > wrote: >> >> Hi Volker, >> >> I think overall this looks OK. I went through the older SCCS histories to >> see if I could figure out why they were using 512 for the input

Re: RFR(S): 8242848: Improve performance of InflaterOutputStream.write()

On Thu, Apr 23, 2020 at 10:56 AM Laurent Bourgès wrote: > > Hi Volker, > > Could you give some benchmark results in the jbs bug to have an idea of the > performance gain ? The results of a benchmark run are at the end of the microbenchmark which is attached to

Re: Unexpected behaviour with larger Strings

On 4/20/20 6:09 PM, Adam Retter wrote: > I was surprised that by my findings that: > > 1. On JDK 7 and 8 with HotSpot - getting the bytes of a UTF-8 string > where all chars are '0' wants to allocate an array larger than the VM > limit, whereas the same operation on ASCII and ISO-8859-1 do not.

Re: RFR(S): 8242848: Improve performance of InflaterOutputStream.write()

Hi Volker, Could you give some benchmark results in the jbs bug to have an idea of the performance gain ? Thanks, Laurent Le jeu. 23 avr. 2020 à 10:20, Langer, Christoph a écrit : > Hi Volker, > > since it's not yet pushed, I also went over the change and I like it. +1  > > One little style

Re: [15] RFR: 8243138: Enhance BaseLdapServer to support starttls extended request

Thank you, Vyom Regards, Chris > On 23 Apr 2020, at 4:35 PM, Vyom Tiwari wrote: > > Hi Chris, > change looks good to me. > Vyom > > On Wed, Apr 22, 2020 at 12:59 PM Chris Yin > wrote: > Hello > > Please review following change for enhancement to >

Re: [15] RFR: 8243138: Enhance BaseLdapServer to support starttls extended request

Thank you, Daniel. Pushed Regards, Chris > On 23 Apr 2020, at 4:11 PM, Daniel Fuchs wrote: > > On 23/04/2020 01:39, Aleks Efimov wrote: >> Hi Chris, >> The changes look good to me. >> Thank you for extending the LDAP test server functionality. > > +1 > > Reviewed. > > best regards, > > --

Re: [15] RFR: 8243138: Enhance BaseLdapServer to support starttls extended request

Hi Chris, change looks good to me. Vyom On Wed, Apr 22, 2020 at 12:59 PM Chris Yin wrote: > Hello > > Please review following change for enhancement to > com/sun/jndi/ldap/lib/BaseLdapServer.java, thanks > > Bug: https://bugs.openjdk.java.net/browse/JDK-8243138 > Webrev:

RE: RFR(S): 8242848: Improve performance of InflaterOutputStream.write()

Hi Volker, since it's not yet pushed, I also went over the change and I like it. +1  One little style nit caught my eye, which you could correct before pushing: The style of the if/else blocks in test/jdk/java/util/zip/DeflateIn_InflateOut.java in lines 48/49 and 59/60 does not match the

Re: [15] RFR: 8243138: Enhance BaseLdapServer to support starttls extended request

On 23/04/2020 01:39, Aleks Efimov wrote: Hi Chris, The changes look good to me. Thank you for extending the LDAP test server functionality. +1 Reviewed. best regards, -- daniel