LGTM++
Thanks,
Serguei
On 4/28/20 23:28, David Holmes wrote:
Looks good!
Thanks,
David
On 29/04/2020 1:20 pm, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8244052/webrev.00/
34 lines changed: 0 ins; 11 del; 23 mod;
Hi all,
could you please review this trivial patch?
from
Looks good!
Thanks,
David
On 29/04/2020 1:20 pm, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8244052/webrev.00/
34 lines changed: 0 ins; 11 del; 23 mod;
Hi all,
could you please review this trivial patch?
from JBS:
JDK-8199290 made it unnecessary to explicitly pass
sun.hot
Looks good.
StefanK
On 2020-04-29 06:41, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8244066/webrev.00
16 lines changed: 0 ins; 0 del; 16 mod;
Hi all,
could you please review this trivial cleanup in tests?
from JBS:
ClassFileInstaller is a test utility class which copies cla
Hello, Paul and Stuart!
Thank you for sharing your thoughts regarding my proposal. Yes, the
proposal was triggered by twitter discussion but I needed this
functionality occasionally in my daily work several times.
Sorry for mixing the goal and possible solution, so let's start again.
The goal of
thanks Ioi for such a prompt review, pushed.
-- Igor
> On Apr 28, 2020, at 9:47 PM, Ioi Lam wrote:
>
> Looks good and trivial.
>
> Thanks
> - Ioi
>
> On 4/28/20 9:41 PM, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev//8244066/webrev.00
>>> 16 lines changed: 0 ins; 0 del; 16 mod
Looks like It is intentional that unmodifiable queues are not present. See:
https://bugs.openjdk.java.net/browse/JDK-5030930. The same logic would have
been used for when Deque was added in the following release.
Jason
From: core-libs-dev on behalf of
Looks good and trivial.
Thanks
- Ioi
On 4/28/20 9:41 PM, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8244066/webrev.00
16 lines changed: 0 ins; 0 del; 16 mod;
Hi all,
could you please review this trivial cleanup in tests?
from JBS:
ClassFileInstaller is a test utility class
http://cr.openjdk.java.net/~iignatyev//8244066/webrev.00
> 16 lines changed: 0 ins; 0 del; 16 mod;
Hi all,
could you please review this trivial cleanup in tests?
from JBS:
> ClassFileInstaller is a test utility class which copies class files to the
> current directory, there is no point in runni
http://cr.openjdk.java.net/~iignatyev//8244052/webrev.00/
> 34 lines changed: 0 ins; 11 del; 23 mod;
Hi all,
could you please review this trivial patch?
from JBS:
> JDK-8199290 made it unnecessary to explicitly pass
> sun.hotspot.WhiteBox$WhiteBoxPermission as an argument to ClassFileInstaller
On 28/04/2020 21:44, Maurizio Cimadamore wrote:
On 28/04/2020 19:09, Mandy Chung wrote:
On 4/28/20 12:58 AM, fo...@univ-mlv.fr wrote:
I don't think you need to store all the values into static
fields, you can directly do a ldc + aaload with the right index
right where you need i
+1
> On Apr 28, 2020, at 5:50 PM, Mandy Chung wrote:
>
> diff --git a/src/java.base/share/classes/java/lang/invoke/package-info.java
> b/src/java.base/share/classes/java/lang/invoke/package-info.java
> --- a/src/java.base/share/classes/java/lang/invoke/package-info.java
> +++ b/src/java.base/sh
+1
--
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Sent from my iPhone
> On Apr 28, 2020, at 8:53 PM, Mandy Chung wrote:
>
> diff --git a/src/java.base/share/classes/java/lang/inv
diff --git
a/src/java.base/share/classes/java/lang/invoke/package-info.java
b/src/java.base/share/classes/java/lang/invoke/package-info.java
--- a/src/java.base/share/classes/java/lang/invoke/package-info.java
+++ b/src/java.base/share/classes/java/lang/invoke/package-info.java
@@ -31,7 +31,7 @@
On 28/04/2020 21:27, Peter Levart wrote:
Hi,
The problem with current implementation of MemoryScope is that if a
child scope is frequently acquired and closed (which increments and
then decrements the parent scope counter atomically using CAS), and
that is performed from multiple concurrent
On 28/04/2020 23:08, Peter Levart wrote:
On 4/28/20 10:49 PM, Maurizio Cimadamore wrote:
On 28/04/2020 17:12, Peter Levart wrote:
Hi Maurizio,
I'm checking out the thread-confinement in the parallel stream case.
I see the Spliterator.trySplit() is calling
AbstractMemorySegmentImpl's:
Hi Paul,
I too hesitate about adding Ordered* interfaces. As I said previously, I don't
think they're very useful, and they do seem rather Queue- or Deque-like.
Indeed, Tagir was musing the other day on Twitter about a Deque view of
LinkedHashSet and possibly LinkedHashMap. I think that might
Hi Andy,
Looks good.
Thanks,
Alexander
On 4/28/20 10:49 AM, Alexey Semenyuk wrote:
Looks good!
- Alexey
On 4/28/2020 10:55 AM, Andy Herrick wrote:
Please review webrev at [1] to address issue [2].
/Andy
[1] - http://cr.openjdk.java.net/~herrick/8243673/webrev.01/
[2] - https://bugs.open
On 4/28/20 10:49 PM, Maurizio Cimadamore wrote:
On 28/04/2020 17:12, Peter Levart wrote:
Hi Maurizio,
I'm checking out the thread-confinement in the parallel stream case.
I see the Spliterator.trySplit() is calling AbstractMemorySegmentImpl's:
102 private AbstractMemorySegmentImpl a
On 28/04/2020 17:12, Peter Levart wrote:
Hi Maurizio,
I'm checking out the thread-confinement in the parallel stream case. I
see the Spliterator.trySplit() is calling AbstractMemorySegmentImpl's:
102 private AbstractMemorySegmentImpl asSliceNoCheck(long offset,
long newSize) {
103
Looks good.
Naoto
On 4/28/20 11:41 AM, Ichiroh Takiguchi wrote:
Hello Naoto.
Thank you for your attention.
And I'm sorry about bad response.
I added ISO8859_16 entry into
test/jdk/java/nio/charset/Charset/RegisteredCharsets.java
Could you review the fix again ?
Bug: https://bugs.openjd
On 28/04/2020 19:09, Mandy Chung wrote:
On 4/28/20 12:58 AM, fo...@univ-mlv.fr wrote:
I don't think you need to store all the values into static fields, you
can directly do a ldc + aaload with the right index right where you need it,
I think this is what you are thinking as
Hi,
The problem with current implementation of MemoryScope is that if a
child scope is frequently acquired and closed (which increments and then
decrements the parent scope counter atomically using CAS), and that is
performed from multiple concurrent threads, contention might become
prohibiti
Hello Naoto.
Thank you for your attention.
And I'm sorry about bad response.
I added ISO8859_16 entry into
test/jdk/java/nio/charset/Charset/RegisteredCharsets.java
Could you review the fix again ?
Bug:https://bugs.openjdk.java.net/browse/JDK-8242541
Change: https://cr.openjdk.java.net/~
On 4/28/20 12:58 AM, fo...@univ-mlv.fr wrote:
I don't think you need to store all the values into static fields, you
can directly do a ldc + aaload with the right index right where you need it,
I think this is what you are thinking as reported in JDK-8243492:
http://cr.open
Hi Tagir,
I am hesitant to add new interfaces specific to Set/Map for a non-indexed
encounter order.
The interface OrderedSet is tantalizingly queue-like, in fact rather close to
the read-only part of Deque. Did you consider the possibility of LinkedHashSet
implementing Deque?
I have not tho
looks good.
/Andy
On 4/28/2020 2:55 AM, Baesken, Matthias wrote:
Hello, please review this small fix for the windows 32bit build .
Currently we run into this compile error on Windows :
./src/jdk.incubator.jpackage/windows/native/libjpackage/VersionInfo.cpp(123):
error C2220: warning treat
Looks good!
- Alexey
On 4/28/2020 10:55 AM, Andy Herrick wrote:
Please review webrev at [1] to address issue [2].
/Andy
[1] - http://cr.openjdk.java.net/~herrick/8243673/webrev.01/
[2] - https://bugs.openjdk.java.net/browse/JDK-8243673
Looks good!
- Alexey
On 4/28/2020 2:55 AM, Baesken, Matthias wrote:
Hello, please review this small fix for the windows 32bit build .
Currently we run into this compile error on Windows :
./src/jdk.incubator.jpackage/windows/native/libjpackage/VersionInfo.cpp(123):
error C2220: warning tr
Hi Simone,
On 4/28/20 5:42 AM, Simone Bordet wrote:
Hi,
in Jetty 10, we use method handles in the WebSocket implementation.
We need to scan WebSocket EndPoint application classes (MyEndPoint)
for annotated methods whose signature may vary and may take
application classes, for example `@OnMessa
Hi Maurizio,
I'm checking out the thread-confinement in the parallel stream case. I
see the Spliterator.trySplit() is calling AbstractMemorySegmentImpl's:
102 private AbstractMemorySegmentImpl asSliceNoCheck(long offset,
long newSize) {
103 return dup(offset, newSize, mask, own
Thanks a lot Ioi for explaining!
I completely missed the fact that this was for Xshare=dump only, that
removes a lot of the complexities I was worried about.
I like the comments, well written and not too much :)
I will look at the coding closer in the coming days, but for now I am
happy, thank y
Please review webrev at [1] to address issue [2].
/Andy
[1] - http://cr.openjdk.java.net/~herrick/8243673/webrev.01/
[2] - https://bugs.openjdk.java.net/browse/JDK-8243673
Hi,
in Jetty 10, we use method handles in the WebSocket implementation.
We need to scan WebSocket EndPoint application classes (MyEndPoint)
for annotated methods whose signature may vary and may take
application classes, for example `@OnMessage void onMessage(Session s,
MyString m)` where @OnMess
> De: "mandy chung"
> À: "Remi Forax" , "Maurizio Cimadamore"
>
> Cc: "core-libs-dev"
> Envoyé: Mardi 28 Avril 2020 01:17:05
> Objet: Re: RFR 8243491: Implementation of Foreign-Memory Access API (Second
> Incubator)
> On 4/27/20 2:42 PM, Remi Forax wrote:
>> Hi Maurizio, Mandy,
>> In [
>> htt
34 matches
Mail list logo
