Looks good!
- Alexey
On 5/2/2020 10:31 AM, Andy Herrick wrote:
Please review fix at [1] for issue [2]
/Andy
[1] - http://cr.openjdk.java.net/~herrick/8242865/webrev.01/
[2] - https://bugs.openjdk.java.net/browse/JDK-8242865
Please review fix at [1] for issue [2]
/Andy
[1] - http://cr.openjdk.java.net/~herrick/8242865/webrev.01/
[2] - https://bugs.openjdk.java.net/browse/JDK-8242865
looks good
/Andy
On 5/1/20 7:18 PM, Alexey Semenyuk wrote:
Evaluation:
Code snippet at memory(1871):
---
~unique_ptr() noexcept {
if (_Mypair._Myval2) {
_Mypair._Get_first()(_Mypair._Myval2);
}
}
---
Where '_Myval2' is of type jni::JniObjWithEnv defined in
Hi Maurizio,
On 5/1/20 4:36 PM, Maurizio Cimadamore wrote:
Hi Peter,
this does look better yes.
I suspect this doesn't affect performance negatively right? (in most
cases, when acquiring, state will be OPEN).
Now there's dup(). I think implementing dup() on a root scope is not
too hard -