Re: RFR: JDK-8242865: Usability problems using mac signing in jpackage

2020-05-02 Thread Alexey Semenyuk
Looks good! - Alexey On 5/2/2020 10:31 AM, Andy Herrick wrote: Please review fix at [1] for issue [2] /Andy [1] - http://cr.openjdk.java.net/~herrick/8242865/webrev.01/ [2] - https://bugs.openjdk.java.net/browse/JDK-8242865

RFR: JDK-8242865: Usability problems using mac signing in jpackage

2020-05-02 Thread Andy Herrick
Please review fix at [1] for issue [2] /Andy [1] - http://cr.openjdk.java.net/~herrick/8242865/webrev.01/ [2] - https://bugs.openjdk.java.net/browse/JDK-8242865

Re: RFR: JDK-8244220 : Compiler error in jpackage with VS2019

2020-05-02 Thread Andy Herrick
looks good /Andy On 5/1/20 7:18 PM, Alexey Semenyuk wrote: Evaluation: Code snippet at memory(1871): ---     ~unique_ptr() noexcept {     if (_Mypair._Myval2) {     _Mypair._Get_first()(_Mypair._Myval2);     }     } --- Where '_Myval2' is of type jni::JniObjWithEnv defined in

Re: RFR 8243491: Implementation of Foreign-Memory Access API (Second Incubator)

2020-05-02 Thread Peter Levart
Hi Maurizio, On 5/1/20 4:36 PM, Maurizio Cimadamore wrote: Hi Peter, this does look better yes. I suspect this doesn't affect performance negatively right? (in most cases, when acquiring, state will be OPEN). Now there's dup(). I think implementing dup() on a root scope is not too hard -