What problem are you trying to solve?
The Collections framework explicitly does not support custom membership
semantics. If you think it should, file an RFE and create a JEP. It’s not a
small change and tinkering is not the way to get there.
If your present concern is performance surprises, be
On 5/1/20 10:41 PM, Jason Mehrens wrote:
1. I assume you are using "c instanceof List" instead of "!(c instanceof Set)"
to correctly handle IdentitityHashMap.values()? The instanceof List seems like safe choice but it
is too bad we can still fool that check by wrapping List as an
Hi Jens,
This is a situation where intuition can easily lead one astray. Indeed, I
initially made the same assumption [1] that x.removeAll(y) should essentially
call x.remove() on each element of y, as if y::forEach(x::remove). This would
imply that y is iterated and that x's membership
Hi Ioi,
On 5/05/2020 3:43 am, Ioi Lam wrote:
On 4/27/20 7:05 PM, David Holmes wrote:
On 28/04/2020 10:01 am, David Holmes wrote:
On 28/04/2020 9:37 am, Ioi Lam wrote:
Hi David & Jiangli,
Thanks for your comments.
I thought about using a system property, but the user can also
specify it
Hi,
Looks fine to me. I have just one minor observation:
src/java.base/share/native/libjli/emessages.h
*** 92,102
#define JRE_ERROR5 "Error: Failed to start a %d-bit JVM process
from a %d-bit JVM."
! #define JRE_ERROR6 "Error: Verify all necessary Java SE
components have
On 4/27/20 7:05 PM, David Holmes wrote:
On 28/04/2020 10:01 am, David Holmes wrote:
On 28/04/2020 9:37 am, Ioi Lam wrote:
Hi David & Jiangli,
Thanks for your comments.
I thought about using a system property, but the user can also
specify it like
java -Djdk.xshare.dump.salt=0
Hi,
Removing all of the api note looks good, since it was really written in the
context of the removed methods.
I’ll sponsor. (I removed the methods but forgot to remove the note.)
Paul.
> On May 3, 2020, at 9:03 AM, Anirvan Sarkar wrote:
>
> Hi,
>
> The class level @apiNote in
Hi Mikael,
I took a look at i18n related files. It looks good overall.
One nit in java/nio/charset/Charset/DefaultCharsetTest.java: If the test
is only applicable to linux (@requires os.family == "linux" in jtreg tag
after the change), the condition isLinux() is no longer needed at line 73.
Looks good.
- Alexey
On 4/29/2020 10:31 AM, Andy Herrick wrote:
Please review fix at [1] for issue [2]
The change just adds error when specified icon is not found, and a
test for that.
/Andy
[1] - http://cr.openjdk.java.net/~herrick/8244018/webrev.01/
[2] -
Hi Michael,
Looks good.
Maybe just a future cleanup to rename files, since the "...so..." is
refering to solaris.
src/java.base/unix/native/libjli/java_md_solinux.h
src/java.base/unix/native/libjli/java_md_solinux.h
Regards, Roger
On 5/4/20 4:49 AM, Alan Bateman wrote:
On 04/05/2020
There are several security-related files (name.contains("security")) and they
all look fine.
--Max
> On May 4, 2020, at 1:12 PM, Mikael Vidstedt
> wrote:
>
>
> Please review this change which implements part of JEP 381:
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8244224
> webrev:
Adding jmx-dev and security-dev.
-Original Message-
From: Thejasvi Voniadka
Sent: Monday, May 4, 2020 12:56 PM
To: core-libs-dev@openjdk.java.net
Subject: [PATCH] 8244199: [TestBug]: Update sun/management/jmxremote/bootstrap
tests
Hi,
May I please find a sponsor for this patch?
Bug:
Hi Stuart,
Yup Contributed-by as picked from my email : jayashreesk .
Will keep in mind about the complicated change-sets.
Thanks
Jay
-Stuart Marks wrote: -
To: Jayashree Sk1
From: Stuart Marks
Date: 05/01/2020 09:32AM
Cc: core-libs-dev@openjdk.java.net
Subject: [EXTERNAL] Re:
On 04/05/2020 06:12, Mikael Vidstedt wrote:
Please review this change which implements part of JEP 381:
JBS: https://bugs.openjdk.java.net/browse/JDK-8244224
webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.00/corelibs/open/webrev/
JEP:
Hi,
May I please find a sponsor for this patch?
Bug: https://bugs.openjdk.java.net/browse/JDK-8244199
Description:
The test
"test/jdk/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh" fails
intermittently on a lower release. While investigating the cause for the
failure, I
15 matches
Mail list logo
