On Tue, 8 Dec 2020 20:42:52 GMT, Mandy Chung wrote:
>> `Reference::isEnqueued` method was never implemented as it was initially
>> specified since 1.2. The specification says that it tests if this reference
>> object has been enqueued, but the long-standing behavior is to test if this
>>
On Tue, 8 Dec 2020 21:15:48 GMT, Martin Buchholz wrote:
>> 8234131: Miscellaneous changes imported from jsr166 CVS 2020-12
>
> Martin Buchholz has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains one commit:
>
> JDK-8234131
Marked
On Tue, 8 Dec 2020 08:54:41 GMT, Aleksey Shipilev wrote:
> See here:
> https://github.com/mcimadamore/jdk/runs/1460615378
>
> $ CONF=linux-x86-server-fastdebug make images run-test
> TEST=java/foreign/TestSegments.java
>
> STDERR:
> Invalid maximum heap size: -Xmx4G
> The specified size
On 09-Dec-20 1:16, Mandy Chung wrote:
On 12/8/20 5:07 AM, Johannes Kuhn wrote:
Not sure if I read this correctly as "please share some example of
code that tries to do that" or "please share code that you write to
fix that".
So I do both.
I was curious to find out what old software
On Tue, 8 Dec 2020 22:52:37 GMT, Mandy Chung wrote:
> This is a follow-up on JDK-8255342 that removes non-specified JVM checks on
> classes with Record attributes. That introduces a regression in
> `InstanceKlass::is_record` that returns true on a non-record class which has
>
On Tue, 8 Dec 2020 06:14:35 GMT, Stuart Marks wrote:
>> This rewrites the doc of ArraysSupport.newLength, adds detail to the
>> exception message, and adds a test. In addition to some renaming and a bit
>> of refactoring of the actual code, I also made two changes of substance to
>> the code:
On 12/8/20 5:07 AM, Johannes Kuhn wrote:
On 08-Dec-20 5:40, Mandy Chung wrote:
Thanks David. I was about to create one.
This is indeed a gap in injecting this trampoline class for
supporting @CallerSensitive methods. The InjectedInvoker ensures
that the InjectedInvoker class has the
On Tue, 8 Dec 2020 08:54:41 GMT, Aleksey Shipilev wrote:
> See here:
> https://github.com/mcimadamore/jdk/runs/1460615378
>
> $ CONF=linux-x86-server-fastdebug make images run-test
> TEST=java/foreign/TestSegments.java
>
> STDERR:
> Invalid maximum heap size: -Xmx4G
> The specified size
- Mail original -
> De: "Mandy Chung"
> À: "core-libs-dev" , "hotspot-dev"
>
> Envoyé: Mardi 8 Décembre 2020 23:57:39
> Objet: RFR: 8257596: Clarify trusted final fields for record classes
Hi Mandy,
> This is a follow-up on JDK-8255342 that removes non-specified JVM checks on
>
> Start of JDK 17 updates.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains 14 additional commits since the
last revision:
- Get in JEP 390
This is similar issue we used to have for hdiutil create/detach, but for
"convert". Added same workaround to repeat command. I also added repeat for
"udifrez" command just in case.
-
Commit messages:
- 8238781: [macos] jpackage tests failed due to "hdiutil: convert failed" in
On Sat, 5 Dec 2020 01:46:31 GMT, Dan Smith wrote:
> Integration of [JEP 390](https://bugs.openjdk.java.net/browse/JDK-8249100).
>
> Development has been broken into 5 tasks, each with its own JBS issue:
> - [JDK-8252180](https://bugs.openjdk.java.net/browse/JDK-8252180): Deprecate
> wrapper
This is a follow-up on JDK-8255342 that removes non-specified JVM checks on
classes with Record attributes. That introduces a regression in
`InstanceKlass::is_record` that returns true on a non-record class which has
`RecordComponents` attribute present. This causes unexpected semantics in
On Tue, 8 Dec 2020 17:10:30 GMT, Joe Darcy wrote:
>> Start of JDK 17 updates.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull request contains 12
On Tue, 8 Dec 2020 17:59:41 GMT, Stuart Marks wrote:
>> Updates to the specifications of Double.{equals, compareTo} to explain more
>> explicitly why the obvious wrappers around "==" and "<"/"==" are not
>> sufficient for floating-point values.
>>
>> Once the wording is worked out, I'll
On Thu, 19 Nov 2020 16:49:30 GMT, Mark Reinhold wrote:
> Please review this implementation of JEP 396
> (https://openjdk.java.net/jeps/396).
> Alan Bateman is the original author; I’ve credited him in the commit metadata.
> Passes tiers 1-3 on {linux,macos,windows}-x64 and linux-aarch64.
This
On Sat, 5 Dec 2020 01:46:31 GMT, Dan Smith wrote:
> Integration of [JEP 390](https://bugs.openjdk.java.net/browse/JDK-8249100).
>
> Development has been broken into 5 tasks, each with its own JBS issue:
> - [JDK-8252180](https://bugs.openjdk.java.net/browse/JDK-8252180): Deprecate
> wrapper
> 8234131: Miscellaneous changes imported from jsr166 CVS 2020-12
Martin Buchholz has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains one commit:
JDK-8234131
-
Changes: https://git.openjdk.java.net/jdk/pull/1647/files
On Thu, 3 Dec 2020 09:22:18 GMT, Jan Lahoda wrote:
>> Adding support for record classes in the historical data for ct.sym. This
>> includes a few changes not strictly needed for the change:
>> -updating and moving tests into test/langtools, so that it is easier to run
>> them.
>> -fixing
On Tue, Dec 8, 2020 at 3:54 AM Daniel Fuchs wrote:
>
> > RandomFactory is probably overkill here as the test just needs to
> exercise untimed and timed get. So just a random boolean rather than a wide
> range of random values.
>
> OK.
>
There's a conflict between the desires to do more thorough
On Mon, Dec 7, 2020 at 11:56 PM Alan Bateman wrote:
>
> > 37: // TODO: Rewrite as a CompletableFuture tck test ?
>
> Do you want the "TODO" in the commit?
>
> Yes!
On Wed, 4 Nov 2020 14:01:53 GMT, Marius Volkhart
wrote:
> The default implementation of javax.xml.stream.XMLEventReader produced a
> StartDocument event that always indicated that the "standalone" attribute was
> set.
>
> The root cause of this was that the
>
> `Reference::isEnqueued` method was never implemented as it was initially
> specified since 1.2. The specification says that it tests if this reference
> object has been enqueued, but the long-standing behavior is to test if this
> reference object is in its associated queue, only reflecting
OK, rollback committed to CVS:
--- src/main/java/util/concurrent/ThreadPoolExecutor.java 27 Nov 2020
17:42:00 - 1.194
+++ src/main/java/util/concurrent/ThreadPoolExecutor.java 8 Dec 2020
20:31:54 -
@@ -1522,13 +1522,11 @@
// As a heuristic, prestart enough new workers (up to
On Tue, 8 Dec 2020 19:10:37 GMT, Joe Wang wrote:
>> Marius Volkhart has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - fixup! Fix: javax.xml.stream.XMLEventReader produces incorrect
>> START_DOCUMENT event
>> - fixup! Fix:
On Tue, 8 Dec 2020 19:35:39 GMT, Alan Bateman wrote:
>> Mandy Chung has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits
On Tue, Dec 8, 2020 at 12:05 AM Aleksey Shipilev
wrote:
> On Sun, 6 Dec 2020 02:56:34 GMT, Martin Buchholz
> wrote:
>
> > 8246585: ForkJoin updates
>
> It would be nice to get it tested with GH Actions. "Checks" tabs should
> have those testing results automatically on push, but it is empty.
On Tue, 8 Dec 2020 18:53:30 GMT, Mandy Chung wrote:
>> `Reference::isEnqueued` method was never implemented as it was initially
>> specified since 1.2. The specification says that it tests if this reference
>> object has been enqueued, but the long-standing behavior is to test if this
>>
> This is an update to javac and javadoc, to introduce support for Preview
> APIs, and generally improve javac and javadoc behavior to more closely adhere
> to JEP 12.
>
> The notable changes are:
>
> * adding support for Preview APIs (javac until now supported primarily only
> preview
On Tue, 8 Dec 2020 17:33:16 GMT, Alan Bateman wrote:
>> The mapping and nr tables, and the *-X.java.template files in
>> make/data/charsetmapping are used to generate source code for the java.base
>> and jdk.charsets modules. The stdcs-$OS files configure the package and
>> module that each
On Tue, 8 Dec 2020 16:25:25 GMT, Marius Volkhart
wrote:
>> The default implementation of javax.xml.stream.XMLEventReader produced a
>> StartDocument event that always indicated that the "standalone" attribute
>> was set.
>>
>> The root cause of this was that the
>>
> `Reference::isEnqueued` method was never implemented as it was initially
> specified since 1.2. The specification says that it tests if this reference
> object has been enqueued, but the long-standing behavior is to test if this
> reference object is in its associated queue, only reflecting
On Tue, 8 Dec 2020 17:17:54 GMT, Aditya Mandaleeka wrote:
>> See here:
>> https://github.com/mcimadamore/jdk/runs/1460615378
>>
>> $ CONF=linux-x86-server-fastdebug make images run-test
>> TEST=java/foreign/TestSegments.java
>>
>> STDERR:
>> Invalid maximum heap size: -Xmx4G
>> The specified
On Tue, 8 Dec 2020 17:33:16 GMT, Alan Bateman wrote:
>> The mapping and nr tables, and the *-X.java.template files in
>> make/data/charsetmapping are used to generate source code for the java.base
>> and jdk.charsets modules. The stdcs-$OS files configure the package and
>> module that each
On Thu, 3 Dec 2020 06:50:11 GMT, Anton Kozlov wrote:
>> Filed https://bugs.openjdk.java.net/browse/JDK-8257633
>
> Thanks for taking care of those issues. To be clear, there is no real need to
> bump the version for this PR, 10.9 is fine. This PR just proposes another way
> to implement the
On Tue, 8 Dec 2020 18:24:21 GMT, Mandy Chung wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8256867: Classes with empty PermittedSubclasses attribute cannot be
>> extended
>
> Marked as reviewed by mchung
On Tue, 8 Dec 2020 17:10:30 GMT, Joe Darcy wrote:
>> Start of JDK 17 updates.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull request contains 12
On Tue, 8 Dec 2020 14:57:26 GMT, Harold Seigel wrote:
>> Please review this fix for JDK-8256867. This change no longer throws a
>> ClassFormatError exception when loading a class whose PermittedSubclasses
>> attribute is empty (contains no classes). Instead, the class is treated as
>> a
On Tue, 8 Dec 2020 18:16:15 GMT, Mandy Chung wrote:
>> @wangweij Moving build tools is a related, but separate, question, which is
>> addressed by https://bugs.openjdk.java.net/browse/JDK-8241463.
>>
>> I send out a review earlier this year (see
>>
On Tue, 8 Dec 2020 16:19:05 GMT, Magnus Ihse Bursie wrote:
>> Is there a plan to move make/jdk/src/classes/build/tools/intpoly into
>> java.base as well?
>>
>> Update: I see all subdirs in tools are still there.
>
> @wangweij Moving build tools is a related, but separate, question, which is
>
On Fri, 4 Dec 2020 18:23:55 GMT, Brent Christian wrote:
> Please review this fix for the intermittently-failing
> java/lang/ClassLoader/nativeLibrary/NativeLibraryTest.java.
>
> The change replaces System.gc()+sleep() with the more robust gcAwait()
> mechanic used elsewhere in the test base,
On Tue, 8 Dec 2020 17:38:12 GMT, Chris Hegarty wrote:
>> src/java.base/share/classes/java/lang/Class.java line 4399:
>>
>>> 4397: * that is {@link #isSealed()} returns {@code false}, then this
>>> method returns {@code null}.
>>> 4398: * Conversely, if {@link #isSealed()} returns
On Tue, 8 Dec 2020 16:29:49 GMT, Joe Darcy wrote:
> Updates to the specifications of Double.{equals, compareTo} to explain more
> explicitly why the obvious wrappers around "==" and "<"/"==" are not
> sufficient for floating-point values.
>
> Once the wording is worked out, I'll replicate it
On Tue, 8 Dec 2020 17:18:20 GMT, Mandy Chung wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8256867: Classes with empty PermittedSubclasses attribute cannot be
>> extended
>
>
On Tue, 8 Dec 2020 12:15:38 GMT, Alan Bateman wrote:
>> Also, to clarify, for me there is a fundamental difference between
>> `src/$MODULE` and `make/modules/$MODULE`. The former is the home of files
>> that are part of the module, owned by the content team, and the `$MODULE`
>> part is
On Tue, 8 Dec 2020 09:52:51 GMT, Kim Barrett wrote:
> Please review this change that eliminates the use of Reference.isEnqueued by
> tests. There were three tests using it:
>
> vmTestbase/gc/gctests/ReferencesGC/ReferencesGC.java
> vmTestbase/gc/gctests/WeakReferenceGC/WeakReferenceGC.java
>
On Tue, 8 Dec 2020 14:57:26 GMT, Harold Seigel wrote:
>> Please review this fix for JDK-8256867. This change no longer throws a
>> ClassFormatError exception when loading a class whose PermittedSubclasses
>> attribute is empty (contains no classes). Instead, the class is treated as
>> a
On Mon, 7 Dec 2020 20:30:07 GMT, Andrey Turbanov
wrote:
> 6882207: Convert javap to use diamond operator internally
Nice; thanks
-
Marked as reviewed by jjg (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1677
On Tue, 8 Dec 2020 08:54:41 GMT, Aleksey Shipilev wrote:
> See here:
> https://github.com/mcimadamore/jdk/runs/1460615378
>
> $ CONF=linux-x86-server-fastdebug make images run-test
> TEST=java/foreign/TestSegments.java
>
> STDERR:
> Invalid maximum heap size: -Xmx4G
> The specified size
On Tue, 8 Dec 2020 16:29:49 GMT, Joe Darcy wrote:
> Updates to the specifications of Double.{equals, compareTo} to explain more
> explicitly why the obvious wrappers around "==" and "<"/"==" are not
> sufficient for floating-point values.
>
> Once the wording is worked out, I'll replicate it
> Start of JDK 17 updates.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains 12 additional commits since the
last revision:
- Merge branch
On 08-Dec-20 5:40, Mandy Chung wrote:
Thanks David. I was about to create one.
This is indeed a gap in injecting this trampoline class for supporting
@CallerSensitive methods. The InjectedInvoker ensures that the
InjectedInvoker class has the same class loader as the lookup class.
W.r.t.
> jaxp.library.SimpleHttpServer
> https://bugs.openjdk.java.net/browse/JDK-8212035
Mahendra Chhipa has updated the pull request incrementally with one additional
commit since the last revision:
Implemented the review comments.
-
Changes:
- all:
On Fri, 4 Dec 2020 20:45:24 GMT, Daniel Fuchs wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Implemented the review comments.
>
> test/lib/jdk/test/lib/net/SimpleHttpServer.java line 95:
>
>> 93:
On Fri, 4 Dec 2020 20:48:01 GMT, Daniel Fuchs wrote:
>> test/jdk/sun/net/www/protocol/jar/MultiReleaseJarURLConnection.java line 80:
>>
>>> 78: creator.buildSignedMultiReleaseJar();
>>> 79:
>>> 80: server = new
>>> SimpleHttpServer(TESTCONTEXT,System.getProperty("user.dir",
Updates to the specifications of Double.{equals, compareTo} to explain more
explicitly why the obvious wrappers around "==" and "<"/"==" are not sufficient
for floating-point values.
Once the wording is worked out, I'll replicate it for the analogous methods on
Float.
-
Commit
On Tue, 8 Dec 2020 16:21:09 GMT, Julia Boes wrote:
>> This change applies a stricter semantic distinction of 'type' versus 'class
>> and interface'. This is based on the JLS changes described in the
>> "Consistent Class and Interface Terminology" document:
>>
On Tue, 8 Dec 2020 16:21:09 GMT, Julia Boes wrote:
>> This change applies a stricter semantic distinction of 'type' versus 'class
>> and interface'. This is based on the JLS changes described in the
>> "Consistent Class and Interface Terminology" document:
>>
> The default implementation of javax.xml.stream.XMLEventReader produced a
> StartDocument event that always indicated that the "standalone" attribute was
> set.
>
> The root cause of this was that the
> com.sun.xml.internal.stream.events.XMLEventAllocatorImpl always set the
> "standalone"
On Tue, 8 Dec 2020 14:56:20 GMT, Andy Herrick wrote:
>> Looks like test failed due to:
>> [Fatal Error] b.wxl:3:1: XML document structures must start and end within
>> the same entity.
>> So, I am not sure how increased repeat will help. Do we know why it failed
>> to parse XML?
>
>>
>>
>>
On Thu, 3 Dec 2020 23:40:40 GMT, Joe Wang wrote:
>> Marius Volkhart has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - fixup! Fix: javax.xml.stream.XMLEventReader produces incorrect
>> START_DOCUMENT event
>> - fixup! Fix:
On Tue, 8 Dec 2020 15:25:47 GMT, Weijun Wang wrote:
>> The mapping and nr tables, and the *-X.java.template files in
>> make/data/charsetmapping are used to generate source code for the java.base
>> and jdk.charsets modules. The stdcs-$OS files configure the package and
>> module that each
> This change applies a stricter semantic distinction of 'type' versus 'class
> and interface'. This is based on the JLS changes described in the "Consistent
> Class and Interface Terminology" document:
> https://download.java.net/java/early_access/jdk16/docs/specs/class-terminology-jls.html.
>
On Tue, 8 Dec 2020 12:15:38 GMT, Alan Bateman wrote:
>> Also, to clarify, for me there is a fundamental difference between
>> `src/$MODULE` and `make/modules/$MODULE`. The former is the home of files
>> that are part of the module, owned by the content team, and the `$MODULE`
>> part is
On Tue, 8 Dec 2020 12:15:38 GMT, Alan Bateman wrote:
>> Also, to clarify, for me there is a fundamental difference between
>> `src/$MODULE` and `make/modules/$MODULE`. The former is the home of files
>> that are part of the module, owned by the content team, and the `$MODULE`
>> part is
On Tue, 8 Dec 2020 06:14:35 GMT, Stuart Marks wrote:
>> This rewrites the doc of ArraysSupport.newLength, adds detail to the
>> exception message, and adds a test. In addition to some renaming and a bit
>> of refactoring of the actual code, I also made two changes of substance to
>> the code:
On Tue, 8 Dec 2020 00:48:55 GMT, Stuart Marks wrote:
>> The algorithm can be well defined for minGrowth and prefGrowth == 0 without
>> extra checks or exceptions with a careful look at the inequality checks.
>> For example, as currently coded, if both are zero, it returns
>>
> increase retries and timeout increasing in runMsiexecWithRetries
Andy Herrick has updated the pull request incrementally with 18 additional
commits since the last revision:
- 8256149: Weird AST structure for incomplete member select
Reviewed-by: vromero
- 8257194: Add 'foreign linker
On Tue, 8 Dec 2020 14:57:26 GMT, Harold Seigel wrote:
>> Please review this fix for JDK-8256867. This change no longer throws a
>> ClassFormatError exception when loading a class whose PermittedSubclasses
>> attribute is empty (contains no classes). Instead, the class is treated as
>> a
On Tue, 8 Dec 2020 03:08:59 GMT, Alexander Matveev wrote:
>
>
> Looks like test failed due to:
> [Fatal Error] b.wxl:3:1: XML document structures must start and end within
> the same entity.
> So, I am not sure how increased repeat will help. Do we know why it failed to
> parse XML?
If you
> Please review this fix for JDK-8256867. This change no longer throws a
> ClassFormatError exception when loading a class whose PermittedSubclasses
> attribute is empty (contains no classes). Instead, the class is treated as a
> sealed class which cannot be extended nor implemented. This
On Tue, 8 Dec 2020 14:37:52 GMT, Chris Hegarty wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8256867: Classes with empty PermittedSubclasses attribute cannot be
>> extended
>
>
On Tue, 8 Dec 2020 14:10:26 GMT, Harold Seigel wrote:
>> Please review this fix for JDK-8256867. This change no longer throws a
>> ClassFormatError exception when loading a class whose PermittedSubclasses
>> attribute is empty (contains no classes). Instead, the class is treated as
>> a
On Tue, 8 Dec 2020 09:30:59 GMT, Chris Hegarty wrote:
>> src/java.base/share/classes/java/lang/Class.java line 4396:
>>
>>> 4394: * is unspecified. If this {@code Class} object represents a
>>> primitive type,
>>> 4395: * {@code void}, an array type, or a class or interface that is
On Tue, 8 Dec 2020 00:09:34 GMT, Mandy Chung wrote:
>> src/hotspot/share/prims/jvm.cpp line 2130:
>>
>>> 2128: JvmtiVMObjectAllocEventCollector oam;
>>> 2129: Array* subclasses = ik->permitted_subclasses();
>>> 2130: int length = subclasses == NULL ? 0 : subclasses->length();
>>
>>
> Please review this fix for JDK-8256867. This change no longer throws a
> ClassFormatError exception when loading a class whose PermittedSubclasses
> attribute is empty (contains no classes). Instead, the class is treated as a
> sealed class which cannot be extended nor implemented. This
On Tue, 8 Dec 2020 14:07:08 GMT, Harold Seigel wrote:
>> Please review this fix for JDK-8256867. This change no longer throws a
>> ClassFormatError exception when loading a class whose PermittedSubclasses
>> attribute is empty (contains no classes). Instead, the class is treated as
>> a
On 2020-12-08 00:30, Magnus Ihse Bursie wrote:
On Tue, 8 Dec 2020 02:40:43 GMT, Mandy Chung wrote:
I have reviewed all lines in the patch file with or near instances of
`jdk.compiler`
Hi Magnus,
I see the motivation of moving these build files for better identification of
ownership.
On Tue, 8 Dec 2020 10:41:06 GMT, Julia Boes wrote:
>> src/java.base/share/classes/java/lang/Enum.java line 62:
>>
>>> 60: * java.util.EnumMap map} implementations are available.
>>> 61: *
>>> 62: * @param The enum class subclass
>>
>> I wonder about this one, given that `` is a type. It
- Mail original -
> De: "Dave Franken"
> À: "core-libs-dev"
> Envoyé: Mardi 8 Décembre 2020 13:17:25
> Objet: Has it been considered to add inverse methods to collections which are
> in Optional?
> Dear all,
Hi Dave,
>
> The class java.util.Optional could be considered a collection
On Tue, 8 Dec 2020 08:32:28 GMT, Magnus Ihse Bursie wrote:
>> @mlchung If you don't have any strong preference, I implore you to accept
>> this change. I **vastly** prefer to move the data out of `make`!
>>
>> This is not just about Skara tooling. When working with make files, autoconf
>> and
On Mon, 7 Dec 2020 17:38:40 GMT, Maurizio Cimadamore
wrote:
> This simple patch updates the jaavdoc in the module-info file of
> jdk.incubator.foreign to reflect the fact that support of foreign function
> calls has been added.
This pull request has now been integrated.
Changeset: a7080247
Dear all,
The class java.util.Optional could be considered a collection with a limit
on how many values it can hold, minimum 0, maximum 1.
Likewise, any class implementing the regular java.util.Collection has a
minimum, 0 and a maximum > 1.
While Optional does not implement Collection, it could
On 12/8/20 3:56 AM, Alan Bateman wrote:
1558: break;
1559: }
1560: */
Is this meant to be commented out?
Yes, but It should be marked as a possible improvement, not yet
committed. While this (prestarting) would improve performance in some
On Tue, 8 Dec 2020 10:35:20 GMT, Alan Bateman wrote:
>> test/jdk/java/util/concurrent/CompletableFuture/LostInterrupt.java line 49:
>>
>>> 47:
>>> 48: public static void main(String[] args) throws Exception {
>>> 49: ThreadLocalRandom rnd = ThreadLocalRandom.current();
>>
>> Hi
On Tue, 8 Dec 2020 08:53:38 GMT, Alan Bateman wrote:
>> Martin Buchholz has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR.
>
>
This change have been already reviewed by Mandy, Alan and David.
Now, the PR approval is needed.
The push was postponed because the CSR was not approved at that time (it is
now):
https://bugs.openjdk.java.net/browse/JDK-8248189
Investigation of existing popular java agents was requested by
On Tue, 8 Dec 2020 08:59:25 GMT, Jie Fu wrote:
> Hi all,
>
> java/foreign/TestSegments.java fails on x86_32 due to '-Xmx4G'.
> The reason is that -Xmx4G is invalid maximum heap size for 32-bit platforms.
> The current implimentation only supports maximum 3800M on 32-bit systems [1].
>
> The
On Tue, 8 Dec 2020 08:54:41 GMT, Aleksey Shipilev wrote:
> See here:
> https://github.com/mcimadamore/jdk/runs/1460615378
>
> $ CONF=linux-x86-server-fastdebug make images run-test
> TEST=java/foreign/TestSegments.java
>
> STDERR:
> Invalid maximum heap size: -Xmx4G
> The specified size
On Tue, 8 Dec 2020 10:17:48 GMT, Aleksey Shipilev wrote:
> > > `-Xm3800M` could still fail on many 32-bit systems, for example where
> > > native libraries are located in the middle of address space. I think it
> > > is safer to `@require` it. In fact, I did it an hour ago here #1688 :)
> >
>
On Mon, 7 Dec 2020 18:22:33 GMT, Daniel Fuchs wrote:
>> This change applies a stricter semantic distinction of 'type' versus 'class
>> and interface'. This is based on the JLS changes described in the
>> "Consistent Class and Interface Terminology" document:
>>
On Tue, 8 Dec 2020 10:19:22 GMT, Daniel Fuchs wrote:
>> Martin Buchholz has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR.
>
>
On Tue, 8 Dec 2020 06:30:28 GMT, Martin Buchholz wrote:
>> 8254350: CompletableFuture.get may swallow InterruptedException
>
> Martin Buchholz has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show differences
> compared to
On Tue, 8 Dec 2020 09:22:05 GMT, Jie Fu wrote:
> > `-Xm3800M` could still fail on many 32-bit systems, for example where
> > native libraries are located in the middle of address space. I think it is
> > safer to `@require` it. In fact, I did it an hour ago here #1688 :)
>
> The test just
Please review this change that eliminates the use of Reference.isEnqueued by
tests. There were three tests using it:
vmTestbase/gc/gctests/ReferencesGC/ReferencesGC.java
vmTestbase/gc/gctests/WeakReferenceGC/WeakReferenceGC.java
jdk/java/lang/ref/ReferenceEnqueue.java
In each of them, some
On Mon, 7 Dec 2020 16:35:52 GMT, Athijegannathan Sundararajan
wrote:
> Safe URI encode logic adopted from UnixUriUtils.
This pull request has now been integrated.
Changeset: d2b66196
Author:Athijegannathan Sundararajan
URL: https://git.openjdk.java.net/jdk/commit/d2b66196
Stats:
On Tue, 8 Dec 2020 08:54:41 GMT, Aleksey Shipilev wrote:
> See here:
> https://github.com/mcimadamore/jdk/runs/1460615378
>
> $ CONF=linux-x86-server-fastdebug make images run-test
> TEST=java/foreign/TestSegments.java
>
> STDERR:
> Invalid maximum heap size: -Xmx4G
> The specified size
On Mon, 7 Dec 2020 23:47:40 GMT, Mandy Chung wrote:
>> Please review this fix for JDK-8256867. This change no longer throws a
>> ClassFormatError exception when loading a class whose PermittedSubclasses
>> attribute is empty (contains no classes). Instead, the class is treated as
>> a
On Tue, 8 Dec 2020 09:07:27 GMT, Aleksey Shipilev wrote:
> `-Xm3800M` could still fail on many 32-bit systems, for example where native
> libraries are located in the middle of address space. I think it is safer to
> `@require` it. In fact, I did it an hour ago here #1688 :)
The test just
On Tue, 8 Dec 2020 08:59:25 GMT, Jie Fu wrote:
> Hi all,
>
> java/foreign/TestSegments.java fails on x86_32 due to '-Xmx4G'.
> The reason is that -Xmx4G is invalid maximum heap size for 32-bit platforms.
> The current implimentation only supports maximum 3800M on 32-bit systems [1].
>
> The
1 - 100 of 108 matches
Mail list logo
