Re: RFR: 8258422: Cleanup unnecessary null comparison before instanceof check in java.base [v4]

2020-12-19 Thread Chris Hegarty
On Thu, 17 Dec 2020 13:16:31 GMT, Aleksei Efimov wrote: >> Andrey Turbanov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8258422: Cleanup unnecessary null comparison before instanceof check in >> java.base >> take advantage of

Re: RFR: 8258584: java/util/HexFormat/HexFormatTest.java fails on x86_32 [v2]

2020-12-19 Thread Jie Fu
On Thu, 17 Dec 2020 16:14:56 GMT, Roger Riggs wrote: > Disabling all of the tests on 32 bit is not a good idea. > > Instead the HexFormatTest.testOOME test should be skipped or the OOME should > be ignored. > Checking Runtime.getRuntime().maxMemory() should provide enough info to skip > it.

Re: RFR: 8258584: java/util/HexFormat/HexFormatTest.java fails on x86_32 [v2]

2020-12-19 Thread Jie Fu
> Hi all, > > java/util/HexFormat/HexFormatTest.java fails on x86_32 due to '-Xmx4G'. > The reason is that -Xmx4G is invalid maximum heap size for 32-bit platforms. > The current implementation only supports maximum 3800M on 32-bit systems [1]. > > I've tried to reduce the -Xmx size, but it

Re: RFR: 8193031: Collections.addAll is likely to perform worse than Collection.addAll

2020-12-19 Thread Guoxiong Li
On Thu, 17 Dec 2020 10:36:17 GMT, RĂ©mi Forax wrote: >> Looks like I've found the original ticket: >> https://bugs.openjdk.java.net/browse/JDK-8193031 > > Apart from the @SuppressWarnings, this looks good to me. > And i like the irony of this. Hi all, According to the document of