Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v37]

2021-03-26 Thread Joe Darcy
On Fri, 26 Mar 2021 12:25:43 GMT, Jim Laskey wrote: >> This PR is to introduce a new random number API for the JDK. The primary API >> is found in RandomGenerator and RandomGeneratorFactory. Further description >> can be found in the JEP https://openjdk.java.net/jeps/356 . >> >> javadoc can

Re: Dynamic Deserialization Filters - a JEP draft

2021-03-26 Thread mark . reinhold
2021/3/26 8:04:23 -0700, roger.ri...@oracle.com: > Please review a JEP to extend deserialization filtering (JEP 290) to > enable deserialization filters to be selected by the application based > on the runtime context. > > JDK-8263381 Dynamic

Integrated: 8262110: DST starts from incorrect time in 2038

2021-03-26 Thread Naoto Sato
On Tue, 23 Mar 2021 23:38:28 GMT, Naoto Sato wrote: > Please review the fix to the DST transition bug after the year 2037. The > logic had the side effect that it adjusted the dst offset every time the > method `getOffsets()` is issued. Only adjust the offset when issued with wall > time.

Re: Comment on CSR 8251991: Hex formatting and parsing utility

2021-03-26 Thread Roger Riggs
fyi,  a PR to make the methods static. https://git.openjdk.java.net/jdk/pull/3205 On 3/15/21 4:26 PM, Raffaello Giulietti wrote: Hello, I understand your points expressed in https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-October/070317.html On the other hand, it kind of hurts

Dynamic Deserialization Filters - a JEP draft

2021-03-26 Thread Roger Riggs
Please review a JEP to extend deserialization filtering (JEP 290) to enable deserialization filters to be selected by the application based on the runtime context. JDK-8263381 Dynamic Deserialization Filters Comments appreciated,  Roger

Re: RFR: 8263754: HexFormat 'fromHex' methods should be static [v2]

2021-03-26 Thread Claes Redestad
On Fri, 26 Mar 2021 14:39:47 GMT, Roger Riggs wrote: >> A number of HexFormat methods converting from strings to numbers do not use >> delimiter, prefix, suffix, and uppercase parameters and would be more >> convenient if the methods were static. >> >> These APIs were added early in JDK 17

Integrated: 8189198: Add "forRemoval = true" to Applet API deprecations

2021-03-26 Thread Andy Herrick
On Wed, 10 Mar 2021 18:33:37 GMT, Andy Herrick wrote: > implementation of > JDK-8256145: JEP 398: Deprecate the Applet API for Removal This pull request has now been integrated. Changeset: 57115fa2 Author:Andy Herrick URL: https://git.openjdk.java.net/jdk/commit/57115fa2 Stats:

Re: RFR: 8263754: HexFormat 'fromHex' methods should be static [v2]

2021-03-26 Thread Roger Riggs
> A number of HexFormat methods converting from strings to numbers do not use > delimiter, prefix, suffix, and uppercase parameters and would be more > convenient if the methods were static. > > These APIs were added early in JDK 17 and are being updated before GA. > This PR updates existing

Re: RFR: 8262110: DST starts from incorrect time in 2038

2021-03-26 Thread Roger Riggs
On Tue, 23 Mar 2021 23:38:28 GMT, Naoto Sato wrote: > Please review the fix to the DST transition bug after the year 2037. The > logic had the side effect that it adjusted the dst offset every time the > method `getOffsets()` is issued. Only adjust the offset when issued with wall > time.

Re: RFR: 8263754: HexFormat 'fromHex' methods should be static

2021-03-26 Thread Chris Hegarty
On Thu, 25 Mar 2021 20:08:14 GMT, Roger Riggs wrote: > A number of HexFormat methods converting from strings to numbers do not use > delimiter, prefix, suffix, and uppercase parameters and would be more > convenient if the methods were static. > > These APIs were added early in JDK 17 and

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v37]

2021-03-26 Thread Jim Laskey
> This PR is to introduce a new random number API for the JDK. The primary API > is found in RandomGenerator and RandomGeneratorFactory. Further description > can be found in the JEP https://openjdk.java.net/jeps/356 . > > javadoc can be found at >

Re: RFR: 8263968: CDS: java/lang/ModuleLayer.EMPTY_LAYER should be singleton [v2]

2021-03-26 Thread Alexander Scherbatiy
On Wed, 24 Mar 2021 16:31:20 GMT, Claes Redestad wrote: >> Aleksei Voitylov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix style > > Looks good. The need to retain singleton/identity semantics of constants like > this when

Re: RFR: 8203359: Container level resources events

2021-03-26 Thread Severin Gehwolf
On Thu, 25 Mar 2021 23:28:18 GMT, Erik Gahlin wrote: > Does each getter call result in parsing /proc, or do things aggregated over > several calls or hooks? >From the looks of it the event emitting code uses `Metrics.java` interface for >retrieving the info. Each call to a method exposed by