On Wed, 2 Mar 2022 18:48:46 GMT, XenoAmess wrote:
>> 8281631: HashMap copy constructor and putAll can over-allocate table
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> revert changes to IdentityHashMap
On Wed, 19 Jan 2022 22:09:26 GMT, Joe Darcy wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8279508: Adding a test for scalar intrinsification.
>
> The testing for this PR doesn't look adequate to me. I don't see
If AbstractStringBuilder only grow, the inflated value which is encoded in
UTF16 can't be compressed.
toString() can skip compression in this case. This can save an ArrayAllocation
in StringUTF16::compress.
java.io.BufferedRead::readLine() is a case that StringBuilder grows only.
On Wed, 2 Mar 2022 17:04:01 GMT, Mandy Chung wrote:
> This patch further cleans up NativeLibraries just for JNI library use.
> RawNativeLibraries implements its own native load and unload methods. In
> addition, this also fixes the implementation of `RawNativeLibraries::load`
> not to throw
On Sat, 26 Feb 2022 01:07:47 GMT, Sandhya Viswanathan
wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8279508: Adding descriptive comments.
>
> src/hotspot/cpu/x86/x86.ad line 7295:
>
>> 7293: __
On Sat, 26 Feb 2022 04:55:08 GMT, Jatin Bhateja wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8279508: Adding descriptive comments.
>
> As per SDM, if post conversion a floating point number is
On Wed, 2 Mar 2022 02:44:41 GMT, Jatin Bhateja wrote:
>> Summary of changes:
>> - Intrinsify Math.round(float) and Math.round(double) APIs.
>> - Extend auto-vectorizer to infer vector operations on encountering scalar
>> IR nodes for above intrinsics.
>> - Test creation using new IR testing
On Sat, 26 Feb 2022 03:38:32 GMT, Quan Anh Mai wrote:
>> I believe the indefinite value should be 2^(w - 1) (a.k.a 0x8000) and
>> the documentation is typoed. If you look at `cvtss2si`, the indefinite value
>> is also written as 2^w - 1 but yet in `MacroAssembler::convert_f2i` we
>>
On Wed, 2 Mar 2022 21:53:01 GMT, Tim Prinzing wrote:
>> The caller class returned by Reflection::getCallerClass was used to gain
>> access to it's module in most cases and class loader in one case. I added a
>> method to translate the caller class to caller module so that the decision
>> of
On Wed, 2 Mar 2022 20:28:45 GMT, Joe Darcy wrote:
> Refactoring of Method and Constructor to share a single empty array for
> parameters and exceptions as well as type variables.
>
> Existing core reflection regression tests pass with the change.
Marked as reviewed by mchung (Reviewer).
On Wed, 2 Mar 2022 14:06:10 GMT, Claes Redestad wrote:
>> Claes Redestad has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 29 commits:
>>
>> - Resolve merge conflict
>> - Fix TestCountPositives to correctly allow 0 return when
On Wed, 2 Mar 2022 04:02:45 GMT, Anthony Scarpino wrote:
> I have some compatibility concerns about the AES change breaking code that
> expects a SecretKeySpec of 16 bytes. I can see situations where
> '.getEncoded()' returns a byte[32] when user code expects a byte[16]. Also,
> I'm pretty
> The caller class returned by Reflection::getCallerClass was used to gain
> access to it's module in most cases and class loader in one case. I added a
> method to translate the caller class to caller module so that the decision of
> what module represents the caller with no stack frame is
> The caller class returned by Reflection::getCallerClass was used to gain
> access to it's module in most cases and class loader in one case. I added a
> method to translate the caller class to caller module so that the decision of
> what module represents the caller with no stack frame is
On Wed, 2 Mar 2022 20:28:45 GMT, Joe Darcy wrote:
> Refactoring of Method and Constructor to share a single empty array for
> parameters and exceptions as well as type variables.
>
> Existing core reflection regression tests pass with the change.
PS I'll update the copyrights before pushing.
Refactoring of Method and Constructor to share a single empty array for
parameters and exceptions as well as type variables.
Existing core reflection regression tests pass with the change.
-
Commit messages:
- JDK-8177107: Reduce memory footprint of
On Wed, 2 Mar 2022 18:56:40 GMT, Tim Prinzing wrote:
> The caller class returned by Reflection::getCallerClass was used to gain
> access to it's module in most cases and class loader in one case. I added a
> method to translate the caller class to caller module so that the decision of
> what
On Wed, 2 Mar 2022 18:56:40 GMT, Tim Prinzing wrote:
> The caller class returned by Reflection::getCallerClass was used to gain
> access to it's module in most cases and class loader in one case. I added a
> method to translate the caller class to caller module so that the decision of
> what
On Wed, 2 Mar 2022 02:50:27 GMT, Xiaohong Gong wrote:
> The vector `"test"` api is implemented with vector `"compare"`. And the
> masked `"test" `is implemented with `"test(op).and(m)"` which means
> `"compare().and(m)"` finally. Since the masked vector `"compare"` has been
> optimized with
The caller class returned by Reflection::getCallerClass was used to gain access
to it's module in most cases and class loader in one case. I added a method to
translate the caller class to caller module so that the decision of what module
represents the caller with no stack frame is made in a
On Fri, 18 Feb 2022 18:32:31 GMT, Stuart Marks wrote:
>> XenoAmess has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - migrate to junit
>> - change threshold
>
> Sigh. (I'm sighing at the author of the
>
> 8281631: HashMap copy constructor and putAll can over-allocate table
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
revert changes to IdentityHashMap
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7431/files
On Wed, 2 Mar 2022 01:44:24 GMT, Stuart Marks wrote:
> I'm starting to look at this again. First, a quick note -- I don't think
> there should be any IdentityHashMap changes here. That uses a completely
> different internal structure and allocation policy, and it's kind of a
> distraction
On Tue, 22 Feb 2022 16:10:22 GMT, Magnus Ihse Bursie wrote:
> This PR adds a new configure argument, `--enable-hsdis-bundling`. Setting
> this, together with a valid backend using `--with-hsdis`, will bundle the
> generated hsdis library with the JDK.
>
> The PR also includes a refactoring of
On Wed, 2 Mar 2022 14:30:43 GMT, Magnus Ihse Bursie wrote:
>> This PR adds a new configure argument, `--enable-hsdis-bundling`. Setting
>> this, together with a valid backend using `--with-hsdis`, will bundle the
>> generated hsdis library with the JDK.
>>
>> The PR also includes a
On Wed, 2 Mar 2022 17:04:01 GMT, Mandy Chung wrote:
> This patch further cleans up NativeLibraries just for JNI library use.
> RawNativeLibraries implements its own native load and unload methods. In
> addition, this also fixes the implementation of `RawNativeLibraries::load`
> not to throw
> This patch further cleans up NativeLibraries just for JNI library use.
> RawNativeLibraries implements its own native load and unload methods. In
> addition, this also fixes the implementation of `RawNativeLibraries::load`
> not to throw UnsatisfiedLinkError if a library cannot be loaded
On Wed, 2 Mar 2022 17:04:01 GMT, Mandy Chung wrote:
> This patch further cleans up NativeLibraries just for JNI library use.
> RawNativeLibraries implements its own native load and unload methods. In
> addition, this also fixes the implementation of `RawNativeLibraries::load`
> not to throw
This patch further cleans up NativeLibraries just for JNI library use.
RawNativeLibraries implements its own native load and unload methods. In
addition, this also fixes the implementation of `RawNativeLibraries::load` not
to throw UnsatisfiedLinkError if a library cannot be loaded for any
On Tue, 18 Jan 2022 01:39:52 GMT, Devin Smith wrote:
> Did a cursory review of the other generators, they seem to set the state
> correctly.
This pull request has now been integrated.
Changeset: ce18ff85
Author:Devin Smith
Committer: Jim Laskey
URL:
On Wed, 2 Mar 2022 15:26:35 GMT, Devin Smith wrote:
> Thanks for the help. I signed the OCA on Jan 17, 2022 and got confirmation it
> was approved on Jan 20, 2022.
Correct. Reviewers may know that this has been recorded if the PR has no `oca`
label (you can see above that the `oca` label was
On 01/03/2022 18:17, Sean Mullan wrote:
On 3/1/22 8:01 AM, Andrew Haley wrote:
On 3/1/22 11:45, Andrew Haley wrote:
Sure, you wouldn't
be able to use the default thread pool, but that's no big deal, I
would have
thought.
I'm sorry, I'll say that again. :-)
I meant to say "you
On Tue, 18 Jan 2022 01:39:52 GMT, Devin Smith wrote:
> Did a cursory review of the other generators, they seem to set the state
> correctly.
Thanks for the help. I signed the OCA on Jan 17, 2022 and got confirmation it
was approved on Jan 20, 2022.
-
PR:
On Tue, 18 Jan 2022 01:39:52 GMT, Devin Smith wrote:
> Did a cursory review of the other generators, they seem to set the state
> correctly.
@JimLaskey would it be possible to create an issue and review this change? I
don't have an account on the OpenJDK issue tracker.
I'm not sure how to
On Tue, 18 Jan 2022 01:39:52 GMT, Devin Smith wrote:
> Did a cursory review of the other generators, they seem to set the state
> correctly.
Created https://bugs.openjdk.java.net/browse/JDK-8282551 for this.
@devinrsmith please change the issue title to `8282551: Properly initialize
On Mon, 21 Feb 2022 19:43:52 GMT, Devin Smith wrote:
>> Did a cursory review of the other generators, they seem to set the state
>> correctly.
>
> I'm not sure how to move this forward, or get the attention of the people
> responsible for this code. I see @turbanoff you liked and may be
Did a cursory review of the other generators, they seem to set the state
correctly.
-
Commit messages:
- [PATCH] Properly initialize L32X64MixRandom state
Changes: https://git.openjdk.java.net/jdk/pull/7120/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=7120=00
Issue:
On Tue, 18 Jan 2022 01:39:52 GMT, Devin Smith wrote:
> Did a cursory review of the other generators, they seem to set the state
> correctly.
Marked as reviewed by jlaskey (Reviewer).
I'll sponsor this change when you receive your OCA.
-
PR:
On Tue, 1 Mar 2022 19:12:17 GMT, Claes Redestad wrote:
> > @theRealAph , @a74nh or someone familiar with aarch64 code, please review
> > aarch64 changes.
>
> Note that the aarch64 changes I've put in for now implements `countPositives`
> to return `0` if there's a negative value anywhere,
On Wed, 23 Feb 2022 14:19:20 GMT, Claes Redestad wrote:
>> I'm requesting comments and, hopefully, some help with this patch to replace
>> `StringCoding.hasNegatives` with `countPositives`. The new method does a
>> very similar pass, but alters the intrinsic to return the number of leading
>>
> I'm requesting comments and, hopefully, some help with this patch to replace
> `StringCoding.hasNegatives` with `countPositives`. The new method does a very
> similar pass, but alters the intrinsic to return the number of leading bytes
> in the `byte[]` range which only has positive bytes.
On Wed, 2 Mar 2022 13:12:52 GMT, Magnus Ihse Bursie wrote:
>> This PR adds a new configure argument, `--enable-hsdis-bundling`. Setting
>> this, together with a valid backend using `--with-hsdis`, will bundle the
>> generated hsdis library with the JDK.
>>
>> The PR also includes a
> This PR adds a new configure argument, `--enable-hsdis-bundling`. Setting
> this, together with a valid backend using `--with-hsdis`, will bundle the
> generated hsdis library with the JDK.
>
> The PR also includes a refactoring of the hsdis handling in autoconf,
> breaking it out to a
43 matches
Mail list logo