Re: RFR: 8279508: Auto-vectorize Math.round API [v17]

2022-03-12 Thread Jatin Bhateja
> Summary of changes: > - Intrinsify Math.round(float) and Math.round(double) APIs. > - Extend auto-vectorizer to infer vector operations on encountering scalar IR > nodes for above intrinsics. > - Test creation using new IR testing framework. > > Following are the performance number of a JMH

Re: RFR: 8279508: Auto-vectorize Math.round API [v16]

2022-03-12 Thread Jatin Bhateja
> Summary of changes: > - Intrinsify Math.round(float) and Math.round(double) APIs. > - Extend auto-vectorizer to infer vector operations on encountering scalar IR > nodes for above intrinsics. > - Test creation using new IR testing framework. > > Following are the performance number of a JMH

Re: RFR: 8279508: Auto-vectorize Math.round API [v15]

2022-03-12 Thread Jatin Bhateja
On Sun, 13 Mar 2022 00:06:07 GMT, Quan Anh Mai wrote: >> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 4161: >> >>> 4159: movl(scratch, 1056964608); >>> 4160: movq(xtmp1, scratch); >>> 4161: vbroadcastss(xtmp1, xtmp1, vec_enc); >> >> An `evpbroadcastd` would reduce this by one

Re: RFR: 8279508: Auto-vectorize Math.round API [v15]

2022-03-12 Thread Jatin Bhateja
On Sat, 12 Mar 2022 23:20:58 GMT, Quan Anh Mai wrote: >> Jatin Bhateja has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8279508: Creating separate test for round double under feature check. > >

Re: RFR: 8283067: Incorrect comment in java.base/share/classes/java/util/ArrayList.java

2022-03-12 Thread liach
On Sat, 12 Mar 2022 09:48:14 GMT, xpbob wrote: > * Constructs an empty list with an initial capacity of ten > > => > > * Constructs an empty list with default sized empty instances. > > > private static final Object[] DEFAULTCAPACITY_EMPTY_ELEMENTDATA = {}; > >

Re: RFR: 8283067: Incorrect comment in java.base/share/classes/java/util/ArrayList.java

2022-03-12 Thread Quan Anh Mai
On Sat, 12 Mar 2022 09:48:14 GMT, xpbob wrote: > * Constructs an empty list with an initial capacity of ten > > => > > * Constructs an empty list with default sized empty instances. > > > private static final Object[] DEFAULTCAPACITY_EMPTY_ELEMENTDATA = {}; > >

Re: RFR: 8283067: Incorrect comment in java.base/share/classes/java/util/ArrayList.java

2022-03-12 Thread xpbob
On Sat, 12 Mar 2022 14:58:48 GMT, Quan Anh Mai wrote: > The comment is correct, it is just that the backing array allocation is > delayed until the first element is added to the list. Thanks. @merykitty Thanks to review. After new ArrayList, don't know whether to add an element. The array

Re: RFR: 8279508: Auto-vectorize Math.round API [v15]

2022-03-12 Thread Quan Anh Mai
On Sat, 12 Mar 2022 23:22:16 GMT, Quan Anh Mai wrote: >> Jatin Bhateja has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8279508: Creating separate test for round double under feature check. > >

Re: RFR: 8279508: Auto-vectorize Math.round API [v15]

2022-03-12 Thread Quan Anh Mai
On Sat, 12 Mar 2022 19:58:37 GMT, Jatin Bhateja wrote: >> Summary of changes: >> - Intrinsify Math.round(float) and Math.round(double) APIs. >> - Extend auto-vectorizer to infer vector operations on encountering scalar >> IR nodes for above intrinsics. >> - Test creation using new IR testing

Re: RFR: 8282929: Localized monetary symbols are not reflected in `toLocalizedPattern` return value [v2]

2022-03-12 Thread Naoto Sato
On Sat, 12 Mar 2022 16:27:51 GMT, Lance Andersen wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Refined the test > > test/jdk/java/text/Format/DecimalFormat/ToLocalizedPatternTest.java line 29: > >> 27: *

Re: RFR: 8279508: Auto-vectorize Math.round API [v15]

2022-03-12 Thread Jatin Bhateja
> Summary of changes: > - Intrinsify Math.round(float) and Math.round(double) APIs. > - Extend auto-vectorizer to infer vector operations on encountering scalar IR > nodes for above intrinsics. > - Test creation using new IR testing framework. > > Following are the performance number of a JMH

Re: RFR: 8282929: Localized monetary symbols are not reflected in `toLocalizedPattern` return value [v2]

2022-03-12 Thread Lance Andersen
On Fri, 11 Mar 2022 22:20:38 GMT, Naoto Sato wrote: >> `DecimalFormat.toLocalizedPattern()` was not honoring the monetary >> decimal/grouping separator symbols. Fix is straightforward to use the >> correct symbols depending on the formatter type. > > Naoto Sato has updated the pull request

Re: RFR: 8283067: Incorrect comment in java.base/share/classes/java/util/ArrayList.java

2022-03-12 Thread Quan Anh Mai
On Sat, 12 Mar 2022 09:48:14 GMT, xpbob wrote: > * Constructs an empty list with an initial capacity of ten > > => > > * Constructs an empty list with default sized empty instances. > > > private static final Object[] DEFAULTCAPACITY_EMPTY_ELEMENTDATA = {}; > >

Re: RFR: JDK-8282776: Bad NullPointerException message when invoking an interface MethodHandle on a null receiver [v2]

2022-03-12 Thread ExE Boss
On Fri, 11 Mar 2022 22:49:25 GMT, Mandy Chung wrote: >> A simple patch to call `Objects.requireNonNull(recv)` for an explicit null >> receiver check rather than NPE thrown by `Object::getClass`. The message of >> NPE generated by JEP 358 (Helpful NullPointerExceptions) is supposed to be >>

RFR: 8283067: Incorrect comment in java.base/share/classes/java/util/ArrayList.java

2022-03-12 Thread xpbob
* Constructs an empty list with an initial capacity of ten => * Constructs an empty list with default sized empty instances. private static final Object[] DEFAULTCAPACITY_EMPTY_ELEMENTDATA = {}; DEFAULTCAPACITY_EMPTY_ELEMENTDATA is empty and the length is 0 - Commit messages: