Re: RFR: 8186958: Need method to create pre-sized HashMap [v10]

2022-04-05 Thread Stuart Marks
On Sat, 2 Apr 2022 22:46:19 GMT, XenoAmess wrote: >> 8186958: Need method to create pre-sized HashMap > > XenoAmess has updated the pull request incrementally with one additional > commit since the last revision: > > revert changes in jdk.compile

Re: RFR: 8283667: [vectorapi] Vectorization for masked load with IOOBE with predicate feature

2022-04-05 Thread Xiaohong Gong
On Wed, 30 Mar 2022 10:31:59 GMT, Xiaohong Gong wrote: > Currently the vector load with mask when the given index happens out of the > array boundary is implemented with pure java scalar code to avoid the IOOBE > (IndexOutOfBoundaryException). This is necessary for architectures that do > not

Re: RFR: 8186958: Need method to create pre-sized HashMap [v10]

2022-04-05 Thread liach
On Wed, 6 Apr 2022 01:13:11 GMT, Stuart Marks wrote: >> src/java.base/share/classes/java/util/LinkedHashMap.java line 804: >> >>> 802: * @since 19 >>> 803: */ >>> 804: public static LinkedHashMap newLinkedHashMap(int >>> numMappings) { >> >> `LinkedHashMap` may be often

Re: RFR: 8279876: Clean up: isAssignableFrom usages in xpath and jdk internal classes [v2]

2022-04-05 Thread Joe Wang
On Tue, 5 Apr 2022 23:55:22 GMT, Naoto Sato wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> replace with instanceof > > src/java.xml/share/classes/jdk/xml/internal/JdkXmlFeatures.java line 326: > >> 324: public

Re: RFR: 8279876: Clean up: isAssignableFrom usages in xpath and jdk internal classes [v2]

2022-04-05 Thread Joe Wang
> Clean up the usages of isAssignableFrom in a few xpath and jdk/internal > classes where the checks were really about equality or whether they were the > exact class types. It was why they worked nonetheless even though some of > them were backwards. > > Test: existing tests passed. Joe Wang

Re: RFR: 8186958: Need method to create pre-sized HashMap [v10]

2022-04-05 Thread Stuart Marks
On Tue, 5 Apr 2022 23:16:57 GMT, liach wrote: >> XenoAmess has updated the pull request incrementally with one additional >> commit since the last revision: >> >> revert changes in jdk.compile > > src/java.base/share/classes/java/util/LinkedHashMap.java line 804: > >> 802: * @since 19

Re: RFR: 8186958: Need method to create pre-sized HashMap [v10]

2022-04-05 Thread Stuart Marks
On Sat, 2 Apr 2022 22:46:19 GMT, XenoAmess wrote: >> 8186958: Need method to create pre-sized HashMap > > XenoAmess has updated the pull request incrementally with one additional > commit since the last revision: > > revert changes in jdk.compile I've drafted a CSR for this. Please review:

Re: RFR: 8186958: Need method to create pre-sized HashMap [v10]

2022-04-05 Thread Stuart Marks
On Sat, 2 Apr 2022 22:46:19 GMT, XenoAmess wrote: >> 8186958: Need method to create pre-sized HashMap > > XenoAmess has updated the pull request incrementally with one additional > commit since the last revision: > > revert changes in jdk.compile

Re: RFR: 8282221: x86 intrinsics for divideUnsigned and remainderUnsigned methods in java.lang.Integer and java.lang.Long [v8]

2022-04-05 Thread Vladimir Kozlov
On Tue, 5 Apr 2022 20:26:18 GMT, Vamsi Parasa wrote: >> Optimizes the divideUnsigned() and remainderUnsigned() methods in >> java.lang.Integer and java.lang.Long classes using x86 intrinsics. This >> change shows 3x improvement for Integer methods and upto 25% improvement for >> Long. This

Re: RFR: 8282221: x86 intrinsics for divideUnsigned and remainderUnsigned methods in java.lang.Integer and java.lang.Long [v4]

2022-04-05 Thread Vladimir Kozlov
On Thu, 24 Feb 2022 19:04:37 GMT, Vamsi Parasa wrote: >> src/hotspot/share/opto/divnode.cpp line 881: >> >>> 879: return (phase->type( in(2) )->higher_equal(TypeLong::ONE)) ? in(1) : >>> this; >>> 880: } >>> 881: >>>

Re: RFR: 8284067: jpackage'd launcher reports non-zero exit codes with error prompt

2022-04-05 Thread Alexander Matveev
On Thu, 31 Mar 2022 20:08:13 GMT, Alexey Semenyuk wrote: > Add missing `exit(exitCode)` call. > Add relevant unit test. Marked as reviewed by almatvee (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8064

Re: RFR: 8284067: jpackage'd launcher reports non-zero exit codes with error prompt

2022-04-05 Thread Alexey Semenyuk
On Thu, 31 Mar 2022 20:08:13 GMT, Alexey Semenyuk wrote: > Add missing `exit(exitCode)` call. > Add relevant unit test. @sashamatveev please review - PR: https://git.openjdk.java.net/jdk/pull/8064

Re: RFR: 8279876: Clean up: isAssignableFrom usages in xpath and jdk internal classes

2022-04-05 Thread Naoto Sato
On Tue, 5 Apr 2022 23:05:47 GMT, Joe Wang wrote: > Clean up the usages of isAssignableFrom in a few xpath and jdk/internal > classes where the checks were really about equality or whether they were the > exact class types. It was why they worked nonetheless even though some of > them were

Re: RFR: 8186958: Need method to create pre-sized HashMap [v10]

2022-04-05 Thread liach
On Sat, 2 Apr 2022 22:46:19 GMT, XenoAmess wrote: >> 8186958: Need method to create pre-sized HashMap > > XenoAmess has updated the pull request incrementally with one additional > commit since the last revision: > > revert changes in jdk.compile

Re: RFR: 8282221: x86 intrinsics for divideUnsigned and remainderUnsigned methods in java.lang.Integer and java.lang.Long [v8]

2022-04-05 Thread Sandhya Viswanathan
On Tue, 5 Apr 2022 20:26:18 GMT, Vamsi Parasa wrote: >> Optimizes the divideUnsigned() and remainderUnsigned() methods in >> java.lang.Integer and java.lang.Long classes using x86 intrinsics. This >> change shows 3x improvement for Integer methods and upto 25% improvement for >> Long. This

RFR: 8279876: Clean up: isAssignableFrom usages in xpath and jdk internal classes

2022-04-05 Thread Joe Wang
Clean up the usages of isAssignableFrom in a few xpath and jdk/internal classes where the checks were really about equality or whether they were the exact class types. It was why they worked nonetheless even though some of them were backwards. Test: existing tests passed. -

RFR: 8283892: Compress and expand bits

2022-04-05 Thread Paul Sandoz
Add support to compress bits and expand bits of `int` and `long` values, see Hacker's Delight (2nd edition), section 7.4. Compressing or expanding bits of an `int` or `long` value can be composed to enable general permutations, and the "sheep and goats" operation (SAG) see Hacker's Delight

Re: RFR: 8282221: x86 intrinsics for divideUnsigned and remainderUnsigned methods in java.lang.Integer and java.lang.Long [v6]

2022-04-05 Thread Vamsi Parasa
On Tue, 5 Apr 2022 17:06:44 GMT, Sandhya Viswanathan wrote: >> Vamsi Parasa has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add bmi1 support check and jtreg tests > > src/hotspot/cpu/x86/c2_MacroAssembler_x86.hpp line 362: > >> 360:

Re: RFR: 8282221: x86 intrinsics for divideUnsigned and remainderUnsigned methods in java.lang.Integer and java.lang.Long [v8]

2022-04-05 Thread Vamsi Parasa
> Optimizes the divideUnsigned() and remainderUnsigned() methods in > java.lang.Integer and java.lang.Long classes using x86 intrinsics. This > change shows 3x improvement for Integer methods and upto 25% improvement for > Long. This change also implements the DivMod optimization which fuses >