On Thu, 9 Jun 2022 01:03:47 GMT, Joe Darcy wrote:
>> Time to start getting ready for JDK 20...
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull
On Thu, 9 Jun 2022 01:21:30 GMT, Alexander Matveev wrote:
> - Warning will be printed if .jpackage.xml has old version number.
> - Error will be thrown if main-class and app-store values are missing from
> .jpackage.xml.
> - Both main-class and app-store are required values for JDK-8286850
On Tue, 19 Apr 2022 18:00:19 GMT, XenoAmess wrote:
> as title.
This pull request has now been integrated.
Changeset: e01cd7c3
Author:XenoAmess
Committer: Stuart Marks
URL:
https://git.openjdk.java.net/jdk/commit/e01cd7c3ed923cd19509fc972ba6e4aa2991289f
Stats: 154 lines in 29
- Warning will be printed if .jpackage.xml has old version number.
- Error will be thrown if main-class and app-store values are missing from
.jpackage.xml.
- Both main-class and app-store are required values for JDK-8286850 and they
might be missing if user uses app images generated by
> Time to start getting ready for JDK 20...
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains 44 additional commits since the
last revision:
On Wed, 8 Jun 2022 21:07:13 GMT, Maurizio Cimadamore
wrote:
> This simple patch fixes a bunch of references to "CLinker" and replaces them
> with "Linker", following the API name changes.
This pull request has now been integrated.
Changeset: 65f0829d
Author:Maurizio Cimadamore
URL:
On Wed, 8 Jun 2022 09:39:23 GMT, Quan Anh Mai wrote:
>> Hi,
>>
>> This patch implements intrinsics for `Integer/Long::compareUnsigned` using
>> the same approach as the JVM does for long and floating-point comparisons.
>> This allows efficient and reliable usage of unsigned comparison in
On Wed, 8 Jun 2022 21:07:13 GMT, Maurizio Cimadamore
wrote:
> This simple patch fixes a bunch of references to "CLinker" and replaces them
> with "Linker", following the API name changes.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/9094
On Wed, 8 Jun 2022 18:24:35 GMT, Paul Sandoz wrote:
>> Allow JDK modules that use preview features (preview language features or
>> preview API features from dependent modules) to participate without the need
>> to compile with `--enable-preview`.
>>
>> It's difficult to enable participation
This simple patch fixes a bunch of references to "CLinker" and replaces them
with "Linker", following the API name changes.
-
Commit messages:
- Initial push
Changes: https://git.openjdk.java.net/jdk/pull/9094/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=9094=00
On Wed, 8 Jun 2022 17:49:38 GMT, XenoAmess wrote:
>> as title.
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> clean up Calendar
I gave a quick look at the security files touched and seems straightforward. I
didn't see any
On Wed, 8 Jun 2022 14:51:59 GMT, Thiago Henrique Hüpner
wrote:
>> 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved
>> flags is used
>
> Thiago Henrique Hüpner has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Fix
On Wed, 8 Jun 2022 17:49:38 GMT, XenoAmess wrote:
>> as title.
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> clean up Calendar
Running tests and awaiting review from security team. Our internal test system
is backlogged
On Wed, 8 Jun 2022 18:24:35 GMT, Paul Sandoz wrote:
>> Allow JDK modules that use preview features (preview language features or
>> preview API features from dependent modules) to participate without the need
>> to compile with `--enable-preview`.
>>
>> It's difficult to enable participation
On Wed, 25 May 2022 00:35:24 GMT, Joe Darcy wrote:
>> This is an early review of changes to better model JVM access flags, that is
>> "modifiers" like public, protected, etc. but explicitly at a VM level.
>>
>> Language level modifiers and JVM level access flags are closely related, but
>>
On Wed, 8 Jun 2022 18:24:35 GMT, Paul Sandoz wrote:
>> Allow JDK modules that use preview features (preview language features or
>> preview API features from dependent modules) to participate without the need
>> to compile with `--enable-preview`.
>>
>> It's difficult to enable participation
On Wed, 8 Jun 2022 17:21:08 GMT, Alan Bateman wrote:
> Can java.management participate too? It would allow
> sun.management.Util.isVirtual(Thread) to go away (lots of methods in
> sun.management.ThreadImpl need to test if a thread is virtual).
Pushed update.
-
PR:
> Allow JDK modules that use preview features (preview language features or
> preview API features from dependent modules) to participate without the need
> to compile with `--enable-preview`.
>
> It's difficult to enable participation using an annotation due to the nature
> in which symbols
On Wed, 8 Jun 2022 09:39:23 GMT, Quan Anh Mai wrote:
>> Hi,
>>
>> This patch implements intrinsics for `Integer/Long::compareUnsigned` using
>> the same approach as the JVM does for long and floating-point comparisons.
>> This allows efficient and reliable usage of unsigned comparison in
> as title.
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
clean up Calendar
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8302/files
- new:
On Wed, 1 Jun 2022 18:26:17 GMT, Naoto Sato wrote:
>> XenoAmess has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> do it as naotoj said
>
> src/java.base/share/classes/java/util/Calendar.java line 2648:
>
>> 2646:
On Tue, 7 Jun 2022 12:19:29 GMT, Magnus Ihse Bursie wrote:
> The test
> `test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTest.java`
> verifies different failure modes of resource bundles. One of the failures is
> that the runner class, `MissingResourceCauseTestRun.java`,
On Wed, 1 Jun 2022 17:34:04 GMT, Stuart Marks wrote:
>> XenoAmess has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> do it as naotoj said
>
> test/jdk/java/util/HashMap/WhiteBoxResizeTest.java line 441:
>
>> 439: }
>> 440: }
> as title.
XenoAmess has updated the pull request incrementally with two additional
commits since the last revision:
- remove null check for Capacitiable in WhiteBoxResizeTest
- Rename type variable per CSR request; minor spec wording change.
-
Changes:
- all:
On Wed, 8 Jun 2022 15:46:24 GMT, Paul Sandoz wrote:
> Allow JDK modules that use preview features (preview language features or
> preview API features from dependent modules) to participate without the need
> to compile with `--enable-preview`.
>
> It's difficult to enable participation using
On Mon, 6 Jun 2022 06:57:23 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses
> https://bugs.openjdk.java.net/browse/JDK-8285405?
>
> I've added the test for `LinkedHashMap.newLinkedHashMap(int)` in the existing
> `test/jdk/java/util/LinkedHashMap/Basic.java`
> 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved
> flags is used
Thiago Henrique Hüpner has updated the pull request incrementally with one
additional commit since the last revision:
Simplify test names
-
Changes:
- all:
On Thu, 19 May 2022 15:54:06 GMT, Raffaello Giulietti
wrote:
> Extend the range of Random.doubles(double, double) and similar methods.
This pull request has now been integrated.
Changeset: c8cff1bd
Author:Raffaello Giulietti
Committer: Joe Darcy
URL:
On Thu, 26 May 2022 18:02:14 GMT, Raffaello Giulietti
wrote:
> BigDecimal(String) currently fails to accept some strings produced by
> BigDecimal.toString(). This PR removes this limitation.
This pull request has now been integrated.
Changeset: c15e10fb
Author:Raffaello Giulietti
On Sat, 14 May 2022 00:30:00 GMT, Tim Prinzing wrote:
> The Class::forName behavior change to match JNI FindClass is a compatible
> change and seems pretty attractive as it would be expected that
> Class::forName would give the same behavior as FindClass which uses the
> system classloader.
On Wed, 8 Jun 2022 13:07:20 GMT, Tim Prinzing wrote:
>> The Class::forName behavior change to match JNI FindClass is a compatible
>> change and seems pretty attractive as it would be expected that
>> Class::forName would give the same behavior as FindClass which uses the
>> system
Allow JDK modules that use preview features (preview language features or
preview API features from dependent modules) to participate without the need to
compile with `--enable-preview`.
It's difficult to enable participation using an annotation due to the nature in
which symbols are
On Fri, 3 Jun 2022 16:48:46 GMT, Naoto Sato wrote:
> The code path calls `String.getBytesNoRepl()`, but it blindly replaces
> unmappable characters with replacements if the encoder is an `ArrayEncoder`.
> Changed only to do so if `doReplace` is `true` in
> `String.encodeWithEncoder()`.
This
On Tue, 7 Jun 2022 12:19:29 GMT, Magnus Ihse Bursie wrote:
> I have failed to reproduce the working conditions that makes a file actually
> unreadable for the owner on Windows, neither on my GHA test repo, nor
> locally.
I had quick look at the CI setup we have access to. It appears that
On Wed, 8 Jun 2022 14:44:33 GMT, Jim Laskey wrote:
>> To take optimal advantage of the pre-existing optimization for repeated
>> filters we could split the application of different types of stringifiers.
>>
>> The resulting difference in order of evaluation is not observable by
>>
On Wed, 8 Jun 2022 14:51:59 GMT, Thiago Henrique Hüpner
wrote:
>> 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved
>> flags is used
>
> Thiago Henrique Hüpner has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Fix
> 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved
> flags is used
Thiago Henrique Hüpner has updated the pull request incrementally with one
additional commit since the last revision:
Fix test message
-
Changes:
- all:
> 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved
> flags is used
Thiago Henrique Hüpner has updated the pull request incrementally with one
additional commit since the last revision:
Add tests
-
Changes:
- all:
On Wed, 8 Jun 2022 10:20:37 GMT, Claes Redestad wrote:
> To take optimal advantage of the pre-existing optimization for repeated
> filters we could split the application of different types of stringifiers.
>
> The resulting difference in order of evaluation is not observable by
> conventional
On Wed, 8 Jun 2022 13:42:11 GMT, Jorn Vernee wrote:
> Looking at the code in MethodHandles::filterArguments, and this optimization.
> It seems that for multiple filters we could potentially always generate just
> a single new lambda form if we wanted, not just for repeated filters.
>
> It
On Wed, 8 Jun 2022 10:20:37 GMT, Claes Redestad wrote:
> To take optimal advantage of the pre-existing optimization for repeated
> filters we could split the application of different types of stringifiers.
>
> The resulting difference in order of evaluation is not observable by
> conventional
These 19'545 doubles were generated on purpose by Paul Zimmermann of INRIA as
hard test cases.
-
Commit messages:
- 8288021: Add hard test cases to jdk.internal.math.DoubleToDecimalChecker
Changes: https://git.openjdk.java.net/jdk/pull/9084/files
Webrev:
On Wed, 8 Jun 2022 12:11:30 GMT, Сергей Цыпанов wrote:
>> To take optimal advantage of the pre-existing optimization for repeated
>> filters we could split the application of different types of stringifiers.
>>
>> The resulting difference in order of evaluation is not observable by
>>
> The Class::forName behavior change to match JNI FindClass is a compatible
> change and seems pretty attractive as it would be expected that
> Class::forName would give the same behavior as FindClass which uses the
> system classloader. The test for 8281006 was enhanced to test for this
>
On Wed, 8 Jun 2022 10:20:37 GMT, Claes Redestad wrote:
> To take optimal advantage of the pre-existing optimization for repeated
> filters we could split the application of different types of stringifiers.
>
> The resulting difference in order of evaluation is not observable by
> conventional
On Wed, 8 Jun 2022 08:25:21 GMT, Severin Gehwolf wrote:
>> src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp line 54:
>>
>>> 52: } else {
>>> 53: char *p = strstr(cgroup_path, _root);
>>> 54: if (p != NULL && p == cgroup_path) {
>>
>> I think this change should be done in
> Please review this cleanup change in the cgroup subsystem which used to use
> hard-coded stack allocated
> buffers for concatenating strings in memory. We can use `stringStream`
> instead which doesn't have the issue
> of hard-coding maximum lengths (and related checks) and makes the code,
In jpackage test suite there is a test utility WindowsHelper.queryRegistryValue
. It is used to verify changes to Windows registry that can be done by
installer packages. It spawns `reg.exe query` process and parses its output.
This patch adds support for quering empty values and additional
> Instead of `Executable.getParameterTypes()` we could use
> `Executable.getSharedParameterTypes()` in trusted code. Same is applicable
> for `Executable.getExceptionTypes()`.
Сергей Цыпанов has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev
To take optimal advantage of the pre-existing optimization for repeated filters
we could split the application of different types of stringifiers.
The resulting difference in order of evaluation is not observable by
conventional means since all reference type share the same object stringifier,
On Thu, 2 Jun 2022 17:00:35 GMT, Joe Darcy wrote:
>> Time to start getting ready for JDK 20...
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull
On Tue, 7 Jun 2022 17:14:18 GMT, Quan Anh Mai wrote:
> Hi,
>
> This patch implements intrinsics for `Integer/Long::compareUnsigned` using
> the same approach as the JVM does for long and floating-point comparisons.
> This allows efficient and reliable usage of unsigned comparison in Java,
>
On Tue, 7 Jun 2022 17:41:13 GMT, Vladimir Kozlov wrote:
>> Quan Anh Mai has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - remove comments
>> - review comments
>
> src/hotspot/share/opto/subnode.hpp line 217:
>
>> 215:
>>
> Hi,
>
> This patch implements intrinsics for `Integer/Long::compareUnsigned` using
> the same approach as the JVM does for long and floating-point comparisons.
> This allows efficient and reliable usage of unsigned comparison in Java,
> which is a basic operation and is important for range
On Wed, 8 Jun 2022 07:13:30 GMT, Ioi Lam wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>> commits
On Tue, 7 Jun 2022 12:34:25 GMT, Claes Redestad wrote:
> - Reduce runtime by running fewer forks, fewer iterations, less warmup. All
> micros tested in this group appear to stabilize very quickly.
> - Refactor BigIntegers to avoid re-running some (most) micros over and over
> with parameter
On Fri, 27 May 2022 14:18:19 GMT, Claes Redestad wrote:
> In preparation of #8855 this PR refactors the conversions from `List` to
> array and array to `List`, reducing the number of conversions when calling
> `MethodHandles.dropArguments` in particular. This remove about ~5% of
> allocations
On Tue, 7 Jun 2022 12:42:26 GMT, Severin Gehwolf wrote:
>> Please review this cleanup change in the cgroup subsystem which used to use
>> hard-coded stack allocated
>> buffers for concatenating strings in memory. We can use `stringStream`
>> instead which doesn't have the issue
>> of
On Mon, 23 May 2022 20:03:05 GMT, Claes Redestad wrote:
> When generating `MethodHandle`-based concatenation expressions in
> `StringConcatFactory` we can reduce the number of classes generated at
> runtime by creating small batches of prependers and mixers before binding
> them into the root
> On Jun 7, 2022, at 9:21 PM, Alexander Matveev
> wrote:
>
> Hi Michael,
>
> Yes, this is correct. It is a three step process as you outlined it below.
>
Alexander,
Could you post an example of the three invocations, without needing to include
any post-processing, to 1) create app-image
On 07/06/22 9:39 am, Stuart Marks wrote:
Hi Jai,
The error
java.lang.OutOfMemoryError: Java heap space
indicates that the VM really has run out of memory. Presumably if you
increased the heap size, it would actually be able to allocate that
memory. You might have to add the /othervm
Can I please get a review of this change which addresses
https://bugs.openjdk.java.net/browse/JDK-8285405?
I've added the test for `LinkedHashMap.newLinkedHashMap(int)` in the existing
`test/jdk/java/util/LinkedHashMap/Basic.java` since that test has tests for
various APIs of this class.
For
62 matches
Mail list logo