On Thu, 4 Mar 2021 03:59:27 GMT, Alexander Matveev wrote:
> - Fixed by adding write permissions to .exe package.
Marked as reviewed by asemenyuk (Committer).
-
PR: https://git.openjdk.java.net/jdk/pull/2822
Fix jpackage app launcher to also look for JLI lib in "lib/jli/libjli.so"
subdirectory of runtime
-
Commit messages:
- 8262300: jpackage app-launcher fails on linux when using JDK11 based runtime
Changes: https://git.openjdk.java.net/jdk/pull/2827/files
Webrev:
On Thu, 4 Mar 2021 14:18:59 GMT, Andy Herrick wrote:
>> when the app modules have already been jlinked with the runtime, and there
>> is no need for module-path, jpackage was acting as if the module-path was
>> "." and picking up jars in the current directory.
>
> Andy Herrick has updated the
On Wed, 24 Feb 2021 21:59:22 GMT, Andy Herrick wrote:
> Implementation of Mac App Support including three new mac specific CLI
> options.
Marked as reviewed by asemenyuk (Committer).
-
PR: https://git.openjdk.java.net/jdk/pull/2716
On Sun, 7 Mar 2021 03:15:46 GMT, Yasumasa Suenaga wrote:
> I saw error during jpackage compilation with VS 2019 (16.9.0) as following
> (on Japanese locale):
>
> c:\progra~2\micros~2\2019\commun~1\vc\tools\msvc\1428~1.299\include\utility(604):
> error C2440: '=': '_Other' から '_Ty' に変換できません。
>
Add support to insert dialog with prompts to create shortcuts in dialog
installation sequence of Windows installers created by jpackage.
As a side effect of the fix, UI-related WiX source code was moved from main.wxs
into generated ui.wxf file. Users can override ui.wxf by placing a file with
On Mon, 1 Mar 2021 15:55:39 GMT, Andy Herrick wrote:
> when the app modules have already been jlinked with the runtime, and there is
> no need for module-path, jpackage was acting as if the module-path was "."
> and picking up jars in the current directory.
Marked as reviewed by asemenyuk
On Mon, 5 Apr 2021 19:46:43 GMT, Alexey Semenyuk wrote:
> Use value of `--icon` jpackage CLI option to set icon for exe installers.
This pull request has now been integrated.
Changeset: 5bd6c745
Author: Alexey Semenyuk
URL: https://git.openjdk.java.net/jdk/commit/5bd6c745
St
On Wed, 7 Apr 2021 01:09:37 GMT, Yasumasa Suenaga wrote:
> Since fix to [JDK-8263135](https://bugs.openjdk.java.net/browse/JDK-8263135),
> we've seen following warning message on the console when we run jpackage to
> create exe.
>
> WARNING: MsiCloseHandle(3174034504) failed with error=6
>
On Mon, 12 Apr 2021 20:18:46 GMT, Alexander Matveev
wrote:
> This is regression from JDK-8242302. Fixed by setting java.library.path to
> same values as it was before JDK-8242302.
Marked as reviewed by asemenyuk (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3443
On Sun, 18 Apr 2021 12:44:17 GMT, Yasumasa Suenaga wrote:
> When creating an "exe" installer on Windows, `AbstractBundler.cleanup()`
> calls `IOUtils.deleteRecursive()` to delete the tmp directory. It can
> intermittently fail trying to delete the msi file.
>
>
On Thu, 15 Apr 2021 01:24:04 GMT, Alexander Matveev
wrote:
> - Issue was reproducible when install-dir points to some invalid location.
> - Fixed by defaulting DMG drag and drop location to /Applications folder and
> --install-dir will be ignored with warning for DMG.
> - I do not see any
On Tue, 13 Apr 2021 18:57:20 GMT, Andy Herrick wrote:
> two changes:
> One to jpackage, when recursively removing directory, when IOException
> occurs, record it and continue (deleting as much as possible) before throwing
> the exception.
> The other to tests, when running jpackage via
On Tue, 13 Apr 2021 21:10:56 GMT, Kevin Rushforth wrote:
> Are you sure you need an `AtomicReference` to set the exception? I don't see
> any use of multiple threads, but I might be missing something. If you do need
> it, you need to fix the order of arguments.
`postVisitDirectory()` and
On Tue, 13 Apr 2021 22:50:12 GMT, Andy Herrick wrote:
>> two changes:
>> One to jpackage, when recursively removing directory, when IOException
>> occurs, record it and continue (deleting as much as possible) before
>> throwing the exception.
>> The other to tests, when running jpackage via
On Fri, 29 Jan 2021 21:33:40 GMT, Alexey Semenyuk wrote:
> Fix for https://bugs.openjdk.java.net/browse/JDK-8254702
>
> The fix splits Linux app launcher in app launcher and launcher shared lib.
> App launcher is pure C and doesn't have C++ code. App launcher lib
> incorpo
On Thu, 18 Feb 2021 19:35:09 GMT, Alexey Semenyuk wrote:
> Follow up for JDK-8235397 fix
This pull request has now been integrated.
Changeset: 0c31d5b9
Author: Alexey Semenyuk
URL: https://git.openjdk.java.net/jdk/commit/0c31d5b9
Stats: 5 lines in 1 file changed: 0 ins; 4 del
Follow up for JDK-8235397 fix
-
Commit messages:
- Fix comment for getPrefixed() in canonicalize_md.c
Changes: https://git.openjdk.java.net/jdk/pull/2631/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2631=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8261977
On Thu, 9 Sep 2021 16:36:44 GMT, Andy Herrick wrote:
> This is a backport from JDK-18
Marked as reviewed by asemenyuk (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/305
On Fri, 10 Sep 2021 13:18:49 GMT, Andy Herrick wrote:
> JDK-8271868 was pushed to JDK17 instead of jdk17u.
> This change is to back it out
Marked as reviewed by asemenyuk (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/307
On Fri, 10 Sep 2021 12:03:48 GMT, Ao Qi wrote:
> A similar issue on Ubuntu has been fixed by
> [JDK-8238953](https://bugs.openjdk.java.net/browse/JDK-8238953). However,
> tools/jpackage tests do not work on Debian Linux or other apt-based Linux,
> when rpm package is installed. This issue
On Fri, 10 Sep 2021 12:03:48 GMT, Ao Qi wrote:
> A similar issue on Ubuntu has been fixed by
> [JDK-8238953](https://bugs.openjdk.java.net/browse/JDK-8238953). However,
> tools/jpackage tests do not work on Debian Linux or other apt-based Linux,
> when rpm package is installed. This issue
On Tue, 14 Sep 2021 17:21:29 GMT, Alexey Semenyuk wrote:
> Fix jpackage error output when "--type" CLI option is missing and jpackage
> detects that it can't build native packages in the environment.
This pull request has now been integrated.
Changeset: a3ca7702
Author:
> Fix jpackage error output when "--type" CLI option is missing and jpackage
> detects that it can't build native packages in the environment.
Alexey Semenyuk has updated the pull request incrementally with one additional
commit since the last revision:
dummy commit
--
On Tue, 14 Sep 2021 13:38:42 GMT, Andy Herrick wrote:
> JDK-8273040: Turning off JpAllowDowngrades (or Upgrades)
Marked as reviewed by asemenyuk (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5509
> Fix jpackage error output when "--type" CLI option is missing and jpackage
> detects that it can't build native packages in the environment.
Alexey Semenyuk has updated the pull request incrementally with one additional
commit since the last revision:
dummy commit
--
Fix jpackage error output when "--type" CLI option is missing and jpackage
detects that it can't build native packages in the environment.
-
Commit messages:
- 8272815: jpackage --type rpm produces an error: Invalid or unsupported type:
[null]
Changes:
On Thu, 9 Sep 2021 20:14:01 GMT, Andy Herrick wrote:
> backport from jdk-18
Marked as reviewed by asemenyuk (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/306
On Wed, 14 Jul 2021 16:50:39 GMT, Andy Herrick wrote:
>> JDK-8269387: jpackage --add-launcher should have option to not create
>> shortcuts for additional launchers
>
> Andy Herrick has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Tue, 13 Jul 2021 16:39:01 GMT, Andy Herrick wrote:
>> JDK-8269387: jpackage --add-launcher should have option to not create
>> shortcuts for additional launchers
>
> Andy Herrick has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Mon, 2 Aug 2021 13:45:17 GMT, Andy Herrick wrote:
> JDK-8271344: Windows product version issue
Marked as reviewed by asemenyuk (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4958
Added jtreg test to verify jpackage launcher adds app dir to
`java.library.path` system property.
Removed unused test/jdk/tools/jpackage/apps/installer/Hello.java.
Moved test/jdk/tools/jpackage/apps/image/Hello.java to
test/jdk/tools/jpackage/apps/Hello.java.
-
Commit messages:
-
> Added jtreg test to verify jpackage launcher adds app dir to
> `java.library.path` system property.
> Removed unused test/jdk/tools/jpackage/apps/installer/Hello.java.
> Moved test/jdk/tools/jpackage/apps/image/Hello.java to
> test/jdk/tools/jpackage/apps/Hello.java.
Alex
On Thu, 5 Aug 2021 17:07:13 GMT, Andy Herrick wrote:
>> 8271868: Warn user when using mac-sign option with unsigned app-image.
>
> Andy Herrick has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8271868: Warn user when using mac-sign
> Added jtreg test to verify jpackage launcher adds app dir to
> `java.library.path` system property.
> Removed unused test/jdk/tools/jpackage/apps/installer/Hello.java.
> Moved test/jdk/tools/jpackage/apps/image/Hello.java to
> test/jdk/tools/jpackage/apps/Hello.java.
Alex
On Wed, 4 Aug 2021 20:00:37 GMT, Andy Herrick wrote:
> 8271868: Warn user when using mac-sign option with unsigned app-image.
What options exist for building a package from app image with invalid signature?
-
PR: https://git.openjdk.java.net/jdk/pull/5004
On Wed, 4 Aug 2021 20:00:37 GMT, Andy Herrick wrote:
> 8271868: Warn user when using mac-sign option with unsigned app-image.
What if we save "signed/not signed" flag in ".jpackage.xml" when building app
image and read its value instead of guessing if they signed app image or not
using
On Wed, 4 Aug 2021 20:00:37 GMT, Andy Herrick wrote:
> 8271868: Warn user when using mac-sign option with unsigned app-image.
My understanding of this enhancement is to warn user when app image created
without --mac-sign is used in building a signed package. I.e. to warn user they
misused
Restart window app launcher to make changes made to `PATH` env variable visible
to JLI code in
https://github.com/openjdk/jdk/blob/master/src/hotspot/os/windows/os_windows.cpp#L347
-
Commit messages:
- 8272328: java.library.path is not set properly by Windows jpackage app
On Wed, 11 Aug 2021 15:20:00 GMT, Alexey Semenyuk wrote:
>> Added jtreg test to verify jpackage launcher adds app dir to
>> `java.library.path` system property.
>> Removed unused test/jdk/tools/jpackage/apps/installer/Hello.java.
>> Moved test/jdk/tools/jpacka
On Mon, 9 Aug 2021 17:02:55 GMT, Alexey Semenyuk wrote:
> Added jtreg test to verify jpackage launcher adds app dir to
> `java.library.path` system property.
> Removed unused test/jdk/tools/jpackage/apps/installer/Hello.java.
> Moved test/jdk/tools/jpackage/apps/image/Hello.java to
> Added jtreg test to verify jpackage launcher adds app dir to
> `java.library.path` system property.
> Removed unused test/jdk/tools/jpackage/apps/installer/Hello.java.
> Moved test/jdk/tools/jpackage/apps/image/Hello.java to
> test/jdk/tools/jpackage/apps/Hello.java.
Alex
On Wed, 11 Aug 2021 17:52:57 GMT, Alexey Semenyuk wrote:
> Restart window app launcher to make changes made to `PATH` env variable
> visible to JLI code in
> https://github.com/openjdk/jdk/blob/master/src/hotspot/os/windows/os_windows.cpp#L347
This pull request has now been i
On Thu, 21 Oct 2021 15:36:36 GMT, Andy Herrick wrote:
>> JDK-8263155: Allow additional contents for DMG
>
> Andy Herrick has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains five commits:
>
> - Merge branch 'master' into
On Wed, 6 Oct 2021 18:53:39 GMT, Andy Herrick wrote:
>> 8274346: Support for additional content in an app-image.
>
> Andy Herrick has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8274346: Support for additional content in an app-image.
On Thu, 30 Sep 2021 18:51:49 GMT, Andy Herrick wrote:
> 8274346: Support for additional content in an app-image.
Changes requested by asemenyuk (Reviewer).
test/jdk/tools/jpackage/share/AppContentTest.java line 97:
> 95: for (String p : paths) {
> 96:
On Thu, 23 Sep 2021 20:03:29 GMT, Andy Herrick wrote:
> JDK-8274087: Windows DLL path not set correctly.
Marked as reviewed by asemenyuk (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5663
8278311: Debian packaging doesn't work
-
Commit messages:
- Changes from another fix removed
- 8278311: Debian packaging doesn't work
Changes: https://git.openjdk.java.net/jdk/pull/6726/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=6726=00
Issue:
On Fri, 17 Dec 2021 03:28:12 GMT, Alexander Matveev
wrote:
> This is regression from JDK-8263155. MacHelper.java is now calling test
> verification callback with all content in DMG root. SigningPackageTest
> expects only path with app name in it and thus it fails when trying to verify
> app
On Thu, 11 Nov 2021 04:07:18 GMT, Alexey Semenyuk wrote:
> 8276084: Linux DEB Bundler: release number in outputted .deb file should be
> optional
This pull request has now been integrated.
Changeset: 9046077f
Author:Alexey Semenyuk
URL:
https://git.openjdk.java.net/jdk/
On Fri, 5 Nov 2021 19:58:01 GMT, Alexey Semenyuk wrote:
> The fix is to isolate C++ calls in the separate forked child process on
> Linux.
> This change requires the passing of JLI command line arguments and values of
> environment variables between two processes.
This pull req
On Fri, 19 Nov 2021 20:57:46 GMT, Daniel D. Daugherty
wrote:
> This reverts commit 936f7ff49ed86adb74bb1ff10d93cb3d7f7d70a0.
>
> So far we've had 3 failed Tier2 job sets in a row. My Mach5 Tier2 of this
> [BACKOUT] has
> passed the macosx-aarch64 test task that was failing before.
Marked as
On 11/24/2021 8:35 AM, Andy Herrick wrote:
Wait - the original change, 'addArgument("-J-Djlink.debug=true");'
adds "-D-J..." as a jpackage arg. This is not a supported command
line option, I'm not sure why it is not throwing an error all the
time, but you need to use
8277429: Conflicting jpackage static library name
-
Commit messages:
- 8277429: Conflicting jpackage static library name
Changes: https://git.openjdk.java.net/jdk/pull/6485/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=6485=00
Issue:
On Sat, 20 Nov 2021 03:26:51 GMT, Alexey Semenyuk wrote:
> 8277429: Conflicting jpackage static library name
This pull request has now been integrated.
Changeset: e3911a85
Author: Alexey Semenyuk
URL:
https://git.openjdk.java.net/jdk/commit/e3911a8532e9b93ba5e65c613bd79864485db
8276084: Linux DEB Bundler: release number in outputted .deb file should be
optional
-
Commit messages:
- Bugfix
- Bugfix
- Bugfix
- 8276084: Linux DEB Bundler: release number in outputted .deb file should be
optional
Changes: https://git.openjdk.java.net/jdk/pull/6345/files
On Fri, 5 Nov 2021 17:21:01 GMT, Andy Herrick wrote:
> JDK-8276562: Fix to JDK-8263155 left out the help text changes
Marked as reviewed by asemenyuk (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6281
The fix is to isolate C++ calls in the separate forked child process on Linux.
This change requires the passing of JLI command line arguments and values of
environment variables between two processes.
-
Commit messages:
- Whitespace clean up
- 8274856: Failing jpackage tests with
On Wed, 1 Dec 2021 14:25:52 GMT, Andy Herrick wrote:
> Before signing, unsign all executables and libraries (not just those in
> runtime).
> Also, run individual file sign and unsign commands in quiet mode.
> Also, add test case to SigningAppImageTest to test that signing app that has
>
On Wed, 1 Dec 2021 21:35:01 GMT, Andy Herrick wrote:
> - We need to unsign all executables and libraries in the app-image before
> signing. (not just those in the runtime).
> - Clean up excessive output by executing the individual file sign and
> unsigning commands in quiet mode.
> - Add
On Tue, 14 Dec 2021 06:10:51 GMT, Alexander Matveev
wrote:
> This is regression from JDK-8276837. exec() was passing INFINITE_TIMEOUT
> instead of actual value of timeout variable. Execution of osascript was
> running without timeout and thus several tests timeout. Osascript hang during
>
Replace `";"` with `FileUtils::pathSeparator` in the expression adding 'app'
dir to env variable in jpackage app launcher.
-
Commit messages:
- 8271155: Wrong path separator in env variable
Changes: https://git.openjdk.java.net/jdk17/pull/271/files
Webrev:
On Thu, 22 Jul 2021 19:35:59 GMT, Alexey Semenyuk wrote:
> Replace `";"` with `FileUtils::pathSeparator` in the expression adding 'app'
> dir to env variable in jpackage app launcher.
This pull request has now been integrated.
Changeset: 7165b3f1
Author: Alexey Semenyuk
U
On Thu, 22 Jul 2021 19:35:59 GMT, Alexey Semenyuk wrote:
> Replace `";"` with `FileUtils::pathSeparator` in the expression adding 'app'
> dir to env variable in jpackage app launcher.
There is no unit test covering this area. I'll file follow up CR to add one in
JDK18.
-
The fix for JDK-8263157 cleared the default value of `java.library.path`
system property and resulted in JDK-8267598 regression. So the fix for
JDK-8263157 was reworked: jpackage doesn't set `java.library.path`
system property, but it adds `app` directory to `DYLD_LIBRARY_PATH` env
variable on
Oh, inconsistent path separators indeed. Good catch! This is the reason
it doesn't work as it should.
Filed https://bugs.openjdk.java.net/browse/JDK-8271155 to track it.
- Alexey
On 7/22/2021 2:04 PM, Michael Hall wrote:
On Jul 22, 2021, at 12:29 PM, Alexey Semenyuk
wrote:
The fix
?
Alan
On Jul 22, 2021, at 11:04 AM, Michael Hall wrote:
On Jul 22, 2021, at 12:29 PM, Alexey Semenyuk
wrote:
The fix for JDK-8263157 cleared the default value of `java.library.path` system
property and resulted in JDK-8267598 regression. So the fix for JDK-8263157 was
reworked: jpacka
On Fri, 18 Jun 2021 22:46:24 GMT, Alexey Semenyuk wrote:
> GetApplicationHomeFromDll() fails if the path to libjli.so contains "bin"
> component (/tmp/bin/HelloWorld/lib/runtime/lib/libjli.so). TruncatePath()
> looks for "/bin/" first in "/tmp/bin/He
On Mon, 3 Jan 2022 08:10:27 GMT, Aleksey Shipilev wrote:
> Seems like a missing include. C++ docs say `offsetof` is from ``,
> adding that include explicitly fixes the build. Seems to only happen with
> older GCCs, but it seems to be a happy accident it works on newer ones,
> probably through
On Mon, 14 Feb 2022 23:56:43 GMT, Alexander Matveev
wrote:
>> Added ability to override description for additional launchers via
>> "description" property.
>
> Alexander Matveev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8279995:
On Mon, 14 Feb 2022 23:56:43 GMT, Alexander Matveev
wrote:
>> Added ability to override description for additional launchers via
>> "description" property.
>
> Alexander Matveev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8279995:
On Fri, 11 Feb 2022 21:22:44 GMT, Alexander Matveev
wrote:
>> Added ability to override description for additional launchers via
>> "description" property.
>
> Alexander Matveev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8279995:
Code clean up. Remove obsolete comments, unused imports, and unneeded jtreg
test parameter.
Fix the code to handle the case when installers are not created and there is
nothing to verify in the test.
-
Commit messages:
- 8281170: Test
8281874: Can't unpack msi installers from
test/jdk/tools/jpackage/windows/test/jdk/tools/jpackage/windows/WinShortcutPromptTest.java
test
-
Commit messages:
- 8281874: Can't unpack msi installers from
Implementation of [JDK-8275062: "Allow jpackage create installers for
services"](https://bugs.openjdk.java.net/browse/JDK-8275062)
CSR
-
Commit messages:
- Whitespace cleanup
- Whitespace cleanup
- JDK-8236128: Allow jpackage create installers for services
- Sync l10n files.
Hi Sverre,
Interesting, I don't see changes in jpackage code related to the issue.
In particular jdk.jpackage.internal.IOUtils.writableOutputDir() function
is the same in JDK14, JDK17, and mainline.
- Alexey
On 2/18/2022 8:31 AM, Sverre Moe wrote:
I executed our JDK11 docker image, which
On Tue, 15 Feb 2022 22:56:35 GMT, Alexey Semenyuk wrote:
> 8281874: Can't unpack msi installers from
> test/jdk/tools/jpackage/windows/test/jdk/tools/jpackage/windows/WinShortcutPromptTest.java
> test
This pull request has now been integrated.
Changeset: 81645521
Author: Alexey
On Tue, 15 Feb 2022 17:44:24 GMT, Alexey Semenyuk wrote:
> Code clean up. Remove obsolete comments, unused imports, and unneeded jtreg
> test parameter.
> Fix the code to handle the case when installers are not created and there is
> nothing to verify in the test.
This pull req
8282011: test/jdk/tools/jpackage/windows/WinL10nTest.java test fails if
light.exe is not in %PATH%
-
Commit messages:
- 8282011: test/jdk/tools/jpackage/windows/WinL10nTest.java test fails locally
Changes: https://git.openjdk.java.net/jdk/pull/7500/files
Webrev:
8282007: Assorted enhancements to jpackage testing framework
-
Commit messages:
- Trailing whitespace removed
- 8282007: Assorted enhancements to jpackage testing framework
- macOS bugix
- Don't use TKit.assertZZZ to validate test setup correctness. Throw exception
instead.
-
> 8282007: Assorted enhancements to jpackage testing framework
Alexey Semenyuk has updated the pull request incrementally with one additional
commit since the last revision:
Copyright years fixed
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7502/files
- new: ht
On Wed, 16 Feb 2022 23:53:44 GMT, Alexander Matveev
wrote:
>> Alexey Semenyuk has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Don't fail if requested to uninstall not installed Debian package
>
> test/
> 8282007: Assorted enhancements to jpackage testing framework
Alexey Semenyuk has updated the pull request incrementally with one additional
commit since the last revision:
Don't fail if requested to uninstall not installed Debian package
-
Changes:
- all: ht
On Wed, 16 Feb 2022 20:06:09 GMT, Alexey Semenyuk wrote:
> 8282007: Assorted enhancements to jpackage testing framework
This pull request has now been integrated.
Changeset: cd234f5d
Author: Alexey Semenyuk
URL:
https://git.openjdk.java.net/jdk/com
On Wed, 16 Feb 2022 17:52:43 GMT, Alexey Semenyuk wrote:
> 8282011: test/jdk/tools/jpackage/windows/WinL10nTest.java test fails if
> light.exe is not in %PATH%
This pull request has now been integrated.
Changeset: 0b00ce17
Author:Alexey Semenyuk
URL:
https://git.openjdk.ja
On Fri, 25 Feb 2022 01:27:52 GMT, Alexander Matveev
wrote:
>> Added ability to override description for additional launchers via
>> "description" property.
>
> Alexander Matveev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8279995:
On Thu, 17 Feb 2022 06:54:33 GMT, Alexander Matveev
wrote:
>> Added ability to override description for additional launchers via
>> "description" property.
>
> Alexander Matveev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8279995:
much more complex workaround than the one above.
/Sverre
fre. 25. mar. 2022 kl. 08:00 skrev David Holmes :
On 25/03/2022 5:14 am, Alexey Semenyuk wrote:
> Hi Sverre,
>
> Oh, I misunderstood the problem. I though the issue was with
parsing WiX
> version s
Hi Sverre,
The output comes from quite old jpackage (jdk15, I guess). Please try
jpackage from the newer jdk (the latest one would be the best option).
They don't have this issue.
- Alexey
On 3/23/2022 10:01 AM, Sverre Moe wrote:
Could jpackage instruct WiX when building a native
1
14:48:51 * What went wrong:
14:48:51 Execution failed for task ':jpackage'.
14:48:51 > Process 'command 'C:\Program Files\Eclipse
Adoptium\jdk-17.0.2.8-hotspot/bin/jpackage.exe'' finished with
non-zero exit
tor. 24. mar. 2022 kl. 17:39 skrev Alexey Semenyuk
:
Hi Sverre,
The ou
Hi Hiran,
Looks like jpackage fails because of missing package name on the command
line.
I agree that the error message is not helpful. Can you try one of jdk19
EA builds [1] to see if the problem is reproducible?
[1] https://jdk.java.net/19/
- Alexey
On 4/1/2022 5:58 AM, Hiran Chaudhuri
On Wed, 9 Feb 2022 07:37:42 GMT, Alexander Matveev wrote:
> Added ability to override description for additional launchers via
> "description" property.
I don't quite understand how these changes affect the description of launcher
executables on Windows. I'd expect changes at least in
On Wed, 9 Feb 2022 07:37:42 GMT, Alexander Matveev wrote:
> Added ability to override description for additional launchers via
> "description" property.
Unfortunately, manual testing adds zero value to automated test runs. This
feature can be covered with automated tests so it should be.
On Wed, 9 Feb 2022 18:53:35 GMT, Alexander Matveev wrote:
>> test/jdk/tools/jpackage/share/AddLauncherTest.java line 93:
>>
>>> 91: new AdditionalLauncher("Baz2")
>>> 92: .setDefaultArguments()
>>> 93: .addRawProperties(Map.entry("description", "Baz2
>>>
On Tue, 1 Dec 2020 23:54:11 GMT, Alexey Semenyuk wrote:
> Add missing quotes to `%if` expressions in spec template. Required by
> rpmbuild 4.16.0
This pull request has now been integrated.
Changeset: 541c7f74
Author:Alexey Semenyuk
URL:
https://git.openjdk.java.net/jdk/
On Tue, 1 Dec 2020 23:54:11 GMT, Alexey Semenyuk wrote:
> Add missing quotes to `%if` expressions in spec template. Required by
> rpmbuild 4.16.0
@sashamatveev @andyherrick please review
-
PR: https://git.openjdk.java.net/jdk/pull/1551
Add missing quotes to `%if` expressions in spec template. Required by rpmbuild
4.16.0
-
Commit messages:
- 8257434: jpackage fails to create rpm on Fedora Linux
Changes: https://git.openjdk.java.net/jdk/pull/1551/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1551=00
On Thu, 31 Mar 2022 20:08:13 GMT, Alexey Semenyuk wrote:
> Add missing `exit(exitCode)` call.
> Add relevant unit test.
@sashamatveev please review
-
PR: https://git.openjdk.java.net/jdk/pull/8064
idate(Linux
Pa
ckageBundler.java:72)
at
jdk.jpackage/jdk.jpackage.internal.Arguments.generateBundle(Arguments
.j
ava:688)
... 3 more
On Fri, 2022-04-01 at 12:37 -0400, Alexey Semenyuk wrote:
Hi Hiran,
Looks like jpackage fails because of missing package name on the
command
line.
On Thu, 31 Mar 2022 20:08:13 GMT, Alexey Semenyuk wrote:
> Add missing `exit(exitCode)` call.
> Add relevant unit test.
This pull request has now been integrated.
Changeset: b9cc3bc1
Author:Alexey Semenyuk
URL:
https://git.openjdk.java.net/jdk/
501 - 600 of 631 matches
Mail list logo
