8244293 : Remove outdated @apiNote in java.util.Objects

2020-05-03 Thread Anirvan Sarkar
Hi, The class level @apiNote in java.util.Objects refers to variation of static methods checkIndex(int, int), checkFromToIndex(int, int, int), and checkFromIndexSize(int, int, int), which support customization of the runtime exception, and corresponding exception detail message. But these static

Re: 8244293 : Remove outdated @apiNote in java.util.Objects

2020-05-05 Thread Anirvan Sarkar
> > Paul. > > > On May 3, 2020, at 9:03 AM, Anirvan Sarkar > wrote: > > > > Hi, > > > > The class level @apiNote in java.util.Objects refers to variation of > static > > methods checkIndex(int, int), checkFromToIndex(int, int, int), and >

Re: [PATCH] Trivial improvement for j.l.Character.toString() - 8241649: Optimize Character.toString

2020-04-05 Thread Anirvan Sarkar
JDK-8189375 should be closed as duplicate. On Thu, 26 Mar 2020 at 18:06, Claes Redestad wrote: > Filed and pushed: https://bugs.openjdk.java.net/browse/JDK-8241649 > > /Claes > > On 2020-03-26 00:12, Roger Riggs wrote: > > Agreed, +1 > > > > O

Re: 8214761: Bug in parallel Kahan summation implementation

2021-04-03 Thread Anirvan Sarkar
Hi Pavel, I think I have the same issue as Chris. The new OCA contributors list [1] is incorrectly linking the user names to GitHub as compared to the old contributors list [2]. It seems the new OCA contributors list is assuming that the GitHub username of past contributors is the same as the use

8276207: Properties.loadFromXML/storeToXML works incorrectly for supplementary characters

2021-10-31 Thread Anirvan Sarkar
Hi, Properties.loadFromXML/storeToXML works incorrectly for supplementary characters after JDK-8042889[1] was integrated in JDK 9. Properties.storeToXML now generates incorrect character references for supplementary characters. This is similar to JDK-8145974[2] which was fixed in the java.xml mod

Re: 8276207: Properties.loadFromXML/storeToXML works incorrectly for supplementary characters

2021-10-31 Thread Anirvan Sarkar
testLoadAndStore("UTF-16BE", false); @@ -252,10 +303,12 @@ testLoadAndStore("UTF-16BE", true); testLoadAndStore("UTF-16LE", true); testLoadWithoutEncoding(); testLoadWithBadEncoding(); testStoreWithBadEncoding(); +

Re: 8276207: Properties.loadFromXML/storeToXML works incorrectly for supplementary characters

2021-11-02 Thread Anirvan Sarkar
yCharacters" may be > a bit sensitive to file format. It may be solved with a roundtrip > (store/read) and comparing key/value of the entry, or test that the > output contains then entry element. > > Thanks, > Joe > > On 10/31/21 3:56 AM, Anirvan Sarkar wrote: > >

RFR: 8276207: Properties.loadFromXML/storeToXML works incorrectly for supplementary characters

2021-11-02 Thread Anirvan Sarkar
This fixes Properties.loadFromXML/storeToXML so that it works correctly for supplementary characters. - Commit messages: - 8276207: Properties.loadFromXML/storeToXML works incorrectly for supplementary characters Changes: https://git.openjdk.java.net/jdk/pull/6216/files Webrev: h

Integrated: 8276207: Properties.loadFromXML/storeToXML works incorrectly for supplementary characters

2021-11-05 Thread Anirvan Sarkar
On Tue, 2 Nov 2021 19:06:09 GMT, Anirvan Sarkar wrote: > This fixes Properties.loadFromXML/storeToXML so that it works correctly for > supplementary characters. This pull request has now been integrated. Changeset: c7095b20 Author:Anirvan Sarkar Committer: Joe Wang URL:

Re: [PING] PoC for JDK-4347142: Need method to set Password protection to Zip entries

2015-12-16 Thread Anirvan Sarkar
(Not an OpenJDK reviewer) Hi, I was wondering if the CRC32 implementation in TraditionalZipCryption could be replaced with java.util.zip.CRC32 class. Though I note that in this case TraditionalZipCryption#updateKeys(int c) will require CRC32#update(int crc, int b) method which is currently marke