Re: RFR 7183985: Class.getAnnotation() throws an ArrayStoreException when the annotation class not present

2016-01-29 Thread Liam Miller-Cushon
On Thu, Jan 28, 2016 at 11:50 AM, Joel Borggrén-Franck < joel.borggren.fra...@gmail.com> wrote: > Thanks for the update. I think it makes sense to expand testing > slightly, testing all three parsing clauses that you fixed, and for > all three of them also checking that a "thing" after the broken

[10] RFR: 8184940: JDK 9 rejects zip files where the modified day or month is 0

2017-07-26 Thread Liam Miller-Cushon
Hello, This change fixes a regression in JDK 9 by allowing the java.util and zipfs zip implementations to read archives where the modified day or month is 0. bug: https://bugs.openjdk.java.net/browse/JDK-8184940 webrev: http://cr.openjdk.java.net/~cushon/8184940/webrev.00/ Thanks, Liam

Integrated: 8268296: ScopedMemoryAccess build error with readonly filesystems

2021-06-07 Thread Liam Miller-Cushon
On Sun, 6 Jun 2021 20:09:32 GMT, Liam Miller-Cushon wrote: > This change fixes a build error during the generation of > `ScopedMemoryAccess.java` when the sources are readonly, by using `cat a > b` > instead of `cp a b` to avoid propagating the permissions to the generat

RFR: 8266857: PipedOutputStream.sink should be volatile

2021-05-10 Thread Liam Miller-Cushon
8266857: PipedOutputStream.sink should be volatile - Commit messages: - 8266857: PipedOutputStream.sink should be volatile Changes: https://git.openjdk.java.net/jdk/pull/3960/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=3960=00 Issue:

Integrated: 8266857: PipedOutputStream.sink should be volatile

2021-05-11 Thread Liam Miller-Cushon
On Mon, 10 May 2021 23:25:46 GMT, Liam Miller-Cushon wrote: > 8266857: PipedOutputStream.sink should be volatile This pull request has now been integrated. Changeset: d0daa725 Author: Liam Miller-Cushon URL: https://git.openjdk.java.net/jdk/com

Re: RFR: 8266857: PipedOutputStream.sink should be volatile

2021-05-11 Thread Liam Miller-Cushon
On Tue, 11 May 2021 10:19:52 GMT, Daniel Fuchs wrote: > For correctness (and peace of mind)- we should probably introduce a local > variable in all the places where `sink` is read more than once outside of a > synchronized block Done, thanks! - PR:

Re: RFR: 8266857: PipedOutputStream.sink should be volatile [v2]

2021-05-11 Thread Liam Miller-Cushon
> 8266857: PipedOutputStream.sink should be volatile Liam Miller-Cushon has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new com

RFR: 8268296: ScopedMemoryAccess build error with readonly filesystems

2021-06-06 Thread Liam Miller-Cushon
This change fixes a build error during the generation of `ScopedMemoryAccess.java` when the sources are readonly, by using `cat a > b` instead of `cp a b` to avoid propagating the permissions to the generated source. - Commit messages: - 8268296: ScopedMemoryAccess build error

Re: RFR: 8231436: Fix the applicability of a no-@Target annotation type [v2]

2021-02-05 Thread Liam Miller-Cushon
> Please review this fix to add `ElementType.MODULE` to the default list of > annotation targets, to allow annotations without an explicit `@Target` to be > used on module declarations. Liam Miller-Cushon has refreshed the contents of this pull request, and previous commits have bee

Re: RFR: 8231436: Fix the applicability of a no-@Target annotation type

2021-02-05 Thread Liam Miller-Cushon
On Thu, 4 Feb 2021 21:04:51 GMT, Liam Miller-Cushon wrote: >> Thanks, I was missing context here. I now realize this patch is fixing a bug >> related to >> [JDK-8254023](https://bugs.openjdk.java.net/browse/JDK-8254023)--when the >> handling of annotations witho

Withdrawn: 8231436: Fix the applicability of a no-@Target annotation type

2021-02-11 Thread Liam Miller-Cushon
On Thu, 28 Jan 2021 22:33:53 GMT, Liam Miller-Cushon wrote: > Please review this fix to add `ElementType.MODULE` to the default list of > annotation targets, to allow annotations without an explicit `@Target` to be > used on module declarations. This pull request has been closed with

RFR: JDK-8283280: Improve exception messages with -Dsun.misc.URLClassPath.disableJarChecking=false

2022-03-16 Thread Liam Miller-Cushon
This change improves an exception message to include a path, e.g. `Invalid Jar file: some.jar` instead of just `Invalid Jar file`. The exception is currently [always being caught and

RFR: 8283340: Remove support for -Dsun.misc.URLClassPath.disableJarChecking

2022-03-17 Thread Liam Miller-Cushon
This change removes support for `-Dsun.misc.URLClassPath.disableJarChecking`. As discussed in the bug the feature doesn't current work, and only ever supported scenarios where a security manager is installed, so it seems safe to remove. - Commit messages: - 8283340: Remove

Re: RFR: 8283340: Remove support for -Dsun.misc.URLClassPath.disableJarChecking

2022-03-30 Thread Liam Miller-Cushon
On Fri, 18 Mar 2022 18:59:16 GMT, Sean Mullan wrote: >> I don't know what the motivation for this change is but there is more to >> this story and I think will require agreement from the security area before >> removing it. > > I agree with @AlanBateman. Please don't proceed with this fix

Re: RFR: 8283340: Remove support for -Dsun.misc.URLClassPath.disableJarChecking

2022-03-18 Thread Liam Miller-Cushon
On Fri, 18 Mar 2022 04:01:05 GMT, Jiangli Zhou wrote: >> This change removes support for >> `-Dsun.misc.URLClassPath.disableJarChecking`. As discussed in the bug the >> feature doesn't current work, and only ever supported scenarios where a >> security manager is installed, so it seems safe

Re: RFR: 8283340: Remove support for -Dsun.misc.URLClassPath.disableJarChecking

2022-03-18 Thread Liam Miller-Cushon
On Thu, 17 Mar 2022 23:44:32 GMT, Liam Miller-Cushon wrote: > This change removes support for `-Dsun.misc.URLClassPath.disableJarChecking`. > As discussed in the bug the feature doesn't current work, and only ever > supported scenarios where a security manager is installed, so it s

Re: RFR: 8283340: Remove support for -Dsun.misc.URLClassPath.disableJarChecking

2022-03-18 Thread Liam Miller-Cushon
On Fri, 18 Mar 2022 08:39:46 GMT, Alan Bateman wrote: > I don't know what the motivation for this change is but there is more to this > story and I think will require agreement from the security area before > removing it. Thanks @AlanBateman. The motivation is that I was investigating an