> Hi all,
>
> Could you please review the 8268457 bug fixes?
>
> The problem is that ToHTMLStream applies processing for non-surrogate pairs
> to the surrogate pair.
> This fix changes the processing for non-surrogate pairs to the else condition.
Masanori Yano has upd
On Fri, 18 Jun 2021 20:28:06 GMT, Naoto Sato wrote:
>> Masanori Yano has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflect the review comments
>
> test/jaxp/javax/xml/jaxp/unittest/transform/SurrogateTe
> Hi all,
>
> Could you please review the 8268457 bug fixes?
>
> The problem is that ToHTMLStream applies processing for non-surrogate pairs
> to the surrogate pair.
> This fix changes the processing for non-surrogate pairs to the else condition.
Masanori Yano has upd
On Fri, 18 Jun 2021 21:09:39 GMT, Joe Wang wrote:
>> src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/ToHTMLStream.java
>> line 1454:
>>
>>> 1452: writer.write(ch); // no escaping in this case
>>> 1453: }
>>> 1454:
Hi all,
Could you please review the 8269373 bug fixes?
These tests call java.lang.ProcessBuilder in direct, so not used jtreg command
option. To run non-localized tests, -Duser.language=en and -Duser.country=US
options should be added in ProcessBuilder.
-
Commit messages:
-
On Fri, 11 Jun 2021 12:42:35 GMT, Masanori Yano wrote:
> Hi all,
>
> Could you please review the 8268457 bug fixes?
>
> The problem is that ToHTMLStream applies processing for non-surrogate pairs
> to the surrogate pair.
> This fix changes the processing for non-surrog
Hi all,
Could you please review the 8268457 bug fixes?
The problem is that ToHTMLStream applies processing for non-surrogate pairs to
the surrogate pair.
This fix changes the processing for non-surrogate pairs to the else condition.
-
Commit messages:
- clean up whitespace
-
On Fri, 11 Jun 2021 12:42:35 GMT, Masanori Yano wrote:
> Hi all,
>
> Could you please review the 8268457 bug fixes?
>
> The problem is that ToHTMLStream applies processing for non-surrogate pairs
> to the surrogate pair.
> This fix changes the processing for non-surrog
On Wed, 4 Aug 2021 07:25:06 GMT, Masanori Yano wrote:
>> Hi all,
>>
>> Could you please review the 8269373 bug fixes?
>>
>> These tests call java.lang.ProcessBuilder in direct, so not used jtreg
>> command option. To run non-localized tests, -Duser.l
On Wed, 4 Aug 2021 07:25:06 GMT, Masanori Yano wrote:
>> Hi all,
>>
>> Could you please review the 8269373 bug fixes?
>>
>> These tests call java.lang.ProcessBuilder in direct, so not used jtreg
>> command option. To run non-localized tests, -Duser.l
Could you please review the 8233674 bug fixes?
This problem is caused by the antivirus software opening the file for a short
time, so CreateFile() should be retried.
-
Commit messages:
- 8233674: JarURLConnection.getJarFile throws Exception if some process is
holding the file
On Fri, 10 Sep 2021 09:23:52 GMT, Masanori Yano wrote:
> Could you please review the 8233674 bug fixes?
> This problem is caused by the antivirus software opening the file for a short
> time, so CreateFile() should be retried.
Thank you for your comment. According to Microsoft
On Fri, 25 Jun 2021 12:10:18 GMT, Masanori Yano wrote:
> Hi all,
>
> Could you please review the 8269373 bug fixes?
>
> These tests call java.lang.ProcessBuilder in direct, so not used jtreg
> command option. To run non-localized tests, -Duser.language=en and
> -Dus
> Hi all,
>
> Could you please review the 8269373 bug fixes?
>
> These tests call java.lang.ProcessBuilder in direct, so not used jtreg
> command option. To run non-localized tests, -Duser.language=en and
> -Duser.country=US options should be added in ProcessBuilder.
Masa
> Hi all,
>
> Could you please review the 8269373 bug fixes?
>
> These tests call java.lang.ProcessBuilder in direct, so not used jtreg
> command option. To run non-localized tests, -Duser.language=en and
> -Duser.country=US options should be added in ProcessBuilder.
Masa
> Hi all,
>
> Could you please review the 8269373 bug fixes?
>
> These tests call java.lang.ProcessBuilder in direct, so not used jtreg
> command option. To run non-localized tests, -Duser.language=en and
> -Duser.country=US options should be added in ProcessBuilder.
Masa
On Tue, 7 Sep 2021 11:12:56 GMT, Masanori Yano wrote:
>> Hi all,
>>
>> Could you please review the 8269373 bug fixes?
>>
>> These tests call java.lang.ProcessBuilder in direct, so not used jtreg
>> command option. To run non-localized tests, -Duser.l
> Hi all,
>
> Could you please review the 8269373 bug fixes?
>
> These tests call java.lang.ProcessBuilder in direct, so not used jtreg
> command option. To run non-localized tests, -Duser.language=en and
> -Duser.country=US options should be added in ProcessBuilder.
Masa
On Wed, 4 Aug 2021 07:25:06 GMT, Masanori Yano wrote:
>> Hi all,
>>
>> Could you please review the 8269373 bug fixes?
>>
>> These tests call java.lang.ProcessBuilder in direct, so not used jtreg
>> command option. To run non-localized tests, -Duser.l
On Wed, 6 Oct 2021 18:40:36 GMT, Mark Reinhold wrote:
>> @mbreinhold Could you comment on this pull request?
>
>> @mbreinhold Could you comment on this pull request?
>
> This is somewhat tricky code. I’ll take a look, but give me a few days.
@mbreinhold I waited for about a week, but I haven't
On Mon, 27 Sep 2021 08:22:02 GMT, Alan Bateman wrote:
>> Could you please review the 8250678 bug fixes?
>>
>> The `parse` method of ModuleDescriptor.Version class behaves incorrectly
>> when the input string contains consecutive delimiters.
>>
>> The `parse` method treats strings as three
On Mon, 27 Sep 2021 08:04:23 GMT, Alan Bateman wrote:
>> It’s a good idea to ask the Microsoft folks about that, but I don't know the
>> way to ask. Could you tell me how to do it?
>>
>> As you say, CreateFile function is used in other parts of the JDK, but it
>> have a significant impact to
On Wed, 6 Oct 2021 18:40:36 GMT, Mark Reinhold wrote:
>> @mbreinhold Could you comment on this pull request?
>
>> @mbreinhold Could you comment on this pull request?
>
> This is somewhat tricky code. I’ll take a look, but give me a few days.
@mbreinhold (@AlanBateman ) Could you tell me how
On Fri, 24 Sep 2021 11:28:09 GMT, Masanori Yano wrote:
> Could you please review the 8250678 bug fixes?
>
> The `parse` method of ModuleDescriptor.Version class behaves incorrectly when
> the input string contains consecutive delimiters.
>
> The `parse` method treats strings
On Mon, 27 Sep 2021 08:22:02 GMT, Alan Bateman wrote:
>> Could you please review the 8250678 bug fixes?
>>
>> The `parse` method of ModuleDescriptor.Version class behaves incorrectly
>> when the input string contains consecutive delimiters.
>>
>> The `parse` method treats strings as three
On Fri, 10 Sep 2021 09:23:52 GMT, Masanori Yano wrote:
> Could you please review the 8233674 bug fixes?
> This problem is caused by the antivirus software opening the file for a short
> time, so CreateFile() should be retried.
I inquired of the Microsoft Technical Support about thi
On Fri, 10 Sep 2021 09:23:52 GMT, Masanori Yano wrote:
> Could you please review the 8233674 bug fixes?
> This problem is caused by the antivirus software opening the file for a short
> time, so CreateFile() should be retried.
It’s a good idea to ask the Microsoft folks about that, bu
Could you please review the 8250678 bug fixes?
The `parse` method of ModuleDescriptor.Version class behaves incorrectly when
the input string contains consecutive delimiters.
The `parse` method treats strings as three sections, but the parsing method
differs between the method for the version
Could you please review the 8276694 bug fixes?
A message specific for this exception should be printed instead of an internal
error. This fix adds a new check to output an appropriate exception message
when the regular expression ends with an unescaped backslash. This fix also
checks the
On Thu, 23 Dec 2021 16:42:50 GMT, Alan Bateman wrote:
>> Masanori Yano has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8272746: ZipFile can't open big file (NegativeArraySizeException)
>
> src/java.ba
ly, but the way will require an extensive fix and degrade
> performance.
> In practical terms, the size of the central directory rarely grows that
> large. So, I fixed it to check the size of the central directory and throw an
> exception if it is too large.
Masanori Yano has updated the
On Thu, 23 Dec 2021 16:42:50 GMT, Alan Bateman wrote:
>> Masanori Yano has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8272746: ZipFile can't open big file (NegativeArraySizeException)
>
> src/java.ba
On Mon, 20 Dec 2021 09:57:14 GMT, Masanori Yano wrote:
> Could you please review the 8276694 bug fixes?
>
> A message specific for this exception should be printed instead of an
> internal error. This fix adds a new check to output an appropriate exception
> message w
Could you please review the JDK-8272746 bug fixes?
Since the array index is of type int, the overflow occurs when the value of
end.cenlen is too large because of too many entries.
It is necessary to read a part of the CEN from the file to fix the problem
fundamentally, but the way will require
On Fri, 29 Oct 2021 10:37:07 GMT, Masanori Yano wrote:
> Could you please review the 8276164 bug fixes?
>
> I suggest adding the missing javadoc of `@throws IndexOutOfBoundsException`.
This pull request has now been integrated.
Changeset: 9bf31652
Author: Masanori Yano
Commit
On Fri, 10 Sep 2021 09:23:52 GMT, Masanori Yano wrote:
> Could you please review the 8233674 bug fixes?
> This problem is caused by the antivirus software opening the file for a short
> time, so CreateFile() should be retried.
This pull request has been closed without being i
On Fri, 10 Sep 2021 09:23:52 GMT, Masanori Yano wrote:
> Could you please review the 8233674 bug fixes?
> This problem is caused by the antivirus software opening the file for a short
> time, so CreateFile() should be retried.
Thank you for your reply.
I understand we have no ne
Could you please review the 8262297 bug fixes?
In this case, ImageIO.write() should throw java.io.IOException rather than
java.lang.IndexOutOfBoundsException. IndexOutOfBoundsException is caught and
wrapped in IIOException in ImageIO.write() with this fix. In addition,
> Could you please review the 8276164 bug fixes?
>
> I suggest adding the missing javadoc of `@throws IndexOutOfBoundsException`.
Masanori Yano has updated the pull request incrementally with two additional
commits since the last revision:
- 8276164: RandomAccessFile#write method co
Could you please review the 8276164 bug fixes?
I suggest adding the missing javadoc of `@throws IndexOutOfBoundsException`.
-
Commit messages:
- 8276164: RandomAccessFile#write method could throw IndexOutOfBoundsException
that is not described in javadoc
Changes:
On Wed, 6 Oct 2021 18:40:36 GMT, Mark Reinhold wrote:
>> @mbreinhold Could you comment on this pull request?
>
>> @mbreinhold Could you comment on this pull request?
>
> This is somewhat tricky code. I’ll take a look, but give me a few days.
@mbreinhold @AlanBateman Could you please reply to
On Fri, 24 Sep 2021 11:28:09 GMT, Masanori Yano wrote:
> Could you please review the 8250678 bug fixes?
>
> The `parse` method of ModuleDescriptor.Version class behaves incorrectly when
> the input string contains consecutive delimiters.
>
> The `parse` method treats strings
On Fri, 24 Sep 2021 11:28:09 GMT, Masanori Yano wrote:
> Could you please review the 8250678 bug fixes?
>
> The `parse` method of ModuleDescriptor.Version class behaves incorrectly when
> the input string contains consecutive delimiters.
>
> The `parse` method treats strings
On Wed, 6 Oct 2021 18:40:36 GMT, Mark Reinhold wrote:
>> @mbreinhold Could you comment on this pull request?
>
>> @mbreinhold Could you comment on this pull request?
>
> This is somewhat tricky code. I’ll take a look, but give me a few days.
@mbreinhold @AlanBateman Are you aware of my
On Fri, 29 Oct 2021 07:13:32 GMT, Alan Bateman wrote:
>> Unfortunately the parent class does not specify this exception via javadoc
>> tags like "@throws IndexOutOfBoundsException", but instead just describe it
>> in the method description
>>
>> should we fix it separately from the imageio
ix. In addition,
> IndexOutOfBoundsException is not expected to throw by
> RandomAccessFile#write() according to its API specification. So it should be
> fixed.
Masanori Yano has updated the pull request incrementally with one additional
commit since the last revision:
8262297: ImageIO.w
I have fixed the javadoc comments as the definition. Could you review this fix?
-
Commit messages:
- 8278892: java.naming module description is missing @uses tags to document
the services that it uses
Changes: https://git.openjdk.java.net/jdk/pull/7041/files
Webrev:
ly, but the way will require an extensive fix and degrade
> performance.
> In practical terms, the size of the central directory rarely grows that
> large. So, I fixed it to check the size of the central directory and throw an
> exception if it is too large.
Masanori Yano has updated the
On Sat, 8 Jan 2022 16:09:59 GMT, Lance Andersen wrote:
>> Masanori Yano has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8272746: ZipFile can't open big file (NegativeArraySizeException)
>
> Thank you for y
On Wed, 12 Jan 2022 05:48:26 GMT, Masanori Yano wrote:
> I have fixed the javadoc comments as the definition. Could you review this
> fix?
Could someone please review this pull request?
-
PR: https://git.openjdk.java.net/jdk/pull/7041
ly, but the way will require an extensive fix and degrade
> performance.
> In practical terms, the size of the central directory rarely grows that
> large. So, I fixed it to check the size of the central directory and throw an
> exception if it is too large.
Masanori Yano has updated the
On Fri, 14 Jan 2022 23:55:58 GMT, Lance Andersen wrote:
>> Masanori Yano has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8272746: ZipFile can't open big file (NegativeArraySizeException)
>
> Thank you fo
On Mon, 20 Dec 2021 09:57:14 GMT, Masanori Yano wrote:
> Could you please review the 8276694 bug fixes?
>
> A message specific for this exception should be printed instead of an
> internal error. This fix adds a new check to output an appropriate exception
> message w
On Tue, 25 Jan 2022 10:47:41 GMT, Masanori Yano wrote:
> I have removed the duplicate property keys.
> Could you please review the fix?
This pull request has now been integrated.
Changeset: e3d5c9e7
Author:Masanori Yano
Committer: Lance Andersen
URL:
https://git.openjdk.ja
On Tue, 25 Jan 2022 11:25:55 GMT, Lance Andersen wrote:
>> I have removed the duplicate property keys.
>> Could you please review the fix?
>
> Marked as reviewed by lancea (Reviewer).
@LanceAndersen Could you please commit this fix as a sponsor?
-
PR:
On Wed, 12 Jan 2022 05:48:26 GMT, Masanori Yano wrote:
> I have fixed the javadoc comments as the definition. Could you review this
> fix?
This pull request has now been integrated.
Changeset: 94522626
Author:Masanori Yano
Committer: Aleksei Efimov
URL:
ly, but the way will require an extensive fix and degrade
> performance.
> In practical terms, the size of the central directory rarely grows that
> large. So, I fixed it to check the size of the central directory and throw an
> exception if it is too large.
Masanori Yano has updated the
On Mon, 17 Jan 2022 18:10:02 GMT, Lance Andersen wrote:
>> Masanori Yano has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8272746: ZipFile can't open big file (NegativeArraySizeException)
>
>
On Thu, 23 Dec 2021 10:55:08 GMT, Masanori Yano wrote:
> Could you please review the JDK-8272746 bug fixes?
> Since the array index is of type int, the overflow occurs when the value of
> end.cenlen is too large because of too many entries.
> It is necessary to read a part of
I have removed the duplicate property keys.
Could you please review the fix?
-
Commit messages:
- 8266974: duplicate property key in java.sql.rowset resource bundle
Changes: https://git.openjdk.java.net/jdk/pull/7212/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=7212=00
60 matches
Mail list logo
