JDK-8231863 bug fix candidate

2019-11-01 Thread Mat Carter
Hello core-libs-dev I'm a VM engineer at Microsoft, now that we've signed the OCA (news of which was shared by Bruno Borges in the discuss mailing list) I wanted to pick up an issue in order to gain familiarity with the change process After reproducing the error reported in "JDK-8231863: Crash

Re: JDK-8231863 bug fix candidate

2019-11-04 Thread Mat Carter
Cheers Mat From: Henry Jen Sent: Monday, November 4, 2019 9:21 AM To: Mat Carter Cc: core-libs-dev@openjdk.java.net Subject: Re: JDK-8231863 bug fix candidate The fix is on the spot, good catch. As the test, test/jdk/tools/launcher/ArgsFileTest.java is testing the file expansions, we

Re: JDK-8231863 bug fix candidate

2019-11-04 Thread Mat Carter
Thanks Henry I'm working on a test, do you want me to share directly with you (incl. questions) or continue with comms through the mailing list Cheers Mat From: Henry Jen Sent: Monday, November 4, 2019 12:47 PM To: Mat Carter Cc: core-lib

Re: RFR: 8231863: Crash if classpath is read from @argument file and the main gets option argument

2019-11-08 Thread Mat Carter
22:55, Henry Jen wrote: > Hi, > > Please review the webrev[1], contributed by Mat Carter. You can find the bug > details at JBS[2]. I have reviewed and tested the fix, I still need an > official review before I can push this. > Looks okay although in the test, the createAFile h

Re: RFR: 8231863: Crash if classpath is read from @argument file and the main gets option argument

2019-11-11 Thread Mat Carter
2019 10:24 AM To: Henry Jen ; Mandy Chung Cc: Mat Carter ; core-libs-dev@openjdk.java.net Subject: Re: RFR: 8231863: Crash if classpath is read from @argument file and the main gets option argument On 11/11/2019 16:53, Henry Jen wrote: > Thanks Alan and Mandy for the review. > >