Thanks for the pointer. I had remembered reading this changeset and it has
motivated to use Arrays.fill but I could not have found it.
Mike
On Apr 2 2013, at 02:12 , Patrick Wright wrote:
On Tue, Apr 2, 2013 at 9:27 AM, Laurent Bourgès
bourges.laur...@gmail.comwrote:
---
604
On Apr 2 2013, at 10:33 , Joe Darcy wrote:
On 04/02/2013 06:34 AM, Paul Sandoz wrote:
On Apr 2, 2013, at 2:37 PM, Chris Hegarty chris.hega...@oracle.com wrote:
Nice work Paul, some small comments.
- new javadocs tags, @implSpec, @apiNote, etc. I really like the use of
implSpec to define
Changeset: 7320922b694e
Author:mduigou
Date: 2013-04-02 14:56 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/rev/7320922b694e
8011342: hgforest.sh : 'python --version' not supported on older python
Reviewed-by: wetmore
! common/bin/hgforest.sh
On Apr 2 2013, at 04:07 , Alan Bateman wrote:
On 02/04/2013 05:44, Mike Duigou wrote:
Hello all;
Last night while pushing another changeset I accidentally pushed a changeset
for JKD-7143928. Since the review and testing was not complete on this issue
I have backed out that changeset
On Apr 1 2013, at 21:44 , Mike Duigou wrote:
Hello all;
Last night while pushing another changeset I accidentally pushed a changeset
for JKD-7143928. Since the review and testing was not complete on this issue
I have backed out that changeset and created a new bug number to continue
Changeset: fc1e08c2bb27
Author:mduigou
Date: 2013-04-01 11:48 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/rev/fc1e08c2bb27
8010267: Add test-clean for cleaning of testoutput directory from output
directory. Add depedency on test-clean to clean
Reviewed-by: mchung, tbell
!
Hello all;
Another changeset for review in the series JDK-8009683 Running regression
tests with make. Many of the targets in jdk/test/Makefile are currently unused
or were never used. These targets will be removed:
perftest
packtest
vmsqe_*
jck*
I have checked with Kelky O'Hair and Kumar
initial
capacity.
Mike
On Mar 26 2013, at 17:25 , Mike Duigou wrote:
Hello all;
This is a review for optimization work that came out of internal analysis of
Oracle's Java applications. It's based upon analysis that shows that in large
applications as much as 10% of maps and lists
...@oracle.com, Mike Duigou mike.dui...@oracle.com
! src/share/classes/java/util/ArrayList.java
! src/share/classes/java/util/HashMap.java
+ test/java/util/Map/BasicSerialization.java
Changeset: 5ee837ba093a
Author:mduigou
Date: 2013-04-01 20:15 -0700
URL: http://hg.openjdk.java.net/jdk8
Hello all;
Unfortunately while pushing another changeset I accidentally pushed JDK-7143928
as well. Since the review is not complete (and sufficient testing has not been
completed) this change needs to be backed out.
I have created an hg backout -r 0cccdb9a9a4c changeset of
The changeset is now available as a webrev at:
http://cr.openjdk.java.net/~mduigou/JDK-8011199/0/webrev/
Thanks,
Mike
On Apr 1 2013, at 21:02 , David Holmes wrote:
Hi Mike,
I need to see the actual proposed changeset to Review it.
Thanks,
David
On 2/04/2013 1:43 PM, Mike Duigou
Changeset: 760074bec012
Author:mduigou
Date: 2013-04-01 21:11 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/rev/760074bec012
8011178: improve common/bin/hgforest.sh python detection (MacOS)
Reviewed-by: ohair
! common/bin/hgforest.sh
is:
http://cr.openjdk.java.net/~mduigou/JDK-8011200/0/webrev/
It is currently unchanged from the last posted changeset for 7143928.
Mike
On Apr 1 2013, at 19:00 , Mike Duigou wrote:
Hello all;
I have posted an updated version of the empty ArrayList and HashMap patch.
http
, there should be empirical
evidence that this is a net improvement.
I will try to find how much of the analysis I can share.
My guess is that it can be done (we did something similar for
ConcurrentHashMap) but it takes a lot of care.
-Doug
On Wed, Mar 27, 2013 at 8:02 AM, Mike Duigou
Technically the changes look fine but I am a little concerned by the position
of default in the order placement. The emerging practice is to put default
first immediately following the access modifier. Counter to this is the correct
preference for using the blessed modifier order. Can we move
)
sb.append(Modifier.toString(mod)).append(' ');
}
}
Updated webrev including a public default strictfp test case at:
http://cr.openjdk.java.net/~darcy/8004979.1/
Thanks,
-Joe
On 03/28/2013 03:58 PM, Mike Duigou wrote:
Technically the changes look fine but I am a little
apply this trick only for the default-sized lists, and
eliminate the extra field.
On Mar 26, 2013, at 5:25 PM, Mike Duigou wrote:
Hello all;
This is a review for optimization work that came out of internal analysis of
Oracle's Java applications. It's based upon analysis that shows
I still need a review for both of these changes.
Mike
On Mar 18 2013, at 22:48 , Mike Duigou wrote:
A two small changes to review:
If approved I will commit to TL (or someone else can commit to build for me)
Mike
JDK-8010267 : Add test-clean for cleaning of testoutput directory from
Buchholz wrote:
But you can support any requested initial size if stored in the size field
when list is empty.
On Wed, Mar 27, 2013 at 8:02 AM, Mike Duigou mike.dui...@oracle.com wrote:
This seems like a good idea. I will follow up with the performance people to
see if their findings include
This looks fine to me. Nice little optimization (which is no doubt repeated
thousands of times for significant wins).
Mike
On Mar 26 2013, at 15:43 , Joe Darcy wrote:
Hello,
Please review this refactoring of how annotations objects are created:
JDK-7185456 : (ann) Optimize Annotation
Hello all;
This is a review for optimization work that came out of internal analysis of
Oracle's Java applications. It's based upon analysis that shows that in large
applications as much as 10% of maps and lists are initialized but never receive
any entries. A smaller number spend a large
On Mar 25 2013, at 14:28 , Lance Andersen wrote:
So I changed the values above just now from 1.5 and 1.6 to both be 1.7
Which worked much better.
This works in a jdk7 repository.
It looks like shared.xml was changed for jdk8 so it does not have the values
above.
I made this
This looks fine. Get it in before something else changes!
Mike
On Mar 21 2013, at 15:12 , Brad Wetmore wrote:
David,
Plugin's integration next week is now also impacted since they also have to
use the old build environment, so it's time to resolve this. So here's an
the cracks, as I haven't
seen the commit go through the public JDK8 repo… or maybe I missed it.
Thanks again for looking at this :-)
Mike
On Feb 12 2013, at 18:25 , Ulf Zibis wrote:
Am 13.02.2013 02:34, schrieb Mike Duigou:
Thank you for the comments Ulf.
On Feb 12 2013, at 17:24 , Ulf
On Mar 19, 2013, at 9:43 PM, Rob Leland the.rob.lel...@gmail.com wrote:
Has the optional classes been verified to serialize/deserialize correctly? I
noticed it tries to use the null object pattern with the use of EMPTY private
instance. When I have implemented the NULL pattern I have used
Some notes:
- Copyrights update.
- The order of notes on files is the order that I read the files. It seems like
not a bad order to review them.
- package docs? Coming next?
java.util.Map::
- @since 1.8 missing for defaults
- tt/tt should be replace with {@code}
- default methods need the
Looks fine to me. Do we have an issue open for restoring warnings to the new
build?
Mike
On Mar 8 2013, at 05:24 , Chris Hegarty wrote:
Since the new build does not enable -Werror when compiling any java code, and
disables quite a few lint options, new changes my inadvertently introduce
On Mar 5 2013, at 07:12 , Alan Bateman wrote:
Just a couple of small things.
Will the docs build complain about the unknown taglets? (@apiNote, @implNote
...)
It currently issues a warning. I have a Javadoc.gmk patch which I am pursuing
separately to enable recognition of these tags.
Changeset: e38b46041049
Author:mduigou
Date: 2013-03-08 15:45 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e38b46041049
8001667: Comparator combinators and extension methods
Reviewed-by: mduigou, briangoetz
Contributed-by: henry@oracle.com
!
Changeset: b35d986ff276
Author:mduigou
Date: 2013-03-06 08:37 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/rev/b35d986ff276
8009162: root repo make test target should run against image
Reviewed-by: alanb, martin, erikj
! common/makefiles/Main.gmk
On Mar 6 2013, at 09:19 , Alan Bateman wrote:
On 05/03/2013 22:46, Mike Duigou wrote:
I have updated the webrev to remove the useAltHashing boolean.
http://cr.openjdk.java.net/~mduigou/JDK-8006593/5/webrev/
Mike
Peter's suggestion to remove the useAltHashing field is a great idea
On Mar 6 2013, at 08:21 , Bob Vandette wrote:
For a traditional
JRE that doesn't even require static library support, we'd have to make sure
to run on a VM that
support JNI_VERSION_1_8. It looks like the JDK maintains their own copy of
jni.h.
In earlier days the jni.h file was copied
Hi Bill;
Some notes from reviewing the JDK side changes.
System.java/Runtime.java:
The example which begins with the name If the filename argument, needs to
better identify that L is an example. (Italics?)
java/lang/ClassLoader.java:
NativeLibrary::fromClass could be final.
, Salter, Thomas A wrote:
Will this change do anything to fix:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8002283?
Date: Mon, 4 Mar 2013 12:21:08 -0800
From: Mike Duigou mike.dui...@oracle.com
Subject: RFR: 8006593: Performance and compatibility improvements
sun.misc.Hashing.stringHash32((String) k);
-}
-h = hashSeed;
}
h ^= k.hashCode();
Regards, Peter
On 03/05/2013 07:08 AM, Mike Duigou wrote:
After looking more closely at the single read reference to hashSeed I
decided to simplify things and make
Hello All;
This patch introduces Optional container objects to be used by the lambda
streams libraries for returning results.
The reference Optional type, as defined, intentionally does not allow null
values. null may be used with the Optional.orElse() method.
All of the Optional types define
Ouch. That is unfortunate that File cannot reject bad input.
Perhaps FileInputStream etc. should throw a specialized Bad Filename FnF for
paths containing NUL if the underlying filesystem does not support NUL?
Masking garbage input always really scares me.
Mike
On Feb 27 2013, at 02:40 , Alan
Changeset: f4b01f4e8f35
Author:mduigou
Date: 2013-02-27 11:00 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f4b01f4e8f35
8008785: IdentityHashMap.values().toArray(V[]) broken by JDK-8008167
Reviewed-by: alanb
! src/share/classes/java/util/IdentityHashMap.java
+
The look fine to me. The same fixes ToDoubleBiFunction.java and
BinaryOperator.java have been applied in the lambda repository.
Mike
On Feb 26 2013, at 15:38 , Joe Darcy wrote:
Hello,
Please review the patch before the fix some docs build warnings. I'll file a
bug once the review is
Hi Dan;
External link to the bug (will hopefully work soon):
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8003992
I would like to better understand why silently removing the garbage null
characters is the right answer here.
If null is an invalid character for the underlying operating
On Feb 25 2013, at 01:51 , Alan Bateman wrote:
On 25/02/2013 04:06, Mike Duigou wrote:
I have created an issue for fixing the introduced regression and created a
regression test that would have caught the error (fix a bug, write a
test...).
8008785: IdentityHashMap.values().toArray(V
On Feb 25 2013, at 01:51 , Alan Bateman wrote:
On 25/02/2013 04:06, Mike Duigou wrote:
I have created an issue for fixing the introduced regression and created a
regression test that would have caught the error (fix a bug, write a
test...).
8008785: IdentityHashMap.values().toArray(V
On Feb 25 2013, at 10:13 , Alan Bateman wrote:
On 25/02/2013 15:55, Mike Duigou wrote:
:
The webrev suggests you've replaced Map/Collisions.java and assume that is
not the intention. Otherwise the new test looks okay, an alternative would
have been to expand MOAT.
Webrev doesn't
] = Long.valueOf(each + TEST_SIZE);
}
}
On Feb 25 2013, at 01:51 , Alan Bateman wrote:
On 25/02/2013 04:06, Mike Duigou wrote:
I have created an issue for fixing the introduced regression and created a
regression test that would have caught the error (fix a bug, write a
test
Ouch, this would have been introduced by me.
I will check to see how this could have passed the pre-commit regression
testing. I suspect that a regression test needs to be improved.
Mike
On Feb 24 2013, at 10:48 , Alan Bateman wrote:
On 24/02/2013 15:49, Peter Levart wrote:
Hi Alan,
I
24 2013, at 12:27 , Peter Levart wrote:
Hi Mike,
I thought I saw that too when you commited the change, but then re-examinig
the whole source in detail, I couldn't spot it again. I must have stared at
the wrong third of change...
Regards, Peter
On 02/24/2013 07:53 PM, Mike Duigou wrote
looks good to me. Nice to see the JLS additions and good catch on the missing
@since.
On Feb 21 2013, at 17:46 , Joe Darcy wrote:
Hello,
Please review the simple fix below for
6556996: (ann spec) SuppressWarnings strings should be documented
Changeset: c641268c4532
Author:mduigou
Date: 2013-02-20 17:56 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/rev/c641268c4532
8008629: webrev.ksh needs to quote bug title it gets back from scraping
bugs.sun.com
Reviewed-by: darcy
! make/scripts/webrev.ksh
On Feb 19 2013, at 10:50 , Alan Bateman wrote:
On 19/02/2013 05:27, Mike Duigou wrote:
:
http://cr.openjdk.java.net/~mduigou/JDK-7197183/0/
From our current testing we found that applications currently using
subSequence() failed if the equals(), hashCode() and toString
Changeset: 16efb7ba188f
Author:mduigou
Date: 2013-02-19 11:56 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/16efb7ba188f
8004561: Additional functional interfaces, extension methods and name changes
Summary: Adds additional functional interfaces for primitives and Bi (two
Thank you for the feedback David.
On Feb 18 2013, at 21:29 , David Holmes wrote:
package-info.java
I've flagged this elsewhere but you may not have seen it:
+ * Predicatelt;String
If we use lt; then we should also use gt;.
It's not required to use gt; in HTML 4.01 transitional or
On Feb 19 2013, at 19:37 , David Holmes wrote:
On 20/02/2013 6:22 AM, Mike Duigou wrote:
Thank you for the feedback David.
So what got updated, if anything, before the push?
Everything. With the exception of the gt; which I mentioned in my response I
accepted all of your feedback
Hello all;
JDK 7u6 included a significant change to java.lang.String. The change was
internal to the String implementation and didn't result in any API changes but
it does have a significant impact on the performance of some uses cases. (See
Both look fine to me. No need for a webrev.
Mike
On Feb 18 2013, at 22:58 , Joe Darcy wrote:
Hello,
Please review these two simple fixes for javadoc warnings I noticed during a
build (I'll file a bug after getting a review):
diff -r bcde0486261e
Hello All;
This patch introduces a number of new functional interfaces for use by the
lambda libraries. Also included are some name changes following JSR-225 EG
review. The new interfaces are:
BiConsumer
BiFunction
BiPredicate
BooleanSupplier
DoublePredicate
IntPredicate
LongPredicate
On Feb 14 2013, at 05:24 , Peter Levart wrote:
Hello Mike,
On 02/13/2013 09:21 PM, Mike Duigou wrote:
This looks like excellent contribution Peter!
I will proceed with the testing needed to integrate your improved
toArray()/toArray(T[]) implementations. I have created an issue,
JDK
Changeset: e57019d2f34a
Author:mduigou
Date: 2013-02-13 14:50 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e57019d2f34a
8008167: IdentityHashMap.[keySet|values|entrySet].toArray speed-up
Reviewed-by: mduigou, martin
Contributed-by: Peter Levart peter.lev...@gmail.com
!
This looks like excellent contribution Peter!
I will proceed with the testing needed to integrate your improved
toArray()/toArray(T[]) implementations. I have created an issue, JDK-8008167,
for this patch.
I am surprised that this didn't get more attention back in December as it does
seem to
I have updated the patch with some of Ulf's feedback and corrected one
cut-and-paste error that I made.
The updated webrev is at:
http://cr.openjdk.java.net/~mduigou/JDK-8006627/2/webrev/
Mike
On Feb 12 2013, at 18:25 , Ulf Zibis wrote:
Am 13.02.2013 02:34, schrieb Mike Duigou:
Thank you
regression suite across the changes.
Mike
On Feb 11 2013, at 21:18 , Steven Schlansker wrote:
On Feb 11, 2013, at 9:04 PM, Mike Duigou mike.dui...@oracle.com wrote:
I have been following up on this issue. I am going to have to adapt the code
a bit because there have been some changes in JDK8
Thank you for the comments Ulf.
On Feb 12 2013, at 17:24 , Ulf Zibis wrote:
Am 13.02.2013 00:30, schrieb Mike Duigou:
Hi Steven;
I have updated the patch for Java 8. There's somewhat less code sharing and
a bit of refactoring than your last version but the performance should be
about
Changeset: 465cce29a9ed
Author:mduigou
Date: 2013-02-06 11:28 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/465cce29a9ed
8006594: Add jdk_core target to jdk/test/Makefile
Reviewed-by: alanb
! make/jprt.properties
! test/Makefile
! test/ProblemList.txt
Changeset: 7817368287cd
Author:mduigou
Date: 2013-02-06 11:12 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/rev/7817368287cd
8006595: Use jdk/test/Makefile targets in preference to local definitions
Reviewed-by: alanb
! common/makefiles/Main.gmk
! test/Makefile
, 2013, at 11:42 AM, Mike Duigou mike.dui...@oracle.com wrote:
I have created another issue 8007398 for the changes to Long. We can even
test and push the two issues at the same time. Separating them into two
changesets makes the intent easier to follow for future maintainers.
We can use
Thank you Doug, Martin, Peter and Alan for efforts your in tracking this down.
Even though it's not implicated, I am going to hold off on the OpenJDK7u-dev
push of 7175464 for a few days to allow for some additional testing.
Mike
On Feb 10 2013, at 19:52 , Martin Buchholz wrote:
Alright, now
Changeset: 168dd033604a
Author:mduigou
Date: 2013-02-06 11:09 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/rev/168dd033604a
8004726: Link bug ids to jbs rather than monaco.
Reviewed-by: ohair, chegar, katleman
! make/scripts/webrev.ksh
On Feb 4 2013, at 08:33 , Alan Bateman wrote:
On 04/02/2013 16:02, Mike Duigou wrote:
:
If so then I think we have to careful because -concurrency means a lot of
virtual memory and I'm not convinced that we limit it via -vmoption in
jdk/test/Makefile
I could see us wanting to dial
On Feb 4 2013, at 05:54 , Alan Bateman wrote:
On 02/02/2013 20:40, Mike Duigou wrote:
I have updated both the jdk repo patch:
8006594: Add jdk_core target to jdk/test/Makefile
http://cr.openjdk.java.net/~mduigou/JDK-8006594/1/webrev/
and the root repo patch:
8006595: Use jdk/test
This looks fairly much complete to me. I will run it through the some testing
here and then push your patch.
Great work and thank you!
Mike
On Feb 3 2013, at 21:26 , Steven Schlansker wrote:
On Feb 1, 2013, at 11:42 AM, Mike Duigou mike.dui...@oracle.com wrote:
I have created another
for future patches.
Mike
On Jan 29 2013, at 11:31 , Mike Duigou wrote:
On Jan 23 2013, at 06:35 , Alan Bateman wrote:
On 22/01/2013 21:15, Mike Duigou wrote:
Hello all;
This is a two piece patch.
8006594: Add jdk_core target to jdk/test/Makefile
8006595: Use jdk/test/Makefile
. I have updated the test case and
retested. Please have a look and let me know what you think.
http://cr.openjdk.java.net/~dbuck/7042126/webrev.02/
Cheers,
-Buck
On 2013/02/01 3:03, Mike Duigou wrote:
I like this suggestion. David's most recent webrev with while(true) loop
could
Changeset: cff8d7768d72
Author:mduigou
Date: 2013-01-31 13:27 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cff8d7768d72
8006709: Add minimal support of MacOSX platform for NetBeans Projects
Summary: Adds support for MacOSX platform and architecture detection. Other
minor
This issue still needs a reviewer.
Mike
On Jan 22 2013, at 13:27 , Mike Duigou wrote:
Hello all;
This is a patch that has been lingering around in the lambda/lambda repo for
a long time. It adds minimal support for the MacOSX platform to the JDK
NetBeans projects. It could also be used
Changeset: 4209b3936a7f
Author:mduigou
Date: 2013-01-25 16:13 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4209b3936a7f
8005632: Extend java.util.Logger to use SupplierString for messages
Reviewed-by: briangoetz, mduigou
Contributed-by: henry@oracle.com
!
Hello all;
This is a two piece patch.
8006594: Add jdk_core target to jdk/test/Makefile
8006595: Use jdk/test/Makefile targets in preference to local definitions
I chose to do it as two patches because the changes are in different repos and
the changes in 8006594 could be committed without
Hello all;
This is a patch that has been lingering around in the lambda/lambda repo for a
long time. It adds minimal support for the MacOSX platform to the JDK NetBeans
projects. It could also be used as the basis for similar support for the
langtools NetBeans projects.
The patch also adjust
Seems entirely reasonable.
On Jan 17 2013, at 12:18 , Jim Gish wrote:
Please review
http://cr.openjdk.java.net/~jgish/Bug8006534-getUnusedRandomPort-retry-more/
http://cr.openjdk.java.net/%7Ejgish/Bug8006534-getUnusedRandomPort-retry-more/
TestLibrary.getUnusedPort() attempts to retry
I apologize for the lack of reply. I had missed this thread while on holiday.
As Aleksey suggests the first step is to complete the OCA/CLA.
Until that step is complete we won't be able to act upon this contribution in
any formal way. I encourage you to update the patch with any specific
AbstractStringBuilder probably needs the Unless otherwise noted, blanket
statement as well (Same as StringBuffer/StringBuilder)
You might want to move the Objects.requireNonNull(dst); in String.getBytes() to
after the existing checks so as not to unnecessarily change the exception
thrown for
Perhaps {@code} around java.lang.Object.
The default method and overriding Object method sentences could perhaps be said
more simply:
{@linkplain java.lang.reflect.Method#isDefault() default methods} in
interfaces do provide a method implementation and are not considered abstract.
Interface
Looks good now.
Mike
On Jan 8 2013, at 14:43 , Joe Darcy wrote:
PS The updated webrev is
http://cr.openjdk.java.net/~darcy/8005298.1/
Thanks,
-Joe
On 01/08/2013 02:00 PM, Joe Darcy wrote:
Hi Mike,
On 01/08/2013 01:49 PM, Mike Duigou wrote:
Perhaps {@code} around
I am responding on the StackOverflow thread. I will look into using
ThreadLocalRandom.
The random.next() is clearly a potential bottleneck but given that this happens
only once per HashMap instance it is still unclear why a reasonable application
would want to create hundreds or thousands of
Hello all;
Here are some additional functional interfaces for review. The additions fill
in holes for primitive types and for two operand Bi operations.
http://cr.openjdk.java.net/~mduigou/8004561/0/webrev/
Thank you for adding these links. They look fine.
Mike
On Dec 19 2012, at 11:19 , Joe Darcy wrote:
Hello,
It has come to my attention recently that the various isSynthetic methods in
core reflection cite the Java Language Specification, but do not reference a
particular section. To
On Dec 16 2012, at 20:18 , David Holmes wrote:
On 15/12/2012 4:58 AM, Mike Duigou wrote:
On Dec 13 2012, at 22:28 , David Holmes wrote:
I have added @throws NPE for a number of the default methods. We won't be
including @throws NPE in all cases where null is disallowed because when
Looks good to me. Will a JLS reference be added in when defined? It seems kind
of odd to mention JLS and not provide a ref.
Nice use of annotations in the test. I will steal this technique and can think
of tests where I should have used it.
Mike
On Dec 18 2012, at 12:43 , Joe Darcy wrote:
On Dec 13 2012, at 22:28 , David Holmes wrote:
I have added @throws NPE for a number of the default methods. We won't be
including @throws NPE in all cases where null is disallowed because when the
@throws NPE is declared the API is required to throw NPE in that
circumstance. So for cases
Some notes:
- The Object padding (pad10 - pad1d) in WorkQueue and ForkJoinPool is sensitive
to reference size and compressed OOPS. I was surprised to see Object used
rather than long or int.
- how is getCommonPoolParallelism() different from
commonPool().getParallelism() ? Seems redundant.
-
Hello all;
I have updated the webrev again for hopefully the last time:
http://cr.openjdk.java.net/~mduigou/8004015/3/webrev/
http://cr.openjdk.java.net/~mduigou/8004015/3/specdiff/overview-summary.html
The implementation now uses Primitive.primitiveValue() ie.
Integer.integerValue() rather
Changeset: c4bd81de2868
Author:akhil
Date: 2012-12-11 15:33 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c4bd81de2868
8003246: Add InitialValue Supplier to ThreadLocal
Reviewed-by: mduigou, forax, dl, chegar, briangoetz
! src/share/classes/java/lang/ThreadLocal.java
+
Changeset: 6c795437f212
Author:mduigou
Date: 2012-12-11 20:49 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6c795437f212
8004905: Correct license of test to remove classpath exception
Reviewed-by: akhil
! test/java/lang/ThreadLocal/ThreadLocalSupplierTest.java
On Dec 6 2012, at 03:59 , Chris Hegarty wrote:
Mike,
Some small comments.
1) IntUnaryOperator.java
Typo in:
+ 30 * pThis is the primitive type specialization of {@link
IntUnaryOperator} for
+ 31 * {@code int} and also may be used as a {@code
IntUnaryOperatorInteger}. When
Changeset: fb1bf5e5bc9e
Author:henryjen
Date: 2012-12-06 15:38 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/rev/fb1bf5e5bc9e
8004685: add java.util.function to CORE_PKGS.gmk
Reviewed-by: mduigou
! common/makefiles/javadoc/CORE_PKGS.gmk
statements are intended to be normative
and apply to anyone who might provide an implementation of theses classes -
right?
Correct. I would prefer that they were not but it seems unavoidable.
Mike
Thanks,
David
On 5/12/2012 3:47 PM, Mike Duigou wrote:
Hello all;
I have updated the proposed
Looks good to me.
Mike
On Dec 5 2012, at 11:39 , Akhil Arora wrote:
This patch adds a constructor to ThreadLocal to supply initial values using
the new Supplier functional interface. Please review. This work was done by
Jim Gish.
http://cr.openjdk.java.net/~akhil/8003246.0/webrev/
Changeset: bf6ceb6b8f80
Author:mduigou
Date: 2012-11-29 14:07 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bf6ceb6b8f80
7175464: entrySetView field is never updated in NavigableSubMap
Summary: The method entrySet() in AscendingSubMap and DescendingSubMap failed
to cache
On Nov 27 2012, at 03:56 , Stephen Colebourne wrote:
On 27 November 2012 02:12, Mike Duigou mike.dui...@oracle.com wrote:
In the original patch which added the basic lambda functional interfaces,
CR#8001634 [1], none of the interfaces extended other interfaces. The reason
was primarily
Changeset: c2e80176a697
Author:mduigou
Date: 2012-11-26 15:08 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c2e80176a697
8001634: Initial set of functional interface types
Summary: Add the core functional interfaces used by the JSR335 libraries.
Reviewed-by: dholmes,
Hello all;
In the original patch which added the basic lambda functional interfaces,
CR#8001634 [1], none of the interfaces extended other interfaces. The reason
was primarily that the javac compiler did not, at the time that 8001634 was
proposed, support extension methods. The compiler now
builds:
[ Code Review for jdk ]
http://cr.openjdk.java.net/~dbuck/7198904/webrev.01/
Would someone please review this new version of the test case?
Cheers,
-Buck
On 11/16/12 11:45, Mike Duigou wrote:
Looks like a good test to me as well. The one possible addition is to check
that m1
501 - 600 of 822 matches
Mail list logo
