On Nov 15, 2012, at 1:28 PM, Alan Bateman alan.bate...@oracle.com wrote:
On 15/11/2012 12:19, Nils Loodin wrote:
Webrev: http://cr.openjdk.java.net/~nloodin/exception-tracing/webrev.01/
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8003322
Nils - you can explain why the byte code
Hi Alan,
+ * If neither of these properties is defined then the LogManager uses its
+ * default configuration. The default configuration is typically loaded from
the
+ * properties file {@code lib/logging.properties} in the Java installation
+ * directory.
Will typical become atypical for
On Nov 26, 2012, at 4:52 PM, Alan Bateman alan.bate...@oracle.com wrote:
On 26/11/2012 15:18, Paul Sandoz wrote:
Hi Alan,
+ * If neither of these properties is defined then the LogManager uses its
+ * default configuration. The default configuration is typically loaded
from
On Dec 11, 2012, at 1:24 PM, Alan Bateman alan.bate...@oracle.com wrote:
Joe sent me an update with changes to address issues discussed so far, I've
put the webrev here:
http://cr.openjdk.java.net/~alanb/8004371/webrev.02/
Joe - the classes you sent me were in different packages, also
On Dec 14, 2012, at 11:54 AM, Remi Forax fo...@univ-mlv.fr wrote:
We can't remove Collection.forEach without having perf issue because the
stream pipeline use it.
Iterator.forEach can be removed but it's a pity because it's really
convenient,
And a case can be made performance wise too
On Dec 17, 2012, at 4:39 PM, Daniel Fuchs daniel.fu...@oracle.com wrote:
Hi,
As pointed out by Paul Alan, there's no reason to force
Class.forName to initialize the class when attempting to
load it in FactoryFinder.
FactoryFinder should behave like ServiceLoader in this respect.
So
On Dec 18, 2012, at 7:02 AM, Mandy Chung mandy.ch...@oracle.com wrote:
Hi Daniel,
There are currently several different FactoryFinder class in the JAXP
implementation and there might be slight difference in each of them. Do you
know if it has been looked into whether it's feasible to
On Dec 21, 2012, at 11:31 AM, Chris Hegarty chris.hega...@oracle.com wrote:
On 12/21/2012 01:49 AM, David Holmes wrote:
Hi Chris,
The specdiff is missing the Object variants for some reason.
Sorry, I should have noticed this. There was an old version of specdiff in my
environment. I
Hi Eric,
In Parameter.java:
--
31 public final class Parameter implements AnnotatedElement {
32
33 private String name;
34 private int modifiers;
35 private Executable executable;
36 private int index;
37
Can all the above fields be marked as final?
--
172
On Feb 5, 2013, at 1:05 AM, Joseph Darcy joe.da...@oracle.com wrote:
On 2/4/2013 1:36 PM, Stephen Colebourne wrote:
On 4 February 2013 19:31, Joe Darcy joe.da...@oracle.com wrote:
The stripTrailingZeros method has acted in this surprising way since the
IBM-led JSR 13 was integrated into the
Hi Remi,
Thanks for the feedback i have addressed some of this, mostly related to inner
classes, in following change set to the lambda repo:
http://hg.openjdk.java.net/lambda/lambda/jdk/rev/3e50294c68ea
We can update the webrev next week.
On Feb 23, 2013, at 11:51 AM, Remi Forax
On Feb 25, 2013, at 10:45 PM, David Holmes david.hol...@oracle.com wrote:
On 26/02/2013 3:31 AM, Paul Sandoz wrote:
Hi Remi,
Thanks for the feedback i have addressed some of this, mostly related to
inner classes, in following change set to the lambda repo:
http://hg.openjdk.java.net
On Feb 26, 2013, at 2:50 PM, Remi Forax fo...@univ-mlv.fr wrote:
On 02/25/2013 06:31 PM, Paul Sandoz wrote:
Hi Remi,
Thanks for the feedback i have addressed some of this, mostly related to
inner classes, in following change set to the lambda repo:
http://hg.openjdk.java.net/lambda
Hi Henry,
Minor thing.
In Comparator:
194 * @param other the other comparator used when equals on this.
195 * @throws NullPointerException if the argument is null.
196 * @since 1.8
197 */
198 default ComparatorT thenComparing(Comparator? super T other) {
199
On Mar 12, 2013, at 12:13 AM, Paul Benedict pbened...@apache.org wrote:
3) StreamShape: Javadoc should be formatted to be within 80 characters.
Hmm... that is linked to an old version.
It should be the same as:
On Mar 12, 2013, at 2:29 AM, Mike Duigou mike.dui...@oracle.com wrote:
Some notes:
- Copyrights update.
Pushed to lambda repo:
http://hg.openjdk.java.net/lambda/lambda/jdk/rev/40c0a71455d7
- The order of notes on files is the order that I read the files. It seems
like not a bad
Hi Mike,
On Mar 12, 2013, at 2:29 AM, Mike Duigou mike.dui...@oracle.com wrote:
AbstractTask::
- that describes a portion of the input - describes the he portion of the
input associated with the subtree rooted at this task.
- setRawResult() : needs better docs. Why does getRawResult
Hi,
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8010096
Webrev:
http://cr.openjdk.java.net/~psandoz/lambda/spliterator/jdk-8010096/webrev/
Spec diff:
http://cr.openjdk.java.net/~psandoz/lambda/spliterator/jdk-8010096/specdiff/overview-summary.html
Relevant JavaDoc generated from
On Mar 29, 2013, at 5:39 AM, Paul Benedict pbened...@apache.org wrote:
I think the use of EnumSet in a public API is superior to bit flags.
Worrying about the number of bytes here is not important since they will
all end up being garbage collected when the stream processing ends.
I worry.
Hi Alan,
Thanks for taking a look.
On Apr 1, 2013, at 6:13 PM, Alan Bateman alan.bate...@oracle.com wrote:
On 28/03/2013 15:59, Paul Sandoz wrote:
Hi,
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8010096
Webrev:
http://cr.openjdk.java.net/~psandoz/lambda/spliterator/jdk-8010096
On Apr 2, 2013, at 2:37 PM, Chris Hegarty chris.hega...@oracle.com wrote:
Nice work Paul, some small comments.
- new javadocs tags, @implSpec, @apiNote, etc. I really like the use of
implSpec to define the behavior of this implementations default
methods. There is probably a separate
Hi,
Following up from JDK-8010096 [1] here is a webrev for spliterator
implementations of collection classes in java.util:
http://cr.openjdk.java.net/~psandoz/lambda/spliterator/jdk-8011426/webrev/
This is dependent on [1].
--
Note that for some reason the webrev script creates the jdk
Hi,
Following up from JDK-8010096 [1] here is a webrev for spliterator
implementations of collection classes in java.util.concurrent. More precisely
it represents updates from JSR 166 for collection classes that implement
spliterators:
On Apr 10, 2013, at 5:03 PM, Peter Levart peter.lev...@gmail.com wrote:
On 04/10/2013 03:56 PM, Paul Sandoz wrote:
Hi,
Following up from JDK-8010096 [1] here is a webrev for spliterator
implementations of collection classes in java.util.concurrent. More
precisely it represents updates
Hi Mike,
Thanks for looking at this.
On Apr 16, 2013, at 5:39 AM, Mike Duigou mike.dui...@oracle.com wrote:
I went back and started again with the 8010096 webrev.
Spliterators::
- some implementations are private and some are package private. All package
private?
I don't think there
On Apr 19, 2013, at 6:52 AM, Mike Duigou mike.dui...@oracle.com wrote:
I reversed this change :
-final Collection? extends E c;
-
+final CollectionE c;
in Collections.UnmodifiableCollection instead opting or casts in the forEach
and spliterator Methods.
OK, i prefer the
On Apr 19, 2013, at 1:15 PM, Alan Bateman alan.bate...@oracle.com wrote:
On 18/04/2013 19:49, Akhil Arora wrote:
Looks like the stars are aligning on getting on this into TL... the
refreshed webrev is -
http://cr.openjdk.java.net/~akhil/8001647.8/webrev/
A minor comment on
On Apr 19, 2013, at 2:29 PM, David Holmes david.hol...@oracle.com wrote:
Hi Akhil,
This is only a partial review so far.
I have some issues with the ConcurrentModificationException strategy.
Taking ArrayList, the basic idea is that you want to detect
modifications that are concurrent
On Apr 19, 2013, at 2:42 PM, David Holmes david.hol...@oracle.com wrote:
On 19/04/2013 10:14 PM, Paul Sandoz wrote:
On Apr 19, 2013, at 1:15 PM, Alan Bateman alan.bate...@oracle.com wrote:
On 18/04/2013 19:49, Akhil Arora wrote:
Looks like the stars are aligning on getting
On Apr 26, 2013, at 1:26 AM, Kumar Srinivasan kumar.x.sriniva...@oracle.com
wrote:
On 4/25/2013 3:53 PM, Mike Duigou wrote:
The restyling changes obfustucated things a bit but I didn't see anything of
concern in casual review.
I had hoped to see the updated SmallSet that didn't try to
On Apr 24, 2013, at 7:57 PM, Remi Forax fo...@univ-mlv.fr wrote:
On 04/24/2013 07:24 PM, Akhil Arora wrote:
On 04/24/2013 06:19 AM, Alan Bateman wrote:
On 23/04/2013 20:18, Akhil Arora wrote:
On 04/22/2013 11:42 AM, Alan Bateman wrote:
One thing I meant to ask when forEachRemaining was
On Apr 26, 2013, at 2:06 PM, David Holmes david.hol...@oracle.com wrote:
To avoid blocking the feature, I have filed
https://jbs.oracle.com/bugs/browse/JDK-8013150 to refine the behavior of
remove and other ListIterator methods after forEachRemaining returns.
I think the fact that the
On Apr 26, 2013, at 3:25 PM, Remi Forax fo...@univ-mlv.fr wrote:
On 04/26/2013 01:43 PM, Paul Sandoz wrote:
On Apr 26, 2013, at 1:26 AM, Kumar Srinivasan
kumar.x.sriniva...@oracle.com wrote:
On 4/25/2013 3:53 PM, Mike Duigou wrote:
The restyling changes obfustucated things a bit but I
On Apr 26, 2013, at 4:37 PM, Peter Levart peter.lev...@gmail.com wrote:
Another interesting usage:
Iterator? i = ...;
i.forEachRemaining(e - {
...
if (...) {
i.forEachRemaining(dummy - {}); // drain it
}
...
});
It seems that mixing external and internal iteration
On Apr 27, 2013, at 5:01 PM, Alan Bateman alan.bate...@oracle.com wrote:
On 27/04/2013 00:08, Henry Jen wrote:
Hi,
Please review webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8012645.0/webrev
The API doc in specdiff format is at
On Apr 27, 2013, at 10:15 AM, Alan Bateman alan.bate...@oracle.com wrote:
On 26/04/2013 22:59, Henry Jen wrote:
Hi,
Please review webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8003258.1/webrev/
It adds a method to BufferedReader.
public StreamString lines() {}
A class
Hi,
Please review:
http://cr.openjdk.java.net/~psandoz/lambda/jdk-8012646/webrev/
The stream-based test currently resides in the lambda repo and will flow into
tl with other stream-based tests:
On Apr 29, 2013, at 9:41 PM, Henry Jen henry@oracle.com wrote:
On 04/27/2013 08:01 AM, Alan Bateman wrote:
On 27/04/2013 00:08, Henry Jen wrote:
Hi,
Please review webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8012645.0/webrev
The API doc in specdiff format is at
On Apr 30, 2013, at 5:43 PM, Henry Jen henry@oracle.com wrote:
So if possible we should report ORDERED and state the association, if any,
of encounter order with the order declared in the central directory, which i
hope is, and seems to be, the same. (Plus update the docs of entries()
. However, I don't really know much about the zip
implementation to say much with confidence on this matter.
Paul.
Cheers,
Henry
On Apr 30, 2013, at 9:35 AM, Paul Sandoz paul.san...@oracle.com wrote:
On Apr 30, 2013, at 5:43 PM, Henry Jen henry@oracle.com wrote:
So if possible we
On May 1, 2013, at 6:36 AM, Henry Jen henry@oracle.com wrote:
/**
* Returns a {@code Stream}, the elements of which are lines read from
this
* {@code BufferedReader}. The {@link Stream} is lazily populated via
* calls to {@link #readLine()}.
*
* pEach
Also...
On May 1, 2013, at 5:42 PM, Paul Sandoz paul.san...@oracle.com wrote:
On May 1, 2013, at 6:36 AM, Henry Jen henry@oracle.com wrote:
/**
* Returns a {@code Stream}, the elements of which are lines read from
this
* {@code BufferedReader}. The {@link Stream} is lazily
-by: John Rose john.r.r...@oracle.com, Mike Duigou
mike.dui...@oracle.com,
Paul Sandoz paul.san...@oracle.com
diff -r 470f19b6bfdd -r fda6ca78a7c2
src/share/classes/java/util/Spliterator.java
--- a/src/share/classes/java/util/Spliterator.java Thu May 02 13:21:09
2013 +0200
+++ b/src/share/classes
of
* {@code estimateSize()} for this and the returned Spliterator after
Regards, Peter
On 05/03/2013 11:10 AM, Paul Sandoz wrote:
Hi,
Please review the patch below for some minor fixes to the Spltierator
JavaDoc and a tweak to the spec of Spliterator.trySplit.
http
On May 3, 2013, at 9:42 PM, Peter Levart peter.lev...@gmail.com wrote:
On 05/03/2013 09:10 PM, Paul Sandoz wrote:
Hi Peter,
On May 3, 2013, at 12:07 PM, Peter Levart peter.lev...@gmail.com wrote:
Hi Paul,
Maybe the JavaDoc could also suggest that the trySplit producing N+0 result
On May 10, 2013, at 5:33 AM, David Holmes david.hol...@oracle.com wrote:
Looks good to me Mike!
+1
Paul.
Hi,
Please review:
http://cr.openjdk.java.net/~psandoz/lambda/spliterator/jdk-8014133/webrev/
http://cr.openjdk.java.net/~psandoz/lambda/spliterator/jdk-8014133/specdiff/overview-summary.html
This enables more sharing of primitive-based spliterator code and should also
reduce the bloat of
On May 16, 2013, at 2:00 PM, Alan Bateman alan.bate...@oracle.com wrote:
On 16/05/2013 11:03, David Holmes wrote:
Yes - I don't think we need @Retired as a stepping stone between @Deprecated
and gone. But to date @Deprecated's notion of some point in the future is
a future yet to
On May 17, 2013, at 12:09 AM, David Chase david.r.ch...@oracle.com wrote:
On 2013-05-16, at 5:27 PM, Alan Bateman alan.bate...@oracle.com wrote:
The current proposal doesn't change the API at this time but I wonder if you
have considered adding parallelUpdate methods to complement the
On May 17, 2013, at 3:45 PM, David Chase david.r.ch...@oracle.com wrote:
On 2013-05-17, at 4:28 AM, Paul Sandoz paul.san...@oracle.com wrote:
On May 17, 2013, at 12:09 AM, David Chase david.r.ch...@oracle.com wrote:
On 2013-05-16, at 5:27 PM, Alan Bateman alan.bate...@oracle.com
On May 17, 2013, at 4:45 PM, David Chase david.r.ch...@oracle.com wrote:
On 2013-05-17, at 10:07 AM, Paul Sandoz paul.san...@oracle.com wrote:
Baking it in as a static decision is just kicking the can down the road --
once some module that computes CRCs as part of its larger work chooses
On May 27, 2013, at 3:05 PM, Doug Lea d...@cs.oswego.edu wrote:
- The default for getOrDefault() in ConcurrentMap shouldn't be removed.
- CopyOnWriteArraySet currently has an ORDERED spliterator. Set is not
normally order preserving.
Thanks! Both the results of my not rechecking vs
Hi,
Please review these JavaDoc fixes to j.u.s.{Xxxx}Stream.findFirst.
Paul.
# HG changeset patch
# User psandoz
# Date 1369747350 -7200
# Node ID 6be3ce51e61dbdab6766c74223c076a7b3472be6
# Parent 303e9d2aff3cbaf27823b2591f2e8570b77afcce
8014393: Minor typo in the spec for
6be3ce51e61dbdab6766c74223c076a7b3472be6
8014731: j.u.stream.StreamSupport class has default constructor generated
Summary: This change set also fixes broken links
Reviewed-by:
Contributed-by: Paul Sandoz paul.san...@oracle.com, Henry Jen
henry@oracle.com
diff -r 6be3ce51e61d -r bfdc1ed75460
src/share
Hi,
Please review these JavaDoc fixes to j.u.s.StreamBuilder.
Paul.
# HG changeset patch
# User psandoz
# Date 1369825073 -7200
# Node ID 303e9d2aff3cbaf27823b2591f2e8570b77afcce
# Parent bd6d3801347bfd912507d16dc14488f47e94e626
8014409: Spec typo: extra } in the spec for j.u.s.StreamBuilder
Hi,
Please review these changes to j.u.PrimitiveIterator to ensure the default
forEachRemaining methods consistently throw an NPE when the consumer is null.
I almost produced a webrev for this, but i thought it was just about acceptable
size-wise and i hope easy to review in textual form. If
Hi,
Please review this JavaDoc fixe to j.u.Spliterator.getExactSizeIfKnown.
Paul.
# HG changeset patch
# User psandoz
# Date 1369825085 -7200
# Node ID 840469ba82ab8d8238414a5333aa99b8d4035a9b
# Parent 7ded996200218791c885c0aae4c474066101c7bd
8014732: Minor spec issue:
On May 29, 2013, at 1:34 PM, Alan Bateman alan.bate...@oracle.com wrote:
On 29/05/2013 12:12, Paul Sandoz wrote:
Hi,
Please review these changes to j.u.s. StreamSupport to make it final and
non-instantiable, i also tacked on some JavaDoc broken link fixes made by
Henry.
Paul
On May 29, 2013, at 2:49 PM, Chris Hegarty chris.hega...@oracle.com wrote:
Looks fine to me Paul.
Trivially, there is an extra space which could be removed.
builder__has...
Thanks, i updated the patch/lambda repo.
Paul.
Changeset: 156ee44cd456
Author:psandoz
Date: 2013-05-30 16:08 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/156ee44cd456
8014409: Spec typo: extra } in the spec for j.u.s.StreamBuilder
Summary: Also fixes documentation on StreamBuilder.OfDouble
Reviewed-by: alanb, chegar,
Changeset: b4742d038100
Author:psandoz
Date: 2013-05-28 15:22 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b4742d038100
8014393: Minor typo in the spec for j.u.stream.Stream.findFirst()
Reviewed-by: alanb, chegar
! src/share/classes/java/util/stream/DoubleStream.java
!
On May 31, 2013, at 1:56 AM, Mike Duigou mike.dui...@oracle.com wrote:
Hello all;
A very small review for a change which was fixed in the lambda repo
(JDK-8012691) but escaped into TL:
http://cr.openjdk.java.net/~mduigou/JDK-8015686/0/webrev/
+1 (while lacking reviewer mojo)
Paul.
Changeset: b47044426bcd
Author:psandoz
Date: 2013-05-31 09:58 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b47044426bcd
8014732: Minor spec issue: java.util.Spliterator.getExactSizeIfKnown
Summary: A minor documentation issue (not a spec issue).
Reviewed-by: chegar, dl
!
Hi,
Please review a fix to the key/value/entry spliterators of HashMap/WeakHashMap
when mixed traversal is performed:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8013649/webrev/
A call to forEachRemaning does not correctly check and set the state to
detect/signal all elements have been
Hi,
Please review this JavaDoc fix to j.u.StringJoiner to update and move the
examples to an api note.
--
This has already been fixed in the lambda repo:
http://hg.openjdk.java.net/lambda/lambda/jdk/rev/3a44a6038054
Paul.
# HG changeset patch
# User psandoz
# Date 1369996938 -7200
# Node ID
On May 31, 2013, at 1:14 PM, Alan Bateman alan.bate...@oracle.com wrote:
On 31/05/2013 11:49, Paul Sandoz wrote:
Hi,
Please review this JavaDoc fix to j.u.StringJoiner to update and move the
examples to an api note.
--
This looks okay to me.
Thanks.
The only thing
Hi Brent,
On Jun 3, 2013, at 7:56 AM, Brent Christian brent.christ...@oracle.com wrote:
I went ahead and created a new webrev. It includes this change, and the
comment changes suggested by Alan:
http://cr.openjdk.java.net/~bchristi/8005698/webrev.04/
A minor thing: take it or leave it
Changeset: f3c7c5f753dc
Author:psandoz
Date: 2013-06-03 10:28 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f3c7c5f753dc
8015008: Primitive iterator over empty sequence, null consumer:
forEachRemaining methods do not throw NPE
Reviewed-by: chegar
!
Hi,
This RFR proposes to remove some duplicate spliterator tests.
The tests:
http://hg.openjdk.java.net/jdk8/tl/jdk/file/tip/test/java/util/stream/test/org/openjdk/tests/java/util/stream/SpliteratorTraversingAndSplittingTest.java
Changeset: a79e2683eae3
Author:psandoz
Date: 2013-06-03 17:37 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a79e2683eae3
8014383: StringJoiner example in class description not in sync with streams API
Reviewed-by: alanb
! src/share/classes/java/util/StringJoiner.java
Hi,
The following patch updates DoubleStream to remove the range methods:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8015492-rm-DoubleStream.range/webrev/
CCC is in progress.
It's best if we let numerical libraries integrate with the Stream API since the
library writers are in a better
Hi,
The following patch renames the methods
IntStream.longs/doubles/LongStream.doubles, as decided by the JSR-335 EG which
agreed the new names better convey transformation to another type of primitive
stream:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8015798-asXxxStream/webrev/
Hi,
The following patch renames the Spliterators.spliteratorFromIterator methods to
Spliterators.iterator, which is more consistent with other methods on the class:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8015792-Spliterators.iterator/webrev/
CCC is in progress.
Paul.
t.populate((Entry)table[bucketIndex]);
2247 table[bucketIndex] = t;
2248 }
2249 break;
2250 }
2251 }
2252 }
Paul.
Thanks,
-Brent
On 6/3/13 12:56 AM, Paul Sandoz wrote
I forgot to say please don't let this hold up getting the patch into TL. I
think it more important to get the code in then iterate on it.
Paul.
On Jun 4, 2013, at 9:45 AM, Paul Sandoz paul.san...@oracle.com wrote:
Hi,
On Jun 4, 2013, at 1:34 AM, Brent Christian brent.christ...@oracle.com
On Jun 3, 2013, at 10:33 PM, Henry Jen henry@oracle.com wrote:
Hi,
Please review
http://cr.openjdk.java.net/~henryjen/tl/8015522.0/webrev/
This webrev is based on previous suggestion from Martin Buchholz while
keep the lazy-binding nature without seize the length at construction
Changeset: fad4ef2123ca
Author:psandoz
Date: 2013-06-04 11:53 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fad4ef2123ca
8015790: Remove duplicate spliterator tests
Reviewed-by: alanb, mduigou
-
Changeset: de11b20f8c01
Author:psandoz
Date: 2013-05-31 10:53 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/de11b20f8c01
8013649: HashMap spliterator tryAdvance() encounters remaining elements after
forEachRemaining()
Reviewed-by: chegar
!
Hi,
The following was decided by the JSR-335 EG:
1) Int/LongStream.range are restricted to a fixed step of 1. The map operation
can be used to adjust the step.
2) Int/LongStream.rangeClosed methods were added for a closed range with a
fixed step of 1, in addition to the half open range of 1).
Hi Roel,
Would you like to submit a patch and contribute?
Paul.
On Jun 4, 2013, at 4:16 PM, Roel Spilker r.spil...@gmail.com wrote:
Looking at the implementation, the code in toString suggest that it's
worthwhile to optimize for an empty suffix (although I doubt that this
optimization has
Hi,
The following patch defines the abstract method
PrimitiveIterator.forEachRemaining. This is now consistent with
Spliterator.OfPrimitive and there may be cases in the future where this is
useful and if we don't do it now it becomes difficult to do so later on.
On Jun 7, 2013, at 5:35 PM, Alan Bateman alan.bate...@oracle.com wrote:
On 07/06/2013 10:05, Paul Sandoz wrote:
Hi,
The following patch defines the abstract method
PrimitiveIterator.forEachRemaining. This is now consistent with
Spliterator.OfPrimitive and there may be cases
Changeset: 9c462579b624
Author:psandoz
Date: 2013-06-10 12:26 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9c462579b624
8015792: Rename Spliterators.spliteratorFromIterator to Spliterators.iterator
Reviewed-by: chegar
! src/share/classes/java/util/Spliterators.java
!
Changeset: 3990fcab2cd9
Author:psandoz
Date: 2013-06-10 11:52 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3990fcab2cd9
8015492: Remove DoubleStream.range methods
Reviewed-by: alanb
! src/share/classes/java/util/stream/DoubleStream.java
!
Changeset: 7322e8ad7c01
Author:psandoz
Date: 2013-06-10 12:20 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7322e8ad7c01
8015798: Rename IntStream.longs/doubles and LongStream.doubles to asXxxStream
Reviewed-by: alanb
! src/share/classes/java/util/stream/IntPipeline.java
!
On Jun 10, 2013, at 5:53 PM, Aleksey Shipilev aleksey.shipi...@oracle.com
wrote:
Hi,
This is the follow-up on the issue Doug identified:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-June/017798.html
I had reworked the patch, webrev is here:
On Jun 10, 2013, at 7:20 PM, Aleksey Shipilev aleksey.shipi...@oracle.com
wrote:
Thanks for taking a look, Paul!
Can I count your review as official?
Unfortunately i am not an unofficial reviewer so can only be counted in the
unofficial category for now :-(
On 06/10/2013 08:44 PM, Paul
Hi
Please review the following patch:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8016308-Node/webrev/
This syncs up java.util.stream.Node/Nodes from the lambda repo to the tl repo.
The main changes are related to reducing the code for primitive
specializations. There are some temporary
Changeset: 8d627f324c38
Author:psandoz
Date: 2013-06-11 12:13 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8d627f324c38
8015895: Int/LongStream.range/rangeClosed
8012986: Right-bias range spliterators for large ranges
Reviewed-by: mduigou
!
Hi,
Please review the following patch contributed by Brian Goetz:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8016324-pipelines/webrev/
This syncs most of code in the pipeline implementations from lambda to tl (the
remaining aspects are to do with Comparator changes which will follow later).
On Jun 12, 2013, at 9:45 AM, Peter Levart peter.lev...@gmail.com wrote:
On 06/11/2013 11:06 PM, Mike Duigou wrote:
On Jun 11 2013, at 09:59 , Remi Forax wrote:
Hi guys,
This mail was originality sent to lambda-lib EG but Brian ask me to also
send it here to not forget.
We should
Looks ok to me in my unofficial reviewer role.
Paul.
On Jun 11, 2013, at 10:32 PM, Brent Christian brent.christ...@oracle.com
wrote:
Hi,
Please review my fix for 8010325. Some background:
The alternative string-hashing implementation[1] added to java.lang.String a
new public method,
I did a quick scan, looks OK.
Paul.
On Jun 11, 2013, at 1:36 AM, Mike Duigou mike.dui...@oracle.com wrote:
I've done some further updates based upon feedback. I believe this is now
done and ready for final review.
http://cr.openjdk.java.net/~mduigou/JDK-7129185/3/webrev/
I did find one
Hi Mandy,
JdepsTask:
Given that the dot graph output is likely to be just as human readable as your
original format it is very tempting just to support that format. In fact it is
likely to be more human readable since the output is of a known syntax. So IMHO
we don't need a format option and
On Jun 12, 2013, at 11:28 AM, Remi Forax fo...@univ-mlv.fr wrote:
By the way, could you add to the description of the bug that if we override
Map.forEach for HashMap we also need to override it for LinkedHashMap.
Done.
Paul.
On Jun 12, 2013, at 1:16 PM, Alan Bateman alan.bate...@oracle.com wrote:
On 12/06/2013 11:48, Paul Sandoz wrote:
:
You might be able to use a lambda expression when creating the comparator
for the TreeSet:
SetProfile profiles = new TreeSetProfile((p1, p2) - { ... });
I realize
Hi Mandy,
Regarding the command line arguments of jdeps, would it not be more consistent
to re-use the same classpath related arguments as javac/java/javap/javah
-c becomes -cp
--classpath becomes -classpath
?
Paul.
On Jun 11, 2013, at 4:46 AM, Mandy Chung mandy.ch...@oracle.com wrote:
Hi,
This patch synchronizes the test framework and many of the tests from lambda to
tl and improves:
1) the asserting of results, indicating whether the result to assert on has an
encounter order and was computed in parallel. This will become more relevant
when the improvements to the limit
Hi Henry,
If you don't mind could you hold off on committing this one until the following
have gone through to tl:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8016251-spinedBuffer-splitr/webrev/
http://cr.openjdk.java.net/~psandoz/tl/JDK-8016308-Node/webrev/
On Jun 12, 2013, at 4:50 PM, Chris Hegarty chris.hega...@oracle.com wrote:
Add implementations of parallelPrefix() in Arrays for Object, int, long, and
double arrays.
Specdiff:
http://cr.openjdk.java.net/~chegar/8012647/ver.00/specdiff/java/util/Arrays.html
Webrev:
301 - 400 of 2479 matches
Mail list logo
