On Oct 1, 2013, at 6:03 PM, Joe Darcy joe.da...@oracle.com wrote:
On 10/1/2013 4:18 AM, Paul Sandoz wrote:
On Sep 20, 2013, at 5:30 PM, Martin Buchholz marti...@google.com wrote:
Looks good.
Random nitpicks:
I prefer the old variable name DOUBLE_UNIT to DOUBLE_ULP; else you
[Catching up after J1]
On Sep 24, 2013, at 9:16 AM, Martin Buchholz marti...@google.com wrote:
Stupid SplittableRandom tricks:
System.out.println(sr.nextDouble(0.0d,
Double.POSITIVE_INFINITY));
always prints constant 1.7976931348623157E308
which might be considered a bug.
On Oct 3, 2013, at 7:13 AM, Alan Bateman alan.bate...@oracle.com wrote:
On 02/10/2013 09:49, Aleksey Shipilev wrote:
On 10/02/2013 08:31 PM, Alan Bateman wrote:
On 02/10/2013 07:43, Aleksey Shipilev wrote:
http://cr.openjdk.java.net/~shade/6857566/webrev.00/
I'd like to review, I just
+1.
Paul.
On Oct 4, 2013, at 8:43 AM, Joe Darcy joe.da...@oracle.com wrote:
Hello,
Per previous discussions on the mailing list, we've decided to rename the
annotation type jdk.Supported to jdk.Exported.
Other than the file rename, the changes to the contents of the type are below:
On Oct 4, 2013, at 6:11 PM, Daniel Fuchs daniel.fu...@oracle.com wrote:
On 10/4/13 3:33 PM, Alan Bateman wrote:
On 04/10/2013 03:02, Daniel Fuchs wrote:
:
http://cr.openjdk.java.net/~dfuchs/webrev_8025745/webrev.00/
This mostly looks good, the only thing is that it reads the
On Oct 5, 2013, at 1:13 AM, Henry Jen henry@oracle.com wrote:
Hi,
Please review a port from lambda repo to tl, it contains a refactoring
of OpTestCase and a small addition to fill test gap.
http://cr.openjdk.java.net/~henryjen/tl/8025968/0/webrev/
Looks good.
Paul.
for ThreadLocalRandom.
Thanks to Paul Sandoz for creating webrevs:
https://bugs.openjdk.java.net/browse/JDK-8025136
http://cr.openjdk.java.net/~psandoz/tl/JDK-8025136-SR-enhancements/webrev/
I think we need one more reviewer for it.
-Doug
Hi Mike,
I am probably going over old ground here...
Given that there is ConcurrentMap is there any point in having the defaults on
Map detect concurrent modification and barf, or retry, or neither of the
previous two e.g. putIfAbsent, computeIfPresent and replace respectively i.e.
there
Changeset: b90dcd1a71bf
Author:psandoz
Date: 2013-10-08 11:17 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b90dcd1a71bf
8025136: SplittableRandom enchancements
Reviewed-by: psandoz, martin
Contributed-by: Doug Lea d...@cs.oswego.edu, Guy Steele
guy.ste...@oracle.com
!
Hi,
The following patch is a minor clarification to the documentation of
Spliterator.characteristics():
http://hg.openjdk.java.net/lambda/lambda/jdk/rev/653d17f35169
Paul.
--- a/src/share/classes/java/util/Spliterator.java Tue Oct 01 12:10:04
2013 +0200
+++
.hasCharacteristics(Spliterator.SIZED));
Paul.
-Chris.
On 10/08/2013 12:42 PM, Paul Sandoz wrote:
Hi,
The following patch is a minor clarification to the documentation of
Spliterator.characteristics():
http://hg.openjdk.java.net/lambda/lambda/jdk/rev/653d17f35169
Paul
On Oct 8, 2013, at 10:05 PM, Brian Burkhalter brian.burkhal...@oracle.com
wrote:
On Oct 4, 2013, at 1:33 AM, Paul Sandoz wrote:
On Oct 4, 2013, at 9:18 AM, Aleksey Shipilev aleksey.shipi...@oracle.com
wrote:
On 10/04/2013 03:34 AM, Brian Burkhalter wrote:
Here is an alternative
On Oct 9, 2013, at 5:38 AM, Mike Duigou mike.dui...@oracle.com wrote:
Hello all;
Based upon feedback from the JavaOne Hands-On-Lab and other sources the 335
EG has decided to rename the two substream methods in the Streams interfaces
to skip and slice.
Webrev:
Changeset: 1cd20806fd5c
Author:psandoz
Date: 2013-10-09 15:19 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1cd20806fd5c
8020061: Clarify reporting characteristics between splits
Reviewed-by: alanb, chegar
! src/share/classes/java/util/Spliterator.java
On Oct 9, 2013, at 3:56 AM, Joe Darcy joe.da...@oracle.com wrote:
Hello,
Please review the patch below which addresses
JDK-8024354 Explicitly permit DoubleStream.sum()/average()
implementations to use higher precision summation
Thanks,
The note feels more like an api note
On Oct 10, 2013, at 12:13 AM, Karen Kinnear karen.kinn...@oracle.com wrote:
Please review:
webrev: http://cr.openjdk.java.net/~acorn/8026213/webrev/
bug: https://bugs.openjdk.java.net/browse/JDK-8026213
Summary:
Reflection generates code dynamically to speed up reflection processing
On Oct 9, 2013, at 8:33 PM, Joel Borggren-Franck joel.fra...@oracle.com wrote:
Hi
Please review this spec update and test for getting array classes and
instances of more dimensions than the class file can express or the VM
can handle.
Array.newInstance have a test for arrays of more
On Oct 10, 2013, at 2:46 PM, Joel Borggren-Franck joel.fra...@oracle.com
wrote:
Hi,
Joe, Paul, agreed the test could be better. Improved it (without using
streams) and also added a bug id tag to the old Arrays.newInstance test.
Thanks for the comments.
Webrev here:
the entry under
computation then this method may return incorrect results`.
Paul.
On Oct 10, 2013, at 5:46 AM, Mike Duigou mike.dui...@oracle.com wrote:
On Oct 8 2013, at 01:27 , Paul Sandoz wrote:
Hi Mike,
I am probably going over old ground here...
Given that there is ConcurrentMap
+1
Please send a tweet to @DrDeprecator when pushed
https://twitter.com/DrDeprecator
:-)
Paul.
On Oct 10, 2013, at 3:11 PM, Daniel Fuchs daniel.fu...@oracle.com wrote:
Hi,
Please find below a patch for
8011638 - Remove deprecated methods in sun.util.logging.PlatformLogger
On Oct 10, 2013, at 6:02 PM, Karen Kinnear karen.kinn...@oracle.com wrote:
Updated webrev:
webrev: http://cr.openjdk.java.net/~acorn/8026213.2/webrev/
bug: https://bugs.openjdk.java.net/browse/JDK-8026213
+1
Paul.
Testing:
Specific test for private methods (attached to bug)
jtreg
Hi Ivan,
Why do you require closeLock? is it not sufficient leave processExited as is
and just add:
public synchronized void close() throws IOException {
super.close();
}
Plus there was already some logic checking if close was asynchronously called
(see BufferedInputStream.close):
372
On Oct 11, 2013, at 9:46 PM, Mike Duigou mike.dui...@oracle.com wrote:
On Oct 10 2013, at 06:37 , Paul Sandoz wrote:
Hi Mike,
This looks like a good direction. Need to look more closely.
I wonder if we even require such detailed support to throw CME?
Some additional CME
On Oct 14, 2013, at 11:36 AM, Ivan Gerasimov ivan.gerasi...@oracle.com wrote:
Hi Paul,
Thank you for looking at the webrev!
On 14.10.2013 12:50, Paul Sandoz wrote:
Hi Ivan,
Why do you require closeLock? is it not sufficient leave processExited as is
and just add:
public
Hi,
Some high-level points first:
- try and use static import where possible.
- suggest that all streams are sequential. There is an inconsistency in the use
and in some cases it is embedded in other stream usages.
- ParallelCore is not a very descriptive name. Suggest streams.
- suggest
On Oct 13, 2013, at 10:31 PM, Alan Bateman alan.bate...@oracle.com wrote:
On 11/10/2013 08:08, Mandy Chung wrote:
There were some discussion of jdeps CLI to follow GNU style option
or the traditional Java style. As there will be plans to upgrade
the JDK tools to GNU style options, it'd be
Looks good,
Paul.
On Oct 14, 2013, at 5:52 PM, Chris Hegarty chris.hega...@oracle.com wrote:
This is a request to pull a small change to ForkJoinTask into jdk8, from the
jsr166 CVS. This was first discussed over on c-i [1] a few weeks back.
diff -r 077237e4613f
Hi,
I took a look at the patch, but i am not an expert in this area.
On BigInteger:
99 * @implNote
100 * BigInteger constructors and operations throw {@code
ArithmeticException} when
101 * the result is out of the supported range. The supported range in JDK 8
is
102 * -2sup{@code
On Oct 15, 2013, at 4:20 PM, Tristan Yan tristan@oracle.com wrote:
Thank you Paul
There is one minor question, I can't compile one of your code, then I
realized that's because grouping by signature is public static T, K, A, D
CollectorT, ?, MapK, D groupingBy(Function? super T, ?
On Oct 15, 2013, at 4:35 PM, Tristan Yan tristan@oracle.com wrote:
Hi Paul
you have comments suggest that all streams are sequential. There is an
inconsistency in the use and in some cases it is embedded in other stream
usages.
We do not really understand what exactly is meant,
On Oct 15, 2013, at 6:25 PM, Mike Duigou mike.dui...@oracle.com wrote:
On Oct 14 2013, at 02:32 , Paul Sandoz wrote:
Virtually all the cases where CME is thrown in the new Map defaults are
the points where previously the implementation would have looped/retried.
For the cases where
Looks good with Henry's correction (that i missed the first time around!).
Paul.
On Oct 15, 2013, at 10:18 PM, Mike Duigou mike.dui...@oracle.com wrote:
Hello all;
As promised on the lambda-libs-spec-experts mailing list I have prepared a
changeset which renames the single arg substream()
On Oct 16, 2013, at 6:41 AM, David Holmes david.hol...@oracle.com wrote:
Okay you have incited me to throw in my 2c :) I think the CME issue has been
raised a number of times in the past (and if the below doesn't agree with
what I've said in the past Hey! It's a brand new day! ;-) )
But
On Oct 16, 2013, at 12:28 PM, David Holmes david.hol...@oracle.com wrote:
On 16/10/2013 8:03 PM, Paul Sandoz wrote:
On Oct 16, 2013, at 6:41 AM, David Holmes david.hol...@oracle.com wrote:
Okay you have incited me to throw in my 2c :) I think the CME issue has
been raised a number
On Oct 16, 2013, at 1:52 PM, David Holmes david.hol...@oracle.com wrote:
Perhaps HashMap's implementations should throw CME?
Perhaps, seems to be going beyond the call of duty. My inclination is not to
bother. It becomes most relevant with forEach since the consumer will have
On Oct 16, 2013, at 7:46 PM, Dmitry Nadezhin dmitry.nadez...@gmail.com wrote:
Thank you, Paul.
I tried to combine your and Joe's suggestions in the updated WebRev:
http://cr.openjdk.java.net/~bpb/6910473/webrev.2/
Looks good.
A slight concern is that the test sets the max heap size to 8g.
.
If that collector is useful for you, then perhaps consider adding it to your
demo as an advance use of Collector. Unfortunately it is probably too late to
add such a collector to the API.
Paul.
On Oct 14, 2013, at 5:27 PM, Paul Sandoz paul.san...@oracle.com wrote:
Hi,
Some high-level
On Oct 17, 2013, at 1:52 AM, Mike Duigou mike.dui...@oracle.com wrote:
On Oct 16 2013, at 05:34 , Paul Sandoz paul.san...@oracle.com wrote:
On Oct 16, 2013, at 1:52 PM, David Holmes david.hol...@oracle.com wrote:
Perhaps HashMap's implementations should throw CME?
Perhaps, seems
another implementation suggested by Paul Sandoz with some minor
changes.
http://cr.openjdk.java.net/~igerasim/8024521/2/webrev/
http://cr.openjdk.java.net/%7Eigerasim/8024521/2/webrev/
That looks good: no operation on a re-cycled fd; fail-fast draining on close;
and less blocking on close
On Oct 9, 2013, at 2:57 AM, Joe Darcy joe.da...@oracle.com wrote:
On 10/04/2013 10:30 AM, mark.reinh...@oracle.com wrote:
2013/10/3 16:43 -0700, joe.da...@oracle.com:
Per previous discussions on the mailing list, we've decided to rename
the annotation type jdk.Supported to jdk.Exported.
On Oct 18, 2013, at 1:15 PM, Daniel Fuchs daniel.fu...@oracle.com wrote:
On 10/17/13 8:12 PM, Mandy Chung wrote:
Daniel,
Have you considered to revert to the previous version and simply iterate
props.keySet rather than adding a new entry point just for
Hi Henry,
Collector:
Typo in multiple places:
that accumulate elements - that accumulates elements
Otherwise looks good.
Paul.
On Oct 16, 2013, at 12:34 AM, Henry Jen henry@oracle.com wrote:
Hi,
Please kindly review the latest update on lambda library spec, and a few
minor code
+1
Map/ConcurrentMap.putIfAbsent/remove/replace: missing a close '}' in the doc
code snippets.
That's a good test. Needs updating to include the bug id in the meta-data.
Paul.
On Oct 18, 2013, at 9:34 PM, Mike Duigou mike.dui...@oracle.com wrote:
On Oct 17 2013, at 07:36 , Paul Sandoz
On Oct 23, 2013, at 4:06 PM, Alan Bateman alan.bate...@oracle.com wrote:
j.u.c.atomic.{Double,Long}.{Accumulator,Adder} extend a package-private class
Striped64 that does striping on 64-bit values. This super type is
Serializable by way of extending Number. Striped64 doesn't contribute
Hi
Please review:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8027316-distinct-unordered/webrev/
The fix ensures that the distinct operation, for a parallel stream, is not a
full barrier if the upstream is unordered (and not already distinct, otherwise
it is a no-op).
Thanks,
Paul.
On Oct 30, 2013, at 5:54 PM, Henry Jen henry@oracle.com wrote:
Looks good to me.
Thanks.
In the test,
Integer one = Stream.iterate(1, i - i +
1).unordered().parallel().distinct().findAny().get();
assertEquals(one.intValue(), 1);
The implementation is probably make sure this
Changeset: 18c111c17231
Author:psandoz
Date: 2013-10-31 11:59 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/18c111c17231
8027316: Distinct operation on an unordered stream should not be a barrier
Reviewed-by: henryjen, mduigou, briangoetz
!
Hi Sherman,
IMHO it is worth spending a little time getting the exception messages a little
more accurate. I have spent too many a time staring at such messages wondering
what the heck is going on :-)
e.g.
Syntax error parsing replacement string: escaped literal character is missing
at the
Hi,
I ain't got permission to publish webrevs yet. So attached is a patch produced
by hg export on the jdk tree for:
7157656 (zipfs) SeekableByteChannel to entry in zip file always reports its
position as 0
Paul.
# HG changeset patch
# User psandoz
# Date 1334594401 -3600
# Node ID
On Apr 17, 2012, at 11:50 AM, Alan Bateman wrote:
On 16/04/2012 17:55, Paul Sandoz wrote:
Hi,
I ain't got permission to publish webrevs yet. So attached is a patch
produced by hg export on the jdk tree for:
7157656 (zipfs) SeekableByteChannel to entry in zip file always reports
its
Hi Sherman,
Here is an example:
http://cr.openjdk.java.net/~psandoz/errors-in-matcher/webrev.0/
I am not sure what, if any, are the JDK guidelines for stuffing information in
exception messages.
Paul.
On Apr 16, 2012, at 10:24 AM, Paul Sandoz wrote:
Hi Sherman,
IMHO it is worth
out access.
Thanks,
Paul.
Thanks!
-Sherman
On 04/17/2012 10:02 AM, Paul Sandoz wrote:
Hi Sherman,
Here is an example:
http://cr.openjdk.java.net/~psandoz/errors-in-matcher/webrev.0/
http://cr.openjdk.java.net/%7Epsandoz/errors-in-matcher/webrev.0/
I am not sure what, if any
Hi David,
I think you can retain the same exception throwing behavior (plus no casts are
required to Field) as before by doing:
try {
field = AccessController.doPrivileged(new
PriviledgedExceptionActionField() {
public Field run() throws NoSuchFieldException {
return
said because the NoSuchFieldException has to
remain wrapped in one RuntimeException.
Yes, preferably just once :-) I was just indicating previously there were two
levels of wrapping.
Paul.
David
-
On 19/04/2012 11:53 PM, Paul Sandoz wrote:
Hi David,
I think you can retain the same
On Apr 28, 2012, at 1:01 AM, Rémi Forax wrote:
Hi Jim,
Yes, I've basically try to submit a patch each time I've written a method join
in one of my application :)
The funny think (in fact it's even not funny) is that I think that this
methods
should not be in String anymore. In Java 8,
On May 1, 2012, at 12:53 PM, Rémi Forax wrote:
On 04/30/2012 11:03 AM, Paul Sandoz wrote:
On Apr 28, 2012, at 1:01 AM, Rémi Forax wrote:
Hi Jim,
Yes, I've basically try to submit a patch each time I've written a method
join
in one of my application :)
The funny think (in fact it's
On May 2, 2012, at 8:39 AM, Stuart Marks wrote:
It's fun to think about how joining would work in a lambda/streamy kind of
world, e.g.
stream.infix(,).join(new StringBuilder()).toString()
Indeed :-) [Paul ducks as he makes up stuff!]:
String s = stream.interpose(,).reduce(new
On May 1, 2012, at 2:40 PM, Rémi Forax wrote:
Not saying join should be implemented that way (not so optimal for Strings
only) but i think such functions are very useful. I am not tracking the
lambda library work very closely, have such functions been considered?
Yes, we discuss about
Hi Rob,
I dunno if the following has been pointed out before. It's hard to track review
comments.
The implementation of Process.waitFor normalizes the end time and duration
remaining time to nano seconds. However, the Thread.sleep method expects a
duration in units of milliseconds.
You
On May 11, 2012, at 5:24 PM, Rob McKenna wrote:
For the following code:
227 long rem = end - now;
228 while (!hasExited (rem 0)) {
229 wait(TimeUnit.NANOSECONDS.toMillis(rem));
230 rem = end - System.nanoTime();
231 }
Can the
Hi Mike,
On May 23, 2012, at 7:16 AM, Mike Duigou wrote:
[3] althashing 8 webrev :
http://cr.openjdk.java.net/~mduigou/althashing8/8/webrev/
Can the private method HashMap.getForNullKey be removed?
Paul.
Hi Joe,
Looks OK to me.
Paul.
On Jun 8, 2012, at 12:27 AM, Joe Wang wrote:
The feature is: http://apache.org/xml/features/standard-uri-conformant
True: Requires that a URI has to be provided where a URI is expected.
False: Some invalid URI's are accepted as valid values when a
On Jun 12, 2012, at 1:23 AM, Joe Wang wrote:
Hi,
This is patch to make sure the cause of the error is properly reported. It
has been in jaxp since Feb.
webrev: http://cr.openjdk.java.net/~joehw/7u6/7143711/webrev/
Please review.
Looks OK to me.
Paul.
Hi Lance,
It looks OK to me, however i don't know much about JDBC. Much cleaner than
before.
Very minor point, you can shoot me for being pedantic!: from line 894 you can
do the following since the return value from pstmt.executeUpdate() is never
used:
894try {
895
On Jun 12, 2012, at 11:11 PM, Joe Wang wrote:
Looks good to me, Lance.
+1
Paul.
On Jun 13, 2012, at 1:04 PM, Lance Andersen - Oracle wrote:
Hi Paul,
Thank you for taking the time to review the code.
I made the change you suggested below
http://cr.openjdk.java.net/~lancea/7145913/webrev.02
Let me know if you are good with the change and I will get this puppy
Hi Joe,
It looks a good start.
There is duplication in the 6 factory finding classes, can some of it be
consolidated in one shared factory helper class?
Taking javax.xml.datatyoe.FactoryFinder as an example:
When iterating over the service instances you are catching ConfigurationError
264
On Jun 21, 2012, at 2:44 PM, Alan Bateman wrote:
On 21/06/2012 08:55, Joe Wang wrote:
:
webrev:
http://cr.openjdk.java.net/~joehw/jdk8/7169894/webrev/
It's great to get this work started.
The javadoc changes look okay to me and fine for this change. However there
are a few areas that
On Jun 21, 2012, at 8:02 PM, Joe Wang wrote:
On the implementation changes then I agree with Paul's comment that there is
a lot of duplication. I realize you have inherited some technical debt but
now seems a good opportunity to clean this up instead of changing
essentially the same
Hi Joe,
What happens if there is a space character or other characters in the string
that should be encoded ?
http://greenbytes.de/tech/webdav/rfc2396.html#rfc.section.2.4.3
I suspect escapeNonUSAscii is slightly misleading, it should be really called
something like
H Joe,
I just focused on javax.xml.datatype and assumed the rest follows the same
pattern :-)
Like Alan i am still not sure about swallowing the ServiceConfigurationError.
It enables something that did not work before so i guess it does not take
anything away, if choose that this should be
.
Paul.
-Joe
On 6/25/2012 9:13 AM, Paul Sandoz wrote:
Hi Joe,
What happens if there is a space character or other characters in the string
that should be encoded ?
http://greenbytes.de/tech/webdav/rfc2396.html#rfc.section.2.4.3
I suspect escapeNonUSAscii is slightly misleading
On Oct 15, 2014, at 10:57 AM, Paul Sandoz paul.san...@oracle.com wrote:
Need a sponsor to push!
I can do it later today.
I knew i should of checked before hand, i see Alan has already pushed it,
Pauk.
On Oct 14, 2014, at 8:54 PM, Vladimir Ivanov vladimir.x.iva...@oracle.com
wrote:
Paul,
Thanks for the feedback!
Updated version:
http://cr.openjdk.java.net/~vlivanov/8059877/webrev.01/
http://cr.openjdk.java.net/~vlivanov/8059877/webrev.00/
On Oct 16, 2014, at 10:43 AM, Konstantin Shefov konstantin.she...@oracle.com
wrote:
Gently reminder
On 14.10.2014 16:58, Konstantin Shefov wrote:
Hello,
Please review the test bug fix
https://bugs.openjdk.java.net/browse/JDK-8059070
Webrev is
Hi,
[Including compiler-dev, i am not on that list so please CC me if replying to
just that list]
I dropped this, then JVMLS got in the way... then J1 got in the way so i
better get to this before Devoxx gets in the way... Richard, thanks for your
continued patience.
In the interim
On Oct 22, 2014, at 5:09 PM, Kumar Srinivasan kumar.x.sriniva...@oracle.com
wrote:
Hello,
Please review fix for JDK-8061830, this is merely a refresh of the existing
source
base from upstream ObjectWeb/ASM, the webrev is here:
http://cr.openjdk.java.net/~ksrini/8061830/webrev.00/
On Oct 23, 2014, at 1:25 PM, Konstantin Shefov konstantin.she...@oracle.com
wrote:
Gently reminder
On 17.10.2014 13:38, Konstantin Shefov wrote:
Hi,
I have updated the webrev:
http://cr.openjdk.java.net/~kshefov/8059070/webrev.01/
+1
Sorry for the delay,
Paul.
, at 11:37 AM, Paul Sandoz paul.san...@oracle.com wrote:
Hi,
[Including compiler-dev, i am not on that list so please CC me if replying to
just that list]
...
So Richard has a patch for that too:
http://cr.openjdk.java.net/~rwarburton/buffer-overrides-langtools-0/langtools.patch
On Oct 28, 2014, at 1:59 PM, Joel Borggrén-Franck joel.fra...@oracle.com
wrote:
Hi Paul,
Sorry for the delay.
So if I understand this correctly, we get 4 warnings (and because of -Werror
a build failure) in langtools when compiling vs Jdk 9, but need the casts
because we bootstrap
On Nov 4, 2014, at 6:53 PM, Martin Buchholz marti...@google.com wrote:
Is it possible to make EmptyClass be a static inner class of the test? IIUC
if its enclosed within ThreadSafety it should still work with URLClassLoader.
Done. Webrev regenerated.
+1
Perhaps one reason why the test is
On Nov 5, 2014, at 6:26 AM, joe darcy joe.da...@oracle.com wrote:
Hi Martin,
This description in getGenericInterfaces
876 * p If this object represents a class, the return value is an
877 * array containing objects representing all interfaces
878 * implemented by the
On Nov 6, 2014, at 8:07 PM, Martin Buchholz marti...@google.com wrote:
Sorry, Paul, I missed your offer on the other thread to take this to
CCC. It's yours.
On Thu, Nov 6, 2014 at 10:50 AM, Martin Buchholz marti...@google.com wrote:
Hi Joe,
I'd like you to do a code review.
On Nov 10, 2014, at 10:43 AM, Paul Sandoz paul.san...@oracle.com wrote:
Please shepherd through CCC.
Kick started.
CCC has been approved,
Paul.
On Nov 19, 2014, at 11:24 AM, Vladimir Ivanov vladimir.x.iva...@oracle.com
wrote:
Aleksey, Duncan, thanks for the review and the confirmation that it doesn't
break stuff for you.
Any Reviews, please? :-)
Looks good.
Best regards,
Vladimir Ivanov
On 11/19/14, 2:23 PM, MacGregor,
On Nov 24, 2014, at 10:47 AM, Amy Lu amy...@oracle.com wrote:
Some test/tools/launcher tests have dependency on sun.tools.jar.Main
The dependency actually comes from TestHelper.java
This fix is to remove above internal JDK API dependency from the tests.
bug:
Hi Patrick,
To speed things along for now i recommend creating a new class say IOUtils or
preferably ByteStreams.
You should keep things simple for an initial iteration and just add one static
method :-) which is essentially a refined copy of the private method that Pavel
pointed out. Then
On Nov 24, 2014, at 5:34 PM, Patrick Reinhart patr...@reini.net wrote:
Hi Paul,
Am 24.11.2014 um 15:32 schrieb Paul Sandoz paul.san...@oracle.com:
Hi Patrick,
To speed things along for now i recommend creating a new class say IOUtils
or preferably ByteStreams.
Hmm, in the case
Hi Martin,
Thanks for looking into this.
1141 * Currently hotspot's implementation of a Java language-level volatile
1142 * store has the same effect as a storeFence followed by a relaxed
store,
1143 * although that may be a little stronger than needed.
IIUC to emulate hotpot's
Hi Igor,
This looks ok.
I like how you have factored out things into TimeLimitedRunner. Do you plan in
a future patch to update lambda form test code that uses similar functionality?
Is the adjustment timeout *= 0.9 necessary? does reduction by 10% make a
difference?
Paul.
On Nov 29, 2014,
On Nov 25, 2014, at 3:06 AM, Martin Buchholz marti...@google.com wrote:
I tried to address all the known problems in sun/reflect (except for
the performance ones), including the ones in Peter's webrev (although
it now looks quite different).
I broke down and switched to using
Hi,
Please find below a patch to remove the networking code computing a seed in
ThreadLocal/SplittableRandom.
We thought it a good idea at the time :-) but subsequently on certain platforms
this results in very high initalization costs that can propagate to other
classes such as
On Dec 2, 2014, at 11:10 AM, Alan Bateman alan.bate...@oracle.com wrote:
On 02/12/2014 10:02, Paul Sandoz wrote:
Hi,
Please find below a patch to remove the networking code computing a seed in
ThreadLocal/SplittableRandom.
We thought it a good idea at the time :-) but subsequently
On Dec 2, 2014, at 1:58 AM, Doug Lea d...@cs.oswego.edu wrote:
On 12/01/2014 03:46 PM, Martin Buchholz wrote:
David, Paul (i.e. Reviewers) and Doug,
I'd like to commit corrections so we make progress.
The current one looks OK to me.
On Dec 2, 2014, at 1:17 PM, Doug Lea d...@cs.oswego.edu wrote:
On 12/02/2014 05:02 AM, Paul Sandoz wrote:
Hi,
Please find below a patch to remove the networking code computing a seed in
ThreadLocal/SplittableRandom.
Thanks for pushing this through.
(I also adjusted 166 sources
On Dec 2, 2014, at 5:42 PM, Peter Levart peter.lev...@gmail.com wrote:
On 12/02/2014 11:02 AM, Paul Sandoz wrote:
Hi,
Please find below a patch to remove the networking code computing a seed in
ThreadLocal/SplittableRandom.
We thought it a good idea at the time :-) but subsequently
On Dec 2, 2014, at 5:20 PM, Vladimir Ivanov vladimir.x.iva...@oracle.com
wrote:
Thanks, Paul!
Updated webrev in place.
+1.
Paul.
Hi,
I think we may be over-rotating a little on this.
There is already a mechanism to create a cryptographically strong seed by
setting a system property and using SecureRandom. That has a high
initialization cost, but i think under those circumstances that cost is
acceptable (it may well be
On Dec 6, 2014, at 1:30 PM, Peter Levart peter.lev...@gmail.com wrote:
Now what scares me (might be that I don't have an intimacy with LambdaForm
class like you do). There is a situation where you publish LambdaForm
instances via data race.
One form of LambdaForm.transformCache is an array
On Dec 8, 2014, at 11:47 PM, Martin Buchholz marti...@google.com wrote:
Webrev updated.
Not quite sure how the webrev was updated:
http://cr.openjdk.java.net/~martin/webrevs/openjdk9/core-reflection-more-safety/
But the patch file
601 - 700 of 2479 matches
Mail list logo
