Hi Jon,
Looks good to me.
Thanks,
Serguei
On 6/4/19 2:42 PM, Jonathan Gibbons wrote:
Please review another small patch for the jdk.jdi module, to fix a
missing heading in one file and to adjust a heading in another.
No webrev; patch below.
That being said, the file
t[4]),
and
test/jdk/tools/launcher/modules/basic/LauncherErrors.java
(using the 2-arg Class::forName).
The Launcher is updated to maintain non-confusing error messages :).
The new test included with this fix ensures that 8181144[3] is
addressed. Thanks go to Serguei Spitsyn for writing the test.
Automat
Hi David,
The update looks good.
Thanks,
Serguei
On 10/29/19 9:28 PM, David Holmes wrote:
Hi Doug,
Your proposed patch wasn't quite right. I made some adjustments but
I'm still having issues with the test,
HotSpotMethodSubstitutionTest.testThreadSubstitutions, as I don't see
how to make
On Wed, 9 Sep 2020 19:29:30 GMT, Vipin Sharma wrote:
> Updated @exception with @throws for core-libs, it fixes all open sub-tasks of
> JDK-8252536.
>
> Open Subtasks part of this fix are:
> 1. JDK-8252537
> 2. JDK-8252539
> 3. JDK-8252540
> 4. JDK-8252541
>
> Previous conversation on this:
>
On Tue, 15 Sep 2020 20:02:33 GMT, Coleen Phillimore wrote:
>> The change fixes a 'deadlock' situation in
>> VM_RedefineClasses::lock_classes() when the current thread is in the middle
>> of redefining the same class. The change is based on the fix [1] suggested
>> in the Jira issue [2]
On Tue, 15 Sep 2020 20:02:38 GMT, Coleen Phillimore wrote:
>> The change fixes a 'deadlock' situation in
>> VM_RedefineClasses::lock_classes() when the current thread is in the middle
>> of redefining the same class. The change is based on the fix [1] suggested
>> in the Jira issue [2]
On Thu, 17 Sep 2020 07:45:52 GMT, Goetz Lindenmaier wrote:
>> Marked as reviewed by goetz (Reviewer).
>
> Reviewed in the good old hg times :)
> See also
> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2020-August/041453.html
src/hotspot/share/opto/macro.cpp:
@@ -1091,11 +1091,11
On Tue, 22 Sep 2020 00:38:43 GMT, Serguei Spitsyn wrote:
>> Reviewed in the good old hg times :)
>> See also
>> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2020-August/041453.html
>
> Hi Richard,
>
> Could you consider to p
On Sat, 19 Sep 2020 20:24:14 GMT, Vipin Sharma wrote:
>> Updated @exception with @throws for core-libs, it fixes all open sub-tasks
>> of JDK-8252536.
>>
>> Open Subtasks part of this fix are:
>> 1. JDK-8252537
>> 2. JDK-8252539
>> 3. JDK-8252540
>> 4. JDK-8252541
>>
>> Previous conversation
On Thu, 3 Dec 2020 22:54:54 GMT, Mandy Chung wrote:
> This patch replaces some uses of `Reference::get` to `Reference::refersTo` to
> avoid keeping a referent strongly reachable that could cause unnecessary
> delay in collecting such object. I only made change in some but not all
> classes
This change have been already reviewed by Mandy, Alan and David.
Now, the PR approval is needed.
The push was postponed because the CSR was not approved at that time (it is
now):
https://bugs.openjdk.java.net/browse/JDK-8248189
Investigation of existing popular java agents was requested by
On Tue, 10 Nov 2020 21:24:25 GMT, Harold Seigel wrote:
> Please review this small change to add a cgroups keyword to tests that use
> cgroups. The fix was tested by running Mach5 container tests.
Hi Harold,
The fix looks good.
Thanks,
Serguei
-
Marked as reviewed by sspitsyn
On Fri, 29 Jan 2021 05:14:31 GMT, Lin Zang wrote:
>> Hi Lin,
>>
>> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java
>>
>> Thank you for the update.
>>
>> The list of possible commands must include one more variant with no
>> arguments:
>> + *
On Wed, 24 Mar 2021 23:17:46 GMT, Joe Darcy wrote:
> 8264148: Update spec for exceptions retrofitted for exception chaining
Joe,
The Serviceability part looks good.
Thanks,
Serguei
-
PR: https://git.openjdk.java.net/jdk/pull/3182
On Thu, 16 Sep 2021 01:08:45 GMT, Naoto Sato wrote:
> Fixing failing regression tests caused by the JEP 400: UTF-8 by Default.
>
> `JcmdOutputEncodingTest` test case uses `file.encoding=UTF-8` in `C` locale.
> The output from the agent library is in `UTF-8` so it succeeded before the
> JEP
On Thu, 7 Oct 2021 21:46:47 GMT, Alex Menkov wrote:
> The fix adds "-XX:PerfMaxStringConstLength" argument running target app
> (default is 1024, 8K should be enough for any environments)
LGTM.
Thanks,
Serguei
-
Marked as reviewed by sspitsyn (Reviewer).
PR:
On Thu, 13 Jan 2022 14:01:04 GMT, Pavel Rappo wrote:
>> - Most of the typos are of a trivial kind: missing whitespace.
>> - If any of the typos should be fixed in the upstream projects instead,
>> please say so; I will drop those typos from the patch.
>> - As I understand it, ` ` in
On Fri, 11 Feb 2022 08:54:51 GMT, Leo Korinth wrote:
>> Remove unused imports under test/lib and jtreg/gc. They create lots of
>> warnings if editing using an IDE. Tests in hotspot_gc passed.
>
> Leo Korinth has updated the pull request incrementally with one additional
> commit since the last
On Fri, 28 Jan 2022 15:37:59 GMT, Aleksey Shipilev wrote:
> Recent test regression after adding new cases in the test. Without compressed
> oops, ~1G elements `Object[]` array takes >8G of memory, which fails the
> test. The fix cuts it down to 512M when reference size is 8 bytes.
>
On Mon, 10 Jan 2022 20:46:36 GMT, Andrey Turbanov wrote:
> `Properties.load` uses `java.util.Properties.LineReader`. LineReader already
> buffers input stream. Hence wrapping InputStream in BufferedInputStream is
> redundant.
Marked as reviewed by sspitsyn (Reviewer).
-
PR:
On Tue, 18 Jan 2022 18:33:29 GMT, Aleksey Shipilev wrote:
> While working on JDK-8280003, I noticed that
> java/lang/instrument/GetObjectSizeIntrinsicsTest.java does not test arrays
> with more than 1-byte size elements, and no large arrays (past 4G limit) are
> tested either. It would be
On Thu, 21 Apr 2022 11:22:48 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on modules owned by the serviceability team
> (`java.instrument java.management.rmi java.management jdk.attach
> jdk.hotspot.agent jdk.internal.jvmstat jdk.jcmd jdk.jconsole jdk.jdi
> jdk.jdwp.agent jdk.jstatd
On Tue, 26 Apr 2022 17:27:35 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in
On Wed, 27 Apr 2022 19:00:52 GMT, Coleen Phillimore wrote:
>> Alan Bateman has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refresh 7965cc6b168e567ac2596f2fbc3b00a7d99b7e1e
>
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 2388:
>
>>
On Wed, 4 May 2022 12:12:48 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview).
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the HotSpot VM are disabled by default
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in
31 matches
Mail list logo
