Re: RFR: 8265130: Make ConstantDesc class hierarchy sealed [v2]
On Thu, 20 May 2021 22:28:56 GMT, Mandy Chung wrote:
>> It's a permitted subclass of `ConstantDesc`, so it must be either `final`,
>> `sealed`, or `non-sealed`. Making it `non-sealed` means it can still be
>> extended.
>
> I should have made it clear. I was expecting `DynamicConstantDesc` should be
> `sealed`. Do you expect non-JDK implementation class extending
> `DynamicConstantDesc`?
>From the ConstantDesc Javadoc:
* Non-platform classes should not implement {@linkplain ConstantDesc}
directly.
* Instead, they should extend {@link DynamicConstantDesc} (as {@link EnumDesc}
* and {@link VarHandleDesc} do.)
-
PR: https://git.openjdk.java.net/jdk/pull/4135
Re: RFR: 8263561: Re-examine uses of LinkedList
On Fri, 26 Feb 2021 10:48:33 GMT, Сергей Цыпанов
wrote:
> The usage of `LinkedList` is senseless and can be replaced with either
> `ArrayList` or `ArrayDeque` which are both more compact and effective.
>
> jdk:tier1 and jdk:tier2 are both ok
src/java.base/share/classes/jdk/internal/util/jar/JarIndex.java line 154:
> 152: * @param fileName the key of the mapping
> 153: */
> 154: public List get(String fileName) {
IcedTea-Web seems to be using this method reflectively:
https://github.com/AdoptOpenJDK/IcedTea-Web/blob/master/common/src/main/java/net/adoptopenjdk/icedteaweb/jdk89access/JarIndexAccess.java#L80
-
PR: https://git.openjdk.java.net/jdk/pull/2744
Re: RFR: 8263561: Re-examine uses of LinkedList
On Fri, 21 May 2021 15:00:15 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/jdk/internal/util/jar/JarIndex.java line 154:
>>
>>> 152: * @param fileName the key of the mapping
>>> 153: */
>>> 154: public List get(String fileName) {
>>
>> IcedTea-Web seems to be using this method reflectively:
>> https://github.com/AdoptOpenJDK/IcedTea-Web/blob/master/common/src/main/java/net/adoptopenjdk/icedteaweb/jdk89access/JarIndexAccess.java#L80
>
>> IcedTea-Web seems to be using this method reflectively:
>> https://github.com/AdoptOpenJDK/IcedTea-Web/blob/master/common/src/main/java/net/adoptopenjdk/icedteaweb/jdk89access/JarIndexAccess.java#L80
>
> I assume this doesn't work with JDK 16, at least not without using
> --add-options to export jdk.internal.util.jar.
Just for completeness, they're using the add-exports:
https://github.com/AdoptOpenJDK/IcedTea-Web/blob/master/launchers/itw-modularjdk.args#L19
-
PR: https://git.openjdk.java.net/jdk/pull/2744
RFR: 8287353: Use snippet tag instead of pre tag in Javadoc of InterruptedException
8287353: Use snippet tag instead of pre tag in Javadoc of InterruptedException - Commit messages: - Use snippet tag instead of pre tag Changes: https://git.openjdk.java.net/jdk/pull/8400/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8400=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8287353 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk/pull/8400.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8400/head:pull/8400 PR: https://git.openjdk.java.net/jdk/pull/8400
Re: RFR: 8287353: Use snippet tag instead of pre tag in Javadoc of InterruptedException
On Tue, 26 Apr 2022 15:04:15 GMT, Thiago Henrique Hüpner wrote: > 8287353: Use snippet tag instead of pre tag in Javadoc of InterruptedException If this is a valid change, could someone please create a Jira issue to link to it? - PR: https://git.openjdk.java.net/jdk/pull/8400
Re: RFR: 8287353: Use snippet tag instead of pre tag in Javadoc of InterruptedException [v2]
> 8287353: Use snippet tag instead of pre tag in Javadoc of InterruptedException Thiago Henrique Hüpner has updated the pull request incrementally with one additional commit since the last revision: Fix pull request comment - Changes: - all: https://git.openjdk.java.net/jdk/pull/8400/files - new: https://git.openjdk.java.net/jdk/pull/8400/files/6d091b81..f83dde2f Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=8400=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=8400=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/8400.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8400/head:pull/8400 PR: https://git.openjdk.java.net/jdk/pull/8400
Re: RFR: 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved flags is used [v4]
> 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved > flags is used Thiago Henrique Hüpner has updated the pull request incrementally with one additional commit since the last revision: Add tests - Changes: - all: https://git.openjdk.java.net/jdk/pull/9049/files - new: https://git.openjdk.java.net/jdk/pull/9049/files/2acbedb1..c4a719e3 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=9049=03 - incr: https://webrevs.openjdk.java.net/?repo=jdk=9049=02-03 Stats: 129 lines in 1 file changed: 129 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/9049.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/9049/head:pull/9049 PR: https://git.openjdk.java.net/jdk/pull/9049
Re: RFR: 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved flags is used [v5]
> 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved > flags is used Thiago Henrique Hüpner has updated the pull request incrementally with one additional commit since the last revision: Fix test message - Changes: - all: https://git.openjdk.java.net/jdk/pull/9049/files - new: https://git.openjdk.java.net/jdk/pull/9049/files/c4a719e3..c88bc754 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=9049=04 - incr: https://webrevs.openjdk.java.net/?repo=jdk=9049=03-04 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk/pull/9049.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/9049/head:pull/9049 PR: https://git.openjdk.java.net/jdk/pull/9049
Re: RFR: 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved flags is used [v6]
> 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved > flags is used Thiago Henrique Hüpner has updated the pull request incrementally with one additional commit since the last revision: Simplify test names - Changes: - all: https://git.openjdk.java.net/jdk/pull/9049/files - new: https://git.openjdk.java.net/jdk/pull/9049/files/c88bc754..7362da92 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=9049=05 - incr: https://webrevs.openjdk.java.net/?repo=jdk=9049=04-05 Stats: 30 lines in 1 file changed: 10 ins; 3 del; 17 mod Patch: https://git.openjdk.java.net/jdk/pull/9049.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/9049/head:pull/9049 PR: https://git.openjdk.java.net/jdk/pull/9049
Re: RFR: 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved flags is used [v8]
> 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved > flags is used Thiago Henrique Hüpner has updated the pull request incrementally with one additional commit since the last revision: Fix copyright year - Changes: - all: https://git.openjdk.org/jdk/pull/9049/files - new: https://git.openjdk.org/jdk/pull/9049/files/8544abd9..962f0ec1 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=9049=07 - incr: https://webrevs.openjdk.java.net/?repo=jdk=9049=06-07 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/9049.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9049/head:pull/9049 PR: https://git.openjdk.org/jdk/pull/9049
Re: RFR: 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved flags is used [v8]
On Fri, 10 Jun 2022 18:01:24 GMT, Alan Bateman wrote: >> Thiago Henrique Hüpner has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix copyright year > > test/jdk/tools/jar/modularJar/Basic.java line 44: > >> 42: >> 43: import jdk.internal.module.ModuleReferenceImpl; >> 44: import jdk.internal.module.ModuleResolution; > > At some point we need to put in test infrastructure to avoid this and a few > other tests from depending on JDK internals. Do you think it is better to parse the output of `javap` instead of using the internals to detect if it worked? - PR: https://git.openjdk.org/jdk/pull/9049
Re: RFR: 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved flags is used [v9]
> 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved > flags is used Thiago Henrique Hüpner has updated the pull request incrementally with one additional commit since the last revision: Rename dataprovider - Changes: - all: https://git.openjdk.org/jdk/pull/9049/files - new: https://git.openjdk.org/jdk/pull/9049/files/962f0ec1..d566ebca Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=9049=08 - incr: https://webrevs.openjdk.java.net/?repo=jdk=9049=07-08 Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk/pull/9049.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9049/head:pull/9049 PR: https://git.openjdk.org/jdk/pull/9049
RFR: 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved flags is used
8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved flags is used - Commit messages: - 8287760: Keep do-not-resolve-by-default flag Changes: https://git.openjdk.java.net/jdk/pull/9049/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=9049=00 Issue: https://bugs.openjdk.org/browse/JDK-8287760 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/9049.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/9049/head:pull/9049 PR: https://git.openjdk.java.net/jdk/pull/9049
Re: RFR: 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved flags is used [v3]
> 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved > flags is used Thiago Henrique Hüpner has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Fix copyright year - Changes: - all: https://git.openjdk.java.net/jdk/pull/9049/files - new: https://git.openjdk.java.net/jdk/pull/9049/files/544ee0f7..2acbedb1 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=9049=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk=9049=01-02 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/9049.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/9049/head:pull/9049 PR: https://git.openjdk.java.net/jdk/pull/9049
Re: RFR: 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved flags is used [v2]
> 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved > flags is used Thiago Henrique Hüpner has updated the pull request incrementally with one additional commit since the last revision: Fix copyright year - Changes: - all: https://git.openjdk.java.net/jdk/pull/9049/files - new: https://git.openjdk.java.net/jdk/pull/9049/files/cd25d8ad..544ee0f7 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=9049=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=9049=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/9049.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/9049/head:pull/9049 PR: https://git.openjdk.java.net/jdk/pull/9049
Re: RFR: 8287353: Use snippet tag instead of pre tag in Javadoc of InterruptedException [v3]
> 8287353: Use snippet tag instead of pre tag in Javadoc of InterruptedException Thiago Henrique Hüpner has updated the pull request incrementally with one additional commit since the last revision: Update copyright year - Changes: - all: https://git.openjdk.java.net/jdk/pull/8400/files - new: https://git.openjdk.java.net/jdk/pull/8400/files/f83dde2f..876f45c5 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=8400=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk=8400=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/8400.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8400/head:pull/8400 PR: https://git.openjdk.java.net/jdk/pull/8400
Re: RFR: 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved flags is used [v7]
> 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved > flags is used Thiago Henrique Hüpner has updated the pull request incrementally with one additional commit since the last revision: Update author - Changes: - all: https://git.openjdk.java.net/jdk/pull/9049/files - new: https://git.openjdk.java.net/jdk/pull/9049/files/7362da92..8544abd9 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=9049=06 - incr: https://webrevs.openjdk.java.net/?repo=jdk=9049=05-06 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/9049.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/9049/head:pull/9049 PR: https://git.openjdk.java.net/jdk/pull/9049
Integrated: 8287353: Use snippet tag instead of pre tag in Javadoc of InterruptedException
On Tue, 26 Apr 2022 15:04:15 GMT, Thiago Henrique Hüpner wrote: > 8287353: Use snippet tag instead of pre tag in Javadoc of InterruptedException This pull request has now been integrated. Changeset: 7df48f97 Author: Thiago Henrique Hüpner Committer: Jaikiran Pai URL: https://git.openjdk.java.net/jdk/commit/7df48f97d23fdeba032ddec51b6a6e6ad02d14cd Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod 8287353: Use snippet tag instead of pre tag in Javadoc of InterruptedException Reviewed-by: jpai - PR: https://git.openjdk.java.net/jdk/pull/8400
