RFR 8235699 : ArrayIndexOutOfBoundsException in CalendarBuilder.toString

2019-12-12 Thread Verghese, Clive
Hi, Requesting review for JBS Issue : https://bugs.openjdk.java.net/browse/JDK-8235699 Webrev : https://cr.openjdk.java.net/~phh/8235699/webrev.00/ CalendarBuilder.toString method has a bug which causes an ArrayIndexOutOfBoundsException exception. The class is an internal jdk class that is rest

Re: RFR 8235699 : ArrayIndexOutOfBoundsException in CalendarBuilder.toString

2019-12-12 Thread Verghese, Clive
. Therefore causing an ArrayIndexOutOfBoundsException. I have updated this to display the whole array. Regards, Clive Verghese From: "Verghese, Clive" Date: Thursday, December 12, 2019 at 2:07 PM To: "[email protected]" Subject: RFR 8235699 : ArrayIndexOut

Re: RFR 8235699 : ArrayIndexOutOfBoundsException in CalendarBuilder.toString

2019-12-16 Thread Verghese, Clive
; Thank you and best regards, Volker On Fri, Dec 13, 2019 at 1:05 AM Verghese, Clive wrote: > > Additional information regarding the field array. > > It is meant to hold two arrays, the lower half holds the stamp. And the upper half holds the fields

Re: RFR 8235699 : ArrayIndexOutOfBoundsException in CalendarBuilder.toString

2019-12-31 Thread Verghese, Clive
Hi Volker, Thank you for reviewing the changes and approving. It would be great if you could sponsor the change as well. Regards, Clive Verghese From: Volker Simonis Date: Monday, December 30, 2019 at 3:13 PM To: "Verghese, Clive" Cc: Java Core Libs Subject: Re: R

Re: RFR 8235699 : ArrayIndexOutOfBoundsException in CalendarBuilder.toString(Internet mail)

2019-12-31 Thread Verghese, Clive
Paul On 12/16/19, 7:52 PM, "core-libs-dev on behalf of Verghese, Clive" wrote: Hi Volker, Thank you for the feedback. I have update the revisi

Re: RFR 8235699 : ArrayIndexOutOfBoundsException in CalendarBuilder.toString

2020-01-02 Thread Verghese, Clive
Hi Alan, Thanks for the feedback, I have removed the @Author tag and updated the tests as per your recommendation. Updated Webrev http://cr.openjdk.java.net/~phh/8235699/webrev.04/ Regards, Clive Verghsese Regards, Clive Verghese On 1/2/20, 11:19 AM, "Volker Simonis" wrote: On 0

Re: RFR 8235699 : ArrayIndexOutOfBoundsException in CalendarBuilder.toString

2020-02-04 Thread Verghese, Clive
Hi, A Reminder for review. Regards, Clive Verghese On 1/2/20, 1:18 PM, "Verghese, Clive" wrote: Hi Alan, Thanks for the feedback, I have removed the @Author tag and updated the tests as per your recommendation. Updated Webrev

Re: RFR 8235699 : ArrayIndexOutOfBoundsException in CalendarBuilder.toString

2020-02-04 Thread Verghese, Clive
Thanks, Roger On 1/2/20 4:18 PM, Verghese, Clive wrote: > Hi Alan, > > Thanks for the feedback, > > I have removed the @Author tag and updated the tests as per your recommendation. > > Updated Webrev > http://cr.openjd

Re: RFR 8235699 : ArrayIndexOutOfBoundsException in CalendarBuilder.toString

2020-02-04 Thread Verghese, Clive
> > Thanks, Roger > > > On 2/4/20 5:17 PM, Verghese, Clive wrote: >> Hi Roger, >> >> Thank you for the feedback. I have addressed your comments and >> updated the Webrev. >> http://cr.openjdk.java.net/~alvda