Hi folks,
I'd like to backport this change to JDK7. Note: this fix uses
posix_spawn by default on Mac OSX only. On Solaris fork will remain the
default behaviour.
I've just noticed that there is a problem with the testcase on Solaris
in that it will test fork twice. (and won't test
..
http://cr.openjdk.java.net/~robm/5049299/7/webrev.01/
-Rob
On 05/11/13 21:23, Rob McKenna wrote:
Hi folks,
I'd like to backport this change to JDK7. Note: this fix uses
posix_spawn by default on Mac OSX only. On Solaris fork will remain
the default behaviour.
I've just noticed
Apologies, I forgot to mention the dependency on:
8008118: (process) Possible null pointer dereference in
jdk/src/solaris/native/java/lang/UNIXProcess_md.c
http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/0111bab8dc35
-Rob
On 05/11/13 21:24, Rob McKenna wrote:
..
http://cr.openjdk.java.net
Hi Alan,
On 06/11/13 09:05, Alan Bateman wrote:
On 05/11/2013 21:37, Rob McKenna wrote:
Apologies, I forgot to mention the dependency on:
8008118: (process) Possible null pointer dereference in
jdk/src/solaris/native/java/lang/UNIXProcess_md.c
http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev
Hi David,
The only difference in 5049299 is the change in the default property
value in Solaris. Apologies for not making that clear.
-Rob
On 06/11/13 01:09, David Holmes wrote:
Hi Rob,
How different is this to the JDK 8 version?
Thanks,
David
On 6/11/2013 7:24 AM, Rob McKenna wrote
in
that regard. (not that I would anticipate any on Solaris, but I
understand the desire to be conservative)
-Rob
On 07/11/13 01:51, David Holmes wrote:
On 6/11/2013 10:00 PM, Rob McKenna wrote:
Hi David,
The only difference in 5049299 is the change in the default property
value in Solaris
will call Basic.java
with the correct parameters on each platform.
-Rob
On 07/11/13 11:46, Alan Bateman wrote:
On 06/11/2013 13:30, Rob McKenna wrote:
Yes, absolutely. I'm looking for approval for the code in principle.
Particularly the change in the default property value on Solaris
jdk.lang.Process.launchMechanism
Thanks,
David
-Rob
On 07/11/13 01:51, David Holmes wrote:
On 6/11/2013 10:00 PM, Rob McKenna wrote:
Hi David,
The only difference in 5049299 is the change in the default property
value in Solaris. Apologies for not making that clear.
Given this was primarily aimed
Hi folks,
Looking for a quick review for a test failure we're encountering.
Seemingly no bar is too high for our test infrastructure. Hopefully this
will put this particular failure to rest.
http://cr.openjdk.java.net/~robm/8022206/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8022206
Changeset: 63b696dafc8a
Author:robm
Date: 2013-11-19 15:36 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/63b696dafc8a
8022206: Intermittent test failures in java/lang/ProcessBuilder/Basic.java
Reviewed-by: chegar, alanb
! test/java/lang/ProcessBuilder/Basic.java
Hi folks,
Running this test with fastdebug binaries results in a few warning
messages getting lumped into the commandOutput. I've decided to filter
these test wide.
https://bugs.openjdk.java.net/browse/JDK-6703075
http://cr.openjdk.java.net/~robm/6703075/webrev.01/
-Rob
wrote:
On 19/11/2013 16:46, Rob McKenna wrote:
Hi folks,
Running this test with fastdebug binaries results in a few
warning messages getting lumped into the commandOutput.
I've decided to filter these test wide.
https
Changeset: 89fccc5a7469
Author:martin
Date: 2013-11-21 16:06 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/89fccc5a7469
6703075: (process) java/lang/ProcessBuilder/Basic.java fails with fastdebug
Reviewed-by: alanb
! test/java/lang/ProcessBuilder/Basic.java
This failure cropped up again and Roger Riggs spotted that I was looking
at it from completely the wrong direction. He contributed the following fix:
http://cr.openjdk.java.net/~robm/8029525/webrev.01/
This is to avoid a race between:
thread.interrupt();
p.destroy();
Hoping to get this
Changeset: 72ea199e3e1b
Author:robm
Date: 2013-12-05 16:19 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/72ea199e3e1b
8029525: java/lang/ProcessBuilder/Basic.java fails intermittently
Reviewed-by: alanb, chegar
Contributed-by: roger.ri...@oracle.com
!
Hi folks,
When files are copied by our test harness the permissions are left
unchanged. This can cause trouble for a few tests when the test folder
is read only.
http://cr.openjdk.java.net/~robm/7152892/webrev.01/
-Rob
Changeset: da4b0962ad11
Author:robm
Date: 2014-02-10 14:35 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/da4b0962ad11
7152892: some jtreg tests fail with permission denied
Reviewed-by: coffeys
! test/java/lang/ClassLoader/Assert.sh
!
Sorry Mandy, I totally missed your reply. I'll get this resolved separately.
-Rob
On 10/02/14 15:43, Mandy Chung wrote:
On 2/7/2014 10:44 AM, Rob McKenna wrote:
Hi folks,
When files are copied by our test harness the permissions are left
unchanged. This can cause trouble for a few
Hi folks,
I'd like to push this change into JDK8 7. There is other work going on
in 9 which will supersede this fix so there is likely no point in
pushing to that release.
This is backport of the threadpool specific changes from
https://bugs.openjdk.java.net/browse/JDK-6944584 along with
..just realised I had an out of date webrev up there, I've just updated
in place in case anyone is looking at it.
-Rob
On 21/03/14 17:43, Rob McKenna wrote:
Hi folks,
I'd like to push this change into JDK8 7. There is other work going
on in 9 which will supersede this fix so
and overhead) seem to increase over time.
But I'd put that into a separate change.
Thanks for the comment, I'll take an AI.
-Rob
On Fri, Mar 21, 2014 at 11:23 AM, Rob McKenna rob.mcke...@oracle.com
mailto:rob.mcke...@oracle.com wrote:
..just realised I had an out of date webrev up
Hi folks,
Roger Riggs (cc'd) may want to chip in here as he's looking at the
reaper thread arrangement in 9 at the moment.
On another note, I too support the merging of those files. I didn't
think there was much appetite for it at the time so I must admit this
fell down my todo list.
Hi Peter,
Yup, I'll give this a whirl.
-Rob
On 01/04/14 14:16, Peter Levart wrote:
Hi Alan, Volker,
Thanks for sharing the info and for testing on AIX. Here's the updated
webrev that hopefully includes the correct dispatch on os.name
logic. I included Solaris as an alternative to SunOS
Mac OSX testing was clean.
-Rob
On 01/04/14 16:43, Peter Levart wrote:
On 04/01/2014 03:49 PM, roger riggs wrote:
Hi Peter,
The design using enum for the os dependencies does not make it possible
to include only the support needed for a particular platform at build
time.
Every
Great to see this getting in. Thanks Peter!
-Rob
On 12/05/14 16:51, Peter Levart wrote:
On 05/07/2014 11:04 PM, Martin Buchholz wrote:
Hi Peter,
Your last version version looks very good. Approved! I'm reduced to
asking you to fix ancient buglets of mine.
*I'd spell creat with an
Hi folks,
A simple fix to eliminate a possible infinite loop when an Ldap
Connection cannot contact the server.
http://cr.openjdk.java.net/~robm/8042857/webrev.01/
-Rob
Hi folks,
Very simple fix to ensure that a slow server isn't left waiting around
for a request we have already given up on.
http://cr.openjdk.java.net/~robm/8041451/webrev.01/
-Rob
Hi folks,
Looking for a review for the following:
bug: https://bugs.openjdk.java.net/browse/JDK-7130985
webrev: http://cr.openjdk.java.net/~robm/7130985/webrev.01/
As per the bug report: The IDLtoJava spec clearly specifies the need of
the helper class (not the Holder) for these files. But
Hi folks,
A very simple change suggested by Martin a while back in another review.
I'm just getting around to it now:
bug: https://bugs.openjdk.java.net/browse/JDK-8050044
webrev: http://cr.openjdk.java.net/~robm/8050044/webrev.01/
Martins comments:
And as in that review you have managed to intercept me before I made a
small correction. In this case to the subject.
I'm beginning to suspect you're a highly sophisticated bot.
-Rob
On 15/07/14 18:48, Martin Buchholz wrote:
Looks good to me!
On Tue, Jul 15, 2014 at 10:46 AM, Rob
of
the existing 32k is being used?
The reaper has very limited processing to do and there is one thread
for every process spawned.
Roger
On 7/15/2014 1:46 PM, Rob McKenna wrote:
Hi folks,
A very simple change suggested by Martin a while back in another
review. I'm just getting around
32k is being used?
The reaper has very limited processing to do and there is one thread for
every process spawned.
Roger
On 7/15/2014 1:46 PM, Rob McKenna wrote:
Hi folks,
A very simple change suggested by Martin a while back in another review.
I'm just getting around to it now:
bug: https
Hi folks,
It seems that with the testing of fastdebug and -Xcomp modes we're
stretching the limits set by the test. Timeout wack-a-mole continues:
http://cr.openjdk.java.net/~robm/8030166/webrev.01/
-Rob
; but I'm not keen on having the timeouts vary
by architecture.
I'd just increase it for all.
Roger
On 7/24/2014 4:57 PM, Rob McKenna wrote:
Hi folks,
It seems that with the testing of fastdebug and -Xcomp modes we're
stretching the limits set by the test. Timeout wack-a-mole continues:
http
Changeset: ecc5dd3790a1
Author:robm
Date: 2012-07-02 19:32 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ecc5dd3790a1
7174887: Deadlock in jndi ldap connection cleanup
Reviewed-by: xuelei
! src/share/classes/com/sun/jndi/ldap/Connection.java
!
http://cr.openjdk.java.net/~robm/7179305/webrev.01/
http://cr.openjdk.java.net/%7Erobm/7179305/webrev.01/
Thanks,
-Rob
Changeset: 516e0c884af2
Author:robm
Date: 2012-07-09 22:26 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/516e0c884af2
7179305: (fs) Method name sun.nio.fs.UnixPath.getPathForExecptionMessage is
misspelled
Reviewed-by: dholmes, chegar
!
Hi folks,
Looking for a codereview for a spec change in jdk8.
In summary, when a java application is run as root it can perform file
operations regardless of the permissions attributed to that file. I.e.
canExecute, canRead, canWrite would return true even though the File may
not have those
Changeset: da14e2c90bcb
Author:robm
Date: 2012-08-15 22:46 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/da14e2c90bcb
6931128: (spec) File attribute tests fail when run as root.
Reviewed-by: alanb
! src/share/classes/java/io/File.java
! test/java/io/File/Basic.java
!
Hi folks,
One of the tests from 4244896 failed once during nightly testing. It
isn't known how much of a delay will be necessary in order for it to
pass. In any case the tolerance can't really be loosened much more
without making the test meaningless so I've decided to remove it.
, David Holmes wrote:
Hi Rob,
On 16/08/2012 9:09 AM, Rob McKenna wrote:
Hi folks,
One of the tests from 4244896 failed once during nightly testing. It
isn't known how much of a delay will be necessary in order for it to
pass. In any case the tolerance can't really be loosened much more
without
Changeset: 59aa7660ade4
Author:robm
Date: 2012-08-20 14:52 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/59aa7660ade4
7191777: test/java/lang/ProcessBuilder/Basic.java failing intermittently due to
additions for 4244896
Reviewed-by: dholmes, alanb
!
Changeset: 11a5da68673c
Author:robm
Date: 2012-09-27 22:35 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11a5da68673c
7199862: Make sure that a connection is still alive when retrieved from
KeepAliveCache in certain cases
Reviewed-by: chegar
!
Changeset: bba370caafad
Author:robm
Date: 2012-10-04 19:53 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bba370caafad
7184932: Remove the temporary Selector usage in the NIO socket adapters
Reviewed-by: alanb
! make/java/nio/mapfile-bsd
! make/java/nio/mapfile-linux
!
this is not an issue, I think.
Martin
On Thu, Oct 4, 2012 at 12:39 AM, Alan Bateman alan.bate...@oracle.com
mailto:alan.bate...@oracle.com wrote:
On 03/10/2012 22:44, Rob McKenna wrote:
Hi folks,
The only way I can see this test failing in this manner[*] is
if we
actually exercised
that code due to my while loop implementation and the fact that the
problem wasn't reproducing. Thanks for spotting that.
-Rob
Thanks,
Martin
On Sun, Oct 7, 2012 at 12:48 PM, Rob McKenna rob.mcke...@oracle.com
mailto:rob.mcke...@oracle.com wrote:
Thanks Martin
Hi folks,
Managed to remove the Thread.sleep(10) from the test when fixing
7152183. Sorry about that.
http://cr.openjdk.java.net/~robm/8000817/webrev.01/
http://cr.openjdk.java.net/%7Erobm/8000817/webrev.01/
-Rob
that. I'm not sure what happens on macosx or
windows - you might want to think about that.
Martin
On Fri, Oct 12, 2012 at 1:18 PM, Rob McKenna rob.mcke...@oracle.com
mailto:rob.mcke...@oracle.com wrote:
Sorry for not responding sooner, I was out for the evening.
I threw this fix into our
Changeset: c0736b62160e
Author:robm
Date: 2012-10-15 22:34 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c0736b62160e
8000487: Java JNDI connection library on ldap conn is not honoring configured
timeout
Reviewed-by: vinnie
!
RFE was previously listed under JDK8 features,
but now it's gone.[2]
And I can't find any information about getPid() being dropped from JDK8
either.
In his review request for the System.killProcess part of this RFE, Rob
McKenna wrote:
As per the bug report the toString/pid work has been left
.
Essentially, return in String form what humans would use to identify
processes on the machine, which might be e.g. NODENAME:NNN on a
cluster.
Martin
On Thu, Nov 15, 2012 at 2:08 AM, Alan Bateman
alan.bate...@oracle.comwrote:
On 15/11/2012 01:11, Rob McKenna wrote:
Hi Thomas,
Don't ask me why
Hi folks,
Looking to backport these changes to the test makefiles to jdk7. As per
Alans original mail:
This one is a small clean-up of the test targets defined in
jdk/test/Makefile. The union of the tests executed by each of the make
targets should be the entire test suite but this isn't
Hi folks,
Looking for a review for the webrev below, which also resolves:
7175692: (process) Process.exec should use posix_spawn [macosx]
For additional context and a brief description it would be well worth
looking at the following thread started by Michael McMahon, who did the
brunt of the
I'll put a test together for this before sending out another review. I
was sure I had some sort of issue with this in testing before, but
perhaps it was IPC related.
-Rob
On 27/11/12 17:48, Alan Bateman wrote:
On 27/11/2012 17:45, Martin Buchholz wrote:
On Tue, Nov 27, 2012 at 3:06
Changeset: 40311b5f478f
Author:robm
Date: 2012-11-28 00:47 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/40311b5f478f
8003597: TEST_BUG: Eliminate dependency on javaweb from closed net tests
Reviewed-by: chegar
+ test/java/net/ResponseCache/Test.java
+
Hi folks,
According to HttpCookie.java:
There are 3 http cookie specifications:
Netscape draft
RFC 2109 -/http://www.ietf.org/rfc/rfc2109.txt/
RFC 2965 -/http://www.ietf.org/rfc/rfc2965.txt/
HttpCookie class can accept all these 3 forms of syntax.
According to
Hi folks,
There's a missing folder in the jdk_other test target:
http://cr.openjdk.java.net/~robm/8004337/webrev.01/
http://cr.openjdk.java.net/%7Erobm/8004337/webrev.01/
-Rob
'cal.set(1970, 0, 1, 0, 0, 0)' be inside the for loop?
The test can simply throw Exception, rather can catching.
Otherwise, looks fine to me.
-Crhis.
On 06/12/2012 21:19, Rob McKenna wrote:
Hi folks,
According to HttpCookie.java:
There are 3 http cookie specifications:
Netscape draft
RFC 2109
Changeset: 68374c6e65c1
Author:robm
Date: 2012-12-12 15:57 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/68374c6e65c1
8004337: java/sql tests aren't run in test/Makefile
Reviewed-by: lancea, alanb
! test/Makefile
Hi folks,
This review contains:
8003898: X11 toolkit can be chosen as the default toolkit
7162111: TEST_BUG: change tests run in headless mode [macosx] (open)
8004928: TEST_BUG: Reduce dependence of CoreLib tests from the AWT subsystem
Unfortunately the last two patches didn't apply cleanly,
/pipermail/core-libs-dev/2009-June/001747.html
-Rob
On 30/11/12 03:48, Rob McKenna wrote:
Hi David,
On 30/11/12 02:31, David Holmes wrote:
Hi Rob,
This is only a superficial scan.
The changes in java/java/makefile look pretty horrible. What are all
those -R entries?
Library search paths
to earlier threads are well worth reading for
additional context:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-November/012417.html
http://mail.openjdk.java.net/pipermail/core-libs-dev/2009-June/001747.html
-Rob
On 30/11/12 03:48, Rob McKenna wrote:
Hi
Simple enough fix but to be honest I'm not sure any value will *always*
work for the dead process waitFor(). Our testing infrastructure seems to
glide past whatever we consider to be acceptable tolerances.
http://cr.openjdk.java.net/~robm/8005618/webrev.01/
Changeset: 44d6cabc9a3f
Author:robm
Date: 2013-01-15 19:58 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/44d6cabc9a3f
8005618: TEST_BUG: java/lang/ProcessBuilder/Basic.java failing intermittently
Reviewed-by: alanb, martin, dholmes
!
Hi Erik, I can take care of this later this evening.
-Rob
On 23/01/13 15:16, Eric McCorkle wrote:
I'm not a committer, so I need someone to push this changeset for me.
Thanks,
Eric
/7162111/webrev.02/
-Rob
On 20/12/12 22:11, Stuart Marks wrote:
On 12/19/12 12:32 AM, Alan Bateman wrote:
On 17/12/2012 18:46, Rob McKenna wrote:
Hi folks,
This review contains:
8003898: X11 toolkit can be chosen as the default toolkit
7162111: TEST_BUG: change tests run in headless mode
Yup, all affected tests pass in both jprt and via an ssh session to a mac.
-Rob
On 25/01/13 16:07, Alexey Utkin wrote:
Looks good. Did you test the fix in ssh session to Mac?
-uta
On 25.01.2013 19:37, Rob McKenna wrote:
Had a chat with Alexey off list. Since 7162111 is indeed required
Changeset: f5c85c0a9af0
Author:robm
Date: 2013-03-14 00:21 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f5c85c0a9af0
8009650: HttpClient available() check throws SocketException when connection
has been closed
Reviewed-by: chegar, khazra, dsamersoff
Contributed-by:
Changeset: 3f8fbb0ab155
Author:robm
Date: 2013-03-21 17:33 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3f8fbb0ab155
8009251: Add proxy handling and keep-alive fixes to jsse
Reviewed-by: chegar
! src/share/classes/sun/net/www/http/HttpClient.java
!
Hi folks,
Looking for a review of this suggested fix from Fujitsu.
GetFileAttributesExW() returns ERROR_SHARING_VIOLATION for pagefile.sys
and hiberfi.sys so we're falling back to FindFirstFile instead:
http://cr.openjdk.java.net/~robm/7038105/webrev.01/
-Rob
http://cr.openjdk.java.net/~robm/7038105/webrev.03/
-Rob
On 24/05/13 16:48, Alan Bateman wrote:
On 24/05/2013 16:11, Rob McKenna wrote:
Thanks Alan,
Updated webrev at: http://cr.openjdk.java.net/~robm/7038105/webrev.02/
-Rob
This looks much better except that I assume it should only
Will do Alan, thanks. If its ok I'll just do this with the push as
opposed to posting another review.
-Rob
On 24/05/13 18:06, Alan Bateman wrote:
On 24/05/2013 17:50, Rob McKenna wrote:
http://cr.openjdk.java.net/~robm/7038105/webrev.03/
-Rob
Good, it's right now.
Just a few
Hi folks,
When fixing 7038105 I overlooked the fact I should have use FindClose
instead of CloseHandle after calling FindFirstFileW:
http://msdn.microsoft.com/en-us/library/windows/desktop/aa364418%28v=vs.85%29.aspx
http://cr.openjdk.java.net/~robm/8016063/webrev.01/
Thanks,
-Rob
Changeset: d28f802ce914
Author:robm
Date: 2013-06-06 22:22 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d28f802ce914
8016063: getFinalAttributes should use FindClose
Reviewed-by: alanb
! src/windows/native/java/io/WinNTFileSystem_md.c
Hi folks,
As per the bug:
JAXP must be buildable using JDK7 as the bootdir. Unfortunately
http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/659828443145 calls a method
that only exists in 8. (Double.isFinite())
This element of the changeset needs to be reverted.
Changeset: 2707f600a096
Author:robm
Date: 2013-06-15 09:26 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/2707f600a096
8016701: JAXP Build failure
Reviewed-by: darcy, wetmore, alanb, chegar
! src/com/sun/org/apache/xalan/internal/xsltc/runtime/BasisLibrary.java
Some interesting conversations were had lately about shell scripts
during Joe Darcy's recent infrastructure tech talk. In particular around
the idea of a jdk.testing package to provide libraries that would help
with the types of operations seen in shell scripts. I'm really hoping to
spend some
Erik for a build review.
http://cr.openjdk.java.net/~robm/5049299/webrev.04/
-Rob
On 02/07/13 16:41, Alan Bateman wrote:
On 23/12/2012 01:19, Rob McKenna wrote:
Hi Martin, thanks a lot for this.
I've renamed LINKFLAG to the more appropriate (and common) ARCHFLAG.
It seems to pop up all
Changeset: 607fa1ff3de2
Author:bpb
Date: 2013-07-09 11:26 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/607fa1ff3de2
6178739: (fmt) Formatter.format(%0.4f\n, 56789.456789) generates
MissingFormatWidthException
Summary: Change the field width specification to require a
Hi Alexey,
I've just had a look at the webrev. Looks good. Unfortunately I'm not a
reviewer here so the only benefit was for my education I'm afraid. It
would be great to get Alan's input next week.
For the benefit of the alias: I had asked Alexey if an intermediate
launcher akin to the one
): $(LINK_JSPAWNHELPER_OBJECTS)
/Erik
On 2013-07-04 15:41, Rob McKenna wrote:
Hi Alan,
I've just uploaded the latest changes which rebase the fix to the
current repo. (required post 8008118) I've also swapped out useFork
for jdk.lang.Process.launchMechanism. (it affords us the flexibility
to enable or disable other
-normal-server-release/jdk/bin/java
FDLeakTest
21360 --- this is the pid
10
3010
358
3358
850
3850
1288
4288
1636
4636
10
-Rob
On 28/07/13 22:18, Alan Bateman wrote:
On 25/07/2013 09:17, Rob McKenna wrote:
Thanks a lot Erik,
I've added the dependency to the makefile here:
http
Changeset: a4b0be7341ef
Author:robm
Date: 2013-08-13 19:10 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a4b0be7341ef
5049299: (process) Use posix_spawn, not fork, on S10 to avoid swap exhaustion
Reviewed-by: alanb, dholmes, martin, erikj, coffeys
!
Hi folks,
Looking to backport this fix to JDK7. The backport has resulted in
relatively minor changes to the original fix such as replicating the
BiFunction / Supplier interfaces in a limited sense as inner classes in
WeakCache.
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7123493
...and the actual webrev:
http://cr.openjdk.java.net/~robm/7123493/webrev.01/
http://cr.openjdk.java.net/%7Erobm/7123493/webrev.01/
-Rob
On 15/09/13 00:21, Rob McKenna wrote:
Hi folks,
Looking to backport this fix to JDK7. The backport has resulted in
relatively minor changes
Yep.
-Rob
On 07/10/13 14:24, Alan Bateman wrote:
On 04/10/2013 16:10, Rob McKenna wrote:
Hi Pavel,
Thanks for sorting this out. I'm not a reviewer but hopefully Alan
will have a look when he gets a chance. Based on the bug description
this looks good to me though.
-Rob
I looked
Changeset: f1e31376f419
Author:robm
Date: 2013-10-09 00:10 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f1e31376f419
7180557: InetAddress.getLocalHost throws UnknownHostException on java7u5 on OSX
webbugs
Reviewed-by: chegar, dsamersoff
!
Changeset: d8eec0e3a023
Author:robm
Date: 2013-10-16 15:06 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d8eec0e3a023
8026245: InetAddress.getLocalHost crash if IPv6 disabled (macosx)
Reviewed-by: chegar, alanb
! src/solaris/native/java/net/Inet4AddressImpl.c
!
Yup.
-Rob
On 16/10/13 17:50, Alan Bateman wrote:
On 16/10/2013 17:31, Pavel Punegov wrote:
Alan,
I've updated the fix. New changes are:
1. Make processB fail if interrupted,
2. Replace Error throwing by RuntimeException.
Here is a link to webrev:
The question around a manual test is interesting. I've never seen a
precedent for this. I think it should be relatively simple to include a
manual test in the repo and make sure it doesn't get run by jtreg, (by
altering the regular jtreg directives) but I wasn't aware that it was an
option.
Changeset: 8d1d5a5aeb41
Author:robm
Date: 2013-10-18 16:28 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8d1d5a5aeb41
8024660: TEST_BUG: java/lang/ProcessBuilder/*IOHandle.java leaving hotspot.log
open in fastdebug builds
Reviewed-by: alanb
Contributed-by:
Happy to vounteer for sponsorship duties. Been following this from the
sidelines.
-Rob
On 22/10/13 20:01, Alan Bateman wrote:
On 18/10/2013 17:00, Ivan Gerasimov wrote:
Thank you Martin for the references.
I've implemented passing the limitation to the application in a
similar manner.
Changeset: e2ec05b2ed94
Author:igerasim
Date: 2013-10-23 15:37 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e2ec05b2ed94
8024521: (process) Async close issues with Process InputStream
Reviewed-by: psandoz, martin, alanb, robm
!
Looks good.
-Rob
On 17/10/11 18:29, Alan Bateman wrote:
Seán Coffey wrote:
bug ID : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7101658
(bug report not visible yet)
changes for 7082769 fix have led to behavioral changes which can lead
to native file descriptor exhaustion.
webrev : http://cr.openjdk.java.net/~robm/7095949/webrev.00/
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7095949
-Rob
Hi folks,
I'm hoping for some feedback on the above. Webrev:
http://cr.openjdk.java.net/~robm/4244896/webrev.00/
This bug adds two abstract methods to Process.java with the intention of:
1) providing a facility to implement a destroyForcibly method. In
practical terms this means provide a
STILL_ACTIVE as an error code on their own.
- Test updated to allow for proper execution of shell script.
-Rob
On 12/04/12 10:05, Alan Bateman wrote:
On 12/04/2012 00:48, Rob McKenna wrote:
Hi folks,
I'm hoping for some feedback on the above. Webrev:
http://cr.openjdk.java.net/~robm/4244896
code on their own.
- Test updated to allow for proper execution of shell script.
-Rob
On 12/04/12 10:05, Alan Bateman wrote:
On 12/04/2012 00:48, Rob McKenna wrote:
Hi folks,
I'm hoping for some feedback on the above. Webrev:
http://cr.openjdk.java.net/~robm/4244896/webrev.00
I've uploaded another webrev to:
http://cr.openjdk.java.net/~robm/4244896/webrev.02/
http://cr.openjdk.java.net/%7Erobm/4244896/webrev.02/
I plan to spend some time over the coming day or two beefing up the test
for waitFor (right now its really geared towards destroyForcibly) so I
won't
of the change.
-Rob
On 20/04/12 02:53, David Holmes wrote:
Hi Rob,
On 20/04/2012 11:33 AM, Rob McKenna wrote:
I've uploaded another webrev to:
http://cr.openjdk.java.net/~robm/4244896/webrev.02/
http://cr.openjdk.java.net/%7Erobm/4244896/webrev.02/
I'll take a look as soon as I have a chance
1 - 100 of 182 matches
Mail list logo
