On Mon, 8 Nov 2021 18:59:06 GMT, Сергей Цыпанов wrote:
>> This is a follow-up for https://github.com/openjdk/jdk/pull/4507, looks like
>> there are some cases that were not covered.
>>
>> Also this is related to https://github.com/openjdk/jdk/pull/3615
>
> Сергей Цыпанов has updated the pull re
On Fri, 15 Oct 2021 18:51:44 GMT, Andrey Turbanov wrote:
> Non-static classes hold a link to their parent classes, which can be avoided.
LGTM
-
Marked as reviewed by rriggs (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5971
On Wed, 10 Nov 2021 17:28:05 GMT, Joe Wang wrote:
>> Add setProperty/getProperty methods to the XPath API so that properties can
>> be supported in the future.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> adjust wording
Lo
On Sun, 17 Oct 2021 21:06:44 GMT, Andrey Turbanov wrote:
> Non-static classes hold a link to their parent classes, which can be avoided.
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5983
On Sun, 26 Sep 2021 15:10:52 GMT, Andrey Turbanov wrote:
> In couple of classes, result part of arrays of Pattern.split is compared with
> `null`. Pattern.split (and hence String.split) never returns `null` in array
> elements. Such comparisons are redundant.
Marked as reviewed by rriggs (Revi
On Thu, 7 Oct 2021 18:00:33 GMT, Andrey Turbanov wrote:
> Pass cause exception as constructor parameter is shorter and easier to read.
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5854
et(name, val) should have a
> throws ClassNotFoundException and a ClassNotFoundException exception should
> be thrown.
Roger Riggs has updated the pull request incrementally with three additional
commits since the last revision:
- Merge branch '8276665-readfields-cnfe' of https
On Mon, 15 Nov 2021 17:28:30 GMT, Roger Riggs wrote:
> The ObjectInputStream.GetField.get(String name, Object val) method is
> returning null instead of throwing an exception when the class of the object
> is not found. The caller is not able to correctly handle the case where the
&
The ObjectInputStream.GetField.get(String name, Object val) method is returning
null instead of throwing an exception when the class of the object is not
found. The caller is not able to correctly handle the case where the class is
not found. The signature of GetField.get(name, val) should have
On Tue, 16 Nov 2021 21:09:08 GMT, Naoto Sato wrote:
>> Fixing the default charset for PrintWriter/OutputStreamWriter that wraps a
>> PrintStream to its charset. This issue was raised during the conversations
>> in https://github.com/openjdk/jdk/pull/5771
>> A corresponding CSR has also been dra
On Tue, 9 Nov 2021 15:48:22 GMT, Roger Riggs wrote:
> When set on the command line `jdk.serialFilter` to an invalid value, the
> invalid value is logged but the application is allowed to start without
> setting the filter.
> This leaves the application without the protections o
On Tue, 16 Nov 2021 18:08:08 GMT, Naoto Sato wrote:
>> Fixing the default charset for PrintWriter/OutputStreamWriter that wraps a
>> PrintStream to its charset. This issue was raised during the conversations
>> in https://github.com/openjdk/jdk/pull/5771
>> A corresponding CSR has also been dra
On Fri, 12 Nov 2021 21:43:42 GMT, Roman Kennke wrote:
> The caches in ObjectStreamClass basically map WeakReference to
> SoftReference, where the ObjectStreamClass also references
> the same Class. That means that the cache entry, and thus the class and its
> class-loader, will not get reclaim
On Wed, 20 Oct 2021 21:57:29 GMT, Roger Riggs wrote:
> The ObjectInputStream.GetField method `get(String name, Object val)` should
> have been throwing
> a ClassNotFoundException if the class was not found. Instead the
> implementation was returning null.
> A design error doe
On Fri, 29 Oct 2021 15:35:50 GMT, Roger Riggs wrote:
>> The ObjectInputStream.GetField method `get(String name, Object val)` should
>> have been throwing
>> a ClassNotFoundException if the class was not found. Instead the
>> implementation was returning null.
>>
On Wed, 10 Nov 2021 02:06:42 GMT, Jaikiran Pai wrote:
>> When set on the command line `jdk.serialFilter` to an invalid value, the
>> invalid value is logged but the application is allowed to start without
>> setting the filter.
>> This leaves the application without the protections of the seria
On Thu, 11 Nov 2021 13:34:21 GMT, Jim Laskey wrote:
> "There is also an interface RandomGenerator.ArbitrarilyJumpableGenerator for
> algorithms that allow jumping along the state cycle by any user-specified
> distance. In this package, implementations of these interfaces include
> "Xoroshiro12
On Thu, 11 Nov 2021 13:54:37 GMT, Jim Laskey wrote:
> Documentation in `RandomGenerator.rngs()` refers to
> `JumpableGenerator.jump()` when it should be `JumpableGenerator.jumps()`
The change is ok but you'll need to update the title to refer to the original
issue:
JDK-8273792
The CSR can't
On Fri, 12 Nov 2021 12:25:20 GMT, Pavel Rappo wrote:
> Please review this simple two-hunk fix to the documentation comment of
> java.util.Properties#load(java.io.Reader). The first hunk (line/lines) is a
> suggestion. I believe it reads better since the plurality is more idiomatic;
> native En
On Wed, 10 Nov 2021 13:57:21 GMT, Claes Redestad wrote:
> This changes the specification of `DateTimeFormatterBuilder.appendFraction`
> to more clearly specify that the formatter will throw an exception if you
> attempt to print a value outside of the value range of the given field.
> Changes
On Tue, 9 Nov 2021 22:29:12 GMT, Naoto Sato wrote:
> Simple doc clarification where the `toString()` output only conforms to ISO
> 8601 if the seconds in the offset are zero.
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6321
On Tue, 9 Nov 2021 16:05:52 GMT, Roger Riggs wrote:
> The java/lang/RuntimeTests/exec/ExecWithDir test forks 500 subprocesses
> hoping to trigger an intermittent problem fixed in 2002.
>
> The test can be removed, it does not exercise the condition it was created
> for.
This p
On Tue, 9 Nov 2021 19:38:01 GMT, Naoto Sato wrote:
>> Please review the subject fix. In light of JEP400, Java runtime can/should
>> start in UTF-8 charset if the underlying native encoding is not supported.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit s
The java/lang/RuntimeTests/exec/ExecWithDir test forks 500 subprocesses hoping
to trigger an intermittent problem fixed in 2002.
The test can be removed, it does not exercise the condition it was created for.
-
Commit messages:
- 8276880: Remove java/lang/RuntimeTests/exec/ExecWith
When set on the command line `jdk.serialFilter` to an invalid value, the
invalid value is logged but the application is allowed to start without setting
the filter.
This leaves the application without the protections of the serial filter.
The specification should be clarify that an `ExceptionInIn
On Fri, 22 Oct 2021 08:03:34 GMT, Hendrik Schreiber
wrote:
> Trivial improvement.
>
> Explicitly show how to create a `Cleaner` instance using `Cleaner.create()`.
> Repeat (again) in the code example that the `State` `Runnable `should be
> implemented as static class and not reference the inst
On Mon, 8 Nov 2021 19:40:20 GMT, Hendrik Schreiber
wrote:
>> src/java.base/share/classes/java/lang/ref/Cleaner.java line 90:
>>
>>> 88: * public class CleaningExample implements AutoCloseable {
>>> 89: *// A cleaner, preferably one shared within a library
>>> 90: *private sta
On Wed, 3 Nov 2021 14:09:13 GMT, Roger Riggs wrote:
> The three `java.lang.Runtime.exec` methods that tokenize a command line to
> produce an array of string arguments are easily misused, sometimes with
> erroneous results. For example, on some operating systems, spaces are
>
respecting quotes but it is
> undocumented.
Roger Riggs has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains three additional commits since
the last revision:
On Fri, 5 Nov 2021 17:31:50 GMT, Naoto Sato wrote:
> Please review the subject fix. In light of JEP400, Java runtime can/should
> start in UTF-8 charset if the underlying native encoding is not supported.
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/
On Thu, 4 Nov 2021 13:54:37 GMT, Pavel Rappo wrote:
>> This PR fixes two sentences which conflate a string with its length, and
>> also makes the "equivalency wording" consistent.
>>
>> There are many ways to fix "the resulting String may be a different length
>> than the original String". The
The three `java.lang.Runtime.exec` methods that tokenize a command line to
produce an array of string arguments are easily misused, sometimes with
erroneous results. For example, on some operating systems, spaces are supported
in filenames and are in common use.
The tokenization uses only white
On Wed, 3 Nov 2021 11:58:42 GMT, Pavel Rappo wrote:
> This PR fixes two sentences which conflate a string with its length, and also
> makes the "equivalency wording" consistent.
>
> There are many ways to fix "the resulting String may be a different length
> than the original String". The prop
On Tue, 2 Nov 2021 16:30:56 GMT, Pavel Rappo wrote:
> This PR follows up one of the recent PRs, where I used a non-canonical
> modifier order. Since the problem was noticed [^1], why not to address it at
> mass?
>
> As far as I remember, the first mass-canonicalization of modifiers took place
On Tue, 2 Nov 2021 18:48:06 GMT, Mark Sheppard wrote:
>> Here's a bit of archaeology. I found the original JDK-8136583 patch, which
>> has moved from where it was in the RFR to
>> https://cr.openjdk.java.net/~martin/webrevs/jdk9/blessed-modifier-order/.
>> That patch doesn't change Object.java
On Tue, 2 Nov 2021 16:30:56 GMT, Pavel Rappo wrote:
> This PR follows up one of the recent PRs, where I used a non-canonical
> modifier order. Since the problem was noticed [^1], why not to address it at
> mass?
>
> As far as I remember, the first mass-canonicalization of modifiers took place
On Fri, 29 Oct 2021 16:14:57 GMT, Michael McMahon wrote:
> How likely is it that existing code is using ObjectInputStream::getFields and
> is already handling class not found by checking for null return from the
> returned GetField?
Very unlikely, a field value may be null for because it reall
On Fri, 29 Oct 2021 15:06:12 GMT, Daniel Fuchs wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Correct comment on the handling of ClassNotFoundException
>
> src/j
a
> `readObject` method
> so the deserialization logic can catch the IOException and unwrap it to
> handle the CNFE.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Correct comment on the handling of ClassNotFoundExcepti
On Thu, 28 Oct 2021 21:21:38 GMT, Brian Burkhalter wrote:
>> Please consider this proposed change to ignore comparing the total size of
>> `/dev` as returned by `DF(1)` and `STAT(2)` on macOS.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the
On Thu, 28 Oct 2021 18:15:33 GMT, Brian Burkhalter wrote:
>> Please consider this proposed change to ignore comparing the total size of
>> `/dev` as returned by `DF(1)` and `STAT(2)` on macOS.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the
On Mon, 25 Oct 2021 10:16:23 GMT, Claes Redestad wrote:
> Enhance ASCII-compatible `DoubleByte` encodings to make use of the
> `StringCoding.implEncodeAsciiArray` intrinsic, which makes many such
> `CharsetEncoder`s encode ASCII text at speeds comparable to most single-byte
> encoders - and al
On Mon, 25 Oct 2021 16:08:29 GMT, Naoto Sato wrote:
> Trivial clean-up.
LGTM
-
Marked as reviewed by rriggs (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/6110
On Mon, 25 Oct 2021 16:08:29 GMT, Naoto Sato wrote:
> Trivial clean-up.
Given that the code has been that way for a *long time*, did you check that
both paths work as intended and that tests exist for both paths?
-
PR: https://git.openjdk.java.net/jdk/pull/6110
On Sat, 23 Oct 2021 22:13:35 GMT, Naoto Sato wrote:
>> During the review of JEP 400, a proposal to provide an overloaded method to
>> `Charset.forName()` was suggested
>> [[1]](https://github.com/openjdk/jdk/pull/4733#discussion_r669693954). This
>> PR is to implement the proposal. A CSR is al
On Tue, 19 Oct 2021 13:00:01 GMT, Jaikiran Pai wrote:
> The `GlobalFilterTest` has to 2 `@test` tags. One of them has failed with a
> timeout as noted in https://bugs.openjdk.java.net/browse/JDK-8268595. The
> timeout seems to have happened even after the tests had already completed
> successf
On Fri, 22 Oct 2021 17:33:43 GMT, Naoto Sato wrote:
>> During the review of JEP 400, a proposal to provide an overloaded method to
>> `Charset.forName()` was suggested
>> [[1]](https://github.com/openjdk/jdk/pull/4733#discussion_r669693954). This
>> PR is to implement the proposal. A CSR is al
On Tue, 19 Oct 2021 13:00:01 GMT, Jaikiran Pai wrote:
> The `GlobalFilterTest` has to 2 `@test` tags. One of them has failed with a
> timeout as noted in https://bugs.openjdk.java.net/browse/JDK-8268595. The
> timeout seems to have happened even after the tests had already completed
> successf
On Thu, 21 Oct 2021 01:31:31 GMT, Sergey Bylokhov wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Moved the null sentence into @param tag.
>
> src/java.base/share/classes/java/io/Console.java line 594:
>
>> 592:
On Thu, 21 Oct 2021 04:40:25 GMT, Joe Darcy wrote:
> This should be the last core libraries cleanup of non-serializable
> non-transient instance fields ahead of the upcoming javac lint warnings:
> https://mail.openjdk.java.net/pipermail/jdk-dev/2021-October/006166.html
Marked as reviewed by r
On Thu, 21 Oct 2021 01:06:33 GMT, Joe Darcy wrote:
> Another serialization warnings cleanup; this time in java.rmi.
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6055
The ObjectInputStream.GetField method `get(String name, Object val)` should
have been throwing
a ClassNotFoundException if the class was not found. Instead the
implementation was returning null.
A design error does not allow the `get(String name, Object val)` method to
throw CNFE as it should.
On Wed, 20 Oct 2021 19:02:30 GMT, Naoto Sato wrote:
>> During the review of JEP 400, a proposal to provide an overloaded method to
>> `Charset.forName()` was suggested
>> [[1]](https://github.com/openjdk/jdk/pull/4733#discussion_r669693954). This
>> PR is to implement the proposal. A CSR is al
On Tue, 19 Oct 2021 14:22:26 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which addresses
>> https://bugs.openjdk.java.net/browse/JDK-8269336?
>>
>> As noted in that issue, this change will now propagate any exception that
>> occurred during parsing and creation of the
On Tue, 19 Oct 2021 13:00:01 GMT, Jaikiran Pai wrote:
> The `GlobalFilterTest` has to 2 `@test` tags. One of them has failed with a
> timeout as noted in https://bugs.openjdk.java.net/browse/JDK-8268595. The
> timeout seems to have happened even after the tests had already completed
> successf
On Mon, 18 Oct 2021 13:44:56 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which addresses
> https://bugs.openjdk.java.net/browse/JDK-8269336?
>
> As noted in that issue, this change will now propagate any exception that
> occurred during parsing and creation of the filt
On Sun, 10 Oct 2021 20:25:43 GMT, Joe Darcy wrote:
> The java.io.ObjectInputStream and java.io.ObjectOuputStream classes are part
> of the serialization feature. These classes contain brief descriptions of
> some of the methods serializable classes can define to interact with the
> serializati
On Fri, 15 Oct 2021 07:17:52 GMT, Сергей Цыпанов wrote:
> It looks like we cannot use `Long.hashCode(long)` for
> `java.rmi.server.ObjID.hashCode()` due to specification:
> https://docs.oracle.com/en/java/javase/17/docs/api/java.rmi/java/rmi/server/ObjID.html#hashCode().
Marked as reviewed by
On Thu, 14 Oct 2021 15:50:28 GMT, Naoto Sato wrote:
> Fixing a regression in which `file.encoding` was initialized by
> `sprops->encoding` instead of `sprops->sun_jnu_encoding` on non macOS
> platforms. tier1-3 tests passed on all platforms.
Marked as reviewed by rriggs (Reviewer).
--
On Tue, 12 Oct 2021 21:10:12 GMT, Andrey Turbanov wrote:
> Remove 3 unused HashMap's.
> Reported here
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-September/081866.html
> I did the similar PR to treetenbp and it was merged
> https://github.com/ThreeTen/threetenbp/pull/155
Marke
On Sun, 10 Oct 2021 20:25:43 GMT, Joe Darcy wrote:
> The java.io.ObjectInputStream and java.io.ObjectOuputStream classes are part
> of the serialization feature. These classes contain brief descriptions of
> some of the methods serializable classes can define to interact with the
> serializati
On Wed, 6 Oct 2021 01:24:49 GMT, Naoto Sato wrote:
> This PR is to upgrade the time zone data in the JDK to IANA's tzdata2021c
> level. Note that the tz data is "as is", as released by IANA. No `merged
> links` are retracted.
> The PR also fixes two issues along with the 2021c upgrade.
Marked
On Mon, 4 Oct 2021 21:13:02 GMT, PROgrm_JARvis
wrote:
> This is trivial fix of
> [JDK-8274686](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8274686)
> which replaces manually-computed `int`-based `long` hash-code.
>
> Because `Long#hashCode(long)` uses other hashing function than
On Mon, 27 Sep 2021 23:50:38 GMT, Phil Race wrote:
>> macOS launcher code sets JAVA_MAIN_CLASS_ which is read by AWT to set
>> the name of the application in the system menu bar.
>>
>> Because this set shortly after the VM is running, it causes a thread safety
>> issue described in https://bug
On Sat, 25 Sep 2021 03:38:24 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which proposes to fix the issue
>> reported in https://bugs.openjdk.java.net/browse/JDK-8273790?
>>
>> As noted in that issue, trying to class load
>> `sun.util.calendar.CalendarSystem` and `sun.
On Wed, 22 Sep 2021 10:27:45 GMT, Jaikiran Pai wrote:
>> The commit in this PR implements the proposal for enhancement that was
>> discussed in the core-libs-dev mailing list recently[1], for
>> https://bugs.openjdk.java.net/browse/JDK-8231640
>>
>> At a high level - the `store()` APIs in `Pro
On Sat, 25 Sep 2021 01:48:29 GMT, xpbob
wrote:
>> remove vfork() on Darwin
>
> xpbob has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Drop drop "Solaris" from the comment
Looks good, vfork is not/was not being used on Mac OS.
On Fri, 24 Sep 2021 14:36:07 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which proposes to fix the issue
> reported in https://bugs.openjdk.java.net/browse/JDK-8273790?
>
> As noted in that issue, trying to class load
> `sun.util.calendar.CalendarSystem` and `sun.util.
On Wed, 22 Sep 2021 15:00:59 GMT, Roger Riggs wrote:
> The Mac OS specific code to determine the os.version property in
> java_props_macosx.c is updated
> to replace the code extracting the version from the SystemVersion.plist by
> reading the version using t\
> he hidden l
On Wed, 22 Sep 2021 17:41:18 GMT, Roger Riggs wrote:
>> The Mac OS specific code to determine the os.version property in
>> java_props_macosx.c is updated
>> to replace the code extracting the version from the SystemVersion.plist by
>> reading the version using t\
>
> The Mac OS specific code to determine the os.version property in
> java_props_macosx.c is updated
> to replace the code extracting the version from the SystemVersion.plist by
> reading the version using t\
> he hidden link:
Roger Riggs has updated the pull request increme
The Mac OS specific code to determine the os.version property in
java_props_macosx.c is updated
to replace the code extracting the version from the SystemVersion.plist by
reading the version using t\
he hidden link:
-
Commit messages:
- 8269850: Most JDK releases report macOS versi
On Tue, 21 Sep 2021 19:33:05 GMT, Roger Riggs wrote:
> The Mac OS specific code to determine the os.version property in
> java_props_macosx.c is updated
> to replace the code extracting the version from the SystemVersion.plist by
> reading the version using the hidden link:
&
On Tue, 21 Sep 2021 18:14:17 GMT, Roger Riggs wrote:
> Correct the check if any field has been appended to the StringBuilder in
> ProcessHandleImpl.Info.toString().
This pull request has now been integrated.
Changeset: 33df388a
Author: Roger Riggs
URL:
https://git.openjdk.ja
On Tue, 24 Aug 2021 15:55:28 GMT, Roger Riggs wrote:
> The intermittent test in java/lang/ProcessBuilder/Basic.java has identified
> unexpected messages from a child Java VM
> as the cause of the test failure. Attempts to control the output of the
> child VM have failed, the VM is
On Wed, 22 Sep 2021 00:03:41 GMT, David Holmes wrote:
>> I thought of that too, but notice the parens "()" around that /bin/sleep;
>> that creates and extra level of forked processes and its harder to get that
>> pid. There probably is a way to traverse the hierarchy but I'll keep it as
>> is
Indeed, they seem unused...
Stephen, do you recall their original use?
Thanks, Roger
On 9/21/21 5:09 PM, Andrey Turbanov wrote:
Hello.
Today I discovered 3 static HashMap's in ThaiBuddhistChronology class:
ERA_NARROW_NAMES, ERA_SHORT_NAMES, ERA_FULL_NAMES
static initializer put some values i
The Mac OS specific code to determine the os.version property in
java_props_macosx.c is updated
to replace the code extracting the version from the SystemVersion.plist by
reading the version using the hidden link:
`/System/Library/CoreServices/.SystemVersionPlatform.plist`
Its contents are no
Correct the check if any field has been appended to the StringBuilder in
ProcessHandleImpl.Info.toString().
-
Commit messages:
- 8274003: ProcessHandleImpl.Info toString has an if check which is always true
Changes: https://git.openjdk.java.net/jdk/pull/5618/files
Webrev: https://
On Tue, 21 Sep 2021 12:47:00 GMT, Naoto Sato wrote:
> Fixing an AIOOBE on normalizing the month value.
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5611
On Tue, 21 Sep 2021 12:05:27 GMT, Pavel Rappo wrote:
> This PR fixes an inline comment typo and reduces "overlinking" in a doc
> comment in `java.lang.ref.Reference`. Overlinking happens because the
> `reachabilityFence` method:
> * Links `package-summary.html#reachability` twice.
> * Refers
On Tue, 21 Sep 2021 04:54:24 GMT, David Holmes wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> The switch from a Java child to /bin/sleep caused another test
>> to fail on Linux. Th
n the child except to wait long enough for the
> test to finish and the child is destroyed.
> The fix is to switch from using a Java child to using a native child; a new
> executable `sleepmillis`.
Roger Riggs has updated the pull request incrementally with one additional
commit sinc
On Thu, 9 Sep 2021 18:31:43 GMT, Roger Riggs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> dummy commit to trigger GitHub actions job to try and reproduce an
>> unexplained f
n the child except to wait long enough for the
> test to finish and the child is destroyed.
> The fix is to switch from using a Java child to using a native child; a new
> executable `sleepmillis`.
Roger Riggs has updated the pull request incrementally with one additional
commit since th
On Wed, 15 Sep 2021 21:47:39 GMT, David Holmes wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert to using BasicSleep on Windows
>> Added diagnostic output for a test that
On Wed, 15 Sep 2021 21:46:59 GMT, Stuart Marks wrote:
>> src/java.base/share/classes/java/util/Properties.java line 819:
>>
>>> 817: *
>>> 818: * If the {@systemProperty java.util.Properties.storeDate} is set
>>> and
>>> 819: * is non-empty (as determined by {@link String#isEmpt
On Fri, 3 Sep 2021 14:25:53 GMT, Roger Riggs wrote:
>> The intermittent test in java/lang/ProcessBuilder/Basic.java has identified
>> unexpected messages from a child Java VM
>> as the cause of the test failure. Attempts to control the output of the
>> child V
On Wed, 15 Sep 2021 06:11:23 GMT, Jaikiran Pai wrote:
>> The commit in this PR implements the proposal for enhancement that was
>> discussed in the core-libs-dev mailing list recently[1], for
>> https://bugs.openjdk.java.net/browse/JDK-8231640
>>
>> At a high level - the `store()` APIs in `Pro
On Tue, 14 Sep 2021 20:34:21 GMT, Daniel Fuchs wrote:
>> src/java.base/share/classes/java/util/Properties.java line 929:
>>
>>> 927: @SuppressWarnings("unchecked")
>>> 928: var entries = new ArrayList<>(((Map) (Map)
>>> map).entrySet());
>>> 929: entries.sort
On Tue, 14 Sep 2021 14:02:10 GMT, Jaikiran Pai wrote:
>> The commit in this PR implements the proposal for enhancement that was
>> discussed in the core-libs-dev mailing list recently[1], for
>> https://bugs.openjdk.java.net/browse/JDK-8231640
>>
>> At a high level - the `store()` APIs in `Pro
On Tue, 14 Sep 2021 14:02:10 GMT, Jaikiran Pai wrote:
>> The commit in this PR implements the proposal for enhancement that was
>> discussed in the core-libs-dev mailing list recently[1], for
>> https://bugs.openjdk.java.net/browse/JDK-8231640
>>
>> At a high level - the `store()` APIs in `Pro
Hi Jaikiran,
"Editing" the value of the comment property, to remove or ignore blanks
for other special
characters makes the code more complex and adds a bunch of conditions.
Dropping
the comment if it doesn't have the allowed format is hard to track down,
because there's
no way to report it w
On Mon, 13 Sep 2021 11:22:27 GMT, Pavel Rappo wrote:
>> 8273616: Fix trivial doc typos in the java.base module
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use "ensure" instead of "insure"
Marked as reviewed by rriggs (R
On Thu, 9 Sep 2021 16:30:29 GMT, Ian Graves wrote:
>> Relaxing some assertion bounds to allow for small error values that still
>> show improvement over previous summation method.
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last revision:
>
On Thu, 9 Sep 2021 18:01:04 GMT, Jim Laskey wrote:
> RandomSupport.AbstractSplittableWithBrineGenerator. makeSplitsSpliterator is
> intending to create a salt from a random long. The salt should have random
> letters of size 4 for each consecutive 4 bits and then the last 4 bits as ff,
> i.e.
, an unparseable property value is replaced by the current date).
Roger
On 9/10/21 10:40 AM, Jaikiran Pai wrote:
On 10/09/21 7:59 pm, Roger Riggs wrote:
On Fri, 10 Sep 2021 10:15:45 GMT, Jaikiran Pai wrote:
I'm inclined to agree with Magnus, supplying the property as a
string, avoids hardc
080758.html
>> [2] https://reproducible-builds.org/specs/source-date-epoch/
>
> Jaikiran Pai has updated the pull request incrementally with one additional
> commit since the last revision:
>
> jcheck fix - trailing whitespace in test
Hi Jaikiran,
On 9/9/21 9:59 PM, mlbr
On Fri, 10 Sep 2021 10:15:45 GMT, Jaikiran Pai wrote:
>> The commit in this PR implements the proposal for enhancement that was
>> discussed in the core-libs-dev mailing list recently[1], for
>> https://bugs.openjdk.java.net/browse/JDK-8231640
>>
>> At a high level - the `store()` APIs in `Pro
On Thu, 9 Sep 2021 09:56:30 GMT, Jaikiran Pai wrote:
>> The commit in this PR implements the proposal for enhancement that was
>> discussed in the core-libs-dev mailing list recently[1], for
>> https://bugs.openjdk.java.net/browse/JDK-8231640
>>
>> At a high level - the `store()` APIs in `Prop
301 - 400 of 3271 matches
Mail list logo
