hg: jdk8/tl/langtools: 8027660: javac crash while creating LVT entry for a local variable defined in an inner block

2013-11-01 Thread vicente . romero
Changeset: cc80c03c41e4 Author:vromero Date: 2013-11-01 19:08 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/cc80c03c41e4 8027660: javac crash while creating LVT entry for a local variable defined in an inner block Reviewed-by: jjg Contributed-by:

hg: jdk8/tl/langtools: 8026963: type annotations code crashes for code with erroneous trees

2013-11-14 Thread vicente . romero
Changeset: e79d6425f1c4 Author:vromero Date: 2013-11-14 19:28 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e79d6425f1c4 8026963: type annotations code crashes for code with erroneous trees Reviewed-by: jjg, jlahoda !

hg: jdk8/tl/langtools: 8026231: Look at 'static' flag when checking method references

2013-11-15 Thread vicente . romero
Changeset: d4cbb671de1c Author:vromero Date: 2013-11-15 11:08 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d4cbb671de1c 8026231: Look at 'static' flag when checking method references Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/code/Kinds.java !

hg: jdk8/tl/langtools: 8028504: javac generates LocalVariableTable even with -g:none

2013-11-19 Thread vicente . romero
Changeset: 66bcd5d4b3d1 Author:vromero Date: 2013-11-19 23:35 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/66bcd5d4b3d1 8028504: javac generates LocalVariableTable even with -g:none Reviewed-by: jjg, jlahoda !

hg: jdk8/tl/langtools: 8029179: javac produces a compile error for valid boolean expressions

2013-12-03 Thread vicente . romero
Changeset: fb8c59cf26c8 Author:vromero Date: 2013-12-03 18:13 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fb8c59cf26c8 8029179: javac produces a compile error for valid boolean expressions Reviewed-by: jjg, jlahoda !

hg: jdk8/tl/langtools: 8029569: internal javac cast exception when resolving varargs ambiguity

2013-12-09 Thread vicente . romero
Changeset: 5bf0af735c61 Author:vromero Date: 2013-12-09 19:29 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5bf0af735c61 8029569: internal javac cast exception when resolving varargs ambiguity Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Resolve.java

hg: jdk8/tl/langtools: 8029721: javac crash for annotated parameter type of lambda in a field

2013-12-13 Thread vicente . romero
Changeset: 8832b6048e65 Author:vromero Date: 2013-12-13 14:13 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8832b6048e65 8029721: javac crash for annotated parameter type of lambda in a field Reviewed-by: rfield, jfranck !

hg: jdk8/tl/langtools: 8005167: execution time of combo tests in javac should be improved

2013-01-08 Thread vicente . romero
Changeset: 954541f13717 Author:vromero Date: 2013-01-08 13:47 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/954541f13717 8005167: execution time of combo tests in javac should be improved Reviewed-by: jjg, jjh ! test/tools/javac/Diagnostics/6769027/T6769027.java !

hg: jdk8/tl/langtools: 8006694: temporarily workaround combo tests are causing time out in several platforms

2013-01-23 Thread vicente . romero
Changeset: 5c956be64b9e Author:vromero Date: 2013-01-23 20:57 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5c956be64b9e 8006694: temporarily workaround combo tests are causing time out in several platforms Reviewed-by: jjg Contributed-by:

hg: jdk8/tl/langtools: 8005075: Pool.Method, and Pool.Variable redundant Symbol field should be removed

2013-02-02 Thread vicente . romero
Changeset: 4cc73ec94686 Author:vromero Date: 2013-02-02 21:04 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4cc73ec94686 8005075: Pool.Method, and Pool.Variable redundant Symbol field should be removed Reviewed-by: jjg !

hg: jdk8/tl/langtools: 7199823: javac generates inner class that can't be verified

2013-02-02 Thread vicente . romero
Changeset: a51a8dac0a2f Author:vromero Date: 2013-02-03 02:31 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a51a8dac0a2f 7199823: javac generates inner class that can't be verified Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java

hg: jdk8/tl/langtools: 8005931: javac doesn't set ACC_STRICT for classes with package access

2013-02-08 Thread vicente . romero
Changeset: b1deb90d2e37 Author:vromero Date: 2013-02-08 09:15 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b1deb90d2e37 8005931: javac doesn't set ACC_STRICT for classes with package access Reviewed-by: mcimadamore !

hg: jdk8/tl/langtools: 7167125: Two variables after the same operation in a inner class return different results

2013-02-08 Thread vicente . romero
Changeset: 017e8bdd440f Author:vromero Date: 2013-02-08 09:21 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/017e8bdd440f 7167125: Two variables after the same operation in a inner class return different results Reviewed-by: jjg, mcimadamore !

hg: jdk8/tl/langtools: 8006334: javap, JavapTask constructor breaks with null pointer exception if parameter options is null

2013-02-12 Thread vicente . romero
Changeset: 073696f59241 Author:vromero Date: 2013-02-12 13:36 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/073696f59241 8006334: javap, JavapTask constructor breaks with null pointer exception if parameter options is null Reviewed-by: jjg !

hg: jdk8/tl/langtools: 8009170: Regression: javac generates redundant bytecode in assignop involving arrays

2013-03-07 Thread vicente . romero
Changeset: 823fb9229724 Author:vromero Date: 2013-03-07 10:12 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/823fb9229724 8009170: Regression: javac generates redundant bytecode in assignop involving arrays Reviewed-by: mcimadamore !

hg: jdk8/tl/langtools: 6181889: Empty try/finally results in bytecodes being generated

2013-03-11 Thread vicente . romero
Changeset: c61add6bf8ac Author:vromero Date: 2013-03-11 15:35 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c61add6bf8ac 6181889: Empty try/finally results in bytecodes being generated Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java +

hg: jdk8/tl/langtools: 8008582: jtreg failures after conversion of shell tests to Java

2013-03-14 Thread vicente . romero
Changeset: 2e21ecd7a5ad Author:vromero Date: 2013-03-14 08:30 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2e21ecd7a5ad 8008582: jtreg failures after conversion of shell tests to Java Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/util/ArrayUtils.java !

hg: jdk8/tl/langtools: 5053846: javac: MethodRef entries are duplicated in the constant pool

2013-03-15 Thread vicente . romero
Changeset: fa24eba012bd Author:vromero Date: 2013-03-15 09:02 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fa24eba012bd 5053846: javac: MethodRef entries are duplicated in the constant pool Reviewed-by: mcimadamore !

hg: jdk8/tl/langtools: 8011432: javac, compiler regression iterable + captured type

2013-04-10 Thread vicente . romero
Changeset: a4be2c2fe0a1 Author:vromero Date: 2013-04-10 12:31 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a4be2c2fe0a1 8011432: javac, compiler regression iterable + captured type Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java !

hg: jdk8/tl/langtools: 8010659: Javac Crashes while building OpenJFX

2013-04-13 Thread vicente . romero
Changeset: 76537856a54e Author:vromero Date: 2013-04-13 12:25 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/76537856a54e 8010659: Javac Crashes while building OpenJFX Reviewed-by: jjg Contributed-by: maurizio.cimadam...@oracle.com +

hg: jdk8/tl/langtools: 8011181: javac, empty UTF8 entry generated for inner class

2013-04-17 Thread vicente . romero
Changeset: 49d32c84dfea Author:vromero Date: 2013-04-17 11:11 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/49d32c84dfea 8011181: javac, empty UTF8 entry generated for inner class Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java +

hg: jdk8/tl/langtools: 8012723: strictfp interface misses strictfp modifer on default method

2013-04-26 Thread vicente . romero
Changeset: 3c02d2f1a421 Author:vromero Date: 2013-04-26 10:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3c02d2f1a421 8012723: strictfp interface misses strictfp modifer on default method Reviewed-by: mcimadamore !

hg: jdk8/tl/langtools: 8008562: javac, a refactoring to Bits is necessary in order to provide a change history

2013-04-26 Thread vicente . romero
Changeset: 2ca9e7d50136 Author:vromero Date: 2013-04-26 10:17 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2ca9e7d50136 8008562: javac, a refactoring to Bits is necessary in order to provide a change history Reviewed-by: mcimadamore !

hg: jdk8/tl/langtools: 8010304: javac should detect all mutable implicit static fields in langtools using a plugin

2013-04-26 Thread vicente . romero
Changeset: f3f3ac1273e8 Author:vromero Date: 2013-04-26 15:59 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f3f3ac1273e8 8010304: javac should detect all mutable implicit static fields in langtools using a plugin Reviewed-by: jjg ! make/build.xml +

hg: jdk8/tl/langtools: 7177168: Redundant array copy in UnsharedNameTable

2013-05-21 Thread vicente . romero
Changeset: 824932ecdbc8 Author:vromero Date: 2013-05-21 11:41 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/824932ecdbc8 7177168: Redundant array copy in UnsharedNameTable Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/util/UnsharedNameTable.java

hg: jdk8/tl/langtools: 7060779: test/tools/javac/diags/Example.java leaves directories in tempdir

2013-05-21 Thread vicente . romero
Changeset: 3d9750039fff Author:vromero Date: 2013-05-21 12:17 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3d9750039fff 7060779: test/tools/javac/diags/Example.java leaves directories in tempdir Reviewed-by: mcimadamore ! test/tools/javac/diags/Example.java

hg: jdk8/tl/langtools: 7164114: Two jtreg tests are not run due to no file extension on the test files

2013-05-21 Thread vicente . romero
Changeset: 08daea43a7f8 Author:vromero Date: 2013-05-21 14:33 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/08daea43a7f8 7164114: Two jtreg tests are not run due to no file extension on the test files Reviewed-by: mcimadamore -

hg: jdk8/tl/langtools: 6970173: Debug pointer at bad position

2013-05-28 Thread vicente . romero
Changeset: c6df5b20f9eb Author:vromero Date: 2013-05-28 12:46 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c6df5b20f9eb 6970173: Debug pointer at bad position Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java +

hg: jdk8/tl/langtools: 8012333: javac, ClassFile should have a read(Path) method

2013-05-28 Thread vicente . romero
Changeset: d042cba65eab Author:vromero Date: 2013-05-28 17:39 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d042cba65eab 8012333: javac, ClassFile should have a read(Path) method Reviewed-by: jjg ! src/share/classes/com/sun/tools/classfile/ClassFile.java

hg: jdk8/tl/langtools: 7053059: VerifyError with double Assignment using a Generic Member of a Superclass

2013-05-29 Thread vicente . romero
Changeset: 92e420e9807d Author:vromero Date: 2013-05-29 10:56 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/92e420e9807d 7053059: VerifyError with double Assignment using a Generic Member of a Superclass Reviewed-by: mcimadamore !

hg: jdk8/tl/langtools: 7179353: try-with-resources fails to compile with generic exception parameters

2013-05-31 Thread vicente . romero
Changeset: 9f11c7676cd5 Author:vromero Date: 2013-05-31 10:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9f11c7676cd5 7179353: try-with-resources fails to compile with generic exception parameters Reviewed-by: mcimadamore !

hg: jdk8/tl/langtools: 8010737: javac, known parameter's names should be copied to automatically generated constructors for inner classes

2013-06-01 Thread vicente . romero
Changeset: e9855150c5b0 Author:vromero Date: 2013-06-01 21:57 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e9855150c5b0 8010737: javac, known parameter's names should be copied to automatically generated constructors for inner classes Reviewed-by: mcimadamore !

hg: jdk8/tl/langtools: 6695379: Copy method annotations and parameter annotations to synthetic bridge methods

2013-06-01 Thread vicente . romero
Changeset: ec871c3e8337 Author:vromero Date: 2013-06-01 22:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ec871c3e8337 6695379: Copy method annotations and parameter annotations to synthetic bridge methods Reviewed-by: mcimadamore !

hg: jdk8/tl/langtools: 7165659: javac incorrectly sets strictfp access flag on inner-classes

2013-06-04 Thread vicente . romero
Changeset: 775a51e3276f Author:vromero Date: 2013-06-04 13:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/775a51e3276f 7165659: javac incorrectly sets strictfp access flag on inner-classes Reviewed-by: jjg, mcimadamore !

hg: jdk8/tl/langtools: 7113519: test/tools/javac/VersionOpt.java passes on windows

2013-06-10 Thread vicente . romero
Changeset: 105d1f9c1ab8 Author:vromero Date: 2013-06-10 15:18 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/105d1f9c1ab8 7113519: test/tools/javac/VersionOpt.java passes on windows Reviewed-by: jjg ! test/tools/javac/VersionOpt.java

hg: jdk8/tl/langtools: 8008547: javac, warning message: use of ''_'' as an identifier might not be supported in future releases, should be more especific

2013-06-11 Thread vicente . romero
Changeset: bbedff0dc37e Author:vromero Date: 2013-06-11 09:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bbedff0dc37e 8008547: javac, warning message: use of ''_'' as an identifier might not be supported in future releases, should be more especific Reviewed-by:

hg: jdk8/tl/langtools: 8007907: javap, method com.sun.tools.javap.Main.run returns 0 even in case of class not found error

2013-06-11 Thread vicente . romero
Changeset: 7fe655cad9b1 Author:vromero Date: 2013-06-11 09:59 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7fe655cad9b1 8007907: javap, method com.sun.tools.javap.Main.run returns 0 even in case of class not found error Reviewed-by: jjg !

hg: jdk8/tl/langtools: 8016569: javac, add new flag for polymorphic method signatures

2013-06-14 Thread vicente . romero
Changeset: 6b48ebae2569 Author:vromero Date: 2013-06-14 16:25 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6b48ebae2569 8016569: javac, add new flag for polymorphic method signatures Reviewed-by: jjg Contributed-by: maurizio.cimadam...@oracle.com !

hg: jdk8/tl/langtools: 8008023: Get rid of utf8 chars in two tests

2013-06-14 Thread vicente . romero
Changeset: 1936a884b290 Author:vromero Date: 2013-06-14 18:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1936a884b290 8008023: Get rid of utf8 chars in two tests Reviewed-by: jjg ! test/tools/javac/api/6437999/Utf8.java ! test/tools/javac/api/T6306137.java

hg: jdk8/tl/langtools: 8016267: javac, TypeTag refactoring has provoked performance issues

2013-06-18 Thread vicente . romero
Changeset: 9851071b551a Author:vromero Date: 2013-06-18 19:02 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9851071b551a 8016267: javac, TypeTag refactoring has provoked performance issues Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Type.java !

hg: jdk8/tl/langtools: 8016607: javac, avoid analyzing lambdas for source 7 compilation

2013-06-18 Thread vicente . romero
Changeset: e701af23a095 Author:vromero Date: 2013-06-18 18:57 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e701af23a095 8016607: javac, avoid analyzing lambdas for source 7 compilation Reviewed-by: jjg Contributed-by: maurizio.cimadam...@oracle.com !

hg: jdk8/tl/langtools: 8006981: javac, method toString() of class ...javac.code.Flags doesn't print all the flag bits

2013-06-19 Thread vicente . romero
Changeset: 6d3b33aea370 Author:vromero Date: 2013-06-19 11:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6d3b33aea370 8006981: javac, method toString() of class ...javac.code.Flags doesn't print all the flag bits Reviewed-by: jjg !

hg: jdk8/tl/langtools: 8016610: javac, add new internal symbols to make operator resolution faster

2013-06-19 Thread vicente . romero
Changeset: be10ac0081b2 Author:vromero Date: 2013-06-19 22:07 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/be10ac0081b2 8016610: javac, add new internal symbols to make operator resolution faster Reviewed-by: jjg Contributed-by: maurizio.cimadam...@oracle.com !

hg: jdk8/tl/langtools: 8016613: javac should avoid source 8 only analysis when compiling for source 7

2013-06-20 Thread vicente . romero
Changeset: 6debfa63a4a1 Author:vromero Date: 2013-06-20 08:45 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6debfa63a4a1 8016613: javac should avoid source 8 only analysis when compiling for source 7 Reviewed-by: jjg Contributed-by: maurizio.cimadam...@oracle.com !

hg: jdk8/tl/langtools: 8017104: javac should have a class for primitive types that inherits from Type

2013-06-25 Thread vicente . romero
Changeset: 831467c4c6a7 Author:vromero Date: 2013-06-25 16:12 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/831467c4c6a7 8017104: javac should have a class for primitive types that inherits from Type Reviewed-by: jjg !

hg: jdk8/tl/langtools: 7066788: javah again accepts -old option (ineffectively) which was removed in 1.5.

2013-06-27 Thread vicente . romero
Changeset: a47e28759666 Author:vromero Date: 2013-06-27 09:51 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a47e28759666 7066788: javah again accepts -old option (ineffectively) which was removed in 1.5. Reviewed-by: jjg !

hg: jdk8/tl/langtools: 8017609: javac, ClassFile.read(Path) should be ClassFile.read(Path, Attribute.Factory)

2013-06-27 Thread vicente . romero
Changeset: 8e3d391c88c6 Author:vromero Date: 2013-06-27 09:54 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8e3d391c88c6 8017609: javac, ClassFile.read(Path) should be ClassFile.read(Path, Attribute.Factory) Reviewed-by: jjg !

hg: jdk8/tl/langtools: 7008643: inlined finally clauses confuse debuggers

2013-06-27 Thread vicente . romero
Changeset: d137ce373c4c Author:vromero Date: 2013-06-27 16:06 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d137ce373c4c 7008643: inlined finally clauses confuse debuggers Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/jvm/Gen.java +

hg: jdk8/tl/langtools: 8016099: Some @SuppressWarnings annotations ignored ( unchecked, rawtypes )

2013-06-27 Thread vicente . romero
Changeset: e42c27026290 Author:vromero Date: 2013-06-27 16:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e42c27026290 8016099: Some @SuppressWarnings annotations ignored ( unchecked, rawtypes ) Reviewed-by: jjg !

hg: jdk8/tl/langtools: 6473148: TreePath.iterator() should document the iteration order

2013-06-28 Thread vicente . romero
Changeset: bb06c412d079 Author:vromero Date: 2013-06-28 13:20 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bb06c412d079 6473148: TreePath.iterator() should document the iteration order Reviewed-by: mcimadamore ! src/share/classes/com/sun/source/util/TreePath.java

hg: jdk8/tl/langtools: 8005552: c.s.t.javap.AttributeWriter.visitLocalVariableTable() uses incorrect format string

2013-06-28 Thread vicente . romero
Changeset: bdd699d7378d Author:vromero Date: 2013-06-28 14:36 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bdd699d7378d 8005552: c.s.t.javap.AttributeWriter.visitLocalVariableTable() uses incorrect format string Reviewed-by: mcimadamore !

hg: jdk8/tl/langtools: 6983646: javap should identify why a DefaultAttribute is being used

2013-06-29 Thread vicente . romero
Changeset: 891c5ecb8306 Author:vromero Date: 2013-06-29 20:12 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/891c5ecb8306 6983646: javap should identify why a DefaultAttribute is being used Reviewed-by: jjg ! src/share/classes/com/sun/tools/classfile/Attribute.java !

hg: jdk8/tl/langtools: 8019397: javap does not show SourceDebugExtension properly

2013-07-02 Thread vicente . romero
Changeset: 27a2e8c78bd0 Author:vromero Date: 2013-07-02 10:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/27a2e8c78bd0 8019397: javap does not show SourceDebugExtension properly Reviewed-by: jjg Contributed-by: dmytro_she...@hotmail.com !

hg: jdk8/tl/langtools: 6326693: variable x might already have been assigned, when assignment is in catch block

2013-07-02 Thread vicente . romero
Changeset: 3b4f92a3797f Author:vromero Date: 2013-07-02 22:49 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3b4f92a3797f 6326693: variable x might already have been assigned, when assignment is in catch block Reviewed-by: mcimadamore !

hg: jdk8/tl/langtools: 8009924: some langtools tools do not accept -cp as an alias for -classpath

2013-07-04 Thread vicente . romero
Changeset: d6158f8d7235 Author:vromero Date: 2013-07-04 10:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d6158f8d7235 8009924: some langtools tools do not accept -cp as an alias for -classpath Reviewed-by: jjg !

hg: jdk8/tl/langtools: 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members

2013-07-04 Thread vicente . romero
Changeset: 79c3146e417b Author:vromero Date: 2013-07-04 10:41 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/79c3146e417b 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members Reviewed-by: mcimadamore !

hg: jdk8/tl/langtools: 8013179: assertion failure in javac when compiling with -source 1.6 -target 1.6

2013-07-31 Thread vicente . romero
Changeset: 7696282873f6 Author:vromero Date: 2013-07-31 10:52 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7696282873f6 8013179: assertion failure in javac when compiling with -source 1.6 -target 1.6 Reviewed-by: jjg !

hg: jdk8/tl/langtools: 8022186: javac generates dead code if a try with an empty body has a finalizer

2013-08-06 Thread vicente . romero
Changeset: 99b60bcf3862 Author:vromero Date: 2013-08-06 15:08 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/99b60bcf3862 8022186: javac generates dead code if a try with an empty body has a finalizer Reviewed-by: jjg !

hg: jdk8/tl/langtools: 8020997: TreeMaker.AnnotationBuilder creates broken element literals with repeating annotations

2013-08-07 Thread vicente . romero
Changeset: f3deeccbf4cf Author:vromero Date: 2013-08-07 10:41 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f3deeccbf4cf 8020997: TreeMaker.AnnotationBuilder creates broken element literals with repeating annotations Reviewed-by: jjg, jfranck !

hg: jdk8/tl/langtools: 8008274: javac should not reference/use sample code

2013-08-07 Thread vicente . romero
Changeset: c7dcf899 Author:vromero Date: 2013-08-07 11:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c7dcf899 8008274: javac should not reference/use sample code Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/Main.java

hg: jdk8/tl/langtools: 8019486: javac, generates erroneous LVT for a test case with lambda code

2013-08-08 Thread vicente . romero
Changeset: b8610a65fbf9 Author:vromero Date: 2013-08-08 11:49 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b8610a65fbf9 8019486: javac, generates erroneous LVT for a test case with lambda code Reviewed-by: mcimadamore !

hg: jdk8/tl/langtools: 8009640: -profile compact does not work when -bootclasspath specified

2013-08-10 Thread vicente . romero
Changeset: 0d9bc764cac7 Author:vromero Date: 2013-08-10 13:27 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0d9bc764cac7 8009640: -profile compact does not work when -bootclasspath specified Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/main/Main.java !

hg: jdk8/tl/langtools: 8022622: javac, two tests are failing with compile time error after class Collector was modified

2013-08-10 Thread vicente . romero
Changeset: 8f282dc58dfc Author:vromero Date: 2013-08-10 16:26 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8f282dc58dfc 8022622: javac, two tests are failing with compile time error after class Collector was modified Reviewed-by: mcimadamore !

hg: jdk8/tl/langtools: 6983297: methods missing from NewArrayTree

2013-08-10 Thread vicente . romero
Changeset: aa6c6f8b5622 Author:vromero Date: 2013-08-10 16:29 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/aa6c6f8b5622 6983297: methods missing from NewArrayTree Reviewed-by: jjg ! src/share/classes/com/sun/source/tree/NewArrayTree.java !

hg: jdk8/tl/jdk: 8015780: java/lang/reflect/Method/GenericStringTest.java failing

2013-08-12 Thread vicente . romero
Changeset: 70c8f4a4b8d6 Author:vromero Date: 2013-08-12 17:40 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/70c8f4a4b8d6 8015780: java/lang/reflect/Method/GenericStringTest.java failing Reviewed-by: darcy, jfranck ! test/ProblemList.txt !

hg: jdk8/tl/langtools: 8022053: javac generates unverifiable initializer for nested subclass of local class

2013-08-16 Thread vicente . romero
Changeset: a6378c19836b Author:vromero Date: 2013-08-16 10:32 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a6378c19836b 8022053: javac generates unverifiable initializer for nested subclass of local class Reviewed-by: jjg, mcimadamore !

hg: jdk8/tl/langtools: 8022316: Generic throws, overriding and method reference

2013-08-22 Thread vicente . romero
Changeset: 7a4717f3ea7b Author:vromero Date: 2013-08-22 10:22 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7a4717f3ea7b 8022316: Generic throws, overriding and method reference Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/code/Types.java +

hg: jdk8/tl/langtools: 8023112: javac should not use lazy constant evaluation approach for method references

2013-08-22 Thread vicente . romero
Changeset: 25aaff78d754 Author:vromero Date: 2013-08-22 13:12 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/25aaff78d754 8023112: javac should not use lazy constant evaluation approach for method references Reviewed-by: jjg, mcimadamore !

hg: jdk8/tl/langtools: 8022162: Incorrect signature determination for certain inner class generics

2013-09-02 Thread vicente . romero
Changeset: 2bf4c132bf90 Author:vromero Date: 2013-09-02 22:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2bf4c132bf90 8022162: Incorrect signature determination for certain inner class generics Reviewed-by: jjg !

hg: jdk8/tl/langtools: 8016177: structural most specific and stuckness

2013-09-02 Thread vicente . romero
Changeset: 4a6acc42c3a1 Author:vromero Date: 2013-09-02 22:38 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4a6acc42c3a1 8016177: structural most specific and stuckness Reviewed-by: jjg, vromero Contributed-by: maurizio.cimadam...@oracle.com !

hg: jdk8/tl/langtools: 8023549: Compiler emitting spurious errors when constructor reference type is inferred and explicit type arguments are supplied

2013-09-03 Thread vicente . romero
Changeset: 438547d895dc Author:vromero Date: 2013-09-04 00:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/438547d895dc 8023549: Compiler emitting spurious errors when constructor reference type is inferred and explicit type arguments are supplied Reviewed-by: jjg,

hg: jdk8/tl/langtools: 8023389: Javac fails to infer type for lambda used with intersection type and wildcards

2013-09-03 Thread vicente . romero
Changeset: fb5a846c4a49 Author:vromero Date: 2013-09-03 23:31 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fb5a846c4a49 8023389: Javac fails to infer type for lambda used with intersection type and wildcards Reviewed-by: jjg, vromero Contributed-by:

hg: jdk8/tl/langtools: 8023545: Misleading error message when using diamond operator with private constructor

2013-09-03 Thread vicente . romero
Changeset: 9be0afbdf244 Author:vromero Date: 2013-09-03 23:41 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9be0afbdf244 8023545: Misleading error message when using diamond operator with private constructor Reviewed-by: jjg !

hg: jdk8/tl/langtools: 8008275: javac.Main should be @Supported

2013-09-04 Thread vicente . romero
Changeset: b94824ddcbb6 Author:vromero Date: 2013-09-04 11:53 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b94824ddcbb6 8008275: javac.Main should be @Supported Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/Main.java

hg: jdk8/tl/langtools: 8024039: javac, previous solution for JDK-8022186 was incorrect

2013-09-06 Thread vicente . romero
Changeset: 7c7b4aea6d50 Author:vromero Date: 2013-09-06 09:53 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7c7b4aea6d50 8024039: javac, previous solution for JDK-8022186 was incorrect Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Lower.java !

hg: jdk8/tl/langtools: 8024398: javac, compiler crashes with try with empty body

2013-09-08 Thread vicente . romero
Changeset: 2de3750d65a5 Author:vromero Date: 2013-09-08 11:54 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2de3750d65a5 8024398: javac, compiler crashes with try with empty body Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Lower.java +

hg: jdk8/tl/langtools: 8024154: Fix for 8016177: structural most specific and stuckness breaks 6 langtools tests

2013-09-09 Thread vicente . romero
Changeset: a4b9a8859e58 Author:vromero Date: 2013-09-09 16:32 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a4b9a8859e58 8024154: Fix for 8016177: structural most specific and stuckness breaks 6 langtools tests Reviewed-by: jjg, jfranck !

hg: jdk8/tl/langtools: 8024414: javac, should facilitate the use of the bootstrap compiler for debugging

2013-09-10 Thread vicente . romero
Changeset: d87f017ec217 Author:mcimadamore Date: 2013-09-10 16:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d87f017ec217 8024414: javac, should facilitate the use of the bootstrap compiler for debugging Reviewed-by: jjg ! make/netbeans/langtools/build.xml !

hg: jdk8/tl/langtools: 8023558: Javac creates invalid bootstrap methods for complex lambda/methodref case

2013-09-12 Thread vicente . romero
Changeset: 3ae1814f7c59 Author:vromero Date: 2013-09-12 22:40 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3ae1814f7c59 8023558: Javac creates invalid bootstrap methods for complex lambda/methodref case Reviewed-by: jjg Contributed-by:

hg: jdk8/tl/langtools: 8024207: javac crash in Flow.AssignAnalyzer.visitIdent

2013-09-14 Thread vicente . romero
Changeset: 03c26c60499c Author:vromero Date: 2013-09-14 15:23 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/03c26c60499c 8024207: javac crash in Flow.AssignAnalyzer.visitIdent Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Resolve.java +

hg: jdk8/tl/langtools: 7047734: javac, the LVT is not generated correctly in several scenarios

2013-09-14 Thread vicente . romero
Changeset: 4932bb04c4b8 Author:vromero Date: 2013-09-14 19:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4932bb04c4b8 7047734: javac, the LVT is not generated correctly in several scenarios Reviewed-by: jjg, mcimadamore !

hg: jdk8/tl/langtools: 8021112: Spurious unchecked warning reported by javac; ...

2013-09-16 Thread vicente . romero
Changeset: 4ce8148ffc4f Author:jlahoda Date: 2013-09-16 14:13 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4ce8148ffc4f 8021112: Spurious unchecked warning reported by javac 6480588: No way to suppress deprecation warnings when implementing deprecated interface

hg: jdk8/tl/langtools: 8024437: Inferring the exception thrown: sometimes fails to compile

2013-09-19 Thread vicente . romero
Changeset: 2375ce96e80d Author:vromero Date: 2013-09-19 20:57 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2375ce96e80d 8024437: Inferring the exception thrown: sometimes fails to compile Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Flags.java !

hg: jdk8/tl/langtools: 8024696: Missing null check in bound method reference capture

2013-09-22 Thread vicente . romero
Changeset: 571f8ebc2d51 Author:vromero Date: 2013-09-22 12:53 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/571f8ebc2d51 8024696: Missing null check in bound method reference capture Reviewed-by: jjg, briangoetz !

hg: jdk8/tl/langtools: 8025139: javac patch for using bootstrap compiler for debugging is not working properly

2013-09-26 Thread vicente . romero
Changeset: 13eba2e322e6 Author:vromero Date: 2013-09-26 19:06 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/13eba2e322e6 8025139: javac patch for using bootstrap compiler for debugging is not working properly Reviewed-by: jjg ! make/netbeans/langtools/build.xml !

hg: jdk8/tl/langtools: 8024497: crash returning this-referencing lambda from default method

2013-09-27 Thread vicente . romero
Changeset: 16194509e483 Author:vromero Date: 2013-09-27 10:24 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/16194509e483 8024497: crash returning this-referencing lambda from default method Reviewed-by: jjg, rfield !

hg: jdk8/tl/langtools: 8023679: Improve error message for '_' used as a lambda parameter name

2013-10-02 Thread vicente . romero
Changeset: 1e6088da1740 Author:vromero Date: 2013-10-02 17:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1e6088da1740 8023679: Improve error message for '_' used as a lambda parameter name Reviewed-by: jjg, dlsmith !

hg: jdk8/tl/langtools: 8025816: javac crash with method reference with a type variable as the site

2013-10-15 Thread vicente . romero
Changeset: 70a301b35e71 Author:vromero Date: 2013-10-15 19:36 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/70a301b35e71 8025816: javac crash with method reference with a type variable as the site Reviewed-by: jjg !

hg: jdk8/tl/langtools: 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears

2013-10-15 Thread vicente . romero
Changeset: d8d6b58f1ebf Author:vromero Date: 2013-10-15 21:02 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d8d6b58f1ebf 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears Reviewed-by: jjg !

hg: jdk8/tl/jdk: 8026854: java.time.temporal.TemporalQueries doesn't compile after javac modification to lambda flow analysis

2013-10-19 Thread vicente . romero
Changeset: fbb7510f788d Author:vromero Date: 2013-10-19 17:53 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fbb7510f788d 8026854: java.time.temporal.TemporalQueries doesn't compile after javac modification to lambda flow analysis Reviewed-by: psandoz !

hg: jdk8/tl/langtools: 8024809: javac, some lambda programs are rejected by flow analysis

2013-10-19 Thread vicente . romero
Changeset: c4292590fc70 Author:vromero Date: 2013-10-19 17:43 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c4292590fc70 8024809: javac, some lambda programs are rejected by flow analysis Reviewed-by: jjg, dlsmith !

hg: jdk8/tl/langtools: 8026956: test tools/javac/lambda/TargetType58.java is failing after a libs change

2013-10-21 Thread vicente . romero
Changeset: 9f876bd43f55 Author:vromero Date: 2013-10-21 15:55 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9f876bd43f55 8026956: test tools/javac/lambda/TargetType58.java is failing after a libs change Reviewed-by: jfranck !

hg: jdk8/tl/langtools: 8025290: javac implicit versus explicit lambda compilation error

2013-10-22 Thread vicente . romero
Changeset: 963c57175e40 Author:vromero Date: 2013-10-22 13:54 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/963c57175e40 8025290: javac implicit versus explicit lambda compilation error Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/comp/Attr.java

hg: jdk8/tl/langtools: 8027327: jar files related to test test/tools/javac/ExtDirs/ExtDirTest.java should be removed from the repo

2013-10-30 Thread vicente . romero
Changeset: 537fa895fd74 Author:vromero Date: 2013-10-30 18:09 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/537fa895fd74 8027327: jar files related to test test/tools/javac/ExtDirs/ExtDirTest.java should be removed from the repo Reviewed-by: ksrini !

Re: Review Request: JDK-8174694: improve error message shown when main class can't be loaded

2017-02-15 Thread Vicente Romero
Hi, Thanks guys for your comments. I have uploaded another iteration of the review at [1], Vicente [1] http://cr.openjdk.java.net/~vromero/8174694/webrev.01/jdk.patch On 02/15/2017 02:06 PM, Kumar Srinivasan wrote: On 2/15/2017 10:39 AM, Alan Bateman wrote: On 15/02/2017 17:21, Vicente

Re: Review Request: JDK-8174694: improve error message shown when main class can't be loaded

2017-02-15 Thread Vicente Romero
FoundError is produced then it will be: "because class Foo is not defined" Thanks, Vicente On 02/15/2017 12:12 PM, Alan Bateman wrote: On 15/02/2017 17:03, Vicente Romero wrote: Hi, Please review the fix for bug [1]. The fix is improving an already existing error message. The public patch

Re: Review Request: JDK-8174694: improve error message shown when main class can't be loaded

2017-02-15 Thread Vicente Romero
On 02/15/2017 04:25 PM, Alan Bateman wrote: On 15/02/2017 20:41, Vicente Romero wrote: Hi, Thanks guys for your comments. I have uploaded another iteration of the review at [1], Vicente [1] http://cr.openjdk.java.net/~vromero/8174694/webrev.01/jdk.patch I assume you use getClass

Re: Review Request: JDK-8174694: improve error message shown when main class can't be loaded

2017-02-15 Thread Vicente Romero
/webrev.01/jdk.patch On 02/15/2017 02:06 PM, Kumar Srinivasan wrote: On 2/15/2017 10:39 AM, Alan Bateman wrote: On 15/02/2017 17:21, Vicente Romero wrote: The simplest reproductor for this issue

RFR: 8186314: code at c.s.x.i.m.saaj.soap.MessageImpl must be modified to avoid crash after javac change

2017-08-16 Thread Vicente Romero
Hi, Please review the fix for issue [1]. The fix can be found at [2]. The fix is minimal, reproduced below: --- old/src/java.xml.ws/share/classes/com/sun/xml/internal/messaging/saaj/soap/MessageImpl.java 2017-08-16 16:31:21.403085344 -0400 +++

Re: RFR: implementation for JEP 334: JVM Constants API

2018-05-24 Thread Vicente Romero
Thanks for the comments so far, I have uploaded another iteration of the implementation + javadoc Vicente [1] http://cr.openjdk.java.net/~vromero/constant.api/webrev.08 [2] http://cr.openjdk.java.net/~vromero/constant.api/javadoc.08 On 05/23/2018 02:41 PM, Vicente Romero wrote: Hi all

  1   2   3   4   >