Re: RFR: 8287971: Throw exception for missing values in .jpackage.xml

2022-06-14 Thread Alexey Semenyuk
On Mon, 13 Jun 2022 17:01:48 GMT, Alexander Matveev wrote: > - Error will be thrown if app image is generated with another JDK version or > has malformed .jpackage.xml. > - Re-fixed as Alexey suggested in https://github.com/openjdk/jdk/pull/9098.

Re: RFR: 8287971: Throw exception for missing values in .jpackage.xml

2022-06-14 Thread Alexey Semenyuk
On Mon, 13 Jun 2022 17:01:48 GMT, Alexander Matveev wrote: > - Error will be thrown if app image is generated with another JDK version or > has malformed .jpackage.xml. > - Re-fixed as Alexey suggested in https://github.com/openjdk/jdk/pull/9098.

Re: RFR: 8287971: Throw exception for missing values in .jpackage.xml

2022-06-08 Thread Alexey Semenyuk
On Thu, 9 Jun 2022 01:21:30 GMT, Alexander Matveev wrote: > - Warning will be printed if .jpackage.xml has old version number. > - Error will be thrown if main-class and app-store values are missing from > .jpackage.xml. > - Both main-class and app-store are required values for JDK-8286850

Integrated: 8250950: Allow per-user and system wide configuration of a jpackaged app

2022-06-06 Thread Alexey Semenyuk
On Fri, 3 Jun 2022 21:07:47 GMT, Alexey Semenyuk wrote: > 8250950: Allow per-user and system wide configuration of a jpackaged app This pull request has now been integrated. Changeset: c37c8e5d Author: Alexey Semenyuk URL: https://git.openjdk.java.net/jdk/com

Re: RFR: 8250950: Allow per-user and system wide configuration of a jpackaged app

2022-06-06 Thread Alexey Semenyuk
On Fri, 3 Jun 2022 21:07:47 GMT, Alexey Semenyuk wrote: > 8250950: Allow per-user and system wide configuration of a jpackaged app @sashamatveev please resume the review - PR: https://git.openjdk.java.net/jdk/pull/9025

Re: RFR: 8250950: Allow per-user and system wide configuration of a jpackaged app [v2]

2022-06-06 Thread Alexey Semenyuk
> 8250950: Allow per-user and system wide configuration of a jpackaged app Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision: Add TKit.createDirectories() method that will delete created nonexistent director

Re: RFR: 8250950: Allow per-user and system wide configuration of a jpackaged app

2022-06-04 Thread Alexey Semenyuk
On Sat, 4 Jun 2022 01:45:21 GMT, Alexander Matveev wrote: >> 8250950: Allow per-user and system wide configuration of a jpackaged app > > test/jdk/tools/jpackage/share/PerUserCfgTest.java line 174: > >> 172: action.accept(cmd); >> 173: } finally { >> 174:

RFR: 8250950: Allow per-user and system wide configuration of a jpackaged app

2022-06-03 Thread Alexey Semenyuk
8250950: Allow per-user and system wide configuration of a jpackaged app - Commit messages: - Trailing white space removed - EOLs converted - Trailing white space removed - 8250950: Allow per-user and system wide configuration of a jpackaged app Changes:

Re: RFR: 8286850: [macos] Add support for signing user provided app image [v3]

2022-06-03 Thread Alexey Semenyuk
On Fri, 3 Jun 2022 02:03:35 GMT, Alexander Matveev wrote: >> - Added support for signing predefined application image. >> - Following command can be used to sign predefined application images: >> jpackage --type app-image --app-image Test.app --mac-sign [additional >> signing options] >> -

Re: RFR: 8286850: [macos] Add support for signing user provided app image

2022-06-02 Thread Alexey Semenyuk
On Thu, 2 Jun 2022 05:17:25 GMT, Alexander Matveev wrote: > - Added support for signing predefined application image. > - Following command can be used to sign predefined application images: > jpackage --type app-image --app-image Test.app --mac-sign [additional signing > options] > - Main

Re: RFR: 8286850: [macos] Add support for signing user provided app image

2022-06-02 Thread Alexey Semenyuk
On Thu, 2 Jun 2022 05:17:25 GMT, Alexander Matveev wrote: > - Added support for signing predefined application image. > - Following command can be used to sign predefined application images: > jpackage --type app-image --app-image Test.app --mac-sign [additional signing > options] > - Main

Re: RFR: 8287125: [macos] Multiple jpackage tests fail/timeout on same host

2022-06-02 Thread Alexey Semenyuk
On Fri, 27 May 2022 03:12:39 GMT, Alexander Matveev wrote: > Looks like regression from JDK-8277493. JDK-8277493 will always un-sign app > image. Un-signing takes time since we enumerating all files and un-signing > binaries one by one. Average increase 2-3 minutes for tests which generates

Integrated: 8281682: Redundant .ico files in Windows app-image cause unnecessary bloat

2022-05-24 Thread Alexey Semenyuk
On Thu, 19 May 2022 19:13:12 GMT, Alexey Semenyuk wrote: > 8281682: Redundant .ico files in Windows app-image cause unnecessary bloat This pull request has now been integrated. Changeset: 45180633 Author: Alexey Semenyuk URL: https://git.openjdk.java.net/jdk/com

RFR: 8281682: Redundant .ico files in Windows app-image cause unnecessary bloat

2022-05-19 Thread Alexey Semenyuk
8281682: Redundant .ico files in Windows app-image cause unnecessary bloat - Commit messages: - Trailing whitespace removed - Drop unused WinIconVerifierException - remove accidentally added space char - jtreg descriptions fixed - 8281682: Redundant .ico files in Windows

Re: RFR: 8277493: [REDO] Quarantined jpackage apps are labeled as "damaged" [v2]

2022-05-13 Thread Alexey Semenyuk
On Fri, 13 May 2022 05:06:21 GMT, Alexander Matveev wrote: >> - No changes to code provided by original fix. >> - Added ad hoc signing on macOS aarch64, since macOS aarch64 cannot execute >> unsigned code and code should be at least ad hoc signed. >> - Signing of app bundle produced by

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

2022-05-12 Thread Alexey Semenyuk
On Thu, 12 May 2022 20:59:53 GMT, Michael Hall wrote: > However, I don't know how the app is supposed to be started without a > launcher... jpackage supplies an alternative launcher that doesn't have plist. - PR: https://git.openjdk.java.net/jdk/pull/8666

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe [v2]

2022-05-12 Thread Alexey Semenyuk
On Thu, 12 May 2022 04:15:50 GMT, Alexander Matveev wrote: >> - It is not possible to support native JDK commands such as "java" inside >> Mac App Store bundles due to embedded info.plist. Workarounds suggested in >> JDK-8286122 does not seems to be visible. >> - With proposed fix we will

Re: RFR: 8277493: [REDO] Quarantined jpackage apps are labeled as "damaged"

2022-05-11 Thread Alexey Semenyuk
On Wed, 4 May 2022 03:56:10 GMT, Alexander Matveev wrote: > - No changes to code provided by original fix. > - Added ad hoc signing on macOS aarch64, since macOS aarch64 cannot execute > unsigned code and code should be at least ad hoc signed. > - Signing of app bundle produced by

Re: RFR: 8277493: [REDO] Quarantined jpackage apps are labeled as "damaged"

2022-05-11 Thread Alexey Semenyuk
On Wed, 4 May 2022 03:56:10 GMT, Alexander Matveev wrote: > - No changes to code provided by original fix. > - Added ad hoc signing on macOS aarch64, since macOS aarch64 cannot execute > unsigned code and code should be at least ad hoc signed. > - Signing of app bundle produced by

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

2022-05-11 Thread Alexey Semenyuk
On Wed, 11 May 2022 21:31:44 GMT, Alexander Matveev wrote: > - It is not possible to support native JDK commands such as "java" inside Mac > App Store bundles due to embedded info.plist. Workarounds suggested in > JDK-8286122 does not seems to be visible. > - With proposed fix we will

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

2022-05-11 Thread Alexey Semenyuk
On Wed, 11 May 2022 21:31:44 GMT, Alexander Matveev wrote: > - It is not possible to support native JDK commands such as "java" inside Mac > App Store bundles due to embedded info.plist. Workarounds suggested in > JDK-8286122 does not seems to be visible. > - With proposed fix we will

Integrated: 8282351: jpackage does not work if class file has `$$` in the name on windows

2022-05-09 Thread Alexey Semenyuk
On Mon, 9 May 2022 21:25:37 GMT, Alexey Semenyuk wrote: > 8282351: jpackage does not work if class file has `$$` in the name on windows This pull request has now been integrated. Changeset: 29395534 Author: Alexey Semenyuk URL: https://git.openjdk.java.net/jdk/com

RFR: 8282351: jpackage does not work if class file has `$$` in the name on windows

2022-05-09 Thread Alexey Semenyuk
8282351: jpackage does not work if class file has `$$` in the name on windows - Commit messages: - Fix regression - 8282351: jpackage does not work if class file has `$$` in the name on windows Changes: https://git.openjdk.java.net/jdk/pull/8613/files Webrev:

Integrated: 8285616: [macos] Incorrect path for launcher-as-service.txt in .cfg file

2022-05-05 Thread Alexey Semenyuk
On Thu, 5 May 2022 20:00:54 GMT, Alexey Semenyuk wrote: > - Replace `System.getProperty("java.io.tmpdir")` call with hardcoded `/tmp` > string to get root folder for test files. > - Fix test cleanup - the test didn't delete test files upon completion This pull request has

RFR: 8285616: [macos] Incorrect path for launcher-as-service.txt in .cfg file

2022-05-05 Thread Alexey Semenyuk
- Replace `System.getProperty("java.io.tmpdir")` call with hardcoded `/tmp` string to get root folder for test files. - Fix test cleanup - the test didn't delete test files upon completion - Commit messages: - 8285616: [macos] Incorrect path for launcher-as-service.txt in .cfg file

Re: Integrated: 8285736: JDK-8236128 causes validate-source failures

2022-04-27 Thread Alexey Semenyuk
On Wed, 27 Apr 2022 16:53:44 GMT, Daniel D. Daugherty wrote: > A trivial fix for JDK-8236128 causes validate-source failures. Marked as reviewed by asemenyuk (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8429

Integrated: JDK-8236128: Allow jpackage create installers for services

2022-04-27 Thread Alexey Semenyuk
On Fri, 11 Mar 2022 23:37:06 GMT, Alexey Semenyuk wrote: > Implementation of [JDK-8275062: "Allow jpackage create installers for > services"](https://bugs.openjdk.java.net/browse/JDK-8275062) > CSR This pull request has now been integrated. Changeset: b675c597 Author:A

Re: [External] : Re: jpackage usage problems

2022-04-20 Thread Alexey Semenyuk
On 4/18/2022 7:06 PM, Hiran Chaudhuri wrote: On Mon, 2022-04-18 at 18:41 -0400, Alexey Semenyuk wrote: I've filed [1] and [2] CRs to track the issues. [1] https://bugs.openjdk.java.net/browse/JDK-8284973 [2] https://bugs.openjdk.java.net/browse/JDK-8284974 - Alexey Sounds great. Thank you

Re: [External] : Re: jpackage usage problems

2022-04-18 Thread Alexey Semenyuk
On 4/17/2022 2:22 PM, Hiran Chaudhuri wrote: On Thu, 2022-04-07 at 19:53 -0400, Alexey Semenyuk wrote: I can see two separate issues with jpackage: 1. jpackage reports NPE if it can't figure out the package name from the supplied application image. It should issue a helpful error

Re: RFR: JDK-8236128: Allow jpackage create installers for services [v2]

2022-04-14 Thread Alexey Semenyuk
> Implementation of [JDK-8275062: "Allow jpackage create installers for > services"](https://bugs.openjdk.java.net/browse/JDK-8275062) > CSR Alexey Semenyuk has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 121

Re: [External] : Re: jpackage usage problems

2022-04-07 Thread Alexey Semenyuk
(Thread[Daemon worker,5,main]) completed. Took 8.099 secs. I am surprised to see success, so my next step would be to evaluate the content of the .deb file. I doubt jpackage would have created all what was missing just now. However this evaluation will have to wait for a week. Hiran On Thu

Re: jpackage usage problems

2022-04-07 Thread Alexey Semenyuk
idate(Linux Pa ckageBundler.java:72) at jdk.jpackage/jdk.jpackage.internal.Arguments.generateBundle(Arguments .j ava:688) ... 3 more On Fri, 2022-04-01 at 12:37 -0400, Alexey Semenyuk wrote: Hi Hiran, Looks like jpackage fails because of missing package name on the command line.

Integrated: 8284067: jpackage'd launcher reports non-zero exit codes with error prompt

2022-04-06 Thread Alexey Semenyuk
On Thu, 31 Mar 2022 20:08:13 GMT, Alexey Semenyuk wrote: > Add missing `exit(exitCode)` call. > Add relevant unit test. This pull request has now been integrated. Changeset: b9cc3bc1 Author:Alexey Semenyuk URL: https://git.openjdk.java.net/jdk/

Re: RFR: 8284067: jpackage'd launcher reports non-zero exit codes with error prompt

2022-04-05 Thread Alexey Semenyuk
On Thu, 31 Mar 2022 20:08:13 GMT, Alexey Semenyuk wrote: > Add missing `exit(exitCode)` call. > Add relevant unit test. @sashamatveev please review - PR: https://git.openjdk.java.net/jdk/pull/8064

Re: jpackage usage problems

2022-04-01 Thread Alexey Semenyuk
Hi Hiran, Looks like jpackage fails because of missing package name on the command line. I agree that the error message is not helpful. Can you try one of jdk19 EA builds [1] to see if the problem is reproducible? [1] https://jdk.java.net/19/ - Alexey On 4/1/2022 5:58 AM, Hiran Chaudhuri

Re: [External] : Re: jpackage Windows support for 4 digits version

2022-03-25 Thread Alexey Semenyuk
much more complex workaround than the one above. /Sverre fre. 25. mar. 2022 kl. 08:00 skrev David Holmes : On 25/03/2022 5:14 am, Alexey Semenyuk wrote: > Hi Sverre, > > Oh, I misunderstood the problem. I though the issue was with parsing WiX > version s

Re: [External] : Re: jpackage Windows support for 4 digits version

2022-03-24 Thread Alexey Semenyuk
1 14:48:51  * What went wrong: 14:48:51  Execution failed for task ':jpackage'. 14:48:51  > Process 'command 'C:\Program Files\Eclipse Adoptium\jdk-17.0.2.8-hotspot/bin/jpackage.exe'' finished with non-zero exit tor. 24. mar. 2022 kl. 17:39 skrev Alexey Semenyuk : Hi Sverre, The ou

Re: jpackage Windows support for 4 digits version

2022-03-24 Thread Alexey Semenyuk
Hi Sverre, The output comes from quite old jpackage (jdk15, I guess). Please try jpackage from the newer jdk (the latest one would be the best option). They don't have this issue. - Alexey On 3/23/2022 10:01 AM, Sverre Moe wrote: Could jpackage instruct WiX when building a native

RFR: JDK-8236128: Allow jpackage create installers for services

2022-03-11 Thread Alexey Semenyuk
Implementation of [JDK-8275062: "Allow jpackage create installers for services"](https://bugs.openjdk.java.net/browse/JDK-8275062) CSR - Commit messages: - Whitespace cleanup - Whitespace cleanup - JDK-8236128: Allow jpackage create installers for services - Sync l10n files.

Re: RFR: 8279995: jpackage --add-launcher option should allow overriding description [v6]

2022-02-25 Thread Alexey Semenyuk
On Fri, 25 Feb 2022 01:27:52 GMT, Alexander Matveev wrote: >> Added ability to override description for additional launchers via >> "description" property. > > Alexander Matveev has updated the pull request incrementally with one > additional commit since the last revision: > > 8279995:

Re: RFR: 8279995: jpackage --add-launcher option should allow overriding description [v4]

2022-02-23 Thread Alexey Semenyuk
On Thu, 17 Feb 2022 06:54:33 GMT, Alexander Matveev wrote: >> Added ability to override description for additional launchers via >> "description" property. > > Alexander Matveev has updated the pull request incrementally with one > additional commit since the last revision: > > 8279995:

Re: JDK-17: Wndows jpackage destination directory not writable

2022-02-18 Thread Alexey Semenyuk
Hi Sverre, Interesting, I don't see changes in jpackage code related to the issue. In particular jdk.jpackage.internal.IOUtils.writableOutputDir() function is the same in JDK14, JDK17, and mainline. - Alexey On 2/18/2022 8:31 AM, Sverre Moe wrote: I executed our JDK11 docker image, which

Integrated: 8282007: Assorted enhancements to jpackage testing framework

2022-02-16 Thread Alexey Semenyuk
On Wed, 16 Feb 2022 20:06:09 GMT, Alexey Semenyuk wrote: > 8282007: Assorted enhancements to jpackage testing framework This pull request has now been integrated. Changeset: cd234f5d Author: Alexey Semenyuk URL: https://git.openjdk.java.net/jdk/com

Re: RFR: 8282007: Assorted enhancements to jpackage testing framework [v2]

2022-02-16 Thread Alexey Semenyuk
On Wed, 16 Feb 2022 23:53:44 GMT, Alexander Matveev wrote: >> Alexey Semenyuk has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Don't fail if requested to uninstall not installed Debian package > > test/

Re: RFR: 8282007: Assorted enhancements to jpackage testing framework [v3]

2022-02-16 Thread Alexey Semenyuk
> 8282007: Assorted enhancements to jpackage testing framework Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision: Copyright years fixed - Changes: - all: https://git.openjdk.java.net/jdk/pull/7502/files - new: ht

Re: RFR: 8282007: Assorted enhancements to jpackage testing framework [v2]

2022-02-16 Thread Alexey Semenyuk
> 8282007: Assorted enhancements to jpackage testing framework Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision: Don't fail if requested to uninstall not installed Debian package - Changes: - all: ht

Integrated: 8282011: test/jdk/tools/jpackage/windows/WinL10nTest.java test fails if light.exe is not in %PATH%

2022-02-16 Thread Alexey Semenyuk
On Wed, 16 Feb 2022 17:52:43 GMT, Alexey Semenyuk wrote: > 8282011: test/jdk/tools/jpackage/windows/WinL10nTest.java test fails if > light.exe is not in %PATH% This pull request has now been integrated. Changeset: 0b00ce17 Author:Alexey Semenyuk URL: https://git.openjdk.ja

RFR: 8282007: Assorted enhancements to jpackage testing framework

2022-02-16 Thread Alexey Semenyuk
8282007: Assorted enhancements to jpackage testing framework - Commit messages: - Trailing whitespace removed - 8282007: Assorted enhancements to jpackage testing framework - macOS bugix - Don't use TKit.assertZZZ to validate test setup correctness. Throw exception instead. -

RFR: 8282011: test/jdk/tools/jpackage/windows/WinL10nTest.java test fails if light.exe is not in %PATH%

2022-02-16 Thread Alexey Semenyuk
8282011: test/jdk/tools/jpackage/windows/WinL10nTest.java test fails if light.exe is not in %PATH% - Commit messages: - 8282011: test/jdk/tools/jpackage/windows/WinL10nTest.java test fails locally Changes: https://git.openjdk.java.net/jdk/pull/7500/files Webrev:

Integrated: 8281874: Can't unpack msi installers from test/jdk/tools/jpackage/windows/test/jdk/tools/jpackage/windows/WinShortcutPromptTest.java test

2022-02-16 Thread Alexey Semenyuk
On Tue, 15 Feb 2022 22:56:35 GMT, Alexey Semenyuk wrote: > 8281874: Can't unpack msi installers from > test/jdk/tools/jpackage/windows/test/jdk/tools/jpackage/windows/WinShortcutPromptTest.java > test This pull request has now been integrated. Changeset: 81645521 Author: Alexey

Integrated: 8281170: Test jdk/tools/jpackage/windows/WinInstallerIconTest always fails on Windows 11

2022-02-16 Thread Alexey Semenyuk
On Tue, 15 Feb 2022 17:44:24 GMT, Alexey Semenyuk wrote: > Code clean up. Remove obsolete comments, unused imports, and unneeded jtreg > test parameter. > Fix the code to handle the case when installers are not created and there is > nothing to verify in the test. This pull req

RFR: 8281874: Can't unpack msi installers from test/jdk/tools/jpackage/windows/test/jdk/tools/jpackage/windows/WinShortcutPromptTest.java test

2022-02-15 Thread Alexey Semenyuk
8281874: Can't unpack msi installers from test/jdk/tools/jpackage/windows/test/jdk/tools/jpackage/windows/WinShortcutPromptTest.java test - Commit messages: - 8281874: Can't unpack msi installers from

RFR: 8281170: Test jdk/tools/jpackage/windows/WinInstallerIconTest always fails on Windows 11

2022-02-15 Thread Alexey Semenyuk
Code clean up. Remove obsolete comments, unused imports, and unneeded jtreg test parameter. Fix the code to handle the case when installers are not created and there is nothing to verify in the test. - Commit messages: - 8281170: Test

Re: RFR: 8279995: jpackage --add-launcher option should allow overriding description [v3]

2022-02-15 Thread Alexey Semenyuk
On Mon, 14 Feb 2022 23:56:43 GMT, Alexander Matveev wrote: >> Added ability to override description for additional launchers via >> "description" property. > > Alexander Matveev has updated the pull request incrementally with one > additional commit since the last revision: > > 8279995:

Re: RFR: 8279995: jpackage --add-launcher option should allow overriding description [v3]

2022-02-15 Thread Alexey Semenyuk
On Mon, 14 Feb 2022 23:56:43 GMT, Alexander Matveev wrote: >> Added ability to override description for additional launchers via >> "description" property. > > Alexander Matveev has updated the pull request incrementally with one > additional commit since the last revision: > > 8279995:

Re: RFR: 8279995: jpackage --add-launcher option should allow overriding description [v2]

2022-02-11 Thread Alexey Semenyuk
On Fri, 11 Feb 2022 21:22:44 GMT, Alexander Matveev wrote: >> Added ability to override description for additional launchers via >> "description" property. > > Alexander Matveev has updated the pull request incrementally with one > additional commit since the last revision: > > 8279995:

Re: RFR: 8279995: jpackage --add-launcher option should allow overriding description

2022-02-09 Thread Alexey Semenyuk
On Wed, 9 Feb 2022 07:37:42 GMT, Alexander Matveev wrote: > Added ability to override description for additional launchers via > "description" property. Unfortunately, manual testing adds zero value to automated test runs. This feature can be covered with automated tests so it should be.

Re: RFR: 8279995: jpackage --add-launcher option should allow overriding description

2022-02-09 Thread Alexey Semenyuk
On Wed, 9 Feb 2022 18:53:35 GMT, Alexander Matveev wrote: >> test/jdk/tools/jpackage/share/AddLauncherTest.java line 93: >> >>> 91: new AdditionalLauncher("Baz2") >>> 92: .setDefaultArguments() >>> 93: .addRawProperties(Map.entry("description", "Baz2 >>>

Re: RFR: 8279995: jpackage --add-launcher option should allow overriding description

2022-02-09 Thread Alexey Semenyuk
On Wed, 9 Feb 2022 07:37:42 GMT, Alexander Matveev wrote: > Added ability to override description for additional launchers via > "description" property. I don't quite understand how these changes affect the description of launcher executables on Windows. I'd expect changes at least in

Integrated: 8257434: jpackage fails to create rpm on Fedora Linux

2022-01-18 Thread Alexey Semenyuk
On Tue, 1 Dec 2020 23:54:11 GMT, Alexey Semenyuk wrote: > Add missing quotes to `%if` expressions in spec template. Required by > rpmbuild 4.16.0 This pull request has now been integrated. Changeset: 541c7f74 Author:Alexey Semenyuk URL: https://git.openjdk.java.net/jdk/

Re: Integrated: 8257434: jpackage fails to create rpm on Fedora Linux

2022-01-18 Thread Alexey Semenyuk
On Tue, 1 Dec 2020 23:54:11 GMT, Alexey Semenyuk wrote: > Add missing quotes to `%if` expressions in spec template. Required by > rpmbuild 4.16.0 @sashamatveev @andyherrick please review - PR: https://git.openjdk.java.net/jdk/pull/1551

Integrated: 8257434: jpackage fails to create rpm on Fedora Linux

2022-01-18 Thread Alexey Semenyuk
Add missing quotes to `%if` expressions in spec template. Required by rpmbuild 4.16.0 - Commit messages: - 8257434: jpackage fails to create rpm on Fedora Linux Changes: https://git.openjdk.java.net/jdk/pull/1551/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1551=00

Re: [jdk18] RFR: 8279370: jdk.jpackage/share/native/applauncher/JvmLauncher.cpp fails to build with GCC 6.3.0

2022-01-12 Thread Alexey Semenyuk
On Mon, 3 Jan 2022 08:10:27 GMT, Aleksey Shipilev wrote: > Seems like a missing include. C++ docs say `offsetof` is from ``, > adding that include explicitly fixes the build. Seems to only happen with > older GCCs, but it seems to be a happy accident it works on newer ones, > probably through

Re: [jdk18] RFR: 8278907: JPackage test - SigningPackageTest is failed with runtime exception

2021-12-17 Thread Alexey Semenyuk
On Fri, 17 Dec 2021 03:28:12 GMT, Alexander Matveev wrote: > This is regression from JDK-8263155. MacHelper.java is now calling test > verification callback with all content in DMG root. SigningPackageTest > expects only path with app name in it and thus it fails when trying to verify > app

Re: [jdk18] RFR: 8278233: [macos] tools/jpackage tests timeout due to /usr/bin/osascript

2021-12-14 Thread Alexey Semenyuk
On Tue, 14 Dec 2021 06:10:51 GMT, Alexander Matveev wrote: > This is regression from JDK-8276837. exec() was passing INFINITE_TIMEOUT > instead of actual value of timeout variable. Execution of osascript was > running without timeout and thus several tests timeout. Osascript hang during >

RFR: 8278311: Debian packaging doesn't work

2021-12-06 Thread Alexey Semenyuk
8278311: Debian packaging doesn't work - Commit messages: - Changes from another fix removed - 8278311: Debian packaging doesn't work Changes: https://git.openjdk.java.net/jdk/pull/6726/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=6726=00 Issue:

Re: RFR: JDK-8276837: [macos]: Error when signing the additional launcher

2021-12-01 Thread Alexey Semenyuk
On Wed, 1 Dec 2021 21:35:01 GMT, Andy Herrick wrote: > - We need to unsign all executables and libraries in the app-image before > signing. (not just those in the runtime). > - Clean up excessive output by executing the individual file sign and > unsigning commands in quiet mode. > - Add

Re: RFR: JDK-8276837: [macos]: Error when signing the additional launcher

2021-12-01 Thread Alexey Semenyuk
On Wed, 1 Dec 2021 14:25:52 GMT, Andy Herrick wrote: > Before signing, unsign all executables and libraries (not just those in > runtime). > Also, run individual file sign and unsign commands in quiet mode. > Also, add test case to SigningAppImageTest to test that signing app that has >

Re: RFR: 8277647: [REDO] JDK-8277507 Add jlink.debug system property while launching jpackage tests to help diagonize recent intermittent failures

2021-11-24 Thread Alexey Semenyuk
On 11/24/2021 8:35 AM, Andy Herrick wrote: Wait - the original change, 'addArgument("-J-Djlink.debug=true");' adds "-D-J..." as a jpackage arg.  This is not a supported command line option, I'm not sure why it is not throwing an error all the time, but you need to use

Integrated: 8277429: Conflicting jpackage static library name

2021-11-22 Thread Alexey Semenyuk
On Sat, 20 Nov 2021 03:26:51 GMT, Alexey Semenyuk wrote: > 8277429: Conflicting jpackage static library name This pull request has now been integrated. Changeset: e3911a85 Author: Alexey Semenyuk URL: https://git.openjdk.java.net/jdk/commit/e3911a8532e9b93ba5e65c613bd79864485db

RFR: 8277429: Conflicting jpackage static library name

2021-11-19 Thread Alexey Semenyuk
8277429: Conflicting jpackage static library name - Commit messages: - 8277429: Conflicting jpackage static library name Changes: https://git.openjdk.java.net/jdk/pull/6485/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=6485=00 Issue:

Re: RFR: 8277494: [BACKOUT] JDK-8276150 Quarantined jpackage apps are labeled as "damaged"

2021-11-19 Thread Alexey Semenyuk
On Fri, 19 Nov 2021 20:57:46 GMT, Daniel D. Daugherty wrote: > This reverts commit 936f7ff49ed86adb74bb1ff10d93cb3d7f7d70a0. > > So far we've had 3 failed Tier2 job sets in a row. My Mach5 Tier2 of this > [BACKOUT] has > passed the macosx-aarch64 test task that was failing before. Marked as

Integrated: 8274856: Failing jpackage tests with fastdebug/release build

2021-11-15 Thread Alexey Semenyuk
On Fri, 5 Nov 2021 19:58:01 GMT, Alexey Semenyuk wrote: > The fix is to isolate C++ calls in the separate forked child process on > Linux. > This change requires the passing of JLI command line arguments and values of > environment variables between two processes. This pull req

Integrated: 8276084: Linux DEB Bundler: release number in outputted .deb file should be optional

2021-11-15 Thread Alexey Semenyuk
On Thu, 11 Nov 2021 04:07:18 GMT, Alexey Semenyuk wrote: > 8276084: Linux DEB Bundler: release number in outputted .deb file should be > optional This pull request has now been integrated. Changeset: 9046077f Author:Alexey Semenyuk URL: https://git.openjdk.java.net/jdk/

RFR: 8276084: Linux DEB Bundler: release number in outputted .deb file should be optional

2021-11-10 Thread Alexey Semenyuk
8276084: Linux DEB Bundler: release number in outputted .deb file should be optional - Commit messages: - Bugfix - Bugfix - Bugfix - 8276084: Linux DEB Bundler: release number in outputted .deb file should be optional Changes: https://git.openjdk.java.net/jdk/pull/6345/files

RFR: 8274856: Failing jpackage tests with fastdebug/release build

2021-11-05 Thread Alexey Semenyuk
The fix is to isolate C++ calls in the separate forked child process on Linux. This change requires the passing of JLI command line arguments and values of environment variables between two processes. - Commit messages: - Whitespace clean up - 8274856: Failing jpackage tests with

Re: RFR: JDK-8276562: Fix to JDK-8263155 left out the help text changes

2021-11-05 Thread Alexey Semenyuk
On Fri, 5 Nov 2021 17:21:01 GMT, Andy Herrick wrote: > JDK-8276562: Fix to JDK-8263155 left out the help text changes Marked as reviewed by asemenyuk (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6281

Re: RFR: JDK-8263155: Allow additional contents for DMG [v2]

2021-10-21 Thread Alexey Semenyuk
On Thu, 21 Oct 2021 15:36:36 GMT, Andy Herrick wrote: >> JDK-8263155: Allow additional contents for DMG > > Andy Herrick has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains five commits: > > - Merge branch 'master' into

Re: RFR: 8274346: Support for additional content in an app-image. [v2]

2021-10-06 Thread Alexey Semenyuk
On Wed, 6 Oct 2021 18:53:39 GMT, Andy Herrick wrote: >> 8274346: Support for additional content in an app-image. > > Andy Herrick has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8274346: Support for additional content in an app-image.

Re: RFR: 8274346: Support for additional content in an app-image.

2021-10-04 Thread Alexey Semenyuk
On Thu, 30 Sep 2021 18:51:49 GMT, Andy Herrick wrote: > 8274346: Support for additional content in an app-image. Changes requested by asemenyuk (Reviewer). test/jdk/tools/jpackage/share/AppContentTest.java line 97: > 95: for (String p : paths) { > 96:

Re: RFR: JDK-8274087: Windows DLL path not set correctly.

2021-09-23 Thread Alexey Semenyuk
On Thu, 23 Sep 2021 20:03:29 GMT, Andy Herrick wrote: > JDK-8274087: Windows DLL path not set correctly. Marked as reviewed by asemenyuk (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5663

Re: RFR: 8272815: jpackage --type rpm produces an error: Invalid or unsupported type: [null] [v3]

2021-09-15 Thread Alexey Semenyuk
> Fix jpackage error output when "--type" CLI option is missing and jpackage > detects that it can't build native packages in the environment. Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision: dummy commit --

Integrated: 8272815: jpackage --type rpm produces an error: Invalid or unsupported type: [null]

2021-09-15 Thread Alexey Semenyuk
On Tue, 14 Sep 2021 17:21:29 GMT, Alexey Semenyuk wrote: > Fix jpackage error output when "--type" CLI option is missing and jpackage > detects that it can't build native packages in the environment. This pull request has now been integrated. Changeset: a3ca7702 Author:

Re: RFR: 8272815: jpackage --type rpm produces an error: Invalid or unsupported type: [null] [v2]

2021-09-14 Thread Alexey Semenyuk
> Fix jpackage error output when "--type" CLI option is missing and jpackage > detects that it can't build native packages in the environment. Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision: dummy commit --

RFR: 8272815: jpackage --type rpm produces an error: Invalid or unsupported type: [null]

2021-09-14 Thread Alexey Semenyuk
Fix jpackage error output when "--type" CLI option is missing and jpackage detects that it can't build native packages in the environment. - Commit messages: - 8272815: jpackage --type rpm produces an error: Invalid or unsupported type: [null] Changes:

Re: RFR: JDK-8273040: Turning off JpAllowDowngrades (or Upgrades)

2021-09-14 Thread Alexey Semenyuk
On Tue, 14 Sep 2021 13:38:42 GMT, Andy Herrick wrote: > JDK-8273040: Turning off JpAllowDowngrades (or Upgrades) Marked as reviewed by asemenyuk (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5509

Re: RFR: 8273595: tools/jpackage tests do not work on apt-based Linux distros like Debian

2021-09-10 Thread Alexey Semenyuk
On Fri, 10 Sep 2021 12:03:48 GMT, Ao Qi wrote: > A similar issue on Ubuntu has been fixed by > [JDK-8238953](https://bugs.openjdk.java.net/browse/JDK-8238953). However, > tools/jpackage tests do not work on Debian Linux or other apt-based Linux, > when rpm package is installed. This issue

Re: RFR: 8273595: tools/jpackage tests do not work on apt-based Linux distros like Debian

2021-09-10 Thread Alexey Semenyuk
On Fri, 10 Sep 2021 12:03:48 GMT, Ao Qi wrote: > A similar issue on Ubuntu has been fixed by > [JDK-8238953](https://bugs.openjdk.java.net/browse/JDK-8238953). However, > tools/jpackage tests do not work on Debian Linux or other apt-based Linux, > when rpm package is installed. This issue

Re: [jdk17] RFR: JDK-8273592: Backout JDK-8271868

2021-09-10 Thread Alexey Semenyuk
On Fri, 10 Sep 2021 13:18:49 GMT, Andy Herrick wrote: > JDK-8271868 was pushed to JDK17 instead of jdk17u. > This change is to back it out Marked as reviewed by asemenyuk (Reviewer). - PR: https://git.openjdk.java.net/jdk17/pull/307

Re: [jdk17] RFR: JDK-8272639: jpackaged applications using microphone on mac

2021-09-09 Thread Alexey Semenyuk
On Thu, 9 Sep 2021 20:14:01 GMT, Andy Herrick wrote: > backport from jdk-18 Marked as reviewed by asemenyuk (Reviewer). - PR: https://git.openjdk.java.net/jdk17/pull/306

Re: [jdk17] RFR: 8271868: Warn user when using mac-sign option with unsigned app-image.

2021-09-09 Thread Alexey Semenyuk
On Thu, 9 Sep 2021 16:36:44 GMT, Andy Herrick wrote: > This is a backport from JDK-18 Marked as reviewed by asemenyuk (Reviewer). - PR: https://git.openjdk.java.net/jdk17/pull/305

Integrated: 8271170: Add unit test for what jpackage app launcher puts in the environment

2021-08-11 Thread Alexey Semenyuk
On Mon, 9 Aug 2021 17:02:55 GMT, Alexey Semenyuk wrote: > Added jtreg test to verify jpackage launcher adds app dir to > `java.library.path` system property. > Removed unused test/jdk/tools/jpackage/apps/installer/Hello.java. > Moved test/jdk/tools/jpackage/apps/image/Hello.java to

Re: RFR: 8271170: Add unit test for what jpackage app launcher puts in the environment [v4]

2021-08-11 Thread Alexey Semenyuk
> Added jtreg test to verify jpackage launcher adds app dir to > `java.library.path` system property. > Removed unused test/jdk/tools/jpackage/apps/installer/Hello.java. > Moved test/jdk/tools/jpackage/apps/image/Hello.java to > test/jdk/tools/jpackage/apps/Hello.java. Alex

Integrated: 8272328: java.library.path is not set properly by Windows jpackage app launcher

2021-08-11 Thread Alexey Semenyuk
On Wed, 11 Aug 2021 17:52:57 GMT, Alexey Semenyuk wrote: > Restart window app launcher to make changes made to `PATH` env variable > visible to JLI code in > https://github.com/openjdk/jdk/blob/master/src/hotspot/os/windows/os_windows.cpp#L347 This pull request has now been i

RFR: 8272328: java.library.path is not set properly by Windows jpackage app launcher

2021-08-11 Thread Alexey Semenyuk
Restart window app launcher to make changes made to `PATH` env variable visible to JLI code in https://github.com/openjdk/jdk/blob/master/src/hotspot/os/windows/os_windows.cpp#L347 - Commit messages: - 8272328: java.library.path is not set properly by Windows jpackage app

Re: RFR: 8271170: Add unit test for what jpackage app launcher puts in the environment [v3]

2021-08-11 Thread Alexey Semenyuk
On Wed, 11 Aug 2021 15:20:00 GMT, Alexey Semenyuk wrote: >> Added jtreg test to verify jpackage launcher adds app dir to >> `java.library.path` system property. >> Removed unused test/jdk/tools/jpackage/apps/installer/Hello.java. >> Moved test/jdk/tools/jpacka

Re: RFR: 8271170: Add unit test for what jpackage app launcher puts in the environment [v3]

2021-08-11 Thread Alexey Semenyuk
> Added jtreg test to verify jpackage launcher adds app dir to > `java.library.path` system property. > Removed unused test/jdk/tools/jpackage/apps/installer/Hello.java. > Moved test/jdk/tools/jpackage/apps/image/Hello.java to > test/jdk/tools/jpackage/apps/Hello.java. Alex

Re: RFR: 8271170: Add unit test for what jpackage app launcher puts in the environment [v2]

2021-08-09 Thread Alexey Semenyuk
> Added jtreg test to verify jpackage launcher adds app dir to > `java.library.path` system property. > Removed unused test/jdk/tools/jpackage/apps/installer/Hello.java. > Moved test/jdk/tools/jpackage/apps/image/Hello.java to > test/jdk/tools/jpackage/apps/Hello.java. Alex

RFR: 8271170: Add unit test for what jpackage app launcher puts in the environment

2021-08-09 Thread Alexey Semenyuk
Added jtreg test to verify jpackage launcher adds app dir to `java.library.path` system property. Removed unused test/jdk/tools/jpackage/apps/installer/Hello.java. Moved test/jdk/tools/jpackage/apps/image/Hello.java to test/jdk/tools/jpackage/apps/Hello.java. - Commit messages: -

Re: RFR: 8271868: Warn user when using mac-sign option with unsigned app-image. [v2]

2021-08-05 Thread Alexey Semenyuk
On Thu, 5 Aug 2021 17:07:13 GMT, Andy Herrick wrote: >> 8271868: Warn user when using mac-sign option with unsigned app-image. > > Andy Herrick has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8271868: Warn user when using mac-sign

  1   2   3   4   5   6   7   >