Subtle differences in System.getenv() between Windows and Linux

2021-03-09 Thread Galder Zamarreno
Hi all, One of my colleagues discovered an intriguing difference between Linux and Windows, in the context of GraalVM native-image, when it comes to the returned value for System.getenv(). On windows, the native test he's encountered that a test fails with: > Error: No instances of

Re: RFR: JDK-8251397 NPE on ClassValue.ClassValueMap.cacheArray

2020-09-09 Thread Galder Zamarreno
an idea to modify HotSpot so it places a StoreStore fence > directly before the store to a @Stable field. > > Paul. > > > On Aug 19, 2020, at 4:53 AM, Galder Zamarreno wrote: > > > > Hi all, > > > > I've created patch [1] to fix the ClassValue$ClassValue

Re: Possible subtle memory model error in ClassValue

2020-08-19 Thread Galder Zamarreno
On Mon, Aug 10, 2020 at 2:19 PM Doug Lea wrote: > Catching up... > > As implied in other posts, the minimal fix is to add a trailing release > fence (using Unsafe?) to the constructor. FYI I have sent an RFR with the proposed fix ^

RFR: JDK-8251397 NPE on ClassValue.ClassValueMap.cacheArray

2020-08-19 Thread Galder Zamarreno
Hi all, I've created patch [1] to fix the ClassValue$ClassValueMap NPE bug in [2]. The bug has been discussed by other members in the list in thread [3]. The patch follows the simple fix suggested by Doug and others in that exchange, e.g. [4]. That is, it adds a release fence to

Re: Possible subtle memory model error in ClassValue

2020-08-10 Thread Galder Zamarreno
Hi, I'm David's colleague. I'm the one who's spotted this issue twice while GraalVM is doing its points-to analysis with jdk11u-dev. The fuller exception is here: Caused by: java.lang.NullPointerException at java.base/java.lang.ClassValue$ClassValueMap.loadFromCache(ClassValue.java:535)