Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports - (core libraries)

2020-05-07 Thread Kumar Srinivasan
ok to me. I did notice the \n endings for the messages that Brent pointed out. Best Kumar Srinivasan On May 6, 2020, at 9:43 PM, Mikael Vidstedt mailto:mikael.vidst...@oracle.com>> wrote: I have always wondered what “solinux” is supposed to mean - though not enough to actual

Re: [14] RFR(S/T) : 8235866 : bump jtreg requiredVersion to 4.2b16

2019-12-13 Thread Kumar Srinivasan
Hey Igor — please read inlined comment below….. [cc’ed Jon] On Dec 12, 2019, at 10:46 PM, Igor Ignatyev mailto:igor.ignat...@oracle.com>> wrote: On Dec 12, 2019, at 10:21 PM, David Holmes mailto:david.hol...@oracle.com>> wrote: Hi Igor, On 13/12/2019 3:19 pm, Igor Ignatyev wrote:

Re: [EXTERNAL] JDK-8234076 bug fix candidate

2019-12-12 Thread Kumar Srinivasan
e test and push it before > RDP1 if everything is good with Kumar as reviewer. > > Cheers, > Henry > > >> On Dec 11, 2019, at 2:26 PM, Kumar Srinivasan wrote: >> >> Hi Nikola, >> >> Thank you for making the changes. Looks good to me. &g

Re: [EXTERNAL] JDK-8234076 bug fix candidate

2019-12-11 Thread Kumar Srinivasan
Hi Nikola, Thank you for making the changes. Looks good to me. Kumar Srinivasan PS: my new and official email address: kusriniva...@vmware.com On Wed, Dec 11, 2019 at 10:04 AM Nikola Grcevski < nikola.grcev...@microsoft.com> wrote: > Thank you again for reviewing my code Kumar! &

Re: [EXTERNAL] JDK-8234076 bug fix candidate

2019-12-10 Thread Kumar Srinivasan
.shouldContain("F--help"); > + > +// java --module-path=mods --module=$TESTMODULE/$MAINCLASS > <...src/test>/*.java --help > +// We should be able to see argument expansion happen > +ProcessTools.executeProcess( > +create

Re: [EXTERNAL] JDK-8234076 bug fix candidate

2019-12-07 Thread Kumar Srinivasan
, which prints its args, http://hg.openjdk.java.net/jdk/jdk/file/31882abe1494/test/jdk/tools/launcher/TestHelper.java Kumar Srinivasan On Fri, Dec 6, 2019 at 2:44 PM Henry Jen wrote: > Thanks for the work, the test case covers that when —module= is used > before other options, which i

Re: [EXTERNAL] JDK-8234076 bug fix candidate

2019-12-04 Thread Kumar Srinivasan
ook at this, you are correct, this patch doesn’t > address the wildcard expansion issue, but only to address the potential > crash if a main class is not specified as Nikola pointed out. > > We definitely need a follow up to fix wildcard expansion. The pointer to > simplify the test is help

Re: [EXTERNAL] Re: JDK-8234076 bug fix candidate

2019-12-03 Thread Kumar Srinivasan
are in Aaarghs.java the modules related tests for the launcher are at: https://hg.openjdk.java.net/jdk/jdk13/file/0368f3a073a9/test/jdk/tools/launcher/modules/basic Using the modules test framework may make the test simpler. Kumar Srinivasan On Mon, Dec 2, 2019 at 11:34 AM Nikola Grcevski

Re: [11] RFR: 8202553: Update FXLauncherTest as part of removing JavaFX from JDK

2018-05-10 Thread Kumar Srinivasan
. -- Kevin On 5/9/2018 4:32 AM, Kevin Rushforth wrote: I'll work up a new version of the webrev that addresses your feedback, and strip down the mockfx classes to the minimum needed to support the test cases. -- Kevin On 5/8/2018 3:52 PM, Kumar Srinivasan wrote: Hi Kevin, Please review

Re: [11] RFR: 8202553: Update FXLauncherTest as part of removing JavaFX from JDK

2018-05-08 Thread Kumar Srinivasan
Hi Kevin, Please review the following test fix: https://bugs.openjdk.java.net/browse/JDK-8202553 http://cr.openjdk.java.net/~kcr/8202553/webrev.00/ FXLauncherTest.java: 57 private static final String TEST_SRC = System.getProperty("test.src"); Since this test extends TestHelper, it

Re: RFR: 8201274: Launch Single-File Source-Code Programs

2018-04-25 Thread Kumar Srinivasan
Hi John, I focused mainly on the native side, looks ok, except for a couple of minor issues. java.c 1320 const char *prop = "-Djdk.internal.javac.source="; 1321 size_t size = JLI_StrLen(prop) + JLI_StrLen(value) + 1; 1322 char *propValue = (char

RFR: 8201259: Fix warning with VS2017 in jdk.pack

2018-04-20 Thread Kumar Srinivasan
Hello, Please review fix [1] for VS2017 to compile pack200 native header file, without warnings. Thanks Kumar [1] http://cr.openjdk.java.net/~ksrini/8201259/

RFR: 8198793:Add launcher support for preview features

2018-04-11 Thread Kumar Srinivasan
Hello, Could I get a review to update the launcher help message. https://bugs.openjdk.java.net/browse/JDK-8198793 diff --git a/src/java.base/share/classes/sun/launcher/resources/launcher.properties b/src/java.base/share/classes/sun/launcher/resources/launcher.properties ---

Re: RFR: 8196750 [Testbug] tools/launcher tests need to tolerate unrelated warnings

2018-04-05 Thread Kumar Srinivasan
Looks good, thanks for doing this!. Kumar On 4/4/2018 5:09 PM, Andrey Nazarov wrote: On 22 Mar 2018, at 07:18, Kumar Srinivasan <kumar.x.sriniva...@oracle.com> wrote: David, Why would the VM emit these warnings if the deprecated vm flag is not being used ? Andrey, As for the review

Re: RFR: 8196750 [Testbug] tools/launcher tests need to tolerate unrelated warnings

2018-03-22 Thread Kumar Srinivasan
David, Why would the VM emit these warnings if the deprecated vm flag is not being used ? Andrey, As for the reviews I am ok with InfoStreams, wrt. ToolOpts it is not at all apparent, maybe more comments explaining what is going on ? Kumar Hi Andrei, On 22/03/2018 11:12 AM, Andrey

Re: RFR(XS): 8195824: tools/launcher/HelpFlagsTest.java fails with java.lang.AssertionError

2018-01-23 Thread Kumar Srinivasan
Hi, I got the test results and I also manually tested on Windows, everything looks good, you can go ahead and push the changes. Thanks Kumar The last time around, I was missing the deploy repo and thus the build/test system did not take deploy into account. My error. I will retest and

Re: RFR(XS): 8195824: tools/launcher/HelpFlagsTest.java fails with java.lang.AssertionError

2018-01-23 Thread Kumar Srinivasan
The last time around, I was missing the deploy repo and thus the build/test system did not take deploy into account. My error. I will retest and report. Kumar Hi, I can not do proper tests with OracleJDK, sorry for that. This webrev removes the problem from the ProblemList:

Re: RFR(XS): 8195663: jdk/tools/launcher/HelpFlagsTest.java fails with java.lang.AssertionError: HelpFlagsTest failed:

2018-01-19 Thread Kumar Srinivasan
egards, Goetz. -Original Message- From: Weijun Wang [mailto:weijun.w...@oracle.com] Sent: Donnerstag, 18. Januar 2018 16:44 To: Lindenmaier, Goetz <goetz.lindenma...@sap.com> Cc: Kumar Srinivasan <kumar.x.sriniva...@oracle.com>; jdk- d...@openjdk.java.net Subject: Re: RFR(

RFR: 8195072: Update ASM 3rd party legal (TPL) copyright to 6.0

2018-01-12 Thread Kumar Srinivasan
Hello, Could I get a review for this simple update to the 3rd party legal (TPL) information. Thanks Webrev: http://cr.openjdk.java.net/~ksrini/8195072/webrev.00/ JBS: https://bugs.openjdk.java.net/browse/JDK-8195072 Current ASM copyright:

Re: RFR: 8194287 and 8194286: simple test changes for the execution of these tests in a docket container

2018-01-12 Thread Kumar Srinivasan
, Roger On 1/11/2018 6:00 PM, Kumar Srinivasan wrote: Hi, Please review bug fixes for 2 test bugs, which fails with a base Linux installation in a docker container. Thanks Kumar [1] http://cr.openjdk.java.net/~ksrini/8194287/webrev-00/ [2] http://cr.openjdk.java.net/~ksrini/8194287/cmt.txt

RFR: 8194287 and 8194286: simple test changes for the execution of these tests in a docket container

2018-01-11 Thread Kumar Srinivasan
Hi, Please review bug fixes for 2 test bugs, which fails with a base Linux installation in a docker container. Thanks Kumar [1] http://cr.openjdk.java.net/~ksrini/8194287/webrev-00/ [2] http://cr.openjdk.java.net/~ksrini/8194287/cmt.txt

Re: RFR: 8189102: All tools should support -?, -h and --help

2017-12-01 Thread Kumar Srinivasan
. -Original Message- From: Kumar Srinivasan [mailto:kumar.x.sriniva...@oracle.com] Sent: Montag, 27. November 2017 17:43 To: Lindenmaier, Goetz <goetz.lindenma...@sap.com> Cc: core-libs-dev@openjdk.java.net; 'compiler-...@openjdk.java.net' <compiler-...@openjdk.java.net>; servic

Re: RFR: 8189102: All tools should support -?, -h and --help

2017-11-27 Thread Kumar Srinivasan
Hi, I looked at some of the components I maintain, and they look good. Wrt. the test: 1. The local variables/fields don't comply with the coding conventions, we have been following in the JDK. 2. Hmm, someone parked a .ini file in bin directory, later removed, perhaps on windows

Re: RFR: 8190287: Update JDK's internal ASM to ASMv6

2017-10-31 Thread Kumar Srinivasan
Hi Remi, Are you ok with the ASMv6 changes ? Thanks Kumar On 10/27/2017 10:12 AM, Kumar Srinivasan wrote: Hello Remi, Sundar and others, Please review the webrev [1] to update JDK's internal ASM to v6. To help with review areas, you can use the browser to search for mq patches commented

RFR: 8190287: Update JDK's internal ASM to ASMv6

2017-10-27 Thread Kumar Srinivasan
Hello Remi, Sundar and others, Please review the webrev [1] to update JDK's internal ASM to v6. To help with review areas, you can use the browser to search for mq patches commented with // Highlights of changes: 1. updated ASMv6 // jdk-new-asmv6.patch 2. changes to jlink and jar to add

Re: [10] Review Request: 8187442 Xcheck:jni produces various "WARNING in native method" in launcher

2017-09-20 Thread Kumar Srinivasan
Hi, Looks good to me. Kumar On 9/14/2017 12:01 PM, Sergey Bylokhov wrote: Hi, Kumar. The test is updated as suggested: http://cr.openjdk.java.net/~serb/8187442/webrev.01 On 9/13/17 10:16, Kumar Srinivasan wrote: Hi Sergey, If you so wish, you could make the test a little simpler, by using

Re: [10] Review Request: 8187442 Xcheck:jni produces various "WARNING in native method" in launcher

2017-09-13 Thread Kumar Srinivasan
Hi Sergey, If you so wish, you could make the test a little simpler, by using the createJar method in TestHelper.java which compiles a file and creates an executable jar out of it, refer to ArgsEnvVar.java, lines 43 to 54 in the test can be replaced by: StringBuilder tsrc = new

Re: [10] Review Request: 8187442 Xcheck:jni produces various "WARNING in native method" in launcher

2017-09-13 Thread Kumar Srinivasan
Let me take a look as well, I will respond in a day. Kumar On 9/12/2017 5:04 PM, David Holmes wrote: On 13/09/2017 9:42 AM, Sergey Bylokhov wrote: On 9/12/17 16:03, David Holmes wrote: call. That is fine, but still leaves the problem that you are skipping the DeleteLocalRef call. The leak

Re: RFR: JDK-8183579: refactor and cleanup launcher help messages

2017-07-28 Thread Kumar Srinivasan
Mandy, Thanks for the reviewplease see in-lined comments, On Jul 20, 2017, at 11:53 AM, Kumar Srinivasan<kumar.x.sriniva...@oracle.com> wrote: Hi, Please review refactoring and clean up of the java launcher's help/usage messages. The highlights of the changes are as follo

Re: RFR 8179292: a number of launcher tests fail when run with --limit-modules due to CNFE: javax.tools.ToolProvider

2017-07-26 Thread Kumar Srinivasan
+1 Kumar On 7/25/2017 6:30 PM, Andrey Nazarov wrote: Thank you! On 25 Jul 2017, at 18:20, Mandy Chung wrote: On Jul 25, 2017, at 6:18 PM, Andrey Nazarov > wrote: Updated by this line.

RFR: JDK-8183579: refactor and cleanup launcher help messages

2017-07-20 Thread Kumar Srinivasan
Hi, Please review refactoring and clean up of the java launcher's help/usage messages. The highlights of the changes are as follows: 1. Helper.java: is renamed from LauncherHelper.java, simpler name, containing mostly methods to help with class loading, module assistance etc. 2.

RFR: JDK9 : JDK-8183141: java --help-extra in non-English locales lists --permit-illegal-access which no longer exists

2017-06-28 Thread Kumar Srinivasan
Hello, Please review fix for [1] with this webrev [2]. All this does is remove the incorrect option in the localized pages, as described in [1]. I have tested all of them on Unix with the limited default Western European locales, I have on the system. Appreciate if someone wants to check it

Re: RFR: JDK10: JDK-8180334: Unable to build jaotc launcher on windows

2017-06-08 Thread Kumar Srinivasan
as compile time and runtime check, the latter for a good measure. Thanks Kumar PS: Mandy, could you please file a RFE for the jlink requirements and assign it to me. On Jun 7, 2017, at 2:58 PM, Kumar Srinivasan <kumar.x.sriniva...@oracle.com> wrote: Hello, Please review the c

Re: RFR: JDK10: JDK-8180334: Unable to build jaotc launcher on windows

2017-06-08 Thread Kumar Srinivasan
, 2017, at 2:58 PM, Kumar Srinivasan <kumar.x.sriniva...@oracle.com> wrote: Hello, Please review the changes to fix JDK-8180334, essentially -DJAVA_ARGS exceeds a Visual Studio C++ compiler limit, and this fix provides a way to specify very long string literals, by the build system. Thi

RFR: JDK10: JDK-8180334: Unable to build jaotc launcher on windows

2017-06-07 Thread Kumar Srinivasan
Hello, Please review the changes to fix JDK-8180334, essentially -DJAVA_ARGS exceeds a Visual Studio C++ compiler limit, and this fix provides a way to specify very long string literals, by the build system. This also includes some minor and subtle simplifications and cleanups wrt. the

RFR: JDK10 JDK-8180286: Remove the launchers data model flags -d32/-d64

2017-05-25 Thread Kumar Srinivasan
Hello, Please review the removal of the launcher options -d32/-d64 from the launcher's help, the implementations were removed with JDK-8169646, but the help part was overlooked. JBS: https://bugs.openjdk.java.net/browse/JDK-8180286 webrev: http://cr.openjdk.java.net/~ksrini/8180286/webrev.00/

RFR: JDK-8180202: -XXaltjvm is not working anymore on MacOSX

2017-05-16 Thread Kumar Srinivasan
Hi David, Please review simple fix for JDK-8180202, recall we hard coded "server", this is incorrect because the function CheckJvmType will determin the correct jvmtype based on jvm.cfg *or* path/jvmtype specified by -XXaltjvm. IMO all this needs to be cleaned up when jvm.cfg is removed.

Re: RFR: JDK-8180202: -XXaltjvm is not working anymore on MacOSX

2017-05-15 Thread Kumar Srinivasan
Hi David, Please review simple fix for JDK-8180202, recall we hard coded "server", this is incorrect because the function CheckJvmType will determin the correct jvmtype based on jvm.cfg *or* path/jvmtype specified by -XXaltjvm. IMO all this needs to be cleaned up when jvm.cfg is removed. So

Re: RFR: JDK-8179631: Fix Html5 errors in java.management, jdk.management, jdk.jdi and jdk.attach

2017-05-11 Thread Kumar Srinivasan
Hello, Ping!. Lets wrap this up soon, as we have to move to the next steps in the docs related work. Thanks Kumar Hi All, Please review fixes to make the API doc comments HTML5 clean, there are no changes to the verbiage, and mostly fixes for the table styles defined here:

Re: RFR: JDK-8179697: Fix Html5 errors in java.naming, java.logging, jdk.httpserver, jdk.net, jdk.sctp

2017-05-11 Thread Kumar Srinivasan
cation section, and others have it changed to Package Specification. best regards, -- daniel On 10/05/2017 19:57, Kumar Srinivasan wrote: Hello, Please review HTML5 related changes to the above modules, please note there are no changes to the verbiage. Thanks Kumar Webrev: http://cr.openjdk.ja

RFR: JDK-8179697: Fix Html5 errors in java.naming, java.logging, jdk.httpserver, jdk.net, jdk.sctp

2017-05-10 Thread Kumar Srinivasan
Hello, Please review HTML5 related changes to the above modules, please note there are no changes to the verbiage. Thanks Kumar Webrev: http://cr.openjdk.java.net/~ksrini/8179697/webrev.0/ JBS: https://bugs.openjdk.java.net/browse/JDK-8179697

RFR: JDK-8179631: Fix Html5 errors in java.management, jdk.management, jdk.jdi and jdk.attach

2017-05-10 Thread Kumar Srinivasan
Hi All, Please review fixes to make the API doc comments HTML5 clean, there are no changes to the verbiage, and mostly fixes for the table styles defined here: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/ee84b7d44339 For tables with many entries I have used "striped", there are few

Re: RFR: jdk10: 8169646: Remove launcher's -d32/-d64 option

2017-05-09 Thread Kumar Srinivasan
://cr.openjdk.java.net/~ksrini/8169646/webrev.1/ Incremental webrev (since last reviewed changeset): http://cr.openjdk.java.net/~ksrini/8169646/webrev.1/webrev.delta/ Thanks Kumar Hi Kumar, On 9/05/2017 12:27 AM, Kumar Srinivasan wrote: Hi David, Hi Kumar, On 7/05/2017 1:21 AM, Kumar Srinivasan wrote: Hello

Re: RFR: [Updated] Update tables in java.base to be HTML5-friendly.

2017-05-08 Thread Kumar Srinivasan
Hi Jon, I looked at the stylesheet can the descriptive comments for each of the classes be moved closer to the class itself, ie. just before the definition ? Kumar This is an updated review for the changes to improve tables in java.base. The changes incorporate earlier review feedback,

RFR: jdk10: 8169646: Remove launcher's -d32/-d64 option

2017-05-06 Thread Kumar Srinivasan
Hello, Please review the changes to remove the java launcher's data model options -d32/-d64, these options existed to support Solaris dual-mode operation, however for uniformity, these options were accepted by other platforms as well. These options are now obsolete, and deprecated in jdk9,

Re: Review Request: JDK-8179645: java.util.jar.Packer.newPacker and newUnpacker fails when running with security manager

2017-05-04 Thread Kumar Srinivasan
On 5/4/2017 2:52 PM, Mandy Chung wrote: On May 4, 2017, at 2:13 PM, Alan Bateman wrote: On 04/05/2017 21:35, Mandy Chung wrote: java.util.jar.Packer.newPacker and newUnpacker fails when running with security manager. It is an existing bug but we uncovers this only

RFR: JDK-8179538: Update jdk.jdi to be HTML-5 friendly

2017-05-02 Thread Kumar Srinivasan
Hello, Please review changes to make jdk.jdi HTML5 friendly, table cell padding has not been addressed and will be fixed separately, this takes care of others. Note: Some of the errors were due to incorrect@throws but in all cases there is the correct one further down, please use sdiffs in

RFR: 8179415: Update java.management and java.management.rmi to be HTML-5 friendly

2017-04-28 Thread Kumar Srinivasan
Hello, Please review changes for java.management and java.management.rmi to be HTML5 ready, there are outliers like cellpadding, cellspacing that needs to be done separately, note this was *not* done mechanically by a script. http://cr.openjdk.java.net/~ksrini/8179415/

Re: RFR: 8076417: Update test/jdk/asm/AsmSanity.java with modules

2017-04-19 Thread Kumar Srinivasan
/TEST.groups @@ -269,7 +269,6 @@ javax/transaction \ javax/xml \ -javax/xml/crypto \ -jdk/asm \ Thanks, Amy On 4/19/17 2:39 AM, Kumar Srinivasan wrote: Hello, Please review [1] which addresses bug [2]. This test is unnecessary, as there are other components and tests within the jdk

Re: RFR: 8076417: Update test/jdk/asm/AsmSanity.java with modules

2017-04-19 Thread Kumar Srinivasan
\ -jdk/asm \ Thanks, Amy On 4/19/17 2:39 AM, Kumar Srinivasan wrote: Hello, Please review [1] which addresses bug [2]. This test is unnecessary, as there are other components and tests within the jdk, which will fail if ASM is not included, therefore this test is removed. Thanks Kumar [1

RFR: 8076417: Update test/jdk/asm/AsmSanity.java with modules

2017-04-18 Thread Kumar Srinivasan
Hello, Please review [1] which addresses bug [2]. This test is unnecessary, as there are other components and tests within the jdk, which will fail if ASM is not included, therefore this test is removed. Thanks Kumar [1] http://cr.openjdk.java.net/~ksrini/8076417/webrev.00/ [2]

Re: JDK 9 RFR(s): JDK-8065825: Make the java -help consistent with the man page

2017-04-05 Thread Kumar Srinivasan
tly. http://cr.openjdk.java.net/~ksrini/8065825/webrev.01/ Kumar On 05/04/2017 01:18, Kumar Srinivasan wrote: Hello, Please review: http://cr.openjdk.java.net/~ksrini/8065825/webrev.00/ This adds a few things to the java -help and some minor cleanup. Changing @ to @argument in the options

JDK 9 RFR(s): JDK-8065825: Make the java -help consistent with the man page

2017-04-04 Thread Kumar Srinivasan
Hello, Please review: http://cr.openjdk.java.net/~ksrini/8065825/webrev.00/ This adds a few things to the java -help and some minor cleanup. Thanks Kumar

RFR: 8173871: Typos in Jar Packer/Unpacker PROGRESS field documentation

2017-03-29 Thread Kumar Srinivasan
Hello, Please review fix for a typo. Thanks Kumar https://bugs.openjdk.java.net/browse/JDK-8173871 diff --git a/src/java.base/share/classes/java/util/jar/Pack200.java b/src/java.base/share/classes/java/util/jar/Pack200.java --- a/src/java.base/share/classes/java/util/jar/Pack200.java +++

RFR: 8174148: Typo in java.util.jar.Pack200.Unpacker.properties() method documentation

2017-03-29 Thread Kumar Srinivasan
Hello, Please review a fix for a simple typo. Thanks Kumar Bug: https://bugs.openjdk.java.net/browse/JDK-8174148 diff --git a/src/java.base/share/classes/java/util/jar/Pack200.java b/src/java.base/share/classes/java/util/jar/Pack200.java ---

Re: RFR [XS] : 8175000 : jexec fails to execute simple helloworld.jar

2017-03-01 Thread Kumar Srinivasan
Hello Baesken, I have attached 8175000.patch to the bug report, it includes Thomas' suggested fix + a test. I have also tested it, you may want to post it to corelibs-dev. If posting a new webrev, please add the pipermail to the bug report,

Re: RFR [XS] : 8175000 : jexec fails to execute simple helloworld.jar

2017-03-01 Thread Kumar Srinivasan
Hi Baesken, Thanks for fixing this, BUT.. Has this been tested on other platforms, especially on both the Endian platforms. I think we should have a simplistic regression test for this in jdk/test/tools/launcher area, until we EOL this. Once we have that then we need to test this on all

Re: Review Request: JDK-8174694: improve error message shown when main class can't be loaded

2017-02-15 Thread Kumar Srinivasan
Hi Vicente, Looks good. Mucho gracias for fixing this!. Kumar Hi, Thanks guys for your comments. I have uploaded another iteration of the review at [1], Vicente [1] http://cr.openjdk.java.net/~vromero/8174694/webrev.01/jdk.patch On 02/15/2017 02:06 PM, Kumar Srinivasan wrote: On 2/15

Re: Review Request: JDK-8174694: improve error message shown when main class can't be loaded

2017-02-15 Thread Kumar Srinivasan
On 2/15/2017 10:39 AM, Alan Bateman wrote: On 15/02/2017 17:21, Vicente Romero wrote: The simplest reproductor for this issue is: public class A extends B { public static void

Re: RFR: 8173943: Change error reporting of LauncherHelper to include actual Error class name

2017-02-06 Thread Kumar Srinivasan
+1 Kumar On 2/5/2017 11:14 AM, Ramanand Patil wrote: Hi all, Please review the following trivial bug fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8173943 Webrev: http://cr.openjdk.java.net/~rpatil/8173943/webrev.00/ LinkageError message added by -

Re: RFR: 8167063: spurious message "A JNI error has occurred" if start-class cannot be initialized

2017-01-31 Thread Kumar Srinivasan
Approved, please make sure you have run all the jprt -testset pit tests. Kumar On 1/30/2017 5:05 AM, Alan Bateman wrote: On 30/01/2017 12:11, Ramanand Patil wrote: Thank you Alan. I have eliminated the inner catch block for LinkageError. Here is the updated webrev:

Re: RFR: 8172309: classpath wildcards code does not support --class-path

2017-01-26 Thread Kumar Srinivasan
Hi Henry, Looks ok to me. Thanks for making this change. Kumar Hi, Please review the webrev[1], the fix is to ensure —class-path and —class-path= is processed correctly to expand wildcard. Changes are made in jdk repo. However, test case to verify the bug fix is in langtool repo. Cheers,

Re: Updated RFR: 8170832: Add a new launcher environment variable JAVA_OPTIONS

2017-01-25 Thread Kumar Srinivasan
Thanks Henry, Looks good!. Kumar On Jan 25, 2017, at 12:14 PM, Henry Jen <henry@oracle.com> wrote: On Jan 25, 2017, at 11:32 AM, Kumar Srinivasan <kumar.x.sriniva...@oracle.com> wrote: Hi Henry, I was somewhat surprised to see changes to launcher_LANG.properties, I

Re: RFR: 8170832: Add a new launcher environment variable JAVA_OPTIONS

2017-01-25 Thread Kumar Srinivasan
Hi Henry, I was somewhat surprised to see changes to launcher_LANG.properties, I usually make the change in the english/default locale and allow the L1ON team to make the locale specific changes, but if you are confident of the changes, that is fine.

Re: RFR: 8167063: spurious message "A JNI error has occurred" if start-class cannot be initialized

2017-01-25 Thread Kumar Srinivasan
Thank you for the review and suggestions for the test case. Here is the updated Webrev: http://cr.openjdk.java.net/~rpatil/8167063/webrev.02/ Regards, Ramanand. -Original Message- From: Kumar Srinivasan Sent: Tuesday, January 24, 2017 2:50 AM To: Ramanand Patil <ramanand.pa...@oracle.com> Cc

Re: RFR: 8167063: spurious message "A JNI error has occurred" if start-class cannot be initialized

2017-01-23 Thread Kumar Srinivasan
Hi Ramanand, test/tools/launcher/LauncherMessageTest.java 1) 116 String[] commands = {"java", "--module-path", modules.getPath(), 117 "-m", "mod.b/pkgB.ClassB"}; The execution PATH may or may not contain the JAVA_HOME_UNDER_TEST/bin, so the right "java" may not be picked

Re: RFR: 8166189: Fix for Bug 8165524 breaks AIX build

2016-12-01 Thread Kumar Srinivasan
Hi Volker, Hi Volker et. al., Was a bug opened to track this ? I still see these files around http://hg.openjdk.java.net/jdk9/dev/jdk/file/ff45c582ca8a/src/java.base/aix/native/libjli Hi Kumar, no, as far as I know there's no bug for this issue until now. Have created a bug for you:

Re: RFR: 8166189: Fix for Bug 8165524 breaks AIX build

2016-11-29 Thread Kumar Srinivasan
Hi Volker et. al., Was a bug opened to track this ? I still see these files around http://hg.openjdk.java.net/jdk9/dev/jdk/file/ff45c582ca8a/src/java.base/aix/native/libjli Would you like me to create a bug for you ? Thanks Kumar On 9/29/2016 9:59 AM, Volker Simonis wrote: On Thu, Sep 29,

Re: [9] RfR: 8169289: JavaFX application in named module fails to launch if no main method

2016-11-21 Thread Kumar Srinivasan
Sorry for the delay, looks good. Kumar Please review the (fairly straightforward) JDK changes needed to support launching JavaFX applications in a named module. JBS: https://bugs.openjdk.java.net/browse/JDK-8169289 Webrev: http://cr.openjdk.java.net/~ddehaven/8169289/jdk.0/ For

Re: 8169001: Remove launcher's built-in ergonomics

2016-11-08 Thread Kumar Srinivasan
Hi David, Thanks for the review please see embedded comments: Hi Kumar, On 8/11/2016 4:47 AM, Kumar Srinivasan wrote: Hello, Please review the fix for: https://bugs.openjdk.java.net/browse/JDK-8169001 Webrev at: http://cr.openjdk.java.net/~ksrini/8169001/webrev.00/ Overall this looks

8169001: Remove launcher's built-in ergonomics

2016-11-07 Thread Kumar Srinivasan
Hello, Please review the fix for: https://bugs.openjdk.java.net/browse/JDK-8169001 Webrev at: http://cr.openjdk.java.net/~ksrini/8169001/webrev.00/ Background: Launcher ergonomics was introduced last decade to help determine if the execution system is "Server Class", this was necessary to

Re: RFR: 8168010: Deprecate obsolete launcher -d32/-d64 options

2016-10-27 Thread Kumar Srinivasan
Hello, Please review enclosed fix for: https://bugs.openjdk.java.net/browse/JDK-8168010 Based on this discussion, http://mail.openjdk.java.net/pipermail/jdk9-dev/2016-September/004934.html these options are slated for deprecation, only at the documentation level, and will continue to

RFR: 8168010: Deprecate obsolete launcher -d32/-d64 options

2016-10-26 Thread Kumar Srinivasan
Hello, Please review enclosed fix for: https://bugs.openjdk.java.net/browse/JDK-8168010 Based on this discussion, http://mail.openjdk.java.net/pipermail/jdk9-dev/2016-September/004934.html these options are slated for deprecation, only at the documentation level, and will continue to

RFR: 8160213: tools/pack200/Utils.java should clean up javac*.tmp files

2016-10-24 Thread Kumar Srinivasan
Hello, Please review fix for: https://bugs.openjdk.java.net/browse/JDK-8160213 Webrev: http://cr.openjdk.java.net/~ksrini/8160213/webrev.00/ Now the temporary javac argument file will be written to the working directory of the test which will be purged upon completion. The test for

RFR: 8168093: Need a way for the launcher to query the JRE location using Windows registry.

2016-10-17 Thread Kumar Srinivasan
Hello, I am sponsoring this patch for the client team, the issue here is that the Windows installer copies the java launcher binaries to a system folder, and those binaries need to locate the Java Runtime using Windows registry. These changes are to allow calling an internal (Registry locator)

Re: RFR: 8166189: Fix for Bug 8165524 breaks AIX build

2016-09-29 Thread Kumar Srinivasan
+1. Kumar On 29/09/2016 16:25, Erik Joelsson wrote: Volker's comment above was directed at the suggestion of taking the problematic AIX specific code out of the OpenJDK repositories and create a separate library with a separate lifecycle somewhere else that OpenJDK for AIX would then need

Re: RFR: 8166189: Fix for Bug 8165524 breaks AIX build

2016-09-28 Thread Kumar Srinivasan
to:core-libs-dev-boun...@openjdk.java.net>] On Behalf Of Kumar Srinivasan Sent: Montag, 12. September 2016 22:57 To: core-libs-dev <core-libs-dev@openjdk.java.net <mailto:core-libs-dev@openjdk.java.net>>; Mandy Chung <mandy.ch...@or

Re: RFR: 8166189: Fix for Bug 8165524 breaks AIX build

2016-09-28 Thread Kumar Srinivasan
clanger/webrevs/8166189.0/> Thanks Christoph -Original Message- From: core-libs-dev [mailto:core-libs-dev-boun...@openjdk.java.net <mailto:core-libs-dev-boun...@openjdk.java.net>] On Behalf

Re: RFR: 8166189: Fix for Bug 8165524 breaks AIX build

2016-09-21 Thread Kumar Srinivasan
66189.0/ Thanks Christoph -Original Message- From: core-libs-dev [mailto:core-libs-dev-boun...@openjdk.java.net] On Behalf Of Kumar Srinivasan Sent: Montag, 12. September 2016 22:57 To: core-libs-dev <core-libs-dev@openjdk.java.net>; Mandy Chung <mandy.ch...@oracle.com&

Re: RFR: 8042148: Ensure that the java launcher help is consistent with the manpage where they report common information

2016-09-14 Thread Kumar Srinivasan
Henry, Thanks for taking care of this, if the VM team is happy with it. I am good, consider me as reviewer. Thanks Kumar Well, comments about -Xcomp and -Xusealtsigs doesn’t seem to require a change, are we good on this webrev? Let me know if there is anything need to change, otherwise, I

RFR: 8165524: Better detect JRE that Linux JLI will be using

2016-09-12 Thread Kumar Srinivasan
Hello, I am sponsoring this changeset for Chris Bensen of the java packager team, please review fix for the launcher to better locate java.home. http://cr.openjdk.java.net/~ksrini/8165524/ Thanks Kumar

Re: JDK 9 RFR of JDK-8165818: Remove tools/pack200/Pack200Props.java from ProblemList

2016-09-12 Thread Kumar Srinivasan
Looks good. Thanks for looking into this. Kumar On 9/12/16 11:38 AM, Amy Lu wrote: tools/pack200/Pack200Props.java This test was put into ProblemList.txt in 9/117 due to test timed out issue: JDK-8155857. Test failure (timed out) is reproducible with 9/117 and 9/118, but issue gone in

Re: RFR 8165726: fix for 8165595 revealed a bug in pack200 tool's handling of main class attribute of module-info classes

2016-09-09 Thread Kumar Srinivasan
Looks good, thanks for taking care of it. We need to double check these again, I will take a closer look later. Kumar On 9/9/2016 9:36 AM, Sundararajan Athijegannathan wrote: Please review http://cr.openjdk.java.net/~sundar/8165726/webrev.01/ for

Re: RFR: 8042148: Ensure that the java launcher help is consistent with the manpage where they report common information

2016-09-08 Thread Kumar Srinivasan
Hi Henry, Looks a lot nicer with the alpha ordering, but it seems to be missing -Xusealtsigs use alternative signals instead of SIGUSR1 and SIGUSR2 for JVM internal signals Kumar On 9/8/2016 12:52 PM, Henry Jen wrote: Hi, Please review a trivial fix for bug 8042148 at following URL:

Re: RFR: 8151901: test/tools/pack200/Pack200Test fails on verifying native unpacked JAR

2016-09-02 Thread Kumar Srinivasan
change<0 and we recompute from scratch.) Suggested amended patch enclosed. --- John On Mar 21, 2016, at 12:49 PM, Kumar Srinivasan <kumar.x.sriniva...@oracle.com> wrote: Hi John, This patch contains fixes for two bugs: 8151901: test/tools/pack200/Pack200Test fails on verifying native

Re: RFR: 8081388: JNI exception pending in jdk/src/windows/bin/java_md.c

2016-08-31 Thread Kumar Srinivasan
Looks good, thanks Henry for fixing this. Kumar Hi, Please review a trivial fix for 8081388, in a nutshell, - Return NULL from NewPlatformStringArray if an exception occurred - All other places call this function already handled return value NULL - Launcher handles exception in JavaMain,

Re: RFE to re-purpose option --version:

2016-08-08 Thread Kumar Srinivasan
Hello Paul, There is a light weight method to get the version from the launcher, "-fullversion" noting that, this does not invoke the VM, and obtains the version string set at build time in the launcher itself. However you would have to exec java twice, once to get the version, another to

Re: RFR: 8132379: -J options can cause crash or "Warning: app args parsing error passing arguments as-is"

2016-07-13 Thread Kumar Srinivasan
Henry, Thanks for fixing this. Looks good. Kumar Hi, Please review a fix for JDK-8132379, the fix is to build matching index to the original arguments for the application arguments, used later for the sanity check and wildcard expansion. The fix is specific to Windows platform. -J prefix

RFR: 8145418: [macosx] Help message for -Xdock:name has a superfluous trailing quote "

2016-07-01 Thread Kumar Srinivasan
Hello, Please review simple fix: https://bugs.openjdk.java.net/browse/JDK-8145418 Thanks Kumar diff --git a/src/java.base/share/classes/sun/launcher/resources/launcher.properties b/src/java.base/share/classes/sun/launcher/resources/launcher.properties ---

Re: Review Request: JDK-8160698 java --dry-run should not cause main class be initialized

2016-07-01 Thread Kumar Srinivasan
Looks ok, btw. doesn't the bug need to be added to the test ? If that is all there is to it. I don't need to see an iteration. Thanks Kumar Kumar, I move the call to CreateApplicationArgs before PostJVMInit and dryRun stops before PostJVMInit which shows the splash screen. Webrev:

Re: [9] RFR: 8022291: Mac OS: Unexpected JavaLaunchHelper message displaying

2016-06-27 Thread Kumar Srinivasan
I am not an expert in this area, if Sergey is ok with it. I am fine with it. Brent ? Kumar Thanks, Sergey. Can someone from the core-libs launcher group please approve? (looks at Kumar) -DrD- Looks fine. On 22.06.16 1:58, David DeHaven wrote: JBS:

Re: RFR: 8065831: Ensure the pack200/unpack200 help is consistent with man page

2016-06-15 Thread Kumar Srinivasan
Oops, I missed making changes to the unpack200 executable's help strings, no changes to DriverResource.java. http://cr.openjdk.java.net/~ksrini/8065831/webrev.02/ Just finished verifying with jprt. Thanks Kumar On Jun 14, 2016, at 6:31 PM, Kumar Srinivasan<kumar.x.sriniva...@oracle.

Re: RFR: 8065831: Ensure the pack200/unpack200 help is consistent with man page

2016-06-14 Thread Kumar Srinivasan
Thanks for looking at this. I wrapped all of them. http://cr.openjdk.java.net/~ksrini/8065831/webrev.01/ Kumar On Jun 14, 2016, at 1:19 PM, Kumar Srinivasan <kumar.x.sriniva...@oracle.com> wrote: Hi, Please review the simple changes which makes pack200 help consistent with man page

RFR: 8065831: Ensure the pack200/unpack200 help is consistent with man page

2016-06-14 Thread Kumar Srinivasan
Hi, Please review the simple changes which makes pack200 help consistent with man page. http://cr.openjdk.java.net/~ksrini/8065831/webrev.00/ Thanks Kumar

Re: RFR: 8156807: Pack200 must support v53.0 class files

2016-05-18 Thread Kumar Srinivasan
Will fix that, thanks for the reviews!. I was told by Amy, meanwhile this test has been added to ProblemList.txt so I will have to remove that line as well. Thanks Kumar On 05/18/2016 05:20 PM, Kumar Srinivasan wrote: The second part is fixing up the test, which does not read the process

RFR: 8156807: Pack200 must support v53.0 class files

2016-05-18 Thread Kumar Srinivasan
Hi, Alex or someone please review this simple fix, the first part is simply bumping the class file version number, and some cleanup of redundant constants in the native unpacker. The second part is fixing up the test, which does not read the process streams correctly and causes a test hang,

Re: RFR: JDK-8152690: main thread does not have native thread name

2016-04-26 Thread Kumar Srinivasan
ank you for your comment! I've fixed them and uploaded new webrev. Could you review again? http://cr.openjdk.java.net/~ysuenaga/JDK-8152690/webrev.06/hotspot/ http://cr.openjdk.java.net/~ysuenaga/JDK-8152690/webrev.06/jdk/ Thanks, Yasumasa On 2016/04/23 1:14, Kumar Sr

Re: RFR: JDK-8152690: main thread does not have native thread name

2016-04-24 Thread Kumar Srinivasan
/~ysuenaga/JDK-8152690/webrev.06/jdk/ Thanks, Yasumasa On 2016/04/23 1:14, Kumar Srinivasan wrote: Also a couple of minor suggestions: - * Set native thread name as possible. + * Set native thread name if possible. + /* - * We can clear pending exception because exception at this point

Re: RFR: JDK-8152690: main thread does not have native thread name

2016-04-22 Thread Kumar Srinivasan
Also a couple of minor suggestions: - * Set native thread name as possible. + * Set native thread name if possible. + /* - * We can clear pending exception because exception at this point - * is not critical. + */ + /* + * Clear non critical pending

Re: RFR: JDK-8152690: main thread does not have native thread name

2016-04-22 Thread Kumar Srinivasan
Hi, This is in the wrong place: 1715 if ((*env)->ExceptionOccurred(env)) { 1716 /* 1717* We can clear pending exception because exception at this point 1718* is not critical. 1719*/ 1720 (*env)->ExceptionClear(env); 1721 } This above needs to be

  1   2   3   4   5   >