Re: RFR: 8281146: Replace StringCoding.hasNegatives with countPositives [v11]

2022-03-08 Thread Lutz Schmidt
On Mon, 7 Mar 2022 23:13:36 GMT, Claes Redestad wrote: >> I'm requesting comments and, hopefully, some help with this patch to replace >> `StringCoding.hasNegatives` with `countPositives`. The new method does a >> very similar pass, but alters the intrinsic to return the number of leading >>

Re: RFR: 8281146: Replace StringCoding.hasNegatives with countPositives [v9]

2022-03-03 Thread Lutz Schmidt
On Thu, 3 Mar 2022 14:37:34 GMT, Andrew Haley wrote: > > > Well, it just didn't build. With the annotation being present, you also > > > need an intrinsic implementation. That's what the error message is > > > saying... > > > > > > Doh, I had no idea the presence of `@IntrinsicCandidate` was

Re: RFR: 8281146: Replace StringCoding.hasNegatives with countPositives [v9]

2022-03-03 Thread Lutz Schmidt
On Thu, 3 Mar 2022 12:45:51 GMT, Claes Redestad wrote: >>> * There are a few minor regressions (~5%) in the x86 implementation on >>> `encode-/decodeLatin1Short`. Those regressions disappear when mixing >>> inputs, for example `encode-/decodeShortMixed` even see a minor >>> improvement,

Re: RFR: 8281146: Replace StringCoding.hasNegatives with countPositives [v6]

2022-03-02 Thread Lutz Schmidt
On Wed, 2 Mar 2022 14:06:10 GMT, Claes Redestad wrote: >> Claes Redestad has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 29 commits: >> >> - Resolve merge conflict >> - Fix TestCountPositives to correctly allow 0 return when

Re: RFR: 8281146: Replace StringCoding.hasNegatives with countPositives [v6]

2022-03-01 Thread Lutz Schmidt
On Tue, 1 Mar 2022 19:12:17 GMT, Claes Redestad wrote: >> @theRealAph , @a74nh or someone familiar with aarch64 code, please review >> aarch64 changes. > >> @theRealAph , @a74nh or someone familiar with aarch64 code, please review >> aarch64 changes. > > Note that the aarch64 changes I've

Re: RFR: 8281146: Replace StringCoding.hasNegatives with countPositives [v6]

2022-03-01 Thread Lutz Schmidt
On Wed, 23 Feb 2022 14:19:20 GMT, Claes Redestad wrote: >> I'm requesting comments and, hopefully, some help with this patch to replace >> `StringCoding.hasNegatives` with `countPositives`. The new method does a >> very similar pass, but alters the intrinsic to return the number of leading >>

Re: RFR: 8281146: Replace StringCoding.hasNegatives with countPositives [v2]

2022-02-15 Thread Lutz Schmidt
On Fri, 11 Feb 2022 12:11:54 GMT, Claes Redestad wrote: >> I'm requesting comments and, hopefully, some help with this patch to replace >> `StringCoding.hasNegatives` with `countPositives`. The new method does a >> very similar pass, but alters the intrinsic to return the number of leading >>

Re: RFR: 8281146: Replace StringCoding.hasNegatives with countPositives [v2]

2022-02-15 Thread Lutz Schmidt
On Fri, 11 Feb 2022 12:11:54 GMT, Claes Redestad wrote: >> I'm requesting comments and, hopefully, some help with this patch to replace >> `StringCoding.hasNegatives` with `countPositives`. The new method does a >> very similar pass, but alters the intrinsic to return the number of leading >>

Re: RFR: JDK-8266490: Extend the OSContainer API to support the pids controller of cgroups [v8]

2021-08-09 Thread Lutz Schmidt
On Thu, 5 Aug 2021 11:21:59 GMT, Matthias Baesken wrote: >> Hello, please review this PR; it extend the OSContainer API in order to also >> support the pids controller of cgroups. >> >> I noticed that unlike the other controllers "cpu", "cpuset", "cpuacct", >> "memory" on some older Linux