Re: RFR: 8286294 : ForkJoinPool.commonPool().close() spins [v4]

On Sat, 7 May 2022 11:29:32 GMT, Doug Lea wrote: >> Changes ForkJoinPool.close spec and code to trap close as a no-op if called >> on common pool > > Doug Lea has updated the pull request incrementally with three additional > commits since the last revision: > > - Accommodate restrictive

Re: RFR: 8286294 : ForkJoinPool.commonPool().close() spins [v4]

On Sat, 7 May 2022 11:29:32 GMT, Doug Lea wrote: >> Changes ForkJoinPool.close spec and code to trap close as a no-op if called >> on common pool > > Doug Lea has updated the pull request incrementally with three additional > commits since the last revision: > > - Accommodate restrictive

Re: RFR: 8286294 : ForkJoinPool.commonPool().close() spins [v4]

On Sat, 7 May 2022 11:29:32 GMT, Doug Lea wrote: >> Changes ForkJoinPool.close spec and code to trap close as a no-op if called >> on common pool > > Doug Lea has updated the pull request incrementally with three additional > commits since the last revision: > > - Accommodate restrictive

Re: RFR: 8286294 : ForkJoinPool.commonPool().close() spins [v2]

On Fri, 6 May 2022 21:28:45 GMT, Martin Buchholz wrote: >> Tests in this file are not being executed. I think you need: >> >> --- a/test/jdk/java/util/concurrent/tck/ForkJoinPool19Test.java >> +++ b/test/jdk/java/util/concurrent/tck/ForkJoinPool19Test.java >>

Re: RFR: 8286294 : ForkJoinPool.commonPool().close() spins [v2]

On Fri, 6 May 2022 20:25:10 GMT, Martin Buchholz wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix doc types > > test/jdk/java/util/concurrent/tck/ForkJoinPool19Test.java line 496: >

Re: RFR: 8286294 : ForkJoinPool.commonPool().close() spins [v2]

On Fri, 6 May 2022 21:27:53 GMT, Martin Buchholz wrote: >> test/jdk/java/util/concurrent/tck/ForkJoinPool19Test.java line 496: >> >>> 494: >>> 495: /** >>> 496: * Implictly closing a new pool using try-with-resources >>> termina

Re: RFR: 8286294 : ForkJoinPool.commonPool().close() spins

On Fri, 6 May 2022 15:05:57 GMT, Doug Lea wrote: > Changes ForkJoinPool.close spec and code to trap close as a no-op if called > on common pool test/jdk/java/util/concurrent/tck/ForkJoinPool19Test.java line 496: > 494: > 495: /** > 496: * Implictly closing a new pool using

Re: RFR: 8277090 : jsr166 refresh for jdk19 [v2]

On Mon, 2 May 2022 13:33:33 GMT, Doug Lea wrote: >> This is the jsr166 refresh for jdk19. See >> https://bugs.openjdk.java.net/browse/JDK-8285450 and >> https://bugs.openjdk.java.net/browse/JDK-8277090 > > Doug Lea has updated the pull request incrementally with one additional > commit since

Re: RFR: 8277087: ZipException: zip END header not found at ZipFile#Source.findEND

On Sat, 13 Nov 2021 23:16:22 GMT, Sergey Bylokhov wrote: > The ZipOutputStream class may create bogus zip data which cannot be opened by > the ZipFile. The root cause is how the comment field is stored by the > ZipOutputStream. According to the zip specification, the comment field should >

Re: RFR: 8276348: Use blessed modifier order in java.base

On Tue, 2 Nov 2021 19:14:23 GMT, Pavel Rappo wrote: >> Pragmatically, fix the script to ignore those keywords on comment lines. >> Learn Perl, its just a regular expression pattern match and replace >> expression. >> >> All of the changes have to be manually reviewed by the author and then

Re: RFR: 8276348: Use blessed modifier order in java.base

On Tue, 2 Nov 2021 16:30:56 GMT, Pavel Rappo wrote: > This PR follows up one of the recent PRs, where I used a non-canonical > modifier order. Since the problem was noticed [^1], why not to address it at > mass? > > As far as I remember, the first mass-canonicalization of modifiers took place

Re: RFR: 8275002: Remove unused AbstractStringBuilder.MAX_ARRAY_SIZE [v2]

On Mon, 11 Oct 2021 18:52:07 GMT, Andrey Turbanov wrote: >> 8275002: Remove unused AbstractStringBuilder.MAX_ARRAY_SIZE > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since the last revision: > > 275002: Remove unused

Re: RFR: 8275002: Remove unused AbstractStringBuilder.MAX_ARRAY_SIZE

On Sat, 9 Oct 2021 17:54:16 GMT, Andrey Turbanov wrote: > 8275002: Remove unused AbstractStringBuilder.MAX_ARRAY_SIZE JDK sources should not contain dead unused fields - thanks for fixing. The change to use newLength in this file should have adjusted the javadoc of newCapacity, perhaps

Re: RFR: 8274715: Implement forEach in Collections.CopiesList [v3]

On Tue, 5 Oct 2021 17:51:31 GMT, Сергей Цыпанов wrote: >> Originally was proposed by Zheka Kozlov here: >> http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-December/057192.html >> >> Just a tiny optimization: we can use for-i loop instead of >> `Iterable.forEach()` which is relying

Re: RFR: 8274715: Implement forEach in Collections.CopiesList [v3]

On Tue, 5 Oct 2021 17:51:31 GMT, Сергей Цыпанов wrote: >> Originally was proposed by Zheka Kozlov here: >> http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-December/057192.html >> >> Just a tiny optimization: we can use for-i loop instead of >> `Iterable.forEach()` which is relying

Re: RFR: 8274715: Implement forEach in Collections.CopiesList [v2]

On Tue, 5 Oct 2021 09:18:57 GMT, Сергей Цыпанов wrote: >> Originally was proposed by Zheka Kozlov here: >> http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-December/057192.html >> >> Just a tiny optimization: we can use for-i loop instead of >> `Iterable.forEach()` which is relying

Re: RFR: 8274715: Implement forEach in Collections.CopiesList

On Thu, 11 Feb 2021 13:28:49 GMT, Сергей Цыпанов wrote: > Originally was proposed by Zheka Kozlov here: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-December/057192.html > > Just a tiny optimization: we can use for-i loop instead of > `Iterable.forEach()` which is relying on

Re: RFR: 8274349: ForkJoinPool.commonPool() does not work with 1 CPU [v2]

On Fri, 1 Oct 2021 05:10:17 GMT, David Holmes wrote: >> A regression introduced in Java 17 will give the default FJ pool a >> parallelism of zero in a uniprocessor environment. The fix restores this to >> a value of 1. See bug report for details. >> >> Testing: >> - new regression test >> -

Integrated: 8260664: Phaser.arrive() memory consistency effects

On Wed, 3 Feb 2021 21:55:54 GMT, Martin Buchholz wrote: > 8260664: Phaser.arrive() memory consistency effects This pull request has now been integrated. Changeset: eb4a8af5 Author: Martin Buchholz URL: https://git.openjdk.java.net/jdk/commit/eb4a8af5 Stats: 6 lines in 1 f

Re: RFR: 8259800: timeout in tck test testForkJoin(ForkJoinPool8Test)

On Sat, 20 Feb 2021 14:17:16 GMT, Doug Lea wrote: > This addresses interactions between parallelism-0 and new shutdown support in > https://bugs.openjdk.java.net/browse/JDK-8259800 Marked as reviewed by martin (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2661

Integrated: 8259074: regex benchmarks and tests

On Tue, 5 Jan 2021 03:15:56 GMT, Martin Buchholz wrote: > 8259074: regex benchmarks and tests This pull request has now been integrated. Changeset: 351d7888 Author: Martin Buchholz URL: https://git.openjdk.java.net/jdk/commit/351d7888 Stats: 483 lines in 5 files changed: 473

Re: RFR: 8259074: regex benchmarks and tests [v5]

On Tue, 2 Feb 2021 13:10:29 GMT, Claes Redestad wrote: >> Martin Buchholz has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix imports > > Marked as reviewed by redestad (Reviewer). @cl4es Your comment se

Re: RFR: 8260664: Phaser.arrive() memory consistency effects

On Wed, 3 Feb 2021 21:55:54 GMT, Martin Buchholz wrote: > 8260664: Phaser.arrive() memory consistency effects @DougLea - PR: https://git.openjdk.java.net/jdk/pull/2388

RFR: 8260664: Phaser.arrive() memory consistency effects

8260664: Phaser.arrive() memory consistency effects - Commit messages: - JDK-8260664 Changes: https://git.openjdk.java.net/jdk/pull/2388/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2388=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8260664 Stats: 6 lines in 1

Re: RFR: 8259074: regex benchmarks and tests [v5]

> 8259074: regex benchmarks and tests Martin Buchholz has updated the pull request incrementally with one additional commit since the last revision: fix imports - Changes: - all: https://git.openjdk.java.net/jdk/pull/1940/files - new: https://git.openjdk.java.net/jdk/p

Re: RFR: 8259074: regex benchmarks and tests

On Tue, 2 Feb 2021 01:40:09 GMT, Martin Buchholz wrote: >> @cl4es I agree pruning is a good idea. I settled on 3 data points with 16x >> separations as good enough to clearly show the difference between O(1) O(N) >> O(N^2) and O(2^N) (although O(2^N) would "run fore

Re: RFR: 8259074: regex benchmarks and tests [v4]

> 8259074: regex benchmarks and tests Martin Buchholz has updated the pull request incrementally with one additional commit since the last revision: add annotations for sensible defaults - Changes: - all: https://git.openjdk.java.net/jdk/pull/1940/files - new: ht

Re: RFR: 8259074: regex benchmarks and tests

On Mon, 1 Feb 2021 20:52:12 GMT, Martin Buchholz wrote: >> The assertion discussion aside, the micros look fine to me. >> >> With an eye towards reducing total run time I'd ask you to consider if all >> parameter combinations are useful or if we can get the same valu

Re: RFR: 8259074: regex benchmarks and tests [v2]

On Mon, 1 Feb 2021 00:23:56 GMT, Martin Buchholz wrote: >> test/micro/org/openjdk/bench/java/util/regex/Trim.java line 119: >> >>> 117: assert ! lookBehind_find(); >>> 118: assert ! find_loop_two_matchers(); >>> 119: assert ! f

Re: RFR: 8259074: regex benchmarks and tests [v3]

> 8259074: regex benchmarks and tests Martin Buchholz has updated the pull request incrementally with two additional commits since the last revision: - refactor correctness checking as suggested by @shipilev - prune @Param values as suggested by Claes - Changes: - all: ht

Re: RFR: 8259074: regex benchmarks and tests

On Mon, 1 Feb 2021 10:22:14 GMT, Claes Redestad wrote: >> @amalloy - you are invited to comment on regex content >> @cl4es @shipilev - you are invited to point out my jmh bad practices > > The assertion discussion aside, the micros look fine to me. > > With an eye towards reducing total run

Re: RFR: 8259074: regex benchmarks and tests

On Mon, 1 Feb 2021 10:22:14 GMT, Claes Redestad wrote: >> @amalloy - you are invited to comment on regex content >> @cl4es @shipilev - you are invited to point out my jmh bad practices > > The assertion discussion aside, the micros look fine to me. > > With an eye towards reducing total run

Re: RFR: 8259074: regex benchmarks and tests [v2]

On Sun, 31 Jan 2021 08:18:28 GMT, Aleksey Shipilev wrote: >> Martin Buchholz has updated the pull request incrementally with one >> additional commit since the last revision: >> >> address comments from @amalloy; introduce technically correct use of >> "

Re: RFR: 8259074: regex benchmarks and tests [v2]

> 8259074: regex benchmarks and tests Martin Buchholz has updated the pull request incrementally with one additional commit since the last revision: address comments from @amalloy; introduce technically correct use of "numeral" - Changes: - all: https://git.ope

Re: RFR: 8259074: regex benchmarks and tests

On Tue, 5 Jan 2021 03:15:56 GMT, Martin Buchholz wrote: > 8259074: regex benchmarks and tests @amalloy - you are invited to comment on regex content @cl4es @shipilev - you are invited to point out my jmh bad practices - PR: https://git.openjdk.java.net/jdk/pull/1940

RFR: 8259074: regex benchmarks and tests

8259074: regex benchmarks and tests - Commit messages: - more benchmarks - JDK-8259074 Changes: https://git.openjdk.java.net/jdk/pull/1940/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1940=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8259074 Stats: 444 lines

Integrated: 8260461: Modernize jsr166 tck tests

On Tue, 26 Jan 2021 21:23:25 GMT, Martin Buchholz wrote: > 8260461: Modernize jsr166 tck tests This pull request has now been integrated. Changeset: 81e9e6a7 Author: Martin Buchholz URL: https://git.openjdk.java.net/jdk/commit/81e9e6a7 Stats: 7616 lines in 71 files changed:

Re: RFR: 8260461: Modernize jsr166 tck tests [v3]

On Wed, 27 Jan 2021 00:44:51 GMT, Doug Lea wrote: >> Martin Buchholz has refreshed the contents of this pull request, and >> previous commits have been removed. The incremental views will show >> differences compared to the previous content of the PR. The pull request &

Re: RFR: 8260461: Modernize jsr166 tck tests [v3]

> 8260461: Modernize jsr166 tck tests Martin Buchholz has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the l

Re: RFR: 8260461: Modernize jsr166 tck tests [v2]

> 8260461: Modernize jsr166 tck tests Martin Buchholz has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: JDK-8260461 - Changes: https://git.openjdk.java.net/jdk/pull/2245/files Webrev: ht

RFR: 8260461: Modernize jsr166 tck tests

8260461: Modernize jsr166 tck tests - Commit messages: - JDK-8260461 Changes: https://git.openjdk.java.net/jdk/pull/2245/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2245=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8260461 Stats: 7535 lines in 70 files

Re: RFR: 8247373: ArraysSupport.newLength doc, test, and exception message [v2]

On Sun, 24 Jan 2021 20:14:04 GMT, Martin Buchholz wrote: >> Stuart Marks has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix typo, clarify asserts disabled, test prefGrowth==0 > > Marked as reviewed by ma

Re: RFR: 8247373: ArraysSupport.newLength doc, test, and exception message [v2]

On Tue, 8 Dec 2020 06:14:35 GMT, Stuart Marks wrote: >> This rewrites the doc of ArraysSupport.newLength, adds detail to the >> exception message, and adds a test. In addition to some renaming and a bit >> of refactoring of the actual code, I also made two changes of substance to >> the code:

Re: RFR: 8247373: ArraysSupport.newLength doc, test, and exception message [v2]

On Fri, 4 Dec 2020 17:31:20 GMT, Stuart Marks wrote: >> src/java.base/share/classes/jdk/internal/util/ArraysSupport.java line 654: >> >>> 652: return SOFT_MAX_ARRAY_LENGTH; >>> 653: } else { >>> 654: return minLength; >> >> Isn't this last `else if... then..

Re: RFR: 8247373: ArraysSupport.newLength doc, test, and exception message [v2]

On Tue, 8 Dec 2020 06:14:35 GMT, Stuart Marks wrote: >> This rewrites the doc of ArraysSupport.newLength, adds detail to the >> exception message, and adds a test. In addition to some renaming and a bit >> of refactoring of the actual code, I also made two changes of substance to >> the code:

Re: RFR: 8247373: ArraysSupport.newLength doc, test, and exception message [v2]

On Tue, 8 Dec 2020 06:14:35 GMT, Stuart Marks wrote: >> This rewrites the doc of ArraysSupport.newLength, adds detail to the >> exception message, and adds a test. In addition to some renaming and a bit >> of refactoring of the actual code, I also made two changes of substance to >> the code:

Re: RFR: 8247373: ArraysSupport.newLength doc, test, and exception message [v2]

On Wed, 9 Dec 2020 00:32:37 GMT, Paul Sandoz wrote: >> Stuart Marks has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix typo, clarify asserts disabled, test prefGrowth==0 > >

Re: RFR: 8247373: ArraysSupport.newLength doc, test, and exception message [v2]

On Tue, 8 Dec 2020 06:14:35 GMT, Stuart Marks wrote: >> This rewrites the doc of ArraysSupport.newLength, adds detail to the >> exception message, and adds a test. In addition to some renaming and a bit >> of refactoring of the actual code, I also made two changes of substance to >> the code:

Re: RFR: 8252412: [macos11] system dynamic libraries removed from filesystem [v2]

On Fri, 22 Jan 2021 22:56:08 GMT, Jiangli Zhou wrote: >> Martin Buchholz has refreshed the contents of this pull request, and >> previous commits have been removed. The incremental views will show >> differences compared to the previous content of the PR. > > Marke

Re: RFR: 8252412: [macos11] system dynamic libraries removed from filesystem [v2]

My github comment was mangled forwarding to core-libs. I suspect the skara bidirectional mailing list forwarding bot discards lines with leading "/" . Instead the bot should pass on unrecognized github comment commands unmodified. On Fri, Jan 22, 2021 at 12:12 PM Martin Buchh

Re: RFR: 8252412: [macos11] system dynamic libraries removed from filesystem [v2]

On Fri, 22 Jan 2021 19:46:13 GMT, Jiangli Zhou wrote: >> Martin Buchholz has refreshed the contents of this pull request, and >> previous commits have been removed. The incremental views will show >> differences compared to the previous content of the PR. > > src/java.

[jdk16] Integrated: 8259796: timed CompletableFuture.get may swallow InterruptedException

On Sun, 17 Jan 2021 18:39:55 GMT, Martin Buchholz wrote: > 8259796: timed CompletableFuture.get may swallow InterruptedException This pull request has now been integrated. Changeset: f7b96d34 Author: Martin Buchholz URL: https://git.openjdk.java.net/jdk16/commit/f7b96d34 St

Re: [jdk16] RFR: 8259796: timed CompletableFuture.get may swallow InterruptedException [v2]

> 8259796: timed CompletableFuture.get may swallow InterruptedException Martin Buchholz has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: JDK-8259796 - Changes: https://git.openjdk.java.net/jdk16/pull/

Re: [jdk16] RFR: 8259796: timed CompletableFuture.get may swallow InterruptedException [v2]

On Sun, 17 Jan 2021 18:52:04 GMT, Doug Lea wrote: >> Martin Buchholz has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains one commit: >> >> JDK-8259796 > > Marked as reviewed by dl (Reviewer). we

Re: RFR: 8252412: [macos11] system dynamic libraries removed from filesystem [v2]

> 8252412: [macos11] system dynamic libraries removed from filesystem Martin Buchholz has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains

RFR: 8252412: [macos11] File-based loading of dynamic libraries deprecated

8252412: [macos11] File-based loading of dynamic libraries deprecated - Commit messages: - JDK-8252412: [macos11] File-based loading of dynamic libraries deprecated Changes: https://git.openjdk.java.net/jdk/pull/2119/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2119=00

[jdk16] RFR: 8259796: timed CompletableFuture.get may swallow InterruptedException

8259796: timed CompletableFuture.get may swallow InterruptedException - Commit messages: - JDK-8259796 Changes: https://git.openjdk.java.net/jdk16/pull/126/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk16=126=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8259796

Re: [jdk16] RFR: 8254350: CompletableFuture.get may swallow InterruptedException

On Thu, 14 Jan 2021 13:59:50 GMT, Kezhu Wang wrote: >> 8254350: CompletableFuture.get may swallow InterruptedException > > @Martin-Buchholz @DougLea @AlanBateman Sorry for rough in. After change > `future.get()` to `future.get(1, TimeUnit.DAYS)`, > `SwallowedInterrupte

Integrated: 8254973: CompletableFuture.ThreadPerTaskExecutor does not throw NPE in #execute

On Sun, 10 Jan 2021 20:13:07 GMT, Martin Buchholz wrote: > 8254973: CompletableFuture.ThreadPerTaskExecutor does not throw NPE in > #execute This pull request has now been integrated. Changeset: 9154f643 Author:Martin Buchholz URL: https://git.openjdk.java.net/jdk/commit/91

RFR: 8254973: CompletableFuture.ThreadPerTaskExecutor does not throw NPE in #execute

8254973: CompletableFuture.ThreadPerTaskExecutor does not throw NPE in #execute - Commit messages: - JDK-8254973 Changes: https://git.openjdk.java.net/jdk/pull/2018/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2018=00 Issue:

Integrated: JDK-8258187 IllegalMonitorStateException in ArrayBlockingQueue

On Sat, 9 Jan 2021 23:44:13 GMT, Martin Buchholz wrote: > JDK-8258187 IllegalMonitorStateException in ArrayBlockingQueue This pull request has now been integrated. Changeset: e7c17408 Author: Martin Buchholz URL: https://git.openjdk.java.net/jdk/commit/e7c17408 Stats: 30 li

Re: RFR: 8259518: Fixes for rare test failures due to 8246585: ForkJoin updates

On Sun, 10 Jan 2021 12:01:44 GMT, Doug Lea wrote: >> 8259518: Fixes for rare test failures due to 8246585: ForkJoin updates > > Marked as reviewed by dl (Reviewer). The code is good, but this is actually a fix for JDK-8258187 IllegalMonitorStateException in ArrayBlockingQueue I will fiddle

Integrated: 8258217: PriorityBlockingQueue constructor spec and behavior mismatch

On Sat, 9 Jan 2021 23:41:24 GMT, Martin Buchholz wrote: > 8258217: PriorityBlockingQueue constructor spec and behavior mismatch This pull request has now been integrated. Changeset: 11d5b047 Author: Martin Buchholz URL: https://git.openjdk.java.net/jdk/commit/11d5b047 Stats:

RFR: 8259518: Fixes for rare test failures due to 8246585: ForkJoin updates

8259518: Fixes for rare test failures due to 8246585: ForkJoin updates - Commit messages: - JDK-8259518 Changes: https://git.openjdk.java.net/jdk/pull/2015/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2015=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8259518

RFR: 8258217: PriorityBlockingQueue constructor spec and behavior mismatch

8258217: PriorityBlockingQueue constructor spec and behavior mismatch - Commit messages: - JDK-8258217 Changes: https://git.openjdk.java.net/jdk/pull/2014/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2014=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8258217

Integrated: 8234131: Miscellaneous changes imported from jsr166 CVS 2021-01

On Sun, 6 Dec 2020 02:57:03 GMT, Martin Buchholz wrote: > 8234131: Miscellaneous changes imported from jsr166 CVS 2021-01 This pull request has now been integrated. Changeset: 270014ab Author: Martin Buchholz URL: https://git.openjdk.java.net/jdk/commit/270014ab Stats: 314 li

Integrated: 8246677: LinkedTransferQueue and SynchronousQueue synchronization updates

On Sun, 6 Dec 2020 02:56:04 GMT, Martin Buchholz wrote: > 8246677: LinkedTransferQueue and SynchronousQueue synchronization updates This pull request has now been integrated. Changeset: 63e3bd76 Author: Martin Buchholz URL: https://git.openjdk.java.net/jdk/commit/63e3bd76 St

Integrated: 8246585: ForkJoin updates

On Sun, 6 Dec 2020 02:56:34 GMT, Martin Buchholz wrote: > 8246585: ForkJoin updates This pull request has now been integrated. Changeset: 5cfa8c94 Author: Martin Buchholz URL: https://git.openjdk.java.net/jdk/commit/5cfa8c94 Stats: 3771 lines in 9 files changed: 1594 ins; 1

Re: RFR: 8246585: ForkJoin updates [v5]

> 8246585: ForkJoin updates Martin Buchholz has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:

Re: RFR: 8246585: ForkJoin updates [v4]

> 8246585: ForkJoin updates Martin Buchholz has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: JDK-8246585 - Changes: https://git.openjdk.java.net/jdk/pull/1646/files Webrev: https://webrevs.openjdk.java.

Withdrawn: 8254350: CompletableFuture.get may swallow InterruptedException

On Sun, 6 Dec 2020 22:12:54 GMT, Martin Buchholz wrote: > 8254350: CompletableFuture.get may swallow InterruptedException This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/1651

Re: RFR: 8254350: CompletableFuture.get may swallow InterruptedException [v2]

On Tue, 8 Dec 2020 07:53:17 GMT, Alan Bateman wrote: >> Martin Buchholz has refreshed the contents of this pull request, and >> previous commits have been removed. The incremental views will show >> differences compared to the previous content of the PR. > > Mar

Re: Impossible (?) code path resulting in IllegalStateException on jdk14+

1. JDK-8258187 IllegalMonitorStateException in ArrayBlockingQueue It's surprising that you can have a repro which is essentially just simple producer-consumer. Can we remove the forkjoinpool from the repro (just threads?) On Sun, Dec 13,

Re: RFR: 8234131: Miscellaneous changes imported from jsr166 CVS 2020-12 [v3]

On Fri, 11 Dec 2020 15:07:45 GMT, Petr Janeček wrote: >> The changes to doc comments look good. >> >> Thanks for incorporating my earlier code snippet suggestions published on >> [concurrency-interest](http://cs.oswego.edu/pipermail/concurrency-interest/2020-November/017264.html)! > > This

Re: RFR: 8234131: Miscellaneous changes imported from jsr166 CVS 2020-12 [v4]

> 8234131: Miscellaneous changes imported from jsr166 CVS 2020-12 Martin Buchholz has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: JDK-8234131 - Changes: https://git.openjdk.java.net/jdk/pull/1647/fi

[jdk16] Integrated: 8254350: CompletableFuture.get may swallow InterruptedException

On Sun, 13 Dec 2020 03:31:44 GMT, Martin Buchholz wrote: > 8254350: CompletableFuture.get may swallow InterruptedException This pull request has now been integrated. Changeset: 43dc3f79 Author: Martin Buchholz URL: https://git.openjdk.java.net/jdk16/commit/43dc3f79 Stats:

[jdk16] RFR: 8254350: CompletableFuture.get may swallow InterruptedException

8254350: CompletableFuture.get may swallow InterruptedException - Commit messages: - JDK-8254350 Changes: https://git.openjdk.java.net/jdk16/pull/17/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk16=17=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8254350 Stats:

Re: RFR: 8247402: Documentation for Map::compute contains confusing implementation requirements [v2]

On Sat, 28 Nov 2020 08:35:20 GMT, John Lin wrote: >> This is from the mailing list: >> http://mail.openjdk.java.net/pipermail/core-libs-dev/2020-June/067190.html >> >> - >> ### Progress >> - [x] Change must not contain extraneous whitespace >> - [x] Commit message must refer to an

Re: RFR: 8234131: Miscellaneous changes imported from jsr166 CVS 2020-12 [v3]

Wed, Dec 9, 2020 at 10:46 AM Pavel Rappo wrote: > On Tue, 8 Dec 2020 21:15:48 GMT, Martin Buchholz > wrote: > > >> 8234131: Miscellaneous changes imported from jsr166 CVS 2020-12 > > > > Martin Buchholz has updated the pull request with a new target base due > t

Re: RFR: 8246585: ForkJoin updates [v3]

> 8246585: ForkJoin updates Martin Buchholz has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: JDK-8246585 - Changes: https://git.openjdk.java.net/jdk/pull/1646/files Webrev: https://webrevs.openjdk.java.

Re: RFR: 8234131: Miscellaneous changes imported from jsr166 CVS 2020-12 [v3]

> 8234131: Miscellaneous changes imported from jsr166 CVS 2020-12 Martin Buchholz has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: JDK-8234131 - Changes: https://git.openjdk.java.net/jdk/pull/1647/fi

Re: RFR: 8254350: CompletableFuture.get may swallow InterruptedException [v2]

On Tue, Dec 8, 2020 at 3:54 AM Daniel Fuchs wrote: > > > RandomFactory is probably overkill here as the test just needs to > exercise untimed and timed get. So just a random boolean rather than a wide > range of random values. > > OK. > There's a conflict between the desires to do more thorough

Re: RFR: 8254350: CompletableFuture.get may swallow InterruptedException [v2]

On Mon, Dec 7, 2020 at 11:56 PM Alan Bateman wrote: > > > 37: // TODO: Rewrite as a CompletableFuture tck test ? > > Do you want the "TODO" in the commit? > > Yes!

Re: RFR: 8234131: Miscellaneous changes imported from jsr166 CVS 2020-12 [v2]

OK, rollback committed to CVS: --- src/main/java/util/concurrent/ThreadPoolExecutor.java 27 Nov 2020 17:42:00 - 1.194 +++ src/main/java/util/concurrent/ThreadPoolExecutor.java 8 Dec 2020 20:31:54 - @@ -1522,13 +1522,11 @@ // As a heuristic, prestart enough new workers (up to

Re: RFR: 8246585: ForkJoin updates

On Tue, Dec 8, 2020 at 12:05 AM Aleksey Shipilev wrote: > On Sun, 6 Dec 2020 02:56:34 GMT, Martin Buchholz > wrote: > > > 8246585: ForkJoin updates > > It would be nice to get it tested with GH Actions. "Checks" tabs should > have those testing results auto

Re: RFR: 8254350: CompletableFuture.get may swallow InterruptedException [v2]

> 8254350: CompletableFuture.get may swallow InterruptedException Martin Buchholz has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one

Re: RFR: 8234131: Miscellaneous changes imported from jsr166 CVS 2020-12 [v2]

> 8234131: Miscellaneous changes imported from jsr166 CVS 2020-12 Martin Buchholz has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one

Re: RFR: 8246585: ForkJoin updates [v2]

> 8246585: ForkJoin updates Martin Buchholz has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

Re: RFR: 8246677: LinkedTransferQueue and SynchronousQueue synchronization updates [v2]

> 8246677: LinkedTransferQueue and SynchronousQueue synchronization updates Martin Buchholz has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request conta

RFR: 8254350: CompletableFuture.get may swallow InterruptedException

8254350: CompletableFuture.get may swallow InterruptedException - Commit messages: - JDK-8254350 Changes: https://git.openjdk.java.net/jdk/pull/1651/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1651=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8254350 Stats:

RFR: 8246585: ForkJoin updates

8246585: ForkJoin updates - Commit messages: - JDK-8246585 Changes: https://git.openjdk.java.net/jdk/pull/1646/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1646=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8246585 Stats: 3114 lines in 6 files changed: 1135

RFR: 8246677: LinkedTransferQueue and SynchronousQueue synchronization updates

8246677: LinkedTransferQueue and SynchronousQueue synchronization updates - Commit messages: - JDK-8246677 Changes: https://git.openjdk.java.net/jdk/pull/1645/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1645=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8246677

RFR: 8234131: Miscellaneous changes imported from jsr166 CVS 2020-12

8234131: Miscellaneous changes imported from jsr166 CVS 2020-12 - Commit messages: - JDK-8234131 Changes: https://git.openjdk.java.net/jdk/pull/1647/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1647=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8234131 Stats:

Integrated: 8243614: Typo in ReentrantLock's Javadoc

On Fri, 4 Dec 2020 22:06:03 GMT, Martin Buchholz wrote: > Add missing semicolon > > Martin's first github pr. This pull request has now been integrated. Changeset: c4339c30 Author: Martin Buchholz URL: https://git.openjdk.java.net/jdk/commit/c4339c30 Stats: 1 line

RFR: 8243614: Typo in ReentrantLock's Javadoc

Add missing semicolon Martin's first github pr. - Commit messages: - JDK-8243614-typo Changes: https://git.openjdk.java.net/jdk/pull/1633/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1633=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8243614 Stats: 1 line in

Re: RFR: 8247402: Documentation for Map::compute contains confusing implementation requirements

On Fri, 4 Dec 2020 16:54:26 GMT, Pavel Rappo wrote: >> @pavelrappo Please see my updated CSR below. Thanks. >> >> # Map::compute should have the implementation requirement match its default >> implementation >> >> ## Summary >> >> The implementation requirement of Map::compute does not match

Re: RFR 8252537: Replace @exception with @throws for core-libs

Thanks for doing this! 15 years ago I considered taking on this task, eventually backing away because it was too much work (!). But I made sure most of the classes I maintained were using @throws. When considering this, I thought that tidying the whitespace after conversion would be a big part

Re: JDK 16 RFR of JDK-8250240: Address use of default constructors in the java.util.concurrent

I'm happy with this change whether or not the slightly more evocative "protected" is used. On Thu, Jul 23, 2020 at 5:43 PM Joe Darcy wrote: > > Hi Martin, > > On 7/23/2020 5:24 PM, Martin Buchholz wrote: > > So these are all abstract classes where the constructor can

Re: JDK 16 RFR of JDK-8250240: Address use of default constructors in the java.util.concurrent

So these are all abstract classes where the constructor can only be called via super() ? In which case one would expect the constructors to be protected, not public. But I'm probably missing some reason why "protected" would not be 100% compatible. Historically, we've preferred to put changes in

Re: RFR 8249217: Unexpected StackOverflowError in "process reaper" thread still happens

> > > > Thanks, Roger > > > > > > On 7/22/20 8:35 PM, Martin Buchholz wrote: > >> Roger: You're absolutely right! I should have looked. > >> > >> On Wed, Jul 22, 2020 at 5:25 PM Roger Riggs > >> wrote: > >>> Hi Mart

  1   2   3   4   5   6   7   8   9   10   >